Re: [Spice-devel] [PATCH spice-gtk] keymaps.csv: Add missing columns

[Daniel P. Berrange]

On Tue, Feb 14, 2017 at 08:33:09AM -0500, Marc-André Lureau wrote:
> Hi
> 
> - Original Message -
> > > 
> > > Allow easier processing by scripts and csv editors
> > > ---
> > > Also it renders nicely on github
> > >  https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv
> > > From that ^ table is obvious which values are missing
> > 
> > With
> > 
> >   git diff HEAD^ --word-diff --word-diff-regex='[^[:space:]]'
> > 
> > you can easily see that there's no difference beside the added
> > columns at the end and with a
> > 
> >   perl -pe 's.[^,\n]..sg' src/keymaps.csv | uniq
> > 
> > you can see all rows have the same amount of columns
> > 
> > Acked-by: Frediano Ziglio 
> 
> Are we still in sync with gtk-vnc? 
> https://git.gnome.org/browse/gtk-vnc/tree/src/keymaps.csv
> 
> An option would be to have a submodule for keymaps and related code,
> to be shared with gtk-vnc, spice-gtk, eventually qemu (and a freerdp
> gtk widget etc)

I had done some work in this respect, but I don't think I ever pushed
it anywhere. Originally I had been intending to put it on freedesktop
but their admins never responded to repo creation requests. gitlab
would be a better choice these days. Lemme try and find my previous
work...


Regards,
Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://entangle-photo.org   -o-http://search.cpan.org/~danberr/ :|
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk] keymaps.csv: Add missing columns

[Pavel Grunt]

On Tue, 2017-02-14 at 08:33 -0500, Marc-André Lureau wrote:
> Hi
> 
> - Original Message -
> > > 
> > > Allow easier processing by scripts and csv editors
> > > ---
> > > Also it renders nicely on github
> > >  https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv
> > > From that ^ table is obvious which values are missing
> > 
> > With
> > 
> >   git diff HEAD^ --word-diff --word-diff-regex='[^[:space:]]'
> > 
> > you can easily see that there's no difference beside the added
> > columns at the end and with a
> > 
> >   perl -pe 's.[^,\n]..sg' src/keymaps.csv | uniq
> > 
> > you can see all rows have the same amount of columns
> > 
> > Acked-by: Frediano Ziglio 
> 
> Are we still in sync with gtk-vnc? https://git.gnome.org/browse/gtk-
> vnc/tree/src/keymaps.csv
> 
We are not, recently it was updated for some keys

> An option would be to have a submodule for keymaps and related code,
> to be shared with gtk-vnc, spice-gtk, eventually qemu (and a freerdp
> gtk widget etc)  
> 
I agree, I can create something on our gitlab 

Pavel

> 
> > 
> > OT: why I cannot do SQL queries from github ?
> 
> I had a related idea in the past to have a sql frontend to a git
> repo, last time I searched, couldn't find any.
> 
> > 
> > > ---
> > >  src/keymaps.csv | 702
> > >  
> > >  1 file changed, 351 insertions(+), 351 deletions(-)
> > > 
> > > diff --git a/src/keymaps.csv b/src/keymaps.csv
> > > index 08af269..ef5c33e 100644
> > > --- a/src/keymaps.csv
> > > +++ b/src/keymaps.csv
> > > @@ -133,24 +133,24 @@
> > > KEY_KP2,80,ANSI_Keypad2,0x54,80,114,114,80,80,90,VK_NUMPAD2,0x62
> > > ,80,80,XK_KP_2,0
> > >  KEY_KP3,81,ANSI_Keypad3,0x55,81,122,122,81,81,91,VK_NUMPAD3,0x6
> > > 3,81,81,XK_KP_3,0xffb3
> > >  KEY_KP0,82,ANSI_Keypad0,0x52,82,112,112,82,82,98,VK_NUMPAD0,0x6
> > > 0,82,82,XK_KP_0,0xffb0
> > >  KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,83,113,113,83,83,99,VK_DEC
> > > IMAL,0x6e,83,83,XK_KP_Decimal,0xffae
> > > -,84,,,84,
> > > -KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148
> > > +,84,,,84,,,
> > > +KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148,,
> > >  KEY_102ND,86,,,86,97,19,,86,100,VK_OEM_102,0xe1,86,86,,
> > >  KEY_F11,87,F11,0x67,87,120,86,101,87,68,VK_F11,0x7a,87,87,XK_F1
> > > 1,0xffc8
> > >  KEY_F12,88,F12,0x6f,88,7,94,102,88,69,VK_F12,0x7b,88,88,XK_F12,
> > > 0xffc9
> > > -KEY_RO,89,,,115,81,,,115,135
> > > -KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15
> > > ,,
> > > -KEY_HIRAGANA,91,,,119,98,,,119,147
> > > -KEY_HENKAN,92,,,121,100,134,,121,138
> > > -KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8
> > > -KEY_MUHENKAN,94,,,123,103,133,,123,139
> > > +KEY_RO,89,,,115,81,,,115,135,,
> > > +KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15
> > > 
> > > +KEY_HIRAGANA,91,,,119,98,,,119,147,,
> > > +KEY_HENKAN,92,,,121,100,134,,121,138,,
> > > +KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8,,
> > > +KEY_MUHENKAN,94,,,123,103,133,,123,139,,
> > >  KEY_KPJPCOMMA,95,JIS_KeypadComma,0x5f,92,39,,,92,140,XK_KP_
> > > Separator,0xffac
> > >  KEY_KPENTER,96,ANSI_KeypadEnter,0x4c,,158,121,,284,88,,,0x64,0x
> > > 64,XK_KP_Enter,0xff8d
> > >  KEY_RIGHTCTRL,97,RightControl,0x3e,,,88,,285,228,VK_RCONTROL,0x
> > > a3,0x65,0x65,XK_Control_R,0xffe4
> > >  KEY_KPSLASH,98,ANSI_KeypadDivide,0x4b,,181,119,,309,84,VK_DIVID
> > > E,0x6f,0x68,0x68,XK_KP_Divide,0xffaf
> > >  KEY_SYSRQ,99,,,84,260,87,,84,70,"VK_SNAPSHOT
> > >  ???",0x2c,0x67,0x67,XK_Sys_Req,0xff15
> > >  KEY_RIGHTALT,100,RightOption,0x3d,,,57,,312,230,VK_RMENU,0xa5,0
> > > x69,0x69,XK_Alt_R,0xffea
> > > -KEY_LINEFEED,101,,,91,
> > > +KEY_LINEFEED,101,,,91,,,
> > >  KEY_HOME,102,Home,0x73,,224,110,,327,74,VK_HOME,0x24,0x59,0x59,
> > > XK_Home,0xff50
> > >  KEY_UP,103,UpArrow,0x7e,,236,99,109,328,82,VK_UP,0x26,0x5a,0x5a
> > > ,XK_Up,0xff52
> > >  KEY_PAGEUP,104,PageUp,0x74,,201,111,,329,75,VK_PRIOR,0x21,0x5b,
> > > 0x5b,XK_Page_Up,0xff55
> > > @@ -161,351 +161,351 @@
> > > KEY_DOWN,108,DownArrow,0x7d,,254,96,110,336,81,VK_DOWN,0x28,0x60
> > > ,0x60,XK_Down,0x
> > >  KEY_PAGEDOWN,109,PageDown,0x79,,243,109,,337,78,VK_NEXT,0x22,0x
> > > 61,0x61,XK_Page_Down,0xff56
> > >  KEY_INSERT,110210,103,107,338,73,VK_INSERT,0x2d,0x62,0x62,X
> > > K_Insert,0xff63
> > >  KEY_DELETE,111,ForwardDelete,0x75,,244,100,108,339,76,VK_DELETE
> > > ,0x2e,0x63,0x63,XK_Delete,0x
> > > -KEY_MACRO,112239,142,,367,
> > > -KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad,,,
> > > -KEY_VOLUMEDOWN,114,VolumeDown,0x49,,,157,,302,238,VK_VOLUME_DOW
> > > N,0xae,,
> > > -KEY_VOLUMEUP,115,VolumeUp,0x48,,233,149,,304,237,VK_VOLUME_UP,0
> > > xaf,,
> > > -KEY_POWER,116,,,350,102
> > > +KEY_MACRO,112239,142,,367,,,
> > > +KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad,,,
> > > ,
> > > 

Re: [Spice-devel] [PATCH spice-gtk] keymaps.csv: Add missing columns

[Marc-André Lureau]

Hi

- Original Message -
> > 
> > Allow easier processing by scripts and csv editors
> > ---
> > Also it renders nicely on github
> >  https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv
> > From that ^ table is obvious which values are missing
> 
> With
> 
>   git diff HEAD^ --word-diff --word-diff-regex='[^[:space:]]'
> 
> you can easily see that there's no difference beside the added
> columns at the end and with a
> 
>   perl -pe 's.[^,\n]..sg' src/keymaps.csv | uniq
> 
> you can see all rows have the same amount of columns
> 
> Acked-by: Frediano Ziglio 

Are we still in sync with gtk-vnc? 
https://git.gnome.org/browse/gtk-vnc/tree/src/keymaps.csv

An option would be to have a submodule for keymaps and related code, to be 
shared with gtk-vnc, spice-gtk, eventually qemu (and a freerdp gtk widget etc)  


> 
> OT: why I cannot do SQL queries from github ?

I had a related idea in the past to have a sql frontend to a git repo, last 
time I searched, couldn't find any.

> 
> > ---
> >  src/keymaps.csv | 702
> >  
> >  1 file changed, 351 insertions(+), 351 deletions(-)
> > 
> > diff --git a/src/keymaps.csv b/src/keymaps.csv
> > index 08af269..ef5c33e 100644
> > --- a/src/keymaps.csv
> > +++ b/src/keymaps.csv
> > @@ -133,24 +133,24 @@
> > KEY_KP2,80,ANSI_Keypad2,0x54,80,114,114,80,80,90,VK_NUMPAD2,0x62,80,80,XK_KP_2,0
> >  
> > KEY_KP3,81,ANSI_Keypad3,0x55,81,122,122,81,81,91,VK_NUMPAD3,0x63,81,81,XK_KP_3,0xffb3
> >  
> > KEY_KP0,82,ANSI_Keypad0,0x52,82,112,112,82,82,98,VK_NUMPAD0,0x60,82,82,XK_KP_0,0xffb0
> >  
> > KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,83,113,113,83,83,99,VK_DECIMAL,0x6e,83,83,XK_KP_Decimal,0xffae
> > -,84,,,84,
> > -KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148
> > +,84,,,84,,,
> > +KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148,,
> >  KEY_102ND,86,,,86,97,19,,86,100,VK_OEM_102,0xe1,86,86,,
> >  KEY_F11,87,F11,0x67,87,120,86,101,87,68,VK_F11,0x7a,87,87,XK_F11,0xffc8
> >  KEY_F12,88,F12,0x6f,88,7,94,102,88,69,VK_F12,0x7b,88,88,XK_F12,0xffc9
> > -KEY_RO,89,,,115,81,,,115,135
> > -KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15,,
> > -KEY_HIRAGANA,91,,,119,98,,,119,147
> > -KEY_HENKAN,92,,,121,100,134,,121,138
> > -KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8
> > -KEY_MUHENKAN,94,,,123,103,133,,123,139
> > +KEY_RO,89,,,115,81,,,115,135,,
> > +KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15
> > +KEY_HIRAGANA,91,,,119,98,,,119,147,,
> > +KEY_HENKAN,92,,,121,100,134,,121,138,,
> > +KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8,,
> > +KEY_MUHENKAN,94,,,123,103,133,,123,139,,
> >  
> > KEY_KPJPCOMMA,95,JIS_KeypadComma,0x5f,92,39,,,92,140,XK_KP_Separator,0xffac
> >  
> > KEY_KPENTER,96,ANSI_KeypadEnter,0x4c,,158,121,,284,88,,,0x64,0x64,XK_KP_Enter,0xff8d
> >  
> > KEY_RIGHTCTRL,97,RightControl,0x3e,,,88,,285,228,VK_RCONTROL,0xa3,0x65,0x65,XK_Control_R,0xffe4
> >  
> > KEY_KPSLASH,98,ANSI_KeypadDivide,0x4b,,181,119,,309,84,VK_DIVIDE,0x6f,0x68,0x68,XK_KP_Divide,0xffaf
> >  KEY_SYSRQ,99,,,84,260,87,,84,70,"VK_SNAPSHOT
> >  ???",0x2c,0x67,0x67,XK_Sys_Req,0xff15
> >  
> > KEY_RIGHTALT,100,RightOption,0x3d,,,57,,312,230,VK_RMENU,0xa5,0x69,0x69,XK_Alt_R,0xffea
> > -KEY_LINEFEED,101,,,91,
> > +KEY_LINEFEED,101,,,91,,,
> >  
> > KEY_HOME,102,Home,0x73,,224,110,,327,74,VK_HOME,0x24,0x59,0x59,XK_Home,0xff50
> >  
> > KEY_UP,103,UpArrow,0x7e,,236,99,109,328,82,VK_UP,0x26,0x5a,0x5a,XK_Up,0xff52
> >  
> > KEY_PAGEUP,104,PageUp,0x74,,201,111,,329,75,VK_PRIOR,0x21,0x5b,0x5b,XK_Page_Up,0xff55
> > @@ -161,351 +161,351 @@
> > KEY_DOWN,108,DownArrow,0x7d,,254,96,110,336,81,VK_DOWN,0x28,0x60,0x60,XK_Down,0x
> >  
> > KEY_PAGEDOWN,109,PageDown,0x79,,243,109,,337,78,VK_NEXT,0x22,0x61,0x61,XK_Page_Down,0xff56
> >  
> > KEY_INSERT,110210,103,107,338,73,VK_INSERT,0x2d,0x62,0x62,XK_Insert,0xff63
> >  
> > KEY_DELETE,111,ForwardDelete,0x75,,244,100,108,339,76,VK_DELETE,0x2e,0x63,0x63,XK_Delete,0x
> > -KEY_MACRO,112239,142,,367,
> > -KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad,,,
> > -KEY_VOLUMEDOWN,114,VolumeDown,0x49,,,157,,302,238,VK_VOLUME_DOWN,0xae,,
> > -KEY_VOLUMEUP,115,VolumeUp,0x48,,233,149,,304,237,VK_VOLUME_UP,0xaf,,
> > -KEY_POWER,116,,,350,102
> > +KEY_MACRO,112239,142,,367,,,
> > +KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad
> > +KEY_VOLUMEDOWN,114,VolumeDown,0x49,,,157,,302,238,VK_VOLUME_DOWN,0xae
> > +KEY_VOLUMEUP,115,VolumeUp,0x48,,233,149,,304,237,VK_VOLUME_UP,0xaf
> > +KEY_POWER,116,,,350,102,,
> >  
> > KEY_KPEQUAL,117,ANSI_KeypadEquals,0x51,89,15,,,89,103,,,0x76,0x76,XK_KP_Equal,0xffbd
> > -KEY_KPPLUSMINUS,118206,,,334,
> > +KEY_KPPLUSMINUS,118206,,,334,,,
> >  KEY_PAUSE,119198,98,,326,72,VK_PAUSE,0x013,0x66,0x66,XK_Pause,0xff13
> > -KEY_SCALE,120,,,267,
> > 

Re: [Spice-devel] [PATCH spice-gtk] keymaps.csv: Add missing columns

[Pavel Grunt]

On Tue, 2017-02-14 at 07:07 -0500, Frediano Ziglio wrote:
> > 
> > Allow easier processing by scripts and csv editors
> > ---
> > Also it renders nicely on github
> >  https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv
> > From that ^ table is obvious which values are missing
> 
> With
> 
>   git diff HEAD^ --word-diff --word-diff-regex='[^[:space:]]'
> 
> you can easily see that there's no difference beside the added
> columns at the end and with a
> 
>   perl -pe 's.[^,\n]..sg' src/keymaps.csv | uniq
> 
> you can see all rows have the same amount of columns

I'll append it to the commit log

> 
> Acked-by: Frediano Ziglio 
> 
> Frediano
> 
> OT: why I cannot do SQL queries from github ?

What do you mean?

Thanks,
Pavel

> 
> > ---
> >  src/keymaps.csv | 702
> >  
> >  1 file changed, 351 insertions(+), 351 deletions(-)
> > 
> > diff --git a/src/keymaps.csv b/src/keymaps.csv
> > index 08af269..ef5c33e 100644
> > --- a/src/keymaps.csv
> > +++ b/src/keymaps.csv
> > @@ -133,24 +133,24 @@
> > KEY_KP2,80,ANSI_Keypad2,0x54,80,114,114,80,80,90,VK_NUMPAD2,0x62,8
> > 0,80,XK_KP_2,0
> >  KEY_KP3,81,ANSI_Keypad3,0x55,81,122,122,81,81,91,VK_NUMPAD3,0x63,
> > 81,81,XK_KP_3,0xffb3
> >  KEY_KP0,82,ANSI_Keypad0,0x52,82,112,112,82,82,98,VK_NUMPAD0,0x60,
> > 82,82,XK_KP_0,0xffb0
> >  KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,83,113,113,83,83,99,VK_DECIM
> > AL,0x6e,83,83,XK_KP_Decimal,0xffae
> > -,84,,,84,
> > -KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148
> > +,84,,,84,,,
> > +KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148,,
> >  KEY_102ND,86,,,86,97,19,,86,100,VK_OEM_102,0xe1,86,86,,
> >  KEY_F11,87,F11,0x67,87,120,86,101,87,68,VK_F11,0x7a,87,87,XK_F11,
> > 0xffc8
> >  KEY_F12,88,F12,0x6f,88,7,94,102,88,69,VK_F12,0x7b,88,88,XK_F12,0x
> > ffc9
> > -KEY_RO,89,,,115,81,,,115,135
> > -KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15,,
> > -KEY_HIRAGANA,91,,,119,98,,,119,147
> > -KEY_HENKAN,92,,,121,100,134,,121,138
> > -KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8
> > -KEY_MUHENKAN,94,,,123,103,133,,123,139
> > +KEY_RO,89,,,115,81,,,115,135,,
> > +KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15,,
> > ,,
> > +KEY_HIRAGANA,91,,,119,98,,,119,147,,
> > +KEY_HENKAN,92,,,121,100,134,,121,138,,
> > +KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8,,
> > +KEY_MUHENKAN,94,,,123,103,133,,123,139,,
> >  KEY_KPJPCOMMA,95,JIS_KeypadComma,0x5f,92,39,,,92,140,XK_KP_Se
> > parator,0xffac
> >  KEY_KPENTER,96,ANSI_KeypadEnter,0x4c,,158,121,,284,88,,,0x64,0x64
> > ,XK_KP_Enter,0xff8d
> >  KEY_RIGHTCTRL,97,RightControl,0x3e,,,88,,285,228,VK_RCONTROL,0xa3
> > ,0x65,0x65,XK_Control_R,0xffe4
> >  KEY_KPSLASH,98,ANSI_KeypadDivide,0x4b,,181,119,,309,84,VK_DIVIDE,
> > 0x6f,0x68,0x68,XK_KP_Divide,0xffaf
> >  KEY_SYSRQ,99,,,84,260,87,,84,70,"VK_SNAPSHOT
> >  ???",0x2c,0x67,0x67,XK_Sys_Req,0xff15
> >  KEY_RIGHTALT,100,RightOption,0x3d,,,57,,312,230,VK_RMENU,0xa5,0x6
> > 9,0x69,XK_Alt_R,0xffea
> > -KEY_LINEFEED,101,,,91,
> > +KEY_LINEFEED,101,,,91,,,
> >  KEY_HOME,102,Home,0x73,,224,110,,327,74,VK_HOME,0x24,0x59,0x59,XK
> > _Home,0xff50
> >  KEY_UP,103,UpArrow,0x7e,,236,99,109,328,82,VK_UP,0x26,0x5a,0x5a,X
> > K_Up,0xff52
> >  KEY_PAGEUP,104,PageUp,0x74,,201,111,,329,75,VK_PRIOR,0x21,0x5b,0x
> > 5b,XK_Page_Up,0xff55
> > @@ -161,351 +161,351 @@
> > KEY_DOWN,108,DownArrow,0x7d,,254,96,110,336,81,VK_DOWN,0x28,0x60,0
> > x60,XK_Down,0x
> >  KEY_PAGEDOWN,109,PageDown,0x79,,243,109,,337,78,VK_NEXT,0x22,0x61
> > ,0x61,XK_Page_Down,0xff56
> >  KEY_INSERT,110210,103,107,338,73,VK_INSERT,0x2d,0x62,0x62,XK_
> > Insert,0xff63
> >  KEY_DELETE,111,ForwardDelete,0x75,,244,100,108,339,76,VK_DELETE,0
> > x2e,0x63,0x63,XK_Delete,0x
> > -KEY_MACRO,112239,142,,367,
> > -KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad,,,
> > -KEY_VOLUMEDOWN,114,VolumeDown,0x49,,,157,,302,238,VK_VOLUME_DOWN,
> > 0xae,,
> > -KEY_VOLUMEUP,115,VolumeUp,0x48,,233,149,,304,237,VK_VOLUME_UP,0xa
> > f,,
> > -KEY_POWER,116,,,350,102
> > +KEY_MACRO,112239,142,,367,,,
> > +KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad
> > +KEY_VOLUMEDOWN,114,VolumeDown,0x49,,,157,,302,238,VK_VOLUME_DOWN,
> > 0xae
> > +KEY_VOLUMEUP,115,VolumeUp,0x48,,233,149,,304,237,VK_VOLUME_UP,0xa
> > f
> > +KEY_POWER,116,,,350,102,,
> >  KEY_KPEQUAL,117,ANSI_KeypadEquals,0x51,89,15,,,89,103,,,0x76,0x76
> > ,XK_KP_Equal,0xffbd
> > -KEY_KPPLUSMINUS,118206,,,334,
> > +KEY_KPPLUSMINUS,118206,,,334,,,
> >  KEY_PAUSE,119198,98,,326,72,VK_PAUSE,0x013,0x66,0x66,XK_Pause
> > ,0xff13
> > -KEY_SCALE,120,,,267,
> > -KEY_KPCOMMA,121,ANSI_KeypadClear,0x47,126,109,,,126,133,VK_SE
> > PARATOR??,0x6c,,
> > -KEY_HANGEUL,122144,VK_HANGEUL,0x15,,
> > -KEY_HANJA,123,,,269,145,VK_HANJA,0x19,,
> > 

Re: [Spice-devel] [PATCH spice-gtk] keymaps.csv: Add missing columns

[Frediano Ziglio]

> 
> Allow easier processing by scripts and csv editors
> ---
> Also it renders nicely on github
>  https://github.com/xerus/spice-gtk/blob/keymap/src/keymaps.csv
> From that ^ table is obvious which values are missing

With

  git diff HEAD^ --word-diff --word-diff-regex='[^[:space:]]'

you can easily see that there's no difference beside the added
columns at the end and with a

  perl -pe 's.[^,\n]..sg' src/keymaps.csv | uniq

you can see all rows have the same amount of columns

Acked-by: Frediano Ziglio 

Frediano

OT: why I cannot do SQL queries from github ?

> ---
>  src/keymaps.csv | 702
>  
>  1 file changed, 351 insertions(+), 351 deletions(-)
> 
> diff --git a/src/keymaps.csv b/src/keymaps.csv
> index 08af269..ef5c33e 100644
> --- a/src/keymaps.csv
> +++ b/src/keymaps.csv
> @@ -133,24 +133,24 @@
> KEY_KP2,80,ANSI_Keypad2,0x54,80,114,114,80,80,90,VK_NUMPAD2,0x62,80,80,XK_KP_2,0
>  
> KEY_KP3,81,ANSI_Keypad3,0x55,81,122,122,81,81,91,VK_NUMPAD3,0x63,81,81,XK_KP_3,0xffb3
>  
> KEY_KP0,82,ANSI_Keypad0,0x52,82,112,112,82,82,98,VK_NUMPAD0,0x60,82,82,XK_KP_0,0xffb0
>  
> KEY_KPDOT,83,ANSI_KeypadDecimal,0x41,83,113,113,83,83,99,VK_DECIMAL,0x6e,83,83,XK_KP_Decimal,0xffae
> -,84,,,84,
> -KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148
> +,84,,,84,,,
> +KEY_ZENKAKUHANKAKU,85,,,118,95,,,118,148,,
>  KEY_102ND,86,,,86,97,19,,86,100,VK_OEM_102,0xe1,86,86,,
>  KEY_F11,87,F11,0x67,87,120,86,101,87,68,VK_F11,0x7a,87,87,XK_F11,0xffc8
>  KEY_F12,88,F12,0x6f,88,7,94,102,88,69,VK_F12,0x7b,88,88,XK_F12,0xffc9
> -KEY_RO,89,,,115,81,,,115,135
> -KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15,,
> -KEY_HIRAGANA,91,,,119,98,,,119,147
> -KEY_HENKAN,92,,,121,100,134,,121,138
> -KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8
> -KEY_MUHENKAN,94,,,123,103,133,,123,139
> +KEY_RO,89,,,115,81,,,115,135,,
> +KEY_KATAKANA,90,JIS_Kana,0x68,120,99,,,120,146,VK_KANA,0x15
> +KEY_HIRAGANA,91,,,119,98,,,119,147,,
> +KEY_HENKAN,92,,,121,100,134,,121,138,,
> +KEY_KATAKANAHIRAGANA,93,,,112,19,135,,112,136,,,0xc8,0xc8,,
> +KEY_MUHENKAN,94,,,123,103,133,,123,139,,
>  
> KEY_KPJPCOMMA,95,JIS_KeypadComma,0x5f,92,39,,,92,140,XK_KP_Separator,0xffac
>  
> KEY_KPENTER,96,ANSI_KeypadEnter,0x4c,,158,121,,284,88,,,0x64,0x64,XK_KP_Enter,0xff8d
>  
> KEY_RIGHTCTRL,97,RightControl,0x3e,,,88,,285,228,VK_RCONTROL,0xa3,0x65,0x65,XK_Control_R,0xffe4
>  
> KEY_KPSLASH,98,ANSI_KeypadDivide,0x4b,,181,119,,309,84,VK_DIVIDE,0x6f,0x68,0x68,XK_KP_Divide,0xffaf
>  KEY_SYSRQ,99,,,84,260,87,,84,70,"VK_SNAPSHOT
>  ???",0x2c,0x67,0x67,XK_Sys_Req,0xff15
>  
> KEY_RIGHTALT,100,RightOption,0x3d,,,57,,312,230,VK_RMENU,0xa5,0x69,0x69,XK_Alt_R,0xffea
> -KEY_LINEFEED,101,,,91,
> +KEY_LINEFEED,101,,,91,,,
>  KEY_HOME,102,Home,0x73,,224,110,,327,74,VK_HOME,0x24,0x59,0x59,XK_Home,0xff50
>  KEY_UP,103,UpArrow,0x7e,,236,99,109,328,82,VK_UP,0x26,0x5a,0x5a,XK_Up,0xff52
>  
> KEY_PAGEUP,104,PageUp,0x74,,201,111,,329,75,VK_PRIOR,0x21,0x5b,0x5b,XK_Page_Up,0xff55
> @@ -161,351 +161,351 @@
> KEY_DOWN,108,DownArrow,0x7d,,254,96,110,336,81,VK_DOWN,0x28,0x60,0x60,XK_Down,0x
>  
> KEY_PAGEDOWN,109,PageDown,0x79,,243,109,,337,78,VK_NEXT,0x22,0x61,0x61,XK_Page_Down,0xff56
>  
> KEY_INSERT,110210,103,107,338,73,VK_INSERT,0x2d,0x62,0x62,XK_Insert,0xff63
>  
> KEY_DELETE,111,ForwardDelete,0x75,,244,100,108,339,76,VK_DELETE,0x2e,0x63,0x63,XK_Delete,0x
> -KEY_MACRO,112239,142,,367,
> -KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad,,,
> -KEY_VOLUMEDOWN,114,VolumeDown,0x49,,,157,,302,238,VK_VOLUME_DOWN,0xae,,
> -KEY_VOLUMEUP,115,VolumeUp,0x48,,233,149,,304,237,VK_VOLUME_UP,0xaf,,
> -KEY_POWER,116,,,350,102
> +KEY_MACRO,112239,142,,367,,,
> +KEY_MUTE,113,Mute,0x4a,,251,156,,288,239,VK_VOLUME_MUTE,0xad
> +KEY_VOLUMEDOWN,114,VolumeDown,0x49,,,157,,302,238,VK_VOLUME_DOWN,0xae
> +KEY_VOLUMEUP,115,VolumeUp,0x48,,233,149,,304,237,VK_VOLUME_UP,0xaf
> +KEY_POWER,116,,,350,102,,
>  
> KEY_KPEQUAL,117,ANSI_KeypadEquals,0x51,89,15,,,89,103,,,0x76,0x76,XK_KP_Equal,0xffbd
> -KEY_KPPLUSMINUS,118206,,,334,
> +KEY_KPPLUSMINUS,118206,,,334,,,
>  KEY_PAUSE,119198,98,,326,72,VK_PAUSE,0x013,0x66,0x66,XK_Pause,0xff13
> -KEY_SCALE,120,,,267,
> -KEY_KPCOMMA,121,ANSI_KeypadClear,0x47,126,109,,,126,133,VK_SEPARATOR??,0x6c,,
> -KEY_HANGEUL,122144,VK_HANGEUL,0x15,,
> -KEY_HANJA,123,,,269,145,VK_HANJA,0x19,,
> -KEY_YEN,124,JIS_Yen,0x5d,125,106,,,125,137,,,0x7d,0x7d
> +KEY_SCALE,120,,,267,,,
> +KEY_KPCOMMA,121,ANSI_KeypadClear,0x47,126,109,,,126,133,VK_SEPARATOR??,0x6c
> +KEY_HANGEUL,122144,VK_HANGEUL,0x15
> +KEY_HANJA,123,,,269,145,VK_HANJA,0x19
> +KEY_YEN,124,JIS_Yen,0x5d,125,106,,,125,137,,,0x7d,0x7d,,
>  
> KEY_LEFTMETA,125,Command,0x37,,,139,,347,227,VK_LWIN,0x5b,0x6b,0x6b,XK_Meta_L,0xffe7
>