Re: [sqlite] sqlar: makeDirectory called with permission bits of file
Hi Richard, Dominique, I downloaded and compiled the latest trunk and can confirm that it fixes this issue. Thanks! Martin > -Ursprüngliche Nachricht- > Von: sqlite-users Im Auftrag > von Dominique Devienne > Gesendet: Dienstag, 26. März 2019 11:57 > An: SQLite mailing list > Betreff: Re: [sqlite] sqlar: makeDirectory called with permission bits of file > > On Mon, Mar 25, 2019 at 4:07 PM Richard Hipp wrote: > > > Please try the latest trunk check-in and let use know whether or not > > it fixes your issue. > > > > For reference: > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.sqlite.org%2Fsrc%2Finfo%2Ff11c89595dc65f89data= > 02%7C01%7Cmartin.winter%40siemens.com%7C1113089fb4244966380f08d6b1d9dc0e%7C38ae3bcd95794fd4addab42e1495d55a%7C1 > %7C0%7C636891946588855618sdata=wfFUEcCLLZdHUnrma8v1H20CD21yWtbYjgzXOz1Qgcw%3Dreserved=0 > ___ > sqlite-users mailing list > sqlite-users@mailinglists.sqlite.org > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmailinglists.sqlite.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fsqlite- > usersdata=02%7C01%7Cmartin.winter%40siemens.com%7C1113089fb4244966380f08d6b1d9dc0e%7C38ae3bcd95794fd4addab42 > e1495d55a%7C1%7C0%7C636891946588855618sdata=037IGJUPbMFKR%2B74Sc9zYU6okBgB7GEbUuWZWQQbFH4%3Dr > eserved=0 ___ sqlite-users mailing list sqlite-users@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Re: [sqlite] sqlar: makeDirectory called with permission bits of file
On Mon, Mar 25, 2019 at 4:07 PM Richard Hipp wrote: > Please try the latest trunk check-in and let use know whether or not it > fixes your issue. > For reference: https://www.sqlite.org/src/info/f11c89595dc65f89 ___ sqlite-users mailing list sqlite-users@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Re: [sqlite] sqlar: makeDirectory called with permission bits of file
Please try the latest trunk check-in and let use know whether or not it fixes your issue. On 3/25/19, Winter, Martin wrote: > Hi all, > > since I have received no reaction to my contribution, would like to draw > your attention to it again. > > It is annoying that you get an error message when extracting files from an > sqlar archive using sqlite3 -Ax when this archive contains files with > permission bits 0664 in subdirectories, as the directories are created > without the "x" bit set. > > I think that is not what the user expects and should be changed. > > Thanks > Martin > >> -Ursprüngliche Nachricht- >> Von: Winter, Martin (CT RDA IOT EWT-DE) >> Gesendet: Montag, 11. März 2019 08:01 >> An: 'sqlite-users@mailinglists.sqlite.org' >> >> Betreff: sqlar: makeDirectory called with permission bits of file >> >> Hi, >> >> when extracting files in subdirectories from an sqlar archive, or when >> otherwise using the writefile function to create a file in a >> subdirectory, the makeDirectory function is called with the permission >> bits of the file. If e.g. the file has permission bits 0664, then the >> directory will have the same bits set, which results in a directory in >> which files cannot be accessed, as the execute bits are not set. >> >> In this situation the permission bits of the directory are not explicitly >> given. However it would be much more appropriate to assume a >> 0755 permission for the directory, instead of using those of the file. >> >> In the current code base the relevant code can be found at >> >> https://www.sqlite.org/src/artifact?udc=1=on=e7864c391e14ccaf >> >> line 481ff, where the "mode" variable is used both to create the file and >> to create the directory, if necessary. >> >> Martin > ___ > sqlite-users mailing list > sqlite-users@mailinglists.sqlite.org > http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users > -- D. Richard Hipp d...@sqlite.org ___ sqlite-users mailing list sqlite-users@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Re: [sqlite] sqlar: makeDirectory called with permission bits of file
Hi all, since I have received no reaction to my contribution, would like to draw your attention to it again. It is annoying that you get an error message when extracting files from an sqlar archive using sqlite3 -Ax when this archive contains files with permission bits 0664 in subdirectories, as the directories are created without the "x" bit set. I think that is not what the user expects and should be changed. Thanks Martin > -Ursprüngliche Nachricht- > Von: Winter, Martin (CT RDA IOT EWT-DE) > Gesendet: Montag, 11. März 2019 08:01 > An: 'sqlite-users@mailinglists.sqlite.org' > > Betreff: sqlar: makeDirectory called with permission bits of file > > Hi, > > when extracting files in subdirectories from an sqlar archive, or when > otherwise using the writefile function to create a file in a > subdirectory, the makeDirectory function is called with the permission bits > of the file. If e.g. the file has permission bits 0664, then the > directory will have the same bits set, which results in a directory in which > files cannot be accessed, as the execute bits are not set. > > In this situation the permission bits of the directory are not explicitly > given. However it would be much more appropriate to assume a > 0755 permission for the directory, instead of using those of the file. > > In the current code base the relevant code can be found at > > https://www.sqlite.org/src/artifact?udc=1=on=e7864c391e14ccaf > > line 481ff, where the "mode" variable is used both to create the file and to > create the directory, if necessary. > > Martin ___ sqlite-users mailing list sqlite-users@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
[sqlite] sqlar: makeDirectory called with permission bits of file
Hi, when extracting files in subdirectories from an sqlar archive, or when otherwise using the writefile function to create a file in a subdirectory, the makeDirectory function is called with the permission bits of the file. If e.g. the file has permission bits 0664, then the directory will have the same bits set, which results in a directory in which files cannot be accessed, as the execute bits are not set. In this situation the permission bits of the directory are not explicitly given. However it would be much more appropriate to assume a 0755 permission for the directory, instead of using those of the file. In the current code base the relevant code can be found at https://www.sqlite.org/src/artifact?udc=1=on=e7864c391e14ccaf line 481ff, where the "mode" variable is used both to create the file and to create the directory, if necessary. Martin ___ sqlite-users mailing list sqlite-users@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
