Re: [sqlite] SQLITE 3.8.3 beta: SQLITE_OMIT_CTE build doesn't work
2014/1/20 Richard Hipp : > That single-macro fix allows it to compile and run. But there are memory > leaks associated with that fix that would need to be plugged before we > could use it in a release. Well, I didn't think about memory leaks Never mind. Since CTE doesn't make much difference in library size (only 5Kb on x86_64), I don't know if anyone would actually want CTE to be removed. I just tried it out of curiosity. Thanks! Jan Nijtmans ___ sqlite-users mailing list sqlite-users@sqlite.org http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
Re: [sqlite] SQLITE 3.8.3 beta: SQLITE_OMIT_CTE build doesn't work
On Mon, Jan 20, 2014 at 9:23 AM, Jan Nijtmans wrote: > 2014/1/20 Dan Kennedy : > > Looks like SQLITE_OMIT_CTE only works with full source builds, not > > the amalgamation. As it causes code to be omitted from parse.y. > > > > There are a few others this is true of as well - OMIT_VIRTUALTABLE, > > OMIT_TRIGGER etc. > > Sure, but since addition of a single macro fixes this, I > would say: why not fixing it? > That single-macro fix allows it to compile and run. But there are memory leaks associated with that fix that would need to be plugged before we could use it in a release. -- D. Richard Hipp d...@sqlite.org ___ sqlite-users mailing list sqlite-users@sqlite.org http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
Re: [sqlite] SQLITE 3.8.3 beta: SQLITE_OMIT_CTE build doesn't work
2014/1/20 Dan Kennedy : > Looks like SQLITE_OMIT_CTE only works with full source builds, not > the amalgamation. As it causes code to be omitted from parse.y. > > There are a few others this is true of as well - OMIT_VIRTUALTABLE, > OMIT_TRIGGER etc. Sure, but since addition of a single macro fixes this, I would say: why not fixing it? But - of course- that's up to you. Regards, Jan Nijtmans ___ sqlite-users mailing list sqlite-users@sqlite.org http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
Re: [sqlite] SQLITE 3.8.3 beta: SQLITE_OMIT_CTE build doesn't work
On 01/20/2014 08:36 PM, Jan Nijtmans wrote: $ gcc -c -Wall -o sqlite3.o -DSQLITE_OMIT_CTE sqlite3.c sqlite3.c: In function ‘yy_reduce’: sqlite3.c:117782:3: warning: implicit declaration of function ‘sqlite3WithAdd’ [-Wimplicit-function-declaration] yygotominor.yy59 = sqlite3WithAdd(pParse, 0, &yymsp[-5].minor.yy0, yymsp[-4].minor.yy14, yymsp[-1].minor.yy3); ^ sqlite3.c:117782:20: warning: assignment makes pointer from integer without a cast [enabled by default] yygotominor.yy59 = sqlite3WithAdd(pParse, 0, &yymsp[-5].minor.yy0, yymsp[-4].minor.yy14, yymsp[-1].minor.yy3); ^ sqlite3.c:117787:20: warning: assignment makes pointer from integer without a cast [enabled by default] yygotominor.yy59 = sqlite3WithAdd(pParse, yymsp[-7].minor.yy59, &yymsp[-5].minor.yy0, yymsp[-4].minor.yy14, yymsp[-1].minor.yy3); ^ Looks like SQLITE_OMIT_CTE only works with full source builds, not the amalgamation. As it causes code to be omitted from parse.y. There are a few others this is true of as well - OMIT_VIRTUALTABLE, OMIT_TRIGGER etc. Dan. ___ sqlite-users mailing list sqlite-users@sqlite.org http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users