Re: [sqlite] The old bug strikes back

2008-09-23 Thread Dennis Cote
Shane Harrelson wrote:
 This was my fault.   http://www.sqlite.org/cvstrac/chngview?cn=5654
 strcasecmp() isn't available on all platforms, and I naively assumed
 sqlite3StrICmp() would be (it's not in this case do to the way you
 are compiling/linking).   I'll review the issue and see what I can do.
 

I see this was addressed by checkin [5735] at 
http://www.sqlite.org/cvstrac/chngview?cn=5735.

It seems to me there may be an oversight here. The original function was 
strcasecmp() not strcmp(). The code in question was doing case 
insensitive string comparisons, but it is now doing case sensitive 
comparisons. This may lead to a change in behavior if the string 
zConflict is not constrained to be lower case elsewhere in the code.

HTH
Dennis Cote
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


Re: [sqlite] The old bug strikes back

2008-09-23 Thread D. Richard Hipp

On Sep 23, 2008, at 10:31 AM, Dennis Cote wrote:

 Shane Harrelson wrote:
 This was my fault.   http://www.sqlite.org/cvstrac/chngview?cn=5654
 strcasecmp() isn't available on all platforms, and I naively assumed
 sqlite3StrICmp() would be (it's not in this case do to the way you
 are compiling/linking).   I'll review the issue and see what I can  
 do.


 I see this was addressed by checkin [5735] at
 http://www.sqlite.org/cvstrac/chngview?cn=5735.

 It seems to me there may be an oversight here. The original function  
 was
 strcasecmp() not strcmp(). The code in question was doing case
 insensitive string comparisons, but it is now doing case sensitive
 comparisons. This may lead to a change in behavior if the string
 zConflict is not constrained to be lower case elsewhere in the code.


The COPY method in the TCL interface has never been documented, I  
don't believe.   And TCL is a case-sensitive language.  So I don't  
think this is going to be a big issue.

D. Richard Hipp
[EMAIL PROTECTED]



___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


[sqlite] The old bug strikes back

2008-09-22 Thread Zbigniew Baniewski
On Mon, Sep 22, 2008 at 08:03:49AM -0400, D. Richard Hipp wrote:

 Version 3.6.3 fixes several bugs in version 3.6.2, most notably the  
 problem with DISTINCT.

Just tried to compile and link against TCL 8.5.4 - unfortunately, after the
compilation:

#v+
% package require sqlite3
couldn't load file /usr/lib/tcl8.4/sqlite3/libtclsqlite3.so:
% /usr/lib/tcl8.4/sqlite3/libtclsqlite3.so: undefined symbol: sqlite3StrICmp
#v-

The problem was there before:
http://www.mail-archive.com/sqlite-users@sqlite.org/msg32800.html

And yes, renaming all sqlite3StrICmp occurences to strcasecmp (file
tclsqlite.c) fixed the problem (I guess).
-- 
pozdrawiam / regards

Zbigniew Baniewski
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users


Re: [sqlite] The old bug strikes back

2008-09-22 Thread Shane Harrelson
This was my fault.   http://www.sqlite.org/cvstrac/chngview?cn=5654
strcasecmp() isn't available on all platforms, and I naively assumed
sqlite3StrICmp() would be (it's not in this case do to the way you
are compiling/linking).   I'll review the issue and see what I can do.

On Mon, Sep 22, 2008 at 4:30 PM, Zbigniew Baniewski [EMAIL PROTECTED] wrote:

 On Mon, Sep 22, 2008 at 08:03:49AM -0400, D. Richard Hipp wrote:

  Version 3.6.3 fixes several bugs in version 3.6.2, most notably the
  problem with DISTINCT.

 Just tried to compile and link against TCL 8.5.4 - unfortunately, after the
 compilation:

 #v+
 % package require sqlite3
 couldn't load file /usr/lib/tcl8.4/sqlite3/libtclsqlite3.so:
 % /usr/lib/tcl8.4/sqlite3/libtclsqlite3.so: undefined symbol:
 sqlite3StrICmp
 #v-

 The problem was there before:
 http://www.mail-archive.com/sqlite-users@sqlite.org/msg32800.html

 And yes, renaming all sqlite3StrICmp occurences to strcasecmp (file
 tclsqlite.c) fixed the problem (I guess).
 --
pozdrawiam / regards

Zbigniew Baniewski
 ___
 sqlite-users mailing list
 sqlite-users@sqlite.org
 http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users