Re: Need help with dns_query patch

2005-07-14 Thread Duane Wessels 




On Wed, 13 Jul 2005, Luigi Gangitano wrote:


Hi,
I packaged an update squid 2.4.STABLE6 for Debian woody with the
backported squid-2.5.STABLE9-dns_query from RedHat RHSA-2005-489, which
is quite straight.

With this patch squid fails[1] with

 rfc1035.c:410: rfc1035RRUnpack: Assertion `(*off) = sz' failed

which can be reproduced accessing

 http://62.26.121.2:80/dat/bgf/trpix.gif

This seems to happen on SuSE squid-2.5.STABLE1[2] too.

I cannot understand the RFC1035 code enough to debug it, can you please
help?


Hi Luigi,

I can (mostly) understand the RFC1035 code, but I cannot reproduce this
bug.  Can you reproduce it?

If you can get a core file and stack trace that would be helpful.
Also if you know anything about the type of nameserver that Squid
is using in this case (BIND, dnscache, etc)?

Since the URL contains an IP address, Squid should not issue
a name-to-address DNS query.  Perhaps Squid is configured to make
address-to-name (PTR) queries and this is why the rfc1035.c code
gets called for this request.

Duane W.

Squid 3 build problem on RedHat Enterprise Linux 3 update 4

2005-07-14 Thread Andrey Shorin 
Hello Squid,

[EMAIL PROTECTED] squid3-anon]$ make
...
if g++ -DHAVE_CONFIG_H -I. -I. -I../include -I../include -I../include 
-I../lib/cppunit-1.10.0/include -I ../lib/cppunit-1.10.0/include   -Werror 
-Wall -Wpointer-arith -Wwrite-strings -Wcomments  -D_REENTRANT -g -O2 -MT 
MemPool.o -MD -MP -MF .deps/MemPool.Tpo -c -o MemPool.o MemPool.cc; \
then mv -f .deps/MemPool.Tpo .deps/MemPool.Po; else rm -f 
.deps/MemPool.Tpo; exit 1; fi
cc1plus: warnings being treated as errors
In file included from ../include/Stack.h:37,
 from ../include/splay.h:11,
 from ../include/MemPool.h:9,
 from MemPool.cc:87:
../include/Array.h: In member function `VectorE VectorE::operator+=(E)':
../include/Array.h:95: warning: no return statement in function returning 
   non-void
make[2]: *** [MemPool.o] Error 1
make[2]: Leaving directory `/home/tolsty/squid/squid3-anon/lib'

Line 95 is:
Vector operator += (E item) {push_back(item);};

And the compiler installed with OS is:
[EMAIL PROTECTED] squid3-anon]$ g++ -v
Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/3.2.3/specs
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man 
--infodir=/usr/share/info --enable-shared --enable-threads=posix 
--disable-checking --with-system-zlib --enable-__cxa_atexit 
--host=i386-redhat-linux
Thread model: posix
gcc version 3.2.3 20030502 (Red Hat Linux 3.2.3-47)



Strangely, I don't receive a warning on FreeBSD 5.4
tolsty:~/squid/squid3-anon$ g++ -v
Using built-in specs.
Configured with: FreeBSD/i386 system compiler
Thread model: posix
gcc version 3.4.2 [FreeBSD] 20040728

-- 
Best regards,
 Andrey Shorin