Re: Bug review request
sön 2006-08-13 klockan 22:37 +0200 skrev Guido Serassio: > Hi, > > I'm trying to close the Bug #212. > Someone could review the proposed patch ? > > It' should be incomplete, some errors still need to be verified. Looked at it and my gut feeling is that errorCon should be extended with a request_t argument, pulling all the common details of the request.. ->request ->src_addr ->auth_user_request and maybe more.. there is a bit too much poorly duplicated core surrounding this function today.. Note: fwdFail() tries to patch some of the blank spots, but not all, and is only relevant late in the processing.. Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Bug review request
Hi, I'm trying to close the Bug #212. Someone could review the proposed patch ? It' should be incomplete, some errors still need to be verified. Thanks for any comment. Regards Guido - Guido Serassio Acme Consulting S.r.l. - Microsoft Certified Partner Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY Tel. : +39.011.9530135 Fax. : +39.011.9781115 Email: [EMAIL PROTECTED] WWW: http://www.acmeconsulting.it/
Re: 2.6 HEAD doesn't compile
sön 2006-08-13 klockan 10:27 +0800 skrev Adrian Chadd: > On Sun, Aug 13, 2006, Henrik Nordstrom wrote: > > /home/henrik/SRC/squid/commit-2.6/src/comm.c: In function > > 'CommWriteStateCallbackAndFree': > > /home/henrik/SRC/squid/commit-2.6/src/comm.c:85: warning: comparison > > between pointer and integer > > > > I assume this is from Adrians comm_write optimizations.. > > Eww. How'd this happen? I wasn't getting any errors here.. > I'll check it out in a minute. http://www.squid-cache.org/Versions/v2/2.6/changesets/10918.patch NULL is a (void *)... Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
