Re: ICAP Parental Control Extension, patch to 2.5 STABLE 10

[Gernot Tenchio]

On Mon, 4 Dec 2006 16:26:49 +0200
"Moshe Beeri" <[EMAIL PROTECTED]> wrote:

> I tried again, I could not feagure out what is distclean command,
> Where can I find the distclean command, did you meant 'make distclean'.
> I diffed pre configured src tree.
> 
> Moshe Beeri.

Yes, I mean 'make distclean'. You should consider that there are many
subscribers to the squid mailing list. The mail is delivered to every
subriber out there. 4.4MB * 100 Subscibers are 440MB of traffic and I think
there are a lot more subscribers.

Normally even a distclean is not enough. You should consider to remove all
auto generated stuff like Makefile.in files and so on. Or even better, don't
send the patch at all and give a download location instead.

Regards, Gernot

-- 
Mahatma Glück, Mahatma Pech, Mahatma Gandhi.
-- indian proverb


signature.asc
Description: PGP signature

Re: [squid-users] Re: Upcoming Squid-2.6 work

[Adrian Chadd]

On Mon, Dec 04, 2006, Pablo Garc?a wrote:
> Adrian, no bugs so far.
> I have a little increase in the overall cpu usage ~6%, but also a
> little decrease in response times ~5%

Aha!

> This is My setup
> Running as accelerator. 69% hit ratio, 93% byte Ratio, ~30 Req/s
> 2 x 2.8 Ghz Xeon (HT disabled), Redhat ES 4 Update 4

Thing is, you shouldn't see -that- much of a response time drop
with my initial work if you're only doing 30 req/sec. I was kinda hoping
to get feedback from someone running 1000 req/sec. :) At least there've
been no problems thus far which is great.

I'll announce when I've got my next lot of performance work done and
try to find some testers.

Thanks!



Adrian

-- 
- Xenion - http://www.xenion.com.au/ - Hosting and Commercial Squid Support -

Re: [squid-users] Re: Upcoming Squid-2.6 work

[Pablo García]

Adrian, no bugs so far.
I have a little increase in the overall cpu usage ~6%, but also a
little decrease in response times ~5%
This is My setup
Running as accelerator. 69% hit ratio, 93% byte Ratio, ~30 Req/s
2 x 2.8 Ghz Xeon (HT disabled), Redhat ES 4 Update 4
2 x cache_dir aufs 80% free space
access_log none
store_log none
these are my compile options.

--prefix=/usr/local/squid\
--enable-async-io=64\
--enable-storeio=ufs,aufs,coss,null\
--enable-useragent-log\
--enable-referer-log\
--enable-snmp\
--enable-epoll\
--enable-follow-x-forwarded-for\
--enable-x-accelerator-vary\
--with-maxfd=20480

Regards, Pablo

On 11/30/06, Adrian Chadd <[EMAIL PROTECTED]> wrote:

On Wed, Nov 29, 2006, Adrian Chadd wrote:
> Hi everyone,
>
> I'm going to spend the next few weeks slowly bringing over the patches
> I've written in my parserwork SF branch. I'll start with patches which
> reduce pressure on the memory allocator and then move onto incorporating
> the request line pand client-side parser changes I made to Squid-3 a few
> weeks ago.

The first part of this work has been completed. Henrik has plans to roll
another Squid-2.6 stable release soon so please let us know if you're able
to update to the latest squid-2.6 snapshot (tomorrow's should have the
changes I've just made) and let us know if there's any further issues.
Running the snapshot images will help us find and fix bugs before the next
release.

Thanks!




Adrian

--
- Xenion - http://www.xenion.com.au/ - Hosting and Commercial Squid Support -

Squid 3 HEAD - ICAP Modifications

[Axel Westerhold]

Hi everyone,

Second try this time hopefully complete.

This is again patched against Squid 3 HEAD and includes 4 changes I would
like to have when working with webwasher/squid systems.


A.) ICAPServiceRep::TheSessionFailureLimit set through squid.conf
B.) ICAPServiceRep delay for a down service set through squid.conf
C.) Instead of hardcoding the Header used to transfer the username being
able to set the used one through squid.conf
D.) When using X-Authenticated-User in C I need the username to be base64
encoded so I added another option to turn on encoding if needed.



Regards
Axel Westerhold



squid_icap.diff
Description: Binary data

Re: ICAP Parental Control Extension, patch to 2.5 STABLE 10

[Gernot Tenchio]

Am Mon, 4 Dec 2006 11:23:19 +0200
schrieb "Moshe Beeri" <[EMAIL PROTECTED]>:

> Hi Puchar,
> 
> I included the whole ICAP extension, since the original patch couldn't
> patch
> To STABLE 10, I thought it might be helpful for some.
> 
> Do you still think it is too match??
> 
> I used the following command to generate the patch:
> 
> diff -urNp squid-2.5.STABLE10 squid-icap-2.5.STABLE10 >
> PURESIGHT_squid-icap-2.5.STABLE10.patch
> 
> Moshe.

Your patch is full of autogenerated stuff. You should do a distclean
before diffing. The patch should be ~250K after that.

Greets, Gernot
-- 
office: g.tenchio_AT_telco-tech_DOT_de  http://www.telco-tech.de/
privat: gernot_AT_tenchio_DOT_dehttp://www.tenchio.de/

I have discovered that there are two types of command interfaces in the
world of computing: good interfaces and user interfaces.

 -- D. J. Bernstein

Re: Squid-ICAP problem (bug?)

[Tsantilas Christos]

Christophe Boyanique wrote:


Yes we tried it and this leads to segfault too.


:-(



By reading the log I just noticed that with your modification the 
icapReqModPassHttpBody is not called:


This is for the specific request (POST):

2006/11/24 14:15:22| handing request bodies in ICAP REQMOD
2006/11/24 14:15:22| icapReqModReadHttpBody: FD 38 called
2006/11/24 14:15:22| icapReqModReadHttpBody: read returns 33
.
2006/11/24 14:15:22| icap_reqmod.c:882 chunk_size=-2
2006/11/24 14:15:22| icap_reqmod.c:892 http_entity.callback=(nil)
2006/11/24 14:15:22| icap_reqmod.c:894 http_entity.buf.size=27
2006/11/24 14:15:22| icap_reqmod.c:896 http_entity.callback_bufsize=0
2006/11/24 14:15:22| icapSendRespMod: Create a new connection to icap 
server service_4/icap://xx.xx.xx.xx:1344/wwrespmod/?wwprofile=HTTP_



The strange here is that the http_entity.callback=(nil)
In my test cases, this never happens...
II don't know why .
So why is called icapReqModPassHttpBody if the request does not 
contain a body ? And why dos it find 27 bytes of data which is exactly 
the body of the previous request ?


This looks very strange, isn't it ?

Yes it is .

RE: ICAP Parental Control Extension, patch to 2.5 STABLE 10

[Moshe Beeri]

Hi Puchar,

I included the whole ICAP extension, since the original patch couldn't
patch
To STABLE 10, I thought it might be helpful for some.

Do you still think it is too match??

I used the following command to generate the patch:

diff -urNp squid-2.5.STABLE10 squid-icap-2.5.STABLE10 >
PURESIGHT_squid-icap-2.5.STABLE10.patch

Moshe.

-Original Message-
From: Wojciech Puchar [mailto:[EMAIL PROTECTED] 
Sent: Sunday, December 03, 2006 11:45 PM
To: Moshe Beeri
Cc: squid-dev@squid-cache.org
Subject: Re: ICAP Parental Control Extension, patch to 2.5 STABLE 10

how did you managed to make 4.4MB patch?

On Sun, 3 Dec 2006, Moshe Beeri wrote:

> Hi All,
>
>
>
> Patch file for squid 2.5 stable 10 is attached.
>
> This patch file should be patch using the following command in the
> squid-2.5-STABLE10 folder using the following command:
>
> Patch -p1 < PURESIGHT_squid-icap-2.5.STABLE10.patch
>
>
>
> I included a simple "squid.conf" file for example of use.
>
> I hope the patch will be usefull and that it will be used.
>
> I have left the build script I used to compile and test, PSMakefile,
you
> can run it as is, it will configure and make.
>
>
>
>
>
> The following features where added [All changes were made in the
> separate of squid dev team]:
>
>
>
> 1. Direct response to client in case the server permits at req_mod.
>
> 2. Client context information that will be passed to client at
resp_mod.
>
>
>
> Read the conf file, changes are explained at the bottom of the file.
>
>
>
>
>
>
>
> The main changes in squid are:
>
>
>
> file  function name
> remarks
>
>

>

> 
>
> icap_reqmod.c icapReqModReadIcapPart
> icap_direct_response and icap_server_session_context extracting and
> handling
>
> icap_respmod.cicapRespModStart
> decides if to go direct, if not lets
> icap->respmod.icap_server_session_context to handle the context
>
>  getICAPRespModString
> writes the context to ICAP resp mod request header.
>
> icap_common.c icapStateFree
> release (if needed) icap_server_session_context
>
>
>
> http.clook 4 icapRespModStart
when
> calling icapRespModStart it may have -2 in return, they it continues
> with a normal http flow.
>
> structs.h fde
store
> our information regarding each session
>
> _IcapStateData
store
> our information for ICAP resp_mod session
>
> _IcapConfig   stop
> icap related configuration, should be coordinated with cf.data.pre
in
> case you like to add new.
>
> cf.data.pre   icap_req_mod_direct_reply
> -
>
>
> icap_req_mod_direct_reply_resp_info_tag_name-
>
>  icap_req_mod_direct_reply_values
> -all our added configuration.
>
>  icap_session_context_tag_name
> -
>
>
>
> For any other Q's do not hesitate to email me.
>
> [EMAIL PROTECTED]
>
>
>
>
>
> Moshe Beeri,
>
> [EMAIL PROTECTED]
>
> Senior Software Engineer,
>
> Servers and Networking team leader.
>
> PureSight Technologies Ltd,
>
> http://www.puresight.com 
>
> 16 Basel st.
> P.O.B. 4145
> Petah Tikva 49130
> ISRAEL
>
>
>
>
>
>