cache logic ripped!
I've started tearing out the caching logic in storework-cutaway in SF. I'm pretty certain as it stands objects are cached in memory but now never actually used again by subsequent requests. The code path that gets from the redirector/ACL checking logic through to clientCacheHit() and clientProcessRequest() now needs to be tidied up, along with making all transient objects private. I won't be able to work on this for very long (university starts up again next week) so could someone please give me a hand? Thanks, Adrian
Re: Squid3 BodyReader changes
Alex Rousskov wrote: On Sat, 2007-02-17 at 19:00 +0200, Tsantilas Christos wrote: Still exist problems in preview transaction between icap server and squid. There are cases in which the squid-icap does not send the 0; ieof sequence if all the http response body fits in the preview data but sends the 0\r\n\r\n. After that gets the 100 continue icap response but it stops the icap transaction becouse it fails in ICAPModXact::handle100Continue function in the Must exception: Must(state.writing == State::writingPaused); The state.writing here is equal to State::writingPreview According to your trace, Squid actually sent two last-chunks for the Preview, but it is probably the same bug. Actually what I am seeing using wireshark is the: .. 0\r\n\r\n(squid client) ICAP/1.0 100 Continue (icap server responce) 0\r\n\r\n(squid client) So yes I believe it is the same bug, but I thing the problem begins because the state.writing is not updated correctly ... BTW, do you use manual testing for this or do you have an automated collection of test cases? I am using manual testing. Sometimes I am modifying my icap server to simulate cases. I think it will be good if I spend some time to write some test cases using perl Regards, Christos
Squid-ICAP 2.6
Hello, I would like to give a try to the 2.6 branch of the ICAP patch and I didn't manage to apply the patch available at: http://devel.squid-cache.org/projects.html#icap I tried on squid-2.6.STABLE9-20070220, squid-2.6.STABLE9 and squid-2.6.STABLE8 without success. Is there anywhere: - an history if the icap patch ? - a changelog - a documentation explaining on which squid version an icap patch apply ? Regards, Christophe.
Re: cache logic ripped!
On Tue, Feb 20, 2007, Adrian Chadd wrote: I won't be able to work on this for very long (university starts up again next week) so could someone please give me a hand? I've just ripped out clientCacheHit() and the Internal/Special object path. The code in storework-cutaway now compiles and seems to run fine. It doesn't call storeGet*() to do object lookups but I'm still pretty sure its inserting objects into the (memory-only) store. So I'd like to remove that particular bit so nothing is cached in memory; then test this tree as much as possible for correctness. I'll leave the rest of the store API changes until this stuff has been tested a little. (It passes the normal browser tests at home for me.) Adrian
Re: Squid-ICAP 2.6
Bonjour Jeremy, Here is the answer I got, and I managed to patch squid correctly thanks to it: http://www.squid-cache.org/mail-archive/squid-users/200702/0143.html Would you have a corrected patch ? Because I am applying manually and it is a bit long and not obvious to not make a mistake. Christophe.
Re: Squid-ICAP 2.6
Christophe Boyanique a écrit : Hello, I would like to give a try to the 2.6 branch of the ICAP patch and I didn't manage to apply the patch available at: http://devel.squid-cache.org/projects.html#icap I tried on squid-2.6.STABLE9-20070220, squid-2.6.STABLE9 and squid-2.6.STABLE8 without success. Is there anywhere: - an history if the icap patch ? - a changelog - a documentation explaining on which squid version an icap patch apply ? Regards, Christophe. Here is the answer I got, and I managed to patch squid correctly thanks to it: http://www.squid-cache.org/mail-archive/squid-users/200702/0143.html Hope it helps -- Jérémy Lardon Laboratoire DIOM, équipe SATIn - Doctorant 04 77 48 50 34
Re: Squid-ICAP 2.6
Hi Christophe, I think the best is to get the icap branch from cvs: cvs -d :pserver:[EMAIL PROTECTED]:/cvsroot/squid co -r icap-2_6 squid After that run the bootstrap.sh script which included in cvs sources. Do not try to correct rejected patches. The last merge with main squid26 done after STABLE9 released and after some more changes added by squid developers to the main squid26 branch. The current patch does not apply to any stable release but to the latest(I think) squid26 cvs sources. Sorry about that. Regards, Christos Christophe Boyanique wrote: Hello, I would like to give a try to the 2.6 branch of the ICAP patch and I didn't manage to apply the patch available at: http://devel.squid-cache.org/projects.html#icap I tried on squid-2.6.STABLE9-20070220, squid-2.6.STABLE9 and squid-2.6.STABLE8 without success. Is there anywhere: - an history if the icap patch ? - a changelog - a documentation explaining on which squid version an icap patch apply ? Regards, Christophe.
