[Success!] [MERGE] First string-fix merge
This change has been merged. Previous status: Vetoed For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3Cf4ad058f0901310738r4aa58554n33d8166644dbe926%40mail.gmail.com%3E Project: Squid
Re: [MERGE] Removed code handling K&R-style varargs.
hnordstrom has voted approve. Status is now: Semi-approved Comment: Fully agreed. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219614172.9762.2.camel%40loki.home.kinkie.it%3E Project: Squid
Re: [PATCH] broken_posts RFC 2616 violation
hnordstrom has voted approve. Status is now: Approved Comment: Looks fine, even if I don't really like the resulting code style here.. should preferably be rearranged so that all the HTTP_VIOLATIONS code is in one block for clarity, but that may be done separately. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C6b3ee2e2f97b84f9f6d6a47f1db29458.squirrel%40webmail.treenet.co.nz%3E Project: Squid
Re: [PATCH] WCCPv2 documentation and cleanup for bug 2404
hnordstrom has voted approve. Status is now: Approved Comment: Looks fine from what I can tell by reading the patch. To answer one of the questions in the patch: +char buckets[32]; /* Draft indicates 8x 32-bit buckets. ?? */ It's a bitmask. Does not matter if it's defined as 8x32bit or 32x8bit, still the same bitmask size. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4968ABB9.4040002%40treenet.co.nz%3E Project: Squid
Re: [MERGE] Bug 419: Hop by Hop headers MUST NOT be forwarded (attempt 2)
hnordstrom has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C49759168.2080600%40treenet.co.nz%3E Project: Squid
Re: [MERGE] libsquid-compat shuffling pt 1
hnordstrom has voted abstain. Status is now: Waiting Comment: No opinion on this one. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4976E2A2.6010004%40treenet.co.nz%3E Project: Squid
Re: [MERGE] Removed code handling K&R-style varargs.
Alex Rousskov has voted approve. Status is now: Approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1219614172.9762.2.camel%40loki.home.kinkie.it%3E Project: Squid
Re: [MERGE] libsquid-compat shuffling pt 1
Alex Rousskov has voted resubmit. Status is now: Resubmit Comment: s/libsquid-compat/compat/g I think we should be including headers as compat/foo/... and not just foo/... -I directives need to be adjusted for that to happen. This will help with future moves of the compat directory and with avoiding file name clashes. Why prefix file names with squid_? There should not be conflicts if we #include headers with compat/os/... path. Should the compat directory be moved to src/? Or are we going to do that after the rest of Squid code not in src/ moved to src/? BTW, is there new code here or just renaming/moving stuff around? In other words, do we need to review the code? For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4976E2A2.6010004%40treenet.co.nz%3E Project: Squid
Re: [Success!] [MERGE] First string-fix merge
Bundle Buggy wrote: This change has been merged. Previous status: Vetoed For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3Cf4ad058f0901310738r4aa58554n33d8166644dbe926%40mail.gmail.com%3E Project: Squid Aha, here we have the answer of why BB ignored the second submission. Amos -- Please be using Current Stable Squid 2.7.STABLE6 or 3.0.STABLE13 Current Beta Squid 3.1.0.5
Re: [MERGE] libsquid-compat shuffling pt 1
Alex Rousskov wrote: Alex Rousskov has voted resubmit. Status is now: Resubmit Comment: s/libsquid-compat/compat/g I think we should be including headers as compat/foo/... and not just foo/... -I directives need to be adjusted for that to happen. This will help with future moves of the compat directory and with avoiding file name clashes. We discussed using "compat/" before. There are about 1150 possible reasons to add "squid-" to the directory name: http://www.google.co.nz/search?hl=en&q=%2Fcompat%2Fcompat.h Linking to the full name is a good idea though. Why prefix file names with squid_? There should not be conflicts if we #include headers with compat/os/... path. That was the previous naming (squid_windows). I've found a handful of places using just os/freebd.h for example. But if we use the squid-compat/os/ it seems safe. Should the compat directory be moved to src/? Or are we going to do that after the rest of Squid code not in src/ moved to src/? Definitely not at this point. I started with it src/compat/ and had to re-do the location so the helpers, and tools, and legacy bits could use it. And due to some header clashes as mentioned above. One day maybe, but I don't think it likely. This is like an OS API layer used by Squid. Should not be mistaken for part of the squid codebase itself. BTW, is there new code here or just renaming/moving stuff around? In other words, do we need to review the code? It's all just shuffling in this one. But code dependencies and build integrity on non-linux have not been verified. I'd like at lest a build-cycle on any other OS you may have access to. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C4976E2A2.6010004%40treenet.co.nz%3E Project: Squid Amos -- Please be using Current Stable Squid 2.7.STABLE6 or 3.0.STABLE13 Current Beta Squid 3.1.0.5
Re: [MERGE] Bug 419: Hop by Hop headers MUST NOT be forwarded (attempt 2)
Amos Jeffries has voted approve. Status is now: Approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C49759168.2080600%40treenet.co.nz%3E Project: Squid
