Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
Bernhard Schmidt wrote: Hi, Oh drat. I mis-configured my new test setup. Sorry. Revision 8903 has had a more careful set of tests done and fixes that problem. Confirmed. At least I think so, there was quite some trial and error involved to force the dreaded bzr to sync the trees again (after altering it locally by reversing your commit). But I think I finally did it and the resulting binary works fine. Hmm, I noticed that too yesterday. I think this is a cause to ask the experts for a recipe. I've started a thread 'bzr revert' to see if we can get any help on that. Amos -- Please use Squid 2.6STABLE17+ or 3.0STABLE1+ There are serious security advisories out on all earlier releases.
Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
On Mon, 2008-03-24 at 13:57 +0100, Henrik Nordstrom wrote: > On Sun, 2008-03-23 at 23:20 +1200, Amos Jeffries wrote: > > Fix memory leak in Linux builds. bb:comment Just testing whether voting works now. Please ignore. Alex.
Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
Hi, Oh drat. I mis-configured my new test setup. Sorry. Revision 8903 has had a more careful set of tests done and fixes that problem. Confirmed. At least I think so, there was quite some trial and error involved to force the dreaded bzr to sync the trees again (after altering it locally by reversing your commit). But I think I finally did it and the resulting binary works fine. Bernhard
Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
On Sun, 2008-03-23 at 23:20 +1200, Amos Jeffries wrote: > Fix memory leak in Linux builds. bb:approve
Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
Bernhard Schmidt wrote: Amos Jeffries <[EMAIL PROTECTED]> wrote: Fix memory leak in Linux builds. This one seems to break outgoing IPv4 connects (on a dualstacked Squid) bzr trunk revision 8902 fails with | While trying to retrieve the URL: http://www.heise.de/ | | The following error was encountered: | | * Write Error | | The system returned: | | (32) Broken pipe | | An error condition occurred while writing to the network. Please | retry your request. to all IPv4 hosts. IPv6 hosts work fine. Reverting this changeset with $ bzr merge . --revision 8901..8900 fixes the issue. /configure --prefix=/opt/squid3-ipv6 --enable-ipv6 --disable-carp --disable-wccp --disable-wccpv2 --enable-epoll --disable-ident-lookups --with-localhost-ipv6 --enable-async-io --enable-storeio=aufs on Linux Debian unstable. Bernhard Oh drat. I mis-configured my new test setup. Sorry. Revision 8903 has had a more careful set of tests done and fixes that problem. Amos -- Please use Squid 2.6STABLE17+ or 3.0STABLE1+ There are serious security advisories out on all earlier releases.
Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
Amos Jeffries <[EMAIL PROTECTED]> wrote: > Fix memory leak in Linux builds. This one seems to break outgoing IPv4 connects (on a dualstacked Squid) bzr trunk revision 8902 fails with | While trying to retrieve the URL: http://www.heise.de/ | | The following error was encountered: | | * Write Error | | The system returned: | | (32) Broken pipe | | An error condition occurred while writing to the network. Please | retry your request. to all IPv4 hosts. IPv6 hosts work fine. Reverting this changeset with $ bzr merge . --revision 8901..8900 fixes the issue. /configure --prefix=/opt/squid3-ipv6 --enable-ipv6 --disable-carp --disable-wccp --disable-wccpv2 --enable-epoll --disable-ident-lookups --with-localhost-ipv6 --enable-async-io --enable-storeio=aufs on Linux Debian unstable. Bernhard
Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
Amos Jeffries wrote: Fix memory leak in Linux builds. bb:approve
Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage
Bundle Buggy has detected this merge request. For details, see: http://squid-cache.org/bundlebuggy//request/%3C20080323112051.7AD57E6FE9%40treenet.co.nz%3E
