Re: Download time issue: Squid 2.6 - With Icap patch

[Tsantilas Christos]

Hi all,
This line exists in current icap-2_6 branch and in current patch.
It is missing only in 1.89.4.14 version of client_side.c but not in
other versions (older or newer). I do not know why,  probably by accident ..
I don't think that it causes any problem.

Regards,
Christos



Henrik Nordstrom wrote:
> ons 2007-03-14 klockan 17:03 + skrev Suman Mukherjee:
> 
>> I have used the following icap patch:
>> http://devel.squid-cache.org/cgi-bin/diff2/icap-2_6
>>
>> The patch has removed that line.
>>
>> Would you please let me know whether this patch is safe enough or not
>> WITH the line in client_side.c?
> 
> I don't know the icap patch well enough to say why the timeout was
> changed, but adding a lifetime timeout is always safe.
> 
> Regards
> Henrik

RE: Download time issue: Squid 2.6 - With Icap patch

[Henrik Nordstrom]

ons 2007-03-14 klockan 17:03 + skrev Suman Mukherjee:

> I have used the following icap patch:
> http://devel.squid-cache.org/cgi-bin/diff2/icap-2_6
> 
> The patch has removed that line.
> 
> Would you please let me know whether this patch is safe enough or not
> WITH the line in client_side.c?

I don't know the icap patch well enough to say why the timeout was
changed, but adding a lifetime timeout is always safe.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel

RE: Download time issue: Squid 2.6 - With Icap patch

[Suman Mukherjee]

Hi Henrik

Thank you for the clarification.
I have used the following icap patch:
http://devel.squid-cache.org/cgi-bin/diff2/icap-2_6

The patch has removed that line.

Would you please let me know whether this patch is safe enough or not
WITH the line in client_side.c?

Regards
Suman

-Original Message-
From: Henrik Nordstrom [mailto:[EMAIL PROTECTED] 
Sent: 14 March 2007 16:37
To: Suman Mukherjee
Cc: Squid Users; Squid Developers; Thomas-Martin Seck; Tsantilas
Christos
Subject: Re: Download time issue: Squid 2.6

ons 2007-02-21 klockan 16:00 + skrev Suman Mukherjee:

> In Squid 2.6.STABLE9 I have faced a problem.
> While downloading a big file, squid is getting timeout.

I cannot reproduce this..

> Reason:
> There are two socket connections. 
> 1. Accepted request from client side.
> 2. Read data from file descriptor.

Yes..

> However after 5 minutes time frame connection 1 is getting timed out
and
> that forced connection 2 to quit.

Not here.. the client connection gets the Lifetime timeout assigned.

> 
> This got solved when I add the following line in clientReadRequest
> function within client_side.c before line if (parser_return_code < 0)
> 
> commSetTimeout(fd, Config.Timeout.lifetime, clientLifetimeTimeout,
> http);

Now you are making me confused. That exact line is already there since
ages.

1.511(wessels  09-Nov-00):  commSetTimeout(fd,
Config.Timeout.lifetime, clientLifetimeTimeout, http);
1.170(wessels  03-Dec-97):  if (parser_return_code < 0)
{

Do you have any patches applied on your Squid source tree?

The other user said he installed Squid from FreeBSD ports.
Investigating. Hmm.. the FreeBSD ports collection seem to include the
still experimental ICAP client, which for some reason changes the
timeout management removing this line..

Regards
Henrik