Re: TPROXY support in Squid 2

2008-04-09 Thread Adrian Chadd
On Tue, Apr 08, 2008, Henrik Nordstrom wrote:

  http://www.creative.net.au/diffs/20080408-tproxy-fix-2.diff
 
 using -3 instead of -2 looks better... but incomplete.

Oops!

Try http://www.creative.net.au/diffs/20080409-squid2-tproxy-4.diff

 You need to add the new ipt_* files to the EXTRA_squid_SOURCES macro or
 they won't get distributed.

Ok, I'll do that now.

 The ipt_bind call from forward.c should go into comm_openex. Kind of
 pointless with the new flag otherwise.. You said you had done this, but
 not in the -3 patch...

That was done but I wasn't diff'ing comm.c

 And the new flag isn't even defined..

Done.

 Wrong patch version published?

Wrong arguments to cvs diff when trying to avoid diff'ing lots of Makefiles..




Adrian

-- 
- Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support -
- $25/pm entry-level VPSes w/ capped bandwidth charges available in WA -


Re: TPROXY support in Squid 2

2008-04-09 Thread Henrik Nordstrom
ons 2008-04-09 klockan 17:36 +0800 skrev Adrian Chadd:
  The ipt_bind call from forward.c should go into comm_openex. Kind of
  pointless with the new flag otherwise.. You said you had done this, but
  not in the -3 patch...
 
 That was done but I wasn't diff'ing comm.c

Don't forget to remove it from forward.c as well...

Regards
Henrik



Re: TPROXY support in Squid 2

2008-04-09 Thread Adrian Chadd
On Wed, Apr 09, 2008, Henrik Nordstrom wrote:
 ons 2008-04-09 klockan 17:36 +0800 skrev Adrian Chadd:
   The ipt_bind call from forward.c should go into comm_openex. Kind of
   pointless with the new flag otherwise.. You said you had done this, but
   not in the -3 patch...
  
  That was done but I wasn't diff'ing comm.c
 
 Don't forget to remove it from forward.c as well...

Did that in my local copy.

I'd like to commit this (just to get it out of the way) and then delay doing
anything further until I finally resurrect this tproxy2 Debian box.
I'll give it all a good test before I say its functioning normally and begin
integrating tproxy4 and freebsd stuff.




Adrian

-- 
- Xenion - http://www.xenion.com.au/ - VPS Hosting - Commercial Squid Support -
- $25/pm entry-level VPSes w/ capped bandwidth charges available in WA -


Re: TPROXY support in Squid 2

2008-04-08 Thread Henrik Nordstrom
ons 2008-04-09 klockan 00:19 +0800 skrev Adrian Chadd:
 On Tue, Apr 08, 2008, Adrian Chadd wrote:
 
 
 Take 3:
 
 http://www.creative.net.au/diffs/20080408-tproxy-fix-2.diff

using -3 instead of -2 looks better... but incomplete.

You need to add the new ipt_* files to the EXTRA_squid_SOURCES macro or
they won't get distributed.

The ipt_bind call from forward.c should go into comm_openex. Kind of
pointless with the new flag otherwise.. You said you had done this, but
not in the -3 patch...

And the new flag isn't even defined..

Wrong patch version published?

Regards
Henrik