Re: Removed some uses of RefCount::getRaw() in DelayPool.cc

[Tsantilas Christos]

What I am actually getting using g++ 4.1 and g++ 4.2 compilers is:

cc1plus: warnings being treated as errors
DelayPool.cc: In member function ‘void DelayPool::dump(StoreEntry*, 
unsigned int) const’:

DelayPool.cc:72: warning: NULL used in arithmetic

Regards,
Christos

Duane Wessels wrote:


Thanks, I committed your fix.

Strange that it compiled okay for me with --enable-delay-pools on
FreeBSD (gcc 3.4.2).

DW

Re: Removed some uses of RefCount::getRaw() in DelayPool.cc

[Duane Wessels]

On Sun, 22 Apr 2007, Tsantilas Christos wrote:


Hi Duane,

I think there is an error in DelayPool.cc file and squid3 does not
compiles if delay pools are enabled.


Thanks, I committed your fix.

Strange that it compiled okay for me with --enable-delay-pools on
FreeBSD (gcc 3.4.2).

DW

Removed some uses of RefCount::getRaw() in DelayPool.cc

[Tsantilas Christos]

Hi Duane,

 I think there is an error in DelayPool.cc file and squid3 does not
compiles if delay pools are enabled.
The fix is:

--- DelayPool.cc20 Apr 2007 22:51:19 -  1.6
+++ DelayPool.cc22 Apr 2007 07:21:19 -
@@ -69,7 +69,7 @@
 void
 DelayPool::dump (StoreEntry *entry, unsigned int i) const
 {
-if (!theComposite() != NULL)
+if (theComposite() != NULL)
 return;

 storeAppendPrintf(entry, "delay_class %d %s\n", i + 1,
pool->theClassTypeLabel());



Duane Wessels wrote:
> wessels 2007/04/20 16:24:07 MDT
> 
>   
>   Log:
>   Removed some uses of RefCount::getRaw()
>   
>   We can compare RefCount pointers to NULL without using getRaw() as long
>   as the RefCount pointer is on the left, and NULL is on the right.
>   
>   .