Re: bzr issues
On Thu, Apr 3, 2008 at 12:22 AM, Alex Rousskov [EMAIL PROTECTED] wrote: On Thu, 2008-04-03 at 08:55 +1100, Robert Collins wrote: On Wed, 2008-04-02 at 15:52 -0600, Alex Rousskov wrote: On Thu, 2008-04-03 at 08:38 +1100, Robert Collins wrote: On Wed, 2008-04-02 at 11:21 -0600, Alex Rousskov wrote: I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead to _incorrect_ subjects. In addition, a command line option to specify the subject should be added. Amos wasn't entirely clear in his initial report. What is happening is that bzr send when there is no detected desktop mail client is providing a text editor window with *no* facility for setting the subject. This is clearly a usability bug, and once fixed the issue will go away. There is a bug open on this now. The second bug is that the default subject for desktop mail clients is wrong. You want just [MERGE] right ? This is something that bzr developers should decide. IMHO, [MERGE] or [MERGE] PUT SUBJECT HERE or even [MERGE] PUT SUBJECT HERE unique ID may work, I guess. The [MERGE] prefix seems to be needed because otherwise most folks will not know it is required for integration with other tools. However, if those tools differ in their requirements or often not used, then an empty subject is the best solution (some mailers will warn about it even). IMO integration with other tools should use out-of-band information, such as an extra mail header. [MERGE] in the subject is good to interact with humans, but too flimsy to be used with automated tools. -- /kinkie
Re: bzr issues
On Thu, 2008-04-03 at 12:57 +0200, Kinkie wrote: IMO integration with other tools should use out-of-band information, such as an extra mail header. [MERGE] in the subject is good to interact with humans, but too flimsy to be used with automated tools. [MERGE] is used so humans can manually craft emails themselves. -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part
Re: bzr issues
On Tue, 2008-04-01 at 13:34 +1100, Robert Collins wrote: On Tue, 2008-04-01 at 15:18 +1300, Amos Jeffries wrote: I'm getting annoyed by bzr's method of handling bzr send emails. As you may have noticed it adds the subject of the last commit to the email. regardless of the message thats asked for manually during the send process. It would be good if bzr pulled its email subject from that new message. We are going to be sick of feature submissions going up as Merged from trunk because the last the thing the developer did was properly check the branch was up-to-date. I think this is a good suggestion. Its a little complex because most email clients want a subject given when starting the new email, and you can edit the subject *and* the message at that point. I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead to _incorrect_ subjects. In addition, a command line option to specify the subject should be added. Alex.
Re: bzr issues
On Wed, 2008-04-02 at 11:21 -0600, Alex Rousskov wrote: I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead to _incorrect_ subjects. In addition, a command line option to specify the subject should be added. Amos wasn't entirely clear in his initial report. What is happening is that bzr send when there is no detected desktop mail client is providing a text editor window with *no* facility for setting the subject. This is clearly a usability bug, and once fixed the issue will go away. There is a bug open on this now. -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part
Re: bzr issues
On Thu, 2008-04-03 at 08:38 +1100, Robert Collins wrote: On Wed, 2008-04-02 at 11:21 -0600, Alex Rousskov wrote: I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead to _incorrect_ subjects. In addition, a command line option to specify the subject should be added. Amos wasn't entirely clear in his initial report. What is happening is that bzr send when there is no detected desktop mail client is providing a text editor window with *no* facility for setting the subject. This is clearly a usability bug, and once fixed the issue will go away. There is a bug open on this now. The second bug is that the default subject for desktop mail clients is wrong. Alex.
Re: bzr issues
On Thu, 2008-04-03 at 08:55 +1100, Robert Collins wrote: On Wed, 2008-04-02 at 15:52 -0600, Alex Rousskov wrote: On Thu, 2008-04-03 at 08:38 +1100, Robert Collins wrote: On Wed, 2008-04-02 at 11:21 -0600, Alex Rousskov wrote: I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead to _incorrect_ subjects. In addition, a command line option to specify the subject should be added. Amos wasn't entirely clear in his initial report. What is happening is that bzr send when there is no detected desktop mail client is providing a text editor window with *no* facility for setting the subject. This is clearly a usability bug, and once fixed the issue will go away. There is a bug open on this now. The second bug is that the default subject for desktop mail clients is wrong. You want just [MERGE] right ? This is something that bzr developers should decide. IMHO, [MERGE] or [MERGE] PUT SUBJECT HERE or even [MERGE] PUT SUBJECT HERE unique ID may work, I guess. The [MERGE] prefix seems to be needed because otherwise most folks will not know it is required for integration with other tools. However, if those tools differ in their requirements or often not used, then an empty subject is the best solution (some mailers will warn about it even). Thanks, Alex.
Re: bzr issues
On Wed, 2008-04-02 at 15:52 -0600, Alex Rousskov wrote: On Thu, 2008-04-03 at 08:38 +1100, Robert Collins wrote: On Wed, 2008-04-02 at 11:21 -0600, Alex Rousskov wrote: I think an incomplete [MERGE] default subject would be much better that the current behavior that will lead to _incorrect_ subjects. In addition, a command line option to specify the subject should be added. Amos wasn't entirely clear in his initial report. What is happening is that bzr send when there is no detected desktop mail client is providing a text editor window with *no* facility for setting the subject. This is clearly a usability bug, and once fixed the issue will go away. There is a bug open on this now. The second bug is that the default subject for desktop mail clients is wrong. You want just [MERGE] right ? -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part
Re: bzr issues
tor 2008-04-03 klockan 08:55 +1100 skrev Robert Collins: You want just [MERGE] right ? Yes, or at least make it skip changesets which is already on the target branch (i.e. merged from the target) when selecting the subject to use.. Having it pick a subject based on what is a merge from the target can only get bad results. Regards Henrik
bzr issues
I'm getting annoyed by bzr's method of handling bzr send emails. As you may have noticed it adds the subject of the last commit to the email. regardless of the message thats asked for manually during the send process. It would be good if bzr pulled its email subject from that new message. We are going to be sick of feature submissions going up as Merged from trunk because the last the thing the developer did was properly check the branch was up-to-date. Amos
Re: bzr issues
On Tue, 2008-04-01 at 15:18 +1300, Amos Jeffries wrote: I'm getting annoyed by bzr's method of handling bzr send emails. As you may have noticed it adds the subject of the last commit to the email. regardless of the message thats asked for manually during the send process. It would be good if bzr pulled its email subject from that new message. We are going to be sick of feature submissions going up as Merged from trunk because the last the thing the developer did was properly check the branch was up-to-date. I think this is a good suggestion. Its a little complex because most email clients want a subject given when starting the new email, and you can edit the subject *and* the message at that point. Are you perhaps supplying a fully prepared message to bzr send? If so then we should special case that. affects bzr -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part
Re: bzr issues
On Tue, 2008-04-01 at 15:18 +1300, Amos Jeffries wrote: I'm getting annoyed by bzr's method of handling bzr send emails. As you may have noticed it adds the subject of the last commit to the email. regardless of the message thats asked for manually during the send process. It would be good if bzr pulled its email subject from that new message. We are going to be sick of feature submissions going up as Merged from trunk because the last the thing the developer did was properly check the branch was up-to-date. I think this is a good suggestion. Its a little complex because most email clients want a subject given when starting the new email, and you can edit the subject *and* the message at that point. Are you perhaps supplying a fully prepared message to bzr send? If so then we should special case that. affects bzr No. I'm just using: bzr send --mailto=squid-dev.squid-cache.org and entering the message when it asks for one. Amos
Re: bzr issues
On Tue, 2008-04-01 at 15:41 +1300, Amos Jeffries wrote: No. I'm just using: bzr send --mailto=squid-dev.squid-cache.org and entering the message when it asks for one. Is it popping up a gui client, or a text editor? Does it have a field for setting a subject? -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part
Re: bzr issues
On Tue, 2008-04-01 at 15:41 +1300, Amos Jeffries wrote: No. I'm just using: bzr send --mailto=squid-dev.squid-cache.org and entering the message when it asks for one. Is it popping up a gui client, or a text editor? Does it have a field for setting a subject? Just a text editor (nano is my system default). With an empty area for the message followed by a line of '' then the list of altered files etc. Amos
