Re: default Methods?

[Pawel Worach]

Henrik Nordstrom wrote:

tor 2007-03-01 klockan 09:48 +0800 skrev Adrian Chadd:


I've again been bitten by the by default Squid doesn't support methods
for application X where X is almost always Subversion.


Heh..


What do people think about:

* adding in the Subversion methods in by default?


Yes. Do it now and I'll get it shipped in 2.6.STABLE10.



Here are patches for squid2 and squid3 that add three missing methods 
according to the list in the Subversion FAQ.


--
Pawel
Index: src/enums.h
===
RCS file: /squid/squid/src/enums.h,v
retrieving revision 1.237
diff -u -r1.237 enums.h
--- src/enums.h	19 Jan 2007 01:10:12 -	1.237
+++ src/enums.h	3 Mar 2007 14:44:48 -
@@ -418,6 +418,9 @@
 METHOD_UNSUBSCRIBE,
 METHOD_POLL,
 METHOD_REPORT,
+METHOD_MKACTIVITY,
+METHOD_CHECKOUT,
+METHOD_MERGE,
 /* Extension methods must be last, Add any new methods before this line */
 METHOD_EXT00,
 METHOD_EXT01,
Index: src/url.c
===
RCS file: /squid/squid/src/url.c,v
retrieving revision 1.149
diff -u -r1.149 url.c
--- src/url.c	1 Feb 2007 08:32:51 -	1.149
+++ src/url.c	3 Mar 2007 14:44:49 -
@@ -64,6 +64,9 @@
 {(char *) UNSUBSCRIBE, 11},
 {(char *) POLL, 4},
 {(char *) REPORT, 6},
+{(char *) MKACTIVITY, 10},
+{(char *) CHECKOUT, 8},
+{(char *) MERGE, 5},
 {(char *) %EXT00, 6},
 {(char *) %EXT01, 6},
 {(char *) %EXT02, 6},
Index: src/HttpRequestMethod.cc
===
RCS file: /squid/squid3/src/HttpRequestMethod.cc,v
retrieving revision 1.1
diff -u -r1.1 HttpRequestMethod.cc
--- src/HttpRequestMethod.cc	8 May 2006 23:38:33 -	1.1
+++ src/HttpRequestMethod.cc	3 Mar 2007 14:55:50 -
@@ -67,6 +67,9 @@
 UNSUBSCRIBE,
 POLL,
 REPORT,
+MKACTIVITY,
+CHECKOUT,
+MERGE,
 %EXT00,
 %EXT01,
 %EXT02,
Index: src/HttpRequestMethod.h
===
RCS file: /squid/squid3/src/HttpRequestMethod.h,v
retrieving revision 1.3
diff -u -r1.3 HttpRequestMethod.h
--- src/HttpRequestMethod.h	10 May 2006 21:03:04 -	1.3
+++ src/HttpRequestMethod.h	3 Mar 2007 14:55:51 -
@@ -64,6 +64,9 @@
 METHOD_UNSUBSCRIBE,
 METHOD_POLL,
 METHOD_REPORT,
+METHOD_MKACTIVITY,
+METHOD_CHECKOUT,
+METHOD_MERGE,
 METHOD_EXT00,
 METHOD_EXT01,
 METHOD_EXT02,

Re: default Methods?

[Henrik Nordstrom]

lör 2007-03-03 klockan 15:57 +0100 skrev Pawel Worach:

 Here are patches for squid2 and squid3 that add three missing methods 
 according to the list in the Subversion FAQ.

Thanks. Applied to Squid-3, 2 and 2.6.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel

Re: default Methods?

[Henrik Nordstrom]

tor 2007-03-01 klockan 09:48 +0800 skrev Adrian Chadd:

 I've again been bitten by the by default Squid doesn't support methods
 for application X where X is almost always Subversion.

Heh..

 What do people think about:
 
 * adding in the Subversion methods in by default?

Yes. Do it now and I'll get it shipped in 2.6.STABLE10.

 * as a more long-term goal, adding in an option that allows Squid to handle
   any method but only those it knows about will be considered for caching.

Yes. This is one more of those items should be done, but never get to
do it...

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel

Re: default Methods?

[Adrian Chadd]

On Thu, Mar 01, 2007, Henrik Nordstrom wrote:

  * adding in the Subversion methods in by default?
 
 Yes. Do it now and I'll get it shipped in 2.6.STABLE10.

It probably won't happen until late weekend. The university
semester has started up again and I'm possibly hacking
squid on borrowed time now.

 Yes. This is one more of those items should be done, but never get to
 do it...

I'll keep it in mind when thinking about where to take the client-side
code.



Adrian

default Methods?

[Adrian Chadd]

Hi,

I've again been bitten by the by default Squid doesn't support methods
for application X where X is almost always Subversion.

What do people think about:

* adding in the Subversion methods in by default?
* as a more long-term goal, adding in an option that allows Squid to handle
  any method but only those it knows about will be considered for caching.


Thoughts?



Adrian