Re: [squid-users] Squid 3 upgrade_http0.9 option

2009-09-21 Thread Henrik Nordstrom
tis 2009-09-22 klockan 15:39 +1200 skrev Amos Jeffries:

> I gave it a try but got stuck at finding point in 3.x where the headers
> were upgrade-changed. Seems to be a bit dispersed in 3.x.

That's why I gave the patch as reference... What it is doing is skipping
to produce the headers if the reply was < 1.0 and the acl matches. The
headers are still generated internally as it should, we just skip
sending them under selected conditions.

Regards
Henrik



Re: [squid-users] Squid 3 upgrade_http0.9 option

2009-09-21 Thread Amos Jeffries
On Tue, 22 Sep 2009 01:49:11 +0200, Henrik Nordstrom
 wrote:
> mån 2009-09-21 klockan 14:14 +0100 skrev Michael Graham:
>> Hi all,
>> 
>> I've noticed that the option upgrade_http0.9 doesn't exist for squid 3
>> but does in squid 2.7.
>> 
>> I had brief look at http://wiki.squid-cache.org/RoadMap/Squid3 and
>> couldn't see it mentioned anywhere.
>> 
>> Is there any plan to support this option in squid 3?
> 
> Hmm.. I thought that had already been done..
> 
> Should be pretty simple to do. 
> 
> The squid-2 patch is here if someone is interested in attempting to port
> this:
> http://www.squid-cache.org/Versions/v2/2.7/changesets/12378.patch
> with a trivial correction in
> http://www.squid-cache.org/Versions/v2/HEAD/changesets/12420.patch

I gave it a try but got stuck at finding point in 3.x where the headers
were upgrade-changed. Seems to be a bit dispersed in 3.x.

Amos



Re: [squid-users] Squid 3 upgrade_http0.9 option

2009-09-21 Thread Amos Jeffries
On Mon, 21 Sep 2009 14:14:08 +0100, Michael Graham 
wrote:
> Hi all,
> 
> I've noticed that the option upgrade_http0.9 doesn't exist for squid 3
> but does in squid 2.7.
> 
> I had brief look at http://wiki.squid-cache.org/RoadMap/Squid3 and
> couldn't see it mentioned anywhere.
> 
> Is there any plan to support this option in squid 3?

The feature itself is on the regression since 2.7 list, planned for porting
to 3.2 if anyone is able to find the right way to do it. The 3.x code is
significantly different in those areas.

I don't have time to work on it immediately but have some plans for 3.x so
hopefully we can drop the config option and make Squid cope with the broken
ShoutCast reply traffic. If anyone wants to give it a go please contact me
about the changes required.

Amos



Re: [squid-users] Squid 3 upgrade_http0.9 option

2009-09-21 Thread Henrik Nordstrom
mån 2009-09-21 klockan 14:14 +0100 skrev Michael Graham:
> Hi all,
> 
> I've noticed that the option upgrade_http0.9 doesn't exist for squid 3
> but does in squid 2.7.
> 
> I had brief look at http://wiki.squid-cache.org/RoadMap/Squid3 and
> couldn't see it mentioned anywhere.
> 
> Is there any plan to support this option in squid 3?

Hmm.. I thought that had already been done..

Should be pretty simple to do. 

The squid-2 patch is here if someone is interested in attempting to port
this:
http://www.squid-cache.org/Versions/v2/2.7/changesets/12378.patch
with a trivial correction in
http://www.squid-cache.org/Versions/v2/HEAD/changesets/12420.patch

Regards
Henrik