Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)

2018-02-13 Thread Julien Chavanton 
Closed #1437.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1437#event-1472395932___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] acc: new json format with outputs to mqueue or syslog (#1437)

2018-02-13 Thread Julien Chavanton 
This makes sense, `acc` would remain the base building block for transaction 
callbacks and dialogs and other modules could implement transformation and 
export.

I will do the necessary.
Thank you for the review

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1437#issuecomment-365304948___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] db_redis: Implement db_redis generic db driver (#1432)

2018-02-13 Thread Andreas Granig 
Hi @miconda, I've improved the module with the suggestions you made:

* utilize xml schema definitions and load them from files to avoid having to 
define them as mod params
* allow multiple keys mod params definitions to make config more readable
* reconnect improvements
* documentation fixes and improvements

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1432#issuecomment-365275003___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] db_redis: Implement db_redis generic db driver (#1432)

2018-02-13 Thread Andreas Granig 
@agranig pushed 1 commit.

609c350  db_redis: Use schema files and improve keys def


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1432/files/53e746b5c527fa542e4b2b7353af5a3b4042d7d2..609c35077886b090b62f7515f5c18c9887696a89
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:136f0b6a: core: kemi - exported more core functions

2018-02-13 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 136f0b6afae9279b07ba827451cc5a80980134b5
URL: 
https://github.com/kamailio/kamailio/commit/136f0b6afae9279b07ba827451cc5a80980134b5

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2018-02-13T12:47:46+01:00

core: kemi - exported more core functions

- add_local_rport(), set_advertised_address(addr),
set_advertised_port(port)

---

Modified: src/core/kemi.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/136f0b6afae9279b07ba827451cc5a80980134b5.diff
Patch: 
https://github.com/kamailio/kamailio/commit/136f0b6afae9279b07ba827451cc5a80980134b5.patch

---

diff --git a/src/core/kemi.c b/src/core/kemi.c
index 5631f4b909..a24f1b869d 100644
--- a/src/core/kemi.c
+++ b/src/core/kemi.c
@@ -498,6 +498,20 @@ static int sr_kemi_core_force_rport(sip_msg_t *msg)
return SR_KEMI_TRUE;
 }
 
+/**
+ *
+ */
+static int sr_kemi_core_add_local_rport(sip_msg_t *msg)
+{
+   if(msg==NULL) {
+   LM_WARN("invalid msg parameter\n");
+   return SR_KEMI_FALSE;
+   }
+
+   msg->msg_flags|=FL_ADD_LOCAL_RPORT;
+   return SR_KEMI_TRUE;
+}
+
 /**
  *
  */
@@ -696,6 +710,68 @@ static int sr_kemi_core_set_reply_no_connect(sip_msg_t 
*msg)
return SR_KEMI_TRUE;
 }
 
+/**
+ *
+ */
+static int sr_kemi_core_set_advertised_address(sip_msg_t *msg, str *addr)
+{
+#define SR_ADV_ADDR_SIZE 128
+   static char _sr_adv_addr_buf[SR_ADV_ADDR_SIZE];
+
+   if(addr==NULL || addr->s==NULL) {
+   LM_ERR("invalid addr parameter\n");
+   return SR_KEMI_FALSE;
+   }
+
+   if(addr->len>=SR_ADV_ADDR_SIZE) {
+   LM_ERR("addr parameter is too large\n");
+   return SR_KEMI_FALSE;
+   }
+
+   if(msg==NULL) {
+   LM_WARN("invalid msg parameter\n");
+   return SR_KEMI_FALSE;
+   }
+
+   memcpy(_sr_adv_addr_buf, addr->s, addr->len);
+   _sr_adv_addr_buf[addr->len] = '\0';
+   msg->set_global_address.s = _sr_adv_addr_buf;
+   msg->set_global_address.len = addr->len;
+
+   return SR_KEMI_TRUE;
+}
+
+/**
+ *
+ */
+static int sr_kemi_core_set_advertised_port(sip_msg_t *msg, str *port)
+{
+#define SR_ADV_PORT_SIZE 8
+   static char _sr_adv_port_buf[SR_ADV_PORT_SIZE];
+
+   if(port==NULL || port->s==NULL) {
+   LM_ERR("invalid port parameter\n");
+   return SR_KEMI_FALSE;
+   }
+
+   if(port->len>=SR_ADV_PORT_SIZE) {
+   LM_ERR("port parameter is too large\n");
+   return SR_KEMI_FALSE;
+   }
+
+   if(msg==NULL) {
+   LM_WARN("invalid msg parameter\n");
+   return SR_KEMI_FALSE;
+   }
+
+   memcpy(_sr_adv_port_buf, port->s, port->len);
+   _sr_adv_port_buf[port->len] = '\0';
+   msg->set_global_port.s = _sr_adv_port_buf;
+   msg->set_global_port.len = port->len;
+
+   return SR_KEMI_TRUE;
+}
+
 /**
  *
  */
@@ -825,6 +901,11 @@ static sr_kemi_t _sr_kemi_core[] = {
{ SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,
SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
},
+   { str_init(""), str_init("add_local_rport"),
+   SR_KEMIP_BOOL, sr_kemi_core_add_local_rport,
+   { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,
+   SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
+   },
{ str_init(""), str_init("is_method"),
SR_KEMIP_BOOL, sr_kemi_core_is_method,
{ SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE,
@@ -860,6 +941,16 @@ static sr_kemi_t _sr_kemi_core[] = {
{ SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,
SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
},
+   { str_init(""), str_init("set_advertised_address"),
+   SR_KEMIP_INT, sr_kemi_core_set_advertised_address,
+   { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE,
+   SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
+   },
+   { str_init(""), str_init("set_advertised_port"),
+   SR_KEMIP_INT, sr_kemi_core_set_advertised_port,
+   { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE,
+   SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE }
+   },
 
{ {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } }
 };


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Anyone thinking about adding JWT (JSON Web Token) support to Kamailio (#29)

2018-02-13 Thread ValentinOzanne 
Hi @poldon & @bwiles-vysk  ! I am interested in your pull request status. Could 
you give a feeback about it ?
Thanks

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/29#issuecomment-365214426___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:54afa459: ndb_redis: keep reference to server spec string

2018-02-13 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 54afa4599e2e9384e2fba5b3e9ab47dc0b344421
URL: 
https://github.com/kamailio/kamailio/commit/54afa4599e2e9384e2fba5b3e9ab47dc0b344421

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2018-02-13T09:19:13+01:00

ndb_redis: keep reference to server spec string

- avoid losing the pointer for dynamic discovery which can be
interpreted as memory leak
- free the new server spec if adding it fails
- code reformatted for check_cluster_reply()

---

Modified: src/modules/ndb_redis/redis_client.c
Modified: src/modules/ndb_redis/redis_client.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/54afa4599e2e9384e2fba5b3e9ab47dc0b344421.diff
Patch: 
https://github.com/kamailio/kamailio/commit/54afa4599e2e9384e2fba5b3e9ab47dc0b344421.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] ndb_redis: dynamic discovery of nodes (#1436)

2018-02-13 Thread Daniel-Constantin Mierla 
Merged #1436.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1436#event-1471084136___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:5ea80150: ndb_redis: dynamic discovery of nodes

2018-02-13 Thread Daniel-Constantin Mierla 
Module: kamailio
Branch: master
Commit: 5ea801500e06df6e1eb45712fbd52fb7e0ed382c
URL: 
https://github.com/kamailio/kamailio/commit/5ea801500e06df6e1eb45712fbd52fb7e0ed382c

Author: Giacomo Vacca 
Committer: Daniel-Constantin Mierla 
Date: 2018-02-13T08:59:19+01:00

ndb_redis: dynamic discovery of nodes

---

Modified: src/modules/ndb_redis/doc/ndb_redis_admin.xml
Modified: src/modules/ndb_redis/ndb_redis_mod.c
Modified: src/modules/ndb_redis/redis_client.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/5ea801500e06df6e1eb45712fbd52fb7e0ed382c.diff
Patch: 
https://github.com/kamailio/kamailio/commit/5ea801500e06df6e1eb45712fbd52fb7e0ed382c.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] ndb_redis: dynamic discovery of nodes (#1436)

2018-02-13 Thread Daniel-Constantin Mierla 
Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1436#issuecomment-365179569___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev