Re: [sr-dev] [kamailio/kamailio] P-CSCF crash during client login (#1526)
Closed #1526. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1526#event-164336___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] ims_registrar_pcscf: Update tmp security only if there are sec-agree … (#1527)
Merged #1527. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1527#event-1643444083___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:0f8a879a: ims_registrar_pcscf: Update tmp security only if there are sec-agree params in the message
Module: kamailio Branch: master Commit: 0f8a879a212bd114aaa261a58e256f7fa51042c8 URL: https://github.com/kamailio/kamailio/commit/0f8a879a212bd114aaa261a58e256f7fa51042c8 Author: Tsvetomir Dimitrov Committer: Tsvetomir Dimitrov Date: 2018-05-09T10:12:58+03:00 ims_registrar_pcscf: Update tmp security only if there are sec-agree params in the message --- Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/0f8a879a212bd114aaa261a58e256f7fa51042c8.diff Patch: https://github.com/kamailio/kamailio/commit/0f8a879a212bd114aaa261a58e256f7fa51042c8.patch --- diff --git a/src/modules/ims_registrar_pcscf/save.c b/src/modules/ims_registrar_pcscf/save.c index 0edf7bd808..39dfe4d589 100644 --- a/src/modules/ims_registrar_pcscf/save.c +++ b/src/modules/ims_registrar_pcscf/save.c @@ -354,9 +354,11 @@ int save_pending(struct sip_msg* _m, udomain_t* _d) { } // Update security parameters -if(ul.update_temp_security(_d, sec_params->type, sec_params, pcontact) != 0) -{ -LM_ERR("Error updating temp security\n"); +if(sec_params) { +if(ul.update_temp_security(_d, sec_params->type, sec_params, pcontact) != 0) +{ +LM_ERR("Error updating temp security\n"); +} } ul.unlock_udomain(_d, &ci.via_host, ci.via_port, ci.via_prot); ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:62a669f9: Merge pull request #1527 from tdimitrov/pcscf_crash
Module: kamailio Branch: master Commit: 62a669f9f4125f88e60b2a1f621442a8ca923c82 URL: https://github.com/kamailio/kamailio/commit/62a669f9f4125f88e60b2a1f621442a8ca923c82 Author: Daniel-Constantin Mierla Committer: GitHub Date: 2018-05-24T08:36:28+02:00 Merge pull request #1527 from tdimitrov/pcscf_crash ims_registrar_pcscf: Update tmp security only if there are sec-agree ⦠--- Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/62a669f9f4125f88e60b2a1f621442a8ca923c82.diff Patch: https://github.com/kamailio/kamailio/commit/62a669f9f4125f88e60b2a1f621442a8ca923c82.patch --- diff --git a/src/modules/ims_registrar_pcscf/save.c b/src/modules/ims_registrar_pcscf/save.c index 0edf7bd808..39dfe4d589 100644 --- a/src/modules/ims_registrar_pcscf/save.c +++ b/src/modules/ims_registrar_pcscf/save.c @@ -354,9 +354,11 @@ int save_pending(struct sip_msg* _m, udomain_t* _d) { } // Update security parameters -if(ul.update_temp_security(_d, sec_params->type, sec_params, pcontact) != 0) -{ -LM_ERR("Error updating temp security\n"); +if(sec_params) { +if(ul.update_temp_security(_d, sec_params->type, sec_params, pcontact) != 0) +{ +LM_ERR("Error updating temp security\n"); +} } ul.unlock_udomain(_d, &ci.via_host, ci.via_port, ci.via_prot); ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] sipt: Add functions to work with forwarding info (#1498)
Any estimation when you are going to work on updating the variables. I am reviewing the PRs in order to merge what's ready. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1498#issuecomment-391604848___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] tm: add relay_100 config parameter to support stateless operation (#1534)
miconda commented on this pull request. > @@ -1494,7 +1494,7 @@ static enum rps t_should_relay_response( struct cell > *Trans , int new_code, #endif /* 1xx and 2xx except 100 will be relayed */ Trans->uac[branch].last_received=new_code; - *should_relay= new_code==100? -1 : branch; + *should_relay= (new_code=100 && !cfg_get(tm, tm_cfg, relay_100)) ? -1 : branch; Should it still be `new_code==100` in the condition or I am missing something? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1534#pullrequestreview-122859738___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Bugfix trash expires (#1539)
@ngvoice - any comment on this change? It looks like a simple fix, but better to have a second review on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1539#issuecomment-391603625___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:61c96f0c: p_usrloc: new parameter "mdb_availability_control" has been created.
Module: kamailio Branch: master Commit: 61c96f0cc8ddac3e0aa71046ec4021a90b629975 URL: https://github.com/kamailio/kamailio/commit/61c96f0cc8ddac3e0aa71046ec4021a90b629975 Author: Huseyin Dikme Committer: Huseyin Dikme Date: 2018-05-23T12:54:59+02:00 p_usrloc: new parameter "mdb_availability_control" has been created. - The new parameter "mdb_availability_control" overwrites the "write_on_db" parameter based on the availability of master database. --- Modified: src/modules/p_usrloc/doc/p_usrloc_admin.xml Modified: src/modules/p_usrloc/p_usrloc_mod.c Modified: src/modules/p_usrloc/p_usrloc_mod.h Modified: src/modules/p_usrloc/ul_db.c Modified: src/modules/p_usrloc/ul_db.h Modified: src/modules/p_usrloc/ul_db_watch.c Modified: src/modules/p_usrloc/ul_db_watch.h --- Diff: https://github.com/kamailio/kamailio/commit/61c96f0cc8ddac3e0aa71046ec4021a90b629975.diff Patch: https://github.com/kamailio/kamailio/commit/61c96f0cc8ddac3e0aa71046ec4021a90b629975.patch ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:9bdc1eba: tls: Fixed build tls module on Alpine dist
Module: kamailio Branch: master Commit: 9bdc1eba76f03cd009d7f04906f13bdb6579f511 URL: https://github.com/kamailio/kamailio/commit/9bdc1eba76f03cd009d7f04906f13bdb6579f511 Author: Sergey Safarov Committer: Henning Westerholt Date: 2018-05-22T20:56:42+02:00 tls: Fixed build tls module on Alpine dist --- Modified: src/modules/tls/tls_init.c --- Diff: https://github.com/kamailio/kamailio/commit/9bdc1eba76f03cd009d7f04906f13bdb6579f511.diff Patch: https://github.com/kamailio/kamailio/commit/9bdc1eba76f03cd009d7f04906f13bdb6579f511.patch --- diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c index 030e3d2d79..ef27d08f7f 100644 --- a/src/modules/tls/tls_init.c +++ b/src/modules/tls/tls_init.c @@ -857,7 +857,7 @@ void destroy_tls_h(void) tls_destroy_cfg(); tls_destroy_locks(); tls_ct_wq_destroy(); -#if OPENSSL_VERSION_NUMBER >= 0x01010L +#if OPENSSL_VERSION_NUMBER >= 0x01010L && !defined(LIBRESSL_VERSION_NUMBER) /* explicit execution of libssl cleanup to avoid being executed again * by atexit(), when shm is gone */ LM_DBG("executing openssl v1.1+ cleanup\n"); ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Bugfix trash expires (#1539)
SurendraPlivo commented on this pull request. did you tested those changes ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1539#pullrequestreview-122844189___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:2a3ca594: topos_redis: proper length value when comparing to insert INVITE branch
Module: kamailio Branch: master Commit: 2a3ca5942291d29de05b14338a36cecbec11f129 URL: https://github.com/kamailio/kamailio/commit/2a3ca5942291d29de05b14338a36cecbec11f129 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-05-23T20:43:48+02:00 topos_redis: proper length value when comparing to insert INVITE branch --- Modified: src/modules/topos_redis/topos_redis_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/2a3ca5942291d29de05b14338a36cecbec11f129.diff Patch: https://github.com/kamailio/kamailio/commit/2a3ca5942291d29de05b14338a36cecbec11f129.patch --- diff --git a/src/modules/topos_redis/topos_redis_storage.c b/src/modules/topos_redis/topos_redis_storage.c index 50e33121ee..bc810e702b 100644 --- a/src/modules/topos_redis/topos_redis_storage.c +++ b/src/modules/topos_redis/topos_redis_storage.c @@ -1116,7 +1116,7 @@ int tps_redis_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, return -1; } - if(md->s_method.len==6 && strncmp(md->s_method.s, "INVITE", 7)==0) { + if(md->s_method.len==6 && strncmp(md->s_method.s, "INVITE", 6)==0) { if(tps_redis_insert_invite_branch(md)<0) { LM_ERR("failed to insert INVITE extra branch data\n"); return -1; ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:eb2f25ca: tm: set msg for log_prefix before running failure_route
Module: kamailio Branch: master Commit: eb2f25ca0810f966d089da3aa1e32e3e98a4ab16 URL: https://github.com/kamailio/kamailio/commit/eb2f25ca0810f966d089da3aa1e32e3e98a4ab16 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-05-23T20:42:51+02:00 tm: set msg for log_prefix before running failure_route - reported by GH #1531 --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/eb2f25ca0810f966d089da3aa1e32e3e98a4ab16.diff Patch: https://github.com/kamailio/kamailio/commit/eb2f25ca0810f966d089da3aa1e32e3e98a4ab16.patch --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 9958e70333..8b94cec624 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -988,6 +988,7 @@ int run_failure_handlers(struct cell *t, struct sip_msg *rpl, t->on_failure=0; /* if continuing on timeout of a suspended transaction, reset the flag */ t->flags &= ~T_ASYNC_SUSPENDED; + log_prefix_set(faked_req); if (exec_pre_script_cb(faked_req, FAILURE_CB_TYPE)>0) { /* run a failure_route action if some was marked */ keng = sr_kemi_eng_get(); @@ -1002,6 +1003,7 @@ int run_failure_handlers(struct cell *t, struct sip_msg *rpl, } exec_post_script_cb(faked_req, FAILURE_CB_TYPE); } + log_prefix_set(NULL); /* update message flags, if changed in failure route */ t->uas.request->flags = faked_req->flags; } ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:f3109d4d: core: qm malloc - wrapper to print execution file and line for qm_debug_frag()
Module: kamailio Branch: master Commit: f3109d4dcdc4ef810ccf4a8d17f28f7fce42271c URL: https://github.com/kamailio/kamailio/commit/f3109d4dcdc4ef810ccf4a8d17f28f7fce42271c Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2018-05-23T18:43:22+02:00 core: qm malloc - wrapper to print execution file and line for qm_debug_frag() --- Modified: src/core/mem/q_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/f3109d4dcdc4ef810ccf4a8d17f28f7fce42271c.diff Patch: https://github.com/kamailio/kamailio/commit/f3109d4dcdc4ef810ccf4a8d17f28f7fce42271c.patch --- diff --git a/src/core/mem/q_malloc.c b/src/core/mem/q_malloc.c index 10abb86c43..0c3528544d 100644 --- a/src/core/mem/q_malloc.c +++ b/src/core/mem/q_malloc.c @@ -112,15 +112,18 @@ inline static unsigned long big_hash_idx(unsigned long s) #define END_CHECK_PATTERN2 0xabcdefed -static void qm_debug_frag(struct qm_block* qm, struct qm_frag* f, - const char* file, unsigned int line) +#define qm_debug_frag(qm, f, file, line) \ + qm_debug_check_frag((qm), (f), (file), (line), __FILE__, __LINE__) +static void qm_debug_check_frag(struct qm_block* qm, struct qm_frag* f, + const char* file, unsigned int line, + const char* efile, unsigned int eline) { if (f->check!=ST_CHECK_PATTERN){ LM_CRIT("BUG: qm: fragm. %p (address %p) " "beginning overwritten (%lx)! Memory allocator was called " - "from %s:%u. Fragment marked by %s:%lu.\n", + "from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n", f, (char*)f+sizeof(struct qm_frag), - f->check, file, line, f->file, f->line); + f->check, file, line, f->file, f->line, efile, eline); qm_status(qm); abort(); }; @@ -128,10 +131,10 @@ static void qm_debug_frag(struct qm_block* qm, struct qm_frag* f, (FRAG_END(f)->check2!=END_CHECK_PATTERN2)){ LM_CRIT("BUG: qm: fragm. %p (address %p) " "end overwritten (%lx, %lx)! Memory allocator was called " - "from %s:%u. Fragment marked by %s:%lu.\n", + "from %s:%u. Fragment marked by %s:%lu. Exec from %s:%u.\n", f, (char*)f+sizeof(struct qm_frag), FRAG_END(f)->check1, FRAG_END(f)->check2, - file, line, f->file, f->line); + file, line, f->file, f->line, efile, eline); qm_status(qm); abort(); } @@ -140,9 +143,10 @@ static void qm_debug_frag(struct qm_block* qm, struct qm_frag* f, (PREV_FRAG_END(f)->check2!=END_CHECK_PATTERN2) ) ){ LM_CRIT("BUG: qm: prev. fragm. tail overwritten(%lx, %lx)[%p:%p]! " "Memory allocator was called from %s:%u. Fragment marked by " - "%s:%lu.\n", + "%s:%lu. Exec from %s:%u.\n", PREV_FRAG_END(f)->check1, PREV_FRAG_END(f)->check2, f, - (char*)f+sizeof(struct qm_frag), file, line, f->file, f->line); + (char*)f+sizeof(struct qm_frag), file, line, f->file, f->line, + efile, eline); qm_status(qm); abort(); } ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:3334a011: modules: readme files regenerated - p_usrloc ... [skip ci]
Module: kamailio Branch: master Commit: 3334a011f6de4dc7284e2875e0d08158f8859482 URL: https://github.com/kamailio/kamailio/commit/3334a011f6de4dc7284e2875e0d08158f8859482 Author: Kamailio Dev Committer: Kamailio Dev Date: 2018-05-23T16:31:59+02:00 modules: readme files regenerated - p_usrloc ... [skip ci] --- Modified: src/modules/p_usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/3334a011f6de4dc7284e2875e0d08158f8859482.diff Patch: https://github.com/kamailio/kamailio/commit/3334a011f6de4dc7284e2875e0d08158f8859482.patch ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] p_usrloc: new parameter "mdb_availability_control" has been created. (#1529)
Merged #1529. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1529#event-1641923369___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] p_usrloc: new parameter "mdb_availability_control" has been created. (#1529)
Thank you @hdikme. Closing the pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1529#issuecomment-391364442___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:bec6a75a: Merge pull request #1529 from hdikme/mdb_avail_ctl
Module: kamailio Branch: master Commit: bec6a75ac664a2c8834339b499f3b4f907312e48 URL: https://github.com/kamailio/kamailio/commit/bec6a75ac664a2c8834339b499f3b4f907312e48 Author: Lucian Balaceanu Committer: GitHub Date: 2018-05-23T17:17:51+03:00 Merge pull request #1529 from hdikme/mdb_avail_ctl p_usrloc: new parameter "mdb_availability_control" has been created. --- Modified: src/modules/p_usrloc/doc/p_usrloc_admin.xml Modified: src/modules/p_usrloc/p_usrloc_mod.c Modified: src/modules/p_usrloc/p_usrloc_mod.h Modified: src/modules/p_usrloc/ul_db.c Modified: src/modules/p_usrloc/ul_db.h Modified: src/modules/p_usrloc/ul_db_watch.c Modified: src/modules/p_usrloc/ul_db_watch.h --- Diff: https://github.com/kamailio/kamailio/commit/bec6a75ac664a2c8834339b499f3b4f907312e48.diff Patch: https://github.com/kamailio/kamailio/commit/bec6a75ac664a2c8834339b499f3b4f907312e48.patch ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Bugfix issue 1168 - Unregistered Terminating Services (PSI) Configured at HSS (#1538)
Thank you for the Explanation. Now it should be one single commit in the PR, @henningw -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1538#issuecomment-391306113___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] p_usrloc: new parameter "mdb_availability_control" has been created. (#1529)
hdikme commented on this pull request. > @@ -102,13 +102,16 @@ int ul_db_child_init(void) { if(ul_db_child_locnr_init() == -1) return -1; LM_INFO("location number is %d\n", max_loc_nr); - if(db_master_write){ +lock_get(&write_on_master_db_shared->lock); p_usrloc_mod.c: The fork() system call is triggered in the init_db_check() function, which takes place just before calling the ul_db_child_init() function where the above mentioned lock checking mechanism is used. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1529#discussion_r190155738___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] p_usrloc: new parameter "mdb_availability_control" has been created. (#1529)
hdikme commented on this pull request. > @@ -677,6 +677,26 @@ modparam("usrloc", "db_update_as_insert", 1) ... modparam("p_usrloc", "default_db_url", "mysql://ser:ser@localhost/ser") ... + Done! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1529#discussion_r190150344___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] p_usrloc: new parameter "mdb_availability_control" has been created. (#1529)
hdikme commented on this pull request. > @@ -307,6 +309,13 @@ static int mod_init(void) } #endif + if((write_on_master_db_shared = shm_malloc(sizeof(dbm_write_t))) == NULL) { The parameter will be created once at the beginning of mod_init and used so long as the process runs, therefore i haven't freed it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1529#discussion_r190149605___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] p_usrloc: new parameter "mdb_availability_control" has been created. (#1529)
hdikme commented on this pull request. > @@ -123,5 +123,11 @@ extern int connection_expires; extern int alg_location; extern int max_loc_nr; +typedef struct dbm_write { has been changed with "db_shared_param". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1529#discussion_r190148334___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev