Re: [sr-dev] [kamailio/kamailio] topos: adding param contact_hostname (#1596)
I am fine to add this parameter, but the patch lacks checking if the size is exceeding the available space in the buffer -- it checks only sv.len, which is the uri from where to extract ip, port and transport, not it should also check for param len. If this and the docs are added, then can be merged. There is an alternative to use record_route_preset(), because the contact address is built from the Record-Route URI added by kamailio. But again, I am fine to add a parameter if it is found to be more convenient and simpler for config. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1596#issuecomment-405879711___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:6c94217d: Merge pull request #1593 from adil-mafzool/master
Module: kamailio
Branch: master
Commit: 6c94217d68bdde980bd4b77bdc6d22062bd650ee
URL:
https://github.com/kamailio/kamailio/commit/6c94217d68bdde980bd4b77bdc6d22062bd650ee
Author: Daniel-Constantin Mierla
Committer: GitHub
Date: 2018-07-18T12:03:59+02:00
Merge pull request #1593 from adil-mafzool/master
kamailio always retries deleted RTPEngine Nodes which generates PDD
---
Modified: src/modules/rtpengine/rtpengine.c
---
Diff:
https://github.com/kamailio/kamailio/commit/6c94217d68bdde980bd4b77bdc6d22062bd650ee.diff
Patch:
https://github.com/kamailio/kamailio/commit/6c94217d68bdde980bd4b77bdc6d22062bd650ee.patch
---
diff --git a/src/modules/rtpengine/rtpengine.c
b/src/modules/rtpengine/rtpengine.c
index 7ce81f7de6..0b52e239e0 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -454,7 +454,8 @@ static int is_queried_node(struct rtpp_node *node, struct
rtpp_node **queried_no
int rtpengine_delete_node(struct rtpp_node *rtpp_node)
{
rtpp_node->rn_displayed = 0;
- rtpp_node->rn_disabled = RTPENGINE_MAX_RECHECK_TICKS;
+ rtpp_node->rn_disabled = 1;
+ rtpp_node->rn_recheck_ticks = RTPENGINE_MAX_RECHECK_TICKS;
return 1;
}
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] kamailio always retries deleted RTPEngine Nodes which generates PDD (#1593)
@rfuchs - thanks for the review. I am merging it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1593#issuecomment-405879920___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] kamailio always retries deleted RTPEngine Nodes which generates PDD (#1593)
Merged #1593. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1593#event-1739733669___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] RPC command stats.get_statistics randomly reporting 9223372036854776000 for current active/early dialogs (#1591)
The values are closed to ULONG_MAX for 64bit, so likely some dialog end events are counted many times (likely due to dmq replication) and the value goes below 0, turning it to max value. For reference, ranges for number types: * https://en.wikibooks.org/wiki/C_Programming/limits.h In the past days I was rather busy with other stuff, I will try to get back and analyze the code asap. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1591#issuecomment-405880927___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Module RTPPROXY param Timeout_Socket not Working (#1597)
Closed #1597. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1597#event-1740329401___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] Module RTPPROXY param Timeout_Socket not Working (#1597)
Kamailio should not start listening on the socket if timeout_socket param is set. As explained in the documentation, the value is passed to rtpproxy application, that's all done by rtpproxy module in kamailio. At that socket can be kamailio if you provide an xmlrpc url (see the docs) and use xmlrpc module, or any other application that you may develop. If you want to discuss more about, the right place is the sr-us...@lists.kamailio.org mailing list. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1597#issuecomment-405956158___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] coredumps possibly generated by DMQ in kamailio v5.1.4 (#1594)
@joelsdc - if you still have the core file used to get the content for core2_* files, can you grab the output for next gdb command in frame 0: ``` p *callid p *ftag p *ttag p *dir p d_table p *d_table ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1594#issuecomment-405970034___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] core/parser：parse_headers error. (#1582)
I've got the same problem, i'll sngrep the traffic to send a pcap file as soon as possible. Warmly FULCHIC Gaby -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1582#issuecomment-405974091___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] coredumps possibly generated by DMQ in kamailio v5.1.4 (#1594)
@miconda:
```
(gdb) frame 0
#0 0x7f4e12ce6c68 in get_dlg (callid=0x7ffdc5993850, ftag=0x7ffdc5993860,
ttag=0x7ffdc5993870, dir=0x7ffdc5993840) at dlg_hash.c:797
797 in dlg_hash.c
(gdb) p *callid
$1 = {s = 0x7f4dec572b2e "72a1671957944647-777@138.99.136.21\r\nContent-Length:
70\r\nMax-Forwards: 1\r\nContent-Type:
text/plain\r\n\r\nsip:10.2.1.24:5080;status=active\r\nsip:10.2.1.23:5080;status=disabled\r\n",
len = 34}
(gdb) p *ftag
$2 = {
s = 0x7f4dec572aef "053226fbdabb3180cd6e80991bee5f34-940d\r\nCSeq: 10
KDMQ\r\nCall-ID: 72a1671957944647-777@138.99.136.21\r\nContent-Length:
70\r\nMax-Forwards: 1\r\nContent-Type:
text/plain\r\n\r\nsip:10.2.1.24:5080;status=active\r\nsi"..., len = 37}
(gdb) p *ttag
$3 = {s = 0x0, len = 0}
(gdb) p *dir
$4 = 0
(gdb) p d_table
$5 = (dlg_table_t *) 0x0
(gdb) p *d_table
Cannot access memory at address 0x0
(gdb)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1594#issuecomment-405997714___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] RPC command stats.get_statistics randomly reporting 9223372036854776000 for current active/early dialogs (#1591)
Thanks! Let me know if you need any more info -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1591#issuecomment-406000670___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] topos: adding param contact_hostname (#1596)
Hi, reading the code I found it was taken from the RR header, I missed `record_route_preset()` This param was not absolutely necessary but I guess it is making things more clear for someone wanting to use TOPOS. And maybe simpler as well. I have tested the code "back ported" only for now, but I believe this should be enough to make sure it is working fine. Thanks for the review -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1596#issuecomment-406019020___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
