[sr-dev] [kamailio/kamailio] RPM spec update (#1715)

2018-11-08 Thread sergey-safarov 
 Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
Required backport to `5.2` branch.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1715

-- Commit Summary --

  * pkg/kamailio/obs: Fixed build on OpenSUSE dists
  * pkg/kamailio/obs: Changed rpm package group for OpenSUSE dist

-- File Changes --

M pkg/kamailio/obs/kamailio.spec (158)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1715.patch
https://github.com/kamailio/kamailio/pull/1715.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1715
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] RPM spec update (#1715)

2018-11-08 Thread sergey-safarov 
Could you also backport https://github.com/kamailio/kamailio/pull/1711 into 
`5.2` branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1715#issuecomment-436986460___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] Optimize systemd units (#1716)

2018-11-08 Thread Kevin Olbrich 




 Pre-Submission Checklist



- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, 
...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

Please see conversation on ML for reference:
https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1716

-- Commit Summary --

  * Wait for network to be up before starting kamailio.service
  * Restart service if it fails with unclean exit code instead of only unclean 
signal

-- File Changes --

M pkg/kamailio/deb/bionic/kamailio.service (5)
M pkg/kamailio/deb/buster/kamailio.service (5)
M pkg/kamailio/deb/debian/kamailio.service (5)
M pkg/kamailio/deb/jessie/kamailio.service (5)
M pkg/kamailio/deb/sid/kamailio.service (5)
M pkg/kamailio/deb/stretch/kamailio.service (5)
M pkg/kamailio/deb/xenial/kamailio.service (5)
M pkg/kamailio/oracle/el7/kamailio.service (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1716.patch
https://github.com/kamailio/kamailio/pull/1716.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1716
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Optimize systemd units (#1716)

2018-11-08 Thread Victor Seva 
can you please follow the [commit 
guidelines](https://www.kamailio.org/wiki/devel/git-commit-guidelines) using 
`pkg/kamailio/deb` as the prefix?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1716#issuecomment-437007225___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/deb: optimize systemd units (#1716)

2018-11-08 Thread Kevin Olbrich 
I have now force-pushed the changes and remove the ol/el7 service file from the 
changes.
Please let me know if that one should be fixed as well in a new PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1716#issuecomment-437071611___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/deb: optimize systemd units (#1716)

2018-11-08 Thread Victor Seva 
@kevin-olbrich push those changes with the proper prefix `pkg/kamailio/oracle` 
here too, please

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1716#issuecomment-437074315___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/deb: optimize systemd units (#1716)

2018-11-08 Thread Kevin Olbrich 
@kevin-olbrich pushed 1 commit.

8306adb  pkg/kamailio/oracle: wait for network to be up


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1716/files/e3fa965185617eda7f2bda9512072dcd074e20f1..8306adb46c429280c96b4c3ec33584469b282714
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/deb: optimize systemd units (#1716)

2018-11-08 Thread Kevin Olbrich 
> @kevin-olbrich push those changes with the proper prefix 
> `pkg/kamailio/oracle` here too, please

Done

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1716#issuecomment-437077580___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:f7867838: pkg/kamailio/deb: wait for network to be up

2018-11-08 Thread Victor Seva 
Module: kamailio
Branch: master
Commit: f7867838eb8a68a9ae4c00f2487bdec078b94c88
URL: 
https://github.com/kamailio/kamailio/commit/f7867838eb8a68a9ae4c00f2487bdec078b94c88

Author: Kevin Olbrich 
Committer: Victor Seva 
Date: 2018-11-08T18:02:32+01:00

pkg/kamailio/deb: wait for network to be up

Units that strictly require a configured network connection should pull in 
network-online.target (via a Wants= type dependency) and order themselves after 
it. This target unit is intended to pull in a service that delays further 
execution until the network is sufficiently set up. What precisely this 
requires is left to the implementation of the network managing service.

https://www.freedesktop.org/software/systemd/man/systemd.special.html
https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html

Signed-off-by: Kevin Olbrich 

---

Modified: pkg/kamailio/deb/bionic/kamailio.service
Modified: pkg/kamailio/deb/buster/kamailio.service
Modified: pkg/kamailio/deb/debian/kamailio.service
Modified: pkg/kamailio/deb/jessie/kamailio.service
Modified: pkg/kamailio/deb/sid/kamailio.service
Modified: pkg/kamailio/deb/stretch/kamailio.service
Modified: pkg/kamailio/deb/xenial/kamailio.service

---

Diff:  
https://github.com/kamailio/kamailio/commit/f7867838eb8a68a9ae4c00f2487bdec078b94c88.diff
Patch: 
https://github.com/kamailio/kamailio/commit/f7867838eb8a68a9ae4c00f2487bdec078b94c88.patch

---

diff --git a/pkg/kamailio/deb/bionic/kamailio.service 
b/pkg/kamailio/deb/bionic/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/bionic/kamailio.service
+++ b/pkg/kamailio/deb/bionic/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/buster/kamailio.service 
b/pkg/kamailio/deb/buster/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/buster/kamailio.service
+++ b/pkg/kamailio/deb/buster/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/debian/kamailio.service 
b/pkg/kamailio/deb/debian/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/debian/kamailio.service
+++ b/pkg/kamailio/deb/debian/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/jessie/kamailio.service 
b/pkg/kamailio/deb/jessie/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/jessie/kamailio.service
+++ b/pkg/kamailio/deb/jessie/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/sid/kamailio.service 
b/pkg/kamailio/deb/sid/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/sid/kamailio.service
+++ b/pkg/kamailio/deb/sid/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/stretch/kamailio.service 
b/pkg/kamailio/deb/stretch/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/stretch/kamailio.service
+++ b/pkg/kamailio/deb/stretch/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/xenial/kamailio.service 
b/pkg/kamailio/deb/xenial/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/xenial/kamailio.service
+++ b/pkg/kamailio/deb/xenial/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:a5c45d1a: pkg/kamailio/deb: also restart service if unclean exit code

2018-11-08 Thread Victor Seva 
Module: kamailio
Branch: master
Commit: a5c45d1af4bf31e872963a954c43b8ee5618a90a
URL: 
https://github.com/kamailio/kamailio/commit/a5c45d1af4bf31e872963a954c43b8ee5618a90a

Author: Kevin Olbrich 
Committer: Victor Seva 
Date: 2018-11-08T18:02:32+01:00

pkg/kamailio/deb: also restart service if unclean exit code

New:
If set to on-failure, the service will be restarted when the process exits with 
a non-zero exit code, is terminated by a signal (including on core dump, but 
excluding the aforementioned four signals), when an operation (such as service 
reload) times out, and when the configured watchdog timeout is triggered.

Old:
If set to on-abort, the service will be restarted only if the service process 
exits due to an uncaught signal not specified as a clean exit status.

https://www.freedesktop.org/software/systemd/man/systemd.service.html

Signed-off-by: Kevin Olbrich 

---

Modified: pkg/kamailio/deb/bionic/kamailio.service
Modified: pkg/kamailio/deb/buster/kamailio.service
Modified: pkg/kamailio/deb/debian/kamailio.service
Modified: pkg/kamailio/deb/jessie/kamailio.service
Modified: pkg/kamailio/deb/sid/kamailio.service
Modified: pkg/kamailio/deb/stretch/kamailio.service
Modified: pkg/kamailio/deb/xenial/kamailio.service

---

Diff:  
https://github.com/kamailio/kamailio/commit/a5c45d1af4bf31e872963a954c43b8ee5618a90a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/a5c45d1af4bf31e872963a954c43b8ee5618a90a.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:37c2e5ca: pkg/kamailio/oracle: wait for network to be up

2018-11-08 Thread Victor Seva 
Module: kamailio
Branch: master
Commit: 37c2e5ca25cb3396d2ac969271f9f9330d88fd63
URL: 
https://github.com/kamailio/kamailio/commit/37c2e5ca25cb3396d2ac969271f9f9330d88fd63

Author: Kevin Olbrich 
Committer: Victor Seva 
Date: 2018-11-08T18:02:32+01:00

pkg/kamailio/oracle: wait for network to be up

Units that strictly require a configured network connection should pull in 
network-online.target (via a Wants= type dependency) and order themselves after 
it. This target unit is intended to pull in a service that delays further 
execution until the network is sufficiently set up. What precisely this 
requires is left to the implementation of the network managing service.

https://www.freedesktop.org/software/systemd/man/systemd.special.html
https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html

Signed-off-by: Kevin Olbrich 

---

Modified: pkg/kamailio/oracle/el7/kamailio.service

---

Diff:  
https://github.com/kamailio/kamailio/commit/37c2e5ca25cb3396d2ac969271f9f9330d88fd63.diff
Patch: 
https://github.com/kamailio/kamailio/commit/37c2e5ca25cb3396d2ac969271f9f9330d88fd63.patch

---

diff --git a/pkg/kamailio/oracle/el7/kamailio.service 
b/pkg/kamailio/oracle/el7/kamailio.service
index 63d6da747c..8192488b53 100644
--- a/pkg/kamailio/oracle/el7/kamailio.service
+++ b/pkg/kamailio/oracle/el7/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio SIP router server daemon
-After=syslog.target network.target auditd.service
+Wants=network-online.target
+After=syslog.target network-online.target auditd.service
 
 [Service]
 EnvironmentFile=/etc/sysconfig/kamailio


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/deb: optimize systemd units (#1716)

2018-11-08 Thread Victor Seva 
Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1716#issuecomment-437077850___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] pkg/kamailio/deb: optimize systemd units (#1716)

2018-11-08 Thread Victor Seva 
Merged #1716 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1716#event-1954860020___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:5.2:9bc520a0: pkg/kamailio/oracle: wait for network to be up

2018-11-08 Thread Victor Seva 
Module: kamailio
Branch: 5.2
Commit: 9bc520a02428656c8eb0a5d875c950298ceaf2e7
URL: 
https://github.com/kamailio/kamailio/commit/9bc520a02428656c8eb0a5d875c950298ceaf2e7

Author: Kevin Olbrich 
Committer: Victor Seva 
Date: 2018-11-08T18:05:28+01:00

pkg/kamailio/oracle: wait for network to be up

Units that strictly require a configured network connection should pull in 
network-online.target (via a Wants= type dependency) and order themselves after 
it. This target unit is intended to pull in a service that delays further 
execution until the network is sufficiently set up. What precisely this 
requires is left to the implementation of the network managing service.

https://www.freedesktop.org/software/systemd/man/systemd.special.html
https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html

Signed-off-by: Kevin Olbrich 
(cherry picked from commit 37c2e5ca25cb3396d2ac969271f9f9330d88fd63)

---

Modified: pkg/kamailio/oracle/el7/kamailio.service

---

Diff:  
https://github.com/kamailio/kamailio/commit/9bc520a02428656c8eb0a5d875c950298ceaf2e7.diff
Patch: 
https://github.com/kamailio/kamailio/commit/9bc520a02428656c8eb0a5d875c950298ceaf2e7.patch

---

diff --git a/pkg/kamailio/oracle/el7/kamailio.service 
b/pkg/kamailio/oracle/el7/kamailio.service
index 63d6da747c..8192488b53 100644
--- a/pkg/kamailio/oracle/el7/kamailio.service
+++ b/pkg/kamailio/oracle/el7/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio SIP router server daemon
-After=syslog.target network.target auditd.service
+Wants=network-online.target
+After=syslog.target network-online.target auditd.service
 
 [Service]
 EnvironmentFile=/etc/sysconfig/kamailio


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:5.2:fb9dee9e: pkg/kamailio/deb: wait for network to be up

2018-11-08 Thread Victor Seva 
Module: kamailio
Branch: 5.2
Commit: fb9dee9efee7f832c7c95fab2d066fb3606b1fa8
URL: 
https://github.com/kamailio/kamailio/commit/fb9dee9efee7f832c7c95fab2d066fb3606b1fa8

Author: Kevin Olbrich 
Committer: Victor Seva 
Date: 2018-11-08T18:04:49+01:00

pkg/kamailio/deb: wait for network to be up

Units that strictly require a configured network connection should pull in 
network-online.target (via a Wants= type dependency) and order themselves after 
it. This target unit is intended to pull in a service that delays further 
execution until the network is sufficiently set up. What precisely this 
requires is left to the implementation of the network managing service.

https://www.freedesktop.org/software/systemd/man/systemd.special.html
https://lists.kamailio.org/pipermail/sr-users/2018-November/103668.html

Signed-off-by: Kevin Olbrich 
(cherry picked from commit f7867838eb8a68a9ae4c00f2487bdec078b94c88)

---

Modified: pkg/kamailio/deb/bionic/kamailio.service
Modified: pkg/kamailio/deb/buster/kamailio.service
Modified: pkg/kamailio/deb/debian/kamailio.service
Modified: pkg/kamailio/deb/jessie/kamailio.service
Modified: pkg/kamailio/deb/sid/kamailio.service
Modified: pkg/kamailio/deb/stretch/kamailio.service
Modified: pkg/kamailio/deb/xenial/kamailio.service

---

Diff:  
https://github.com/kamailio/kamailio/commit/fb9dee9efee7f832c7c95fab2d066fb3606b1fa8.diff
Patch: 
https://github.com/kamailio/kamailio/commit/fb9dee9efee7f832c7c95fab2d066fb3606b1fa8.patch

---

diff --git a/pkg/kamailio/deb/bionic/kamailio.service 
b/pkg/kamailio/deb/bionic/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/bionic/kamailio.service
+++ b/pkg/kamailio/deb/bionic/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/buster/kamailio.service 
b/pkg/kamailio/deb/buster/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/buster/kamailio.service
+++ b/pkg/kamailio/deb/buster/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/debian/kamailio.service 
b/pkg/kamailio/deb/debian/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/debian/kamailio.service
+++ b/pkg/kamailio/deb/debian/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/jessie/kamailio.service 
b/pkg/kamailio/deb/jessie/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/jessie/kamailio.service
+++ b/pkg/kamailio/deb/jessie/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/sid/kamailio.service 
b/pkg/kamailio/deb/sid/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/sid/kamailio.service
+++ b/pkg/kamailio/deb/sid/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/stretch/kamailio.service 
b/pkg/kamailio/deb/stretch/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/stretch/kamailio.service
+++ b/pkg/kamailio/deb/stretch/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking
diff --git a/pkg/kamailio/deb/xenial/kamailio.service 
b/pkg/kamailio/deb/xenial/kamailio.service
index e7a9e18484..99679e3372 100644
--- a/pkg/kamailio/deb/xenial/kamailio.service
+++ b/pkg/kamailio/deb/xenial/kamailio.service
@@ -1,6 +1,7 @@
 [Unit]
 Description=Kamailio (OpenSER) - the Open Source SIP Server
-After=network.target
+Wants=network-online.target
+After=network-online.target
 
 [Service]
 Type=forking


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:5.2:33fb7ac2: pkg/kamailio/deb: also restart service if unclean exit code

2018-11-08 Thread Victor Seva 
Module: kamailio
Branch: 5.2
Commit: 33fb7ac2b367b4145815ed6e6919deb8d7c8631d
URL: 
https://github.com/kamailio/kamailio/commit/33fb7ac2b367b4145815ed6e6919deb8d7c8631d

Author: Kevin Olbrich 
Committer: Victor Seva 
Date: 2018-11-08T18:04:54+01:00

pkg/kamailio/deb: also restart service if unclean exit code

New:
If set to on-failure, the service will be restarted when the process exits with 
a non-zero exit code, is terminated by a signal (including on core dump, but 
excluding the aforementioned four signals), when an operation (such as service 
reload) times out, and when the configured watchdog timeout is triggered.

Old:
If set to on-abort, the service will be restarted only if the service process 
exits due to an uncaught signal not specified as a clean exit status.

https://www.freedesktop.org/software/systemd/man/systemd.service.html

Signed-off-by: Kevin Olbrich 
(cherry picked from commit a5c45d1af4bf31e872963a954c43b8ee5618a90a)

---

Modified: pkg/kamailio/deb/bionic/kamailio.service
Modified: pkg/kamailio/deb/buster/kamailio.service
Modified: pkg/kamailio/deb/debian/kamailio.service
Modified: pkg/kamailio/deb/jessie/kamailio.service
Modified: pkg/kamailio/deb/sid/kamailio.service
Modified: pkg/kamailio/deb/stretch/kamailio.service
Modified: pkg/kamailio/deb/xenial/kamailio.service

---

Diff:  
https://github.com/kamailio/kamailio/commit/33fb7ac2b367b4145815ed6e6919deb8d7c8631d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/33fb7ac2b367b4145815ed6e6919deb8d7c8631d.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtpengine module is not retrying for rtpengine_offer. retry is working for rtpengine_answer and rtpengine_delete (#1696)

2018-11-08 Thread Surendra Tiwari 
@miconda This is happening only for offer only. answer and delete getting retry.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1696#issuecomment-437209191___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] OpenSUSE warning cleanup (#1714)

2018-11-08 Thread Henning Westerholt 
More context: 
https://en.opensuse.org/openSUSE:Packaging_checks#binary-or-shlib-calls-gethostbyname

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1714#issuecomment-437261893___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

2018-11-08 Thread Julien Chavanton 
@jchavanton pushed 1 commit.

78d1090  rtp_media_server: review part2 (will be squashed)


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1701/files/1e07a18ded04eaaec30f1bffa2038a85a907a430..78d10903119427e242687a9ec204d8c62381ce96
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

2018-11-08 Thread Julien Chavanton 
revisited the synchronization and added a few more error handling ...
We are sure we want to remove  the small voice file ? `157K Bach_10s_8000.wav`



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1701#issuecomment-437265721___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

2018-11-08 Thread Surendra Tiwari 
Just curious to know that rtp_media_server module will not conflict with
rtpengine module.

On Fri, 9 Nov 2018 at 12:11 PM, Julien Chavanton 
wrote:

> revisited the synchronization and added a few more error handling ...
> We are sure we want to remove the small voice file ? 157K
> Bach_10s_8000.wav
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>
-- 
Surendra Tiwari
VoIP Application Developer,
Plivo Inc., 201 Mission Street, *Suite 230*, San Francisco - 94105, USA
Web: www.plivo.com | Twitter: @plivo


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1701#issuecomment-437266185___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

2018-11-08 Thread Henning Westerholt 
> We are sure we want to remove the small voice file ? 157K Bach_10s_8000.wav

I would just adding a link in the README to e.g. this, they provide voice files 
in different languages:
http://www.voiptroubleshooter.com/open_speech/


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1701#issuecomment-437267923___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

2018-11-08 Thread Julien Chavanton 
> Just curious to know that rtp_media_server module will not conflict with 
> rtpengine module.
> On Fri, 9 Nov 2018 at 12:11 PM, Julien Chavanton ***@***.***> wrote: 
> revisited the synchronization and added a few more error handling ... We are 
> sure we want to remove the small voice file ? 157K Bach_10s_8000.wav — You 
> are receiving this because you are subscribed to this thread. Reply to this 
> email directly, view it on GitHub <[#1701 
> (comment)](https://github.com/kamailio/kamailio/pull/1701#issuecomment-437265721)>,
>  or mute the thread 
> 
>  .
> -- Surendra Tiwari VoIP Application Developer, Plivo Inc., 201 Mission 
> Street, *Suite 230*, San Francisco - 94105, USA Web: 
> [www.plivo.com](http://www.plivo.com) | Twitter: @plivo

Hi Surendra, RTP engine module is encoding the SDP and transferring it to RTP 
engine server application.

RTP Media Server is starting an RTP enpoint in a thread from a Kamailio forked 
process.

There nothing related that can conflict, expect the fact that they will both 
play with the SDP, of course you can not use both module on the same call at 
the same time :) but you could use both module on the same Kamailio 
instance/config 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1701#issuecomment-437268557___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

2018-11-08 Thread Surendra Tiwari 
ohk. Because what I will try with module by converting out of band dtmf to
in band dtmf.

On Fri, 9 Nov 2018 at 12:28 PM, Julien Chavanton 
wrote:

> Just curious to know that rtp_media_server module will not conflict with
> rtpengine module.
> On Fri, 9 Nov 2018 at 12:11 PM, Julien Chavanton ***@***.***> wrote:
> revisited the synchronization and added a few more error handling ... We
> are sure we want to remove the small voice file ? 157K Bach_10s_8000.wav —
> You are receiving this because you are subscribed to this thread. Reply to
> this email directly, view it on GitHub <#1701 (comment)
> >,
> or mute the thread
> https://github.com/notifications/unsubscribe-auth/AZoKAh3lBVGahBWPHLQkyWSn-BvSAHR1ks5utSOPgaJpZM4YF7gV
> .
> -- Surendra Tiwari VoIP Application Developer, Plivo Inc., 201 Mission
> Street,
> *Suite
> 230
> *,
> San Francisco - 94105, USA
> 
> Web: www.plivo.com | Twitter: @plivo 
>
> Hi Surendra, RTP engine module is encoding the SDP and transferring it to
> RTP engine server application.
>
> RTP Media Server is starting an RTP enpoint in a thread from a Kamailio
> forked process.
>
> There nothing related that can conflict, expect the fact that they will
> both play with the SDP, of course you can not use both module on the same
> call at the same time :) but you could use both module on the same Kamailio
> instance/config
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>
-- 
Surendra Tiwari
VoIP Application Developer,
Plivo Inc., 201 Mission Street, *Suite 230*, San Francisco - 94105, USA
Web: www.plivo.com | Twitter: @plivo


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1701#issuecomment-437269006___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] rtp_media_server: adding module (#1701)

2018-11-08 Thread Julien Chavanton 
> ohk. Because what I will try with module by converting out of band dtmf to in 
> band dtmf. On Fri, 9 Nov 2018 at 12:28 PM, Julien Chavanton 
>  wrote:
> Just curious to know that rtp_media_server module will not conflict with 
> rtpengine module. On Fri, 9 Nov 2018 at 12:11 PM, Julien Chavanton 
> ***@***.***> wrote: revisited the synchronization and added a few more error 
> handling ... We are sure we want to remove the small voice file ? 157K 
> Bach_10s_8000.wav — You are receiving this because you are subscribed to this 
> thread. Reply to this email directly, view it on GitHub <#1701 (comment) 
> <[#1701 
> (comment)](https://github.com/kamailio/kamailio/pull/1701#issuecomment-437265721)>>,
>  or mute the thread 
> https://github.com/notifications/unsubscribe-auth/AZoKAh3lBVGahBWPHLQkyWSn-BvSAHR1ks5utSOPgaJpZM4YF7gV
>  . -- Surendra Tiwari VoIP Application Developer, Plivo Inc., 201 Mission 
> Street, 
> *Suite
>  230 
> *,
>  San Francisco - 94105, USA 
> 
>  Web: [www.plivo.com](http://www.plivo.com) | Twitter: @plivo 
>  Hi Surendra, RTP engine module is encoding the SDP 
> and transferring it to RTP engine server application. RTP Media Server is 
> starting an RTP enpoint in a thread from a Kamailio forked process. There 
> nothing related that can conflict, expect the fact that they will both play 
> with the SDP, of course you can not use both module on the same call at the 
> same time :) but you could use both module on the same Kamailio 
> instance/config — You are receiving this because you commented. Reply to this 
> email directly, view it on GitHub <[#1701 
> (comment)](https://github.com/kamailio/kamailio/pull/1701#issuecomment-437268557)>,
>  or mute the thread 
> 
>  .
> -- Surendra Tiwari VoIP Application Developer, Plivo Inc., 201 Mission 
> Street, *Suite 230*, San Francisco - 94105, USA Web: 
> [www.plivo.com](http://www.plivo.com) | Twitter: @plivo

Not sure I understand your last comment

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1701#issuecomment-437269509___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] Suddenly found kamailio dead (#1717)

2018-11-08 Thread Mathias Schneuwly 
### Description

While doing some fail over tests I suddenly found one kamailio dead. 

### Troubleshooting

 Debugging Data

```
(gdb) bt full
#0  0xb6be2dd7 in populate_leg_info (dlg=0xb4d848bc, msg=0xb728901c, 
t=0xb4dfcbe8, leg=1, tag=0xbfee046c) at dlg_handlers.c:251
__llevel = 3
skip_recs = 1
cseq = {s = 0x0, len = 0}
contact = {
  s = 0xb4e3f17c 
"sip:3030911@10.6.148.164:5061;transport=tls>;+u.sip!devicename.ccm.cisco.com=\"SEP00451D6E4F37\"\r\nContent-Type:
 application/sdp\r\nContent-Length: 308\r\n\r\nv=0\r\no=CiscoSystemsCCM-SIP 
1475 1 IN IP4 10.6.148."..., len = 43}
rr_set = {s = 0xb728945c 
"\300\300\300\300\355\357\315\253",
 len = 52}
__FUNCTION__ = "populate_leg_info"
#1  0xb6be5817 in dlg_onreply (t=0xb4dfcbe8, type=1048576, param=0xbfee05a8) at 
dlg_handlers.c:497
dlg = 0xb4d848bc
iuid = 0xb4ceaba4
new_state = 3
old_state = 2
unref = 0
event = 3
tag = {
  s = 0xb4e3ee33 
"1475~853040b9-3e40-4c54-a456-6aead5ad927d-42986430\r\nDate: Thu, 08 Nov 2018 
13:59:40 GMT\r\nCall-ID: 
3330f000756ae87e5a59eff0349f4e3b@10.6.150.163:5071\r\nCSeq: 102 
INVITE\r\nAllow: INVITE, OPTIONS, INFO, BY"..., len = 50}
req = 0xb4dfa58c
rpl = 0xb728901c
__FUNCTION__ = "dlg_onreply"
#2  0xb6fa1d98 in run_trans_callbacks_internal (cb_lst=0xb4dfcc28, 
type=1048576, trans=0xb4dfcbe8, params=0xbfee05a8) at t_hooks.c:260
cbp = 0xb4cf417c
backup_from = 0x8491090
backup_to = 0x8491094
backup_dom_from = 0x8491098
backup_dom_to = 0x849109c
backup_uri_from = 0x8491088
backup_uri_to = 0x849108c
backup_xavps = 0x849111c
__FUNCTION__ = "run_trans_callbacks_internal"
#3  0xb6fa1f8b in run_trans_callbacks_with_buf (type=1048576, rbuf=0xb4dfcc58, 
req=0xb4dfa58c, repl=0xb728901c, flags=0) at t_hooks.c:305
params = {req = 0xb4dfa58c, rpl = 0xb728901c, param = 0xb4cf4188, code 
= 200, flags = 0, branch = 0, t_rbuf = 0xb4dfcc58, dst = 0xb4dfcc8c, send_buf = 
{
s = 0xb4df6844 "SIP/2.0 200 OK\r\nVia: SIP/2.0/TLS 
10.6.150.163:5071;branch=z9hG4bK08efd17b\r\nFrom: \"Personal/Zimmer 4322\" 
;tag=as3df2635b\r\nTo: :5061>"..., len = 1504}}
trans = 0xb4dfcbe8
#4  0xb6fe49c8 in relay_reply (t=0xb4dfcbe8, p_msg=0xb728901c, branch=1, 
msg_status=200, cancel_data=0xbfee0a68, do_put_on_wait=1) at t_reply.c:1948
relay = 1
save_clone = 0
buf = 0xb728ba7c "SIP/2.0 200 OK\r\nVia: SIP/2.0/TLS 
10.6.150.163:5071;branch=z9hG4bK08efd17b\r\nFrom: \"Personal/Zimmer 4322\" 
;tag=as3df2635b\r\nTo: :5061>"...
res_len = 1504
relayed_code = 200
relayed_msg = 0xb728901c
reply_bak = 0x837c358
bm = {to_tag_val = {s = 0x83e7bb4 "core: core/parser/msg_parser.c", len 
= 0}}
totag_retr = 0
reply_status = RPS_COMPLETED
uas_rb = 0xb4dfcc58
to_tag = 0xbfee07c8
reason = {s = 0xb71d8008 "\001", len = -1222393428}
onsend_params = {req = 0xb6fcf41e, rpl = 0xb4dfcd04, param = 0x0, code 
= 1, flags = 36997, branch = 2086, t_rbuf = 0xb4916780, dst = 0x0, send_buf = 
{s = 0xe10 , 
len = 147776392}}
ip = {af = 0, len = 0, u = {addrl = {0, 0, 1024, 3220047736}, addr32 = 
{0, 0, 1024, 3220047736}, addr16 = {0, 0, 0, 0, 1024, 0, 1912, 49134}, 
addr = 
"\000\000\000\000\000\000\000\000\000\004\000\000x\a\356\277"}}
__FUNCTION__ = "relay_reply"
#5  0xb6fe86eb in reply_received (p_msg=0xb728901c) at t_reply.c:2528
msg_status = 200
last_uac_status = 180
ack = 0x76 
---Type  to continue, or q  to quit---
ack_len = 3076795573
branch = 1
reply_status = 1717986920
onreply_route = 1
cancel_data = {cancel_bitmap = 0, reason = {cause = 200, u = {text = {s 
= 0x0, len = -1218037806}, e2e_cancel = 0x0, packed_hdrs = {s = 0x0, len = 
-1218037806
uac = 0xb4dfce80
t = 0xb4dfcbe8
lack_dst = {send_sock = 0x0, to = {s = {sa_family = 0, sa_data = 
"\000\000\000\000\000\000\000\000\000\000X\000\000"}, sin = {sin_family = 0, 
sin_port = 0, sin_addr = {s_addr = 0}, 
  sin_zero = "\000\000\000\000X\000\000"}, sin6 = {sin6_family = 0, 
sin6_port = 0, sin6_flowinfo = 0, sin6_addr = {__in6_u = {
  __u6_addr8 = 
"\000\000\000\000X\000\000\000\224\353\343\264\214\221(\267", __u6_addr16 = {0, 
0, 88, 0, 60308, 46307, 37260, 46888}, __u6_addr32 = {0, 88, 3034835860, 
3072889228}}}, 
  sin6_scope_id = 3220049176}}, id = 137018730, proto = -55 '\311', 
send_flags = {f = 13620, blst_imask = 12276}}
backup_user_from = 0x8491090
backup_user_to = 0x8491094
backup_domain_from = 0x8491098
backup_domain_to = 0x849109c
backup_uri_from = 0x8491088
backup_uri_to = 0x849108c
backup_xavps = 0x849111c
replies_locked = 1
branch_ret =

[sr-dev] log_custom module - LC_LOG_MSG_MAX_SIZE

2018-11-08 Thread Luis Martin Gil 
Hi all,

Is there any strong reason to set LC_LOG_MSG_MAX_SIZE to 16384 in the
log_custom module? Any thoughts / undesired effects if changed to 32768 or
higher?

```
$ grep -R 'define LC_LOG_MSG_MAX_SIZE' *
src/modules/log_custom/log_custom_mod.c:#define LC_LOG_MSG_MAX_SIZE 16384
src/modules/log_systemd/log_systemd_mod.c:#define LC_LOG_MSG_MAX_SIZE 16384
```

Thanks.
Luis
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev