Re: [sr-dev] [kamailio/kamailio] Core dumps possibly related to #2616 or http_async_query (#2632)
Hi, althought I have not been able to reproduce the crash, I think that the problem, as highlighted by @bjokax, is the not correct handling of HTTP/2 multiplexing. The module was written before HTTP/2 was out so it has never been considered. Support for it would require some important refactoring of the module, I'll start seeing if I can work on it for the next major release. Meanwhile we can disable multiplexing at all (this can also be backported to current stable branches while a refactor to support multiplexing wouldn't). I've pushed such fix in this branch https://github.com/kamailio/kamailio/tree/grumvalski/disable_http2_multiplexing. @amessina @bjokax : can you try it? Since I've not been able for now to reproduce the crash I don't know if it solves yours. Thank you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2632#issuecomment-803621237___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] [kamailio/kamailio] rtpengine: remove square brackets from IPv6 address for getaddrinfo (#2685)
rtpengine: IPv6 address in square brackets interpreted as FQDN. - After loading from DB rn_address is in form: [x:x:x:x:x:x:x:x]:, getaddrinfo function expect ipv6 in node argument without square brackets, otherwise, the argument is interpreted as FQDN. Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2685 -- Commit Summary -- * rtpengine: remove square brackets from IPv6 address for getaddrinfo function -- File Changes -- M src/modules/rtpengine/rtpengine.c (15) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2685.patch https://github.com/kamailio/kamailio/pull/2685.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2685 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] git:master:17d21f0b: stirshaken: fixed kemi exports
Module: kamailio Branch: master Commit: 17d21f0b398ca75c1383b124ca6190b4d1ee7dc0 URL: https://github.com/kamailio/kamailio/commit/17d21f0b398ca75c1383b124ca6190b4d1ee7dc0 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2021-03-21T11:40:59+01:00 stirshaken: fixed kemi exports --- Modified: src/modules/stirshaken/stirshaken_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/17d21f0b398ca75c1383b124ca6190b4d1ee7dc0.diff Patch: https://github.com/kamailio/kamailio/commit/17d21f0b398ca75c1383b124ca6190b4d1ee7dc0.patch --- diff --git a/src/modules/stirshaken/stirshaken_mod.c b/src/modules/stirshaken/stirshaken_mod.c index bc4a04f0fb..a98cb3a4e3 100644 --- a/src/modules/stirshaken/stirshaken_mod.c +++ b/src/modules/stirshaken/stirshaken_mod.c @@ -551,7 +551,7 @@ static int w_stirshaken_check_identity(sip_msg_t *msg, char *str1, char *str2) return ki_stirshaken_check_identity(msg); } -static int ki_stirshaken_check_identity_with_cert(sip_msg_t *msg, char *cert_path) +static int ki_stirshaken_check_identity_with_cert(sip_msg_t *msg, str *cert_path) { str ibody = STR_NULL; hdr_field_t *hf = NULL; @@ -574,7 +574,7 @@ static int ki_stirshaken_check_identity_with_cert(sip_msg_t *msg, char *cert_pat ibody = hf->body; - if (!(cert.x = stir_shaken_load_x509_from_file(&ss, cert_path))) { + if (!(cert.x = stir_shaken_load_x509_from_file(&ss, cert_path->s))) { LM_DBG("Cannot load X509 from file\n"); stirshaken_print_error_details(&ss); goto fail; @@ -641,7 +641,7 @@ static int w_stirshaken_check_identity_with_cert(sip_msg_t *msg, char *cert_path return -1; } - return ki_stirshaken_check_identity_with_cert(msg, cert_path); + return ki_stirshaken_check_identity_with_cert(msg, &keyval); } static int ki_stirshaken_check_identity_with_key(sip_msg_t *msg, str *keypath) @@ -954,8 +954,8 @@ static sr_kemi_t sr_kemi_stirshaken_exports[] = { }, { str_init("stirshaken"), str_init("stirshaken_check_identity_with_key"), SR_KEMIP_INT, ki_stirshaken_check_identity_with_key, - { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR, - SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_STR } + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, { str_init("stirshaken"), str_init("stirshaken_add_identity"), SR_KEMIP_INT, ki_stirshaken_add_identity, ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev