[sr-dev] git:master:1947763c: modules: readme files regenerated - ims_qos ... [skip ci]

2023-09-28 Thread Kamailio Dev via sr-dev
Module: kamailio
Branch: master
Commit: 1947763c176f33bcd3cbdfc54d980648855dff8a
URL: 
https://github.com/kamailio/kamailio/commit/1947763c176f33bcd3cbdfc54d980648855dff8a

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2023-09-28T15:46:23+02:00

modules: readme files regenerated - ims_qos ... [skip ci]

---

Modified: src/modules/ims_qos/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/1947763c176f33bcd3cbdfc54d980648855dff8a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/1947763c176f33bcd3cbdfc54d980648855dff8a.patch

---

diff --git a/src/modules/ims_qos/README b/src/modules/ims_qos/README
index e9c150274eb..b0981a0c151 100644
--- a/src/modules/ims_qos/README
+++ b/src/modules/ims_qos/README
@@ -64,6 +64,7 @@ Carsten Bock
   3.21. omit_flow_ports integer
   3.22. rs_default_bandwidth integer
   3.23. rr_default_bandwidth integer
+  3.24. suspend_transaction integer
 
 4. Functions
 
@@ -101,8 +102,9 @@ Carsten Bock
1.21. omit_flow_ports parameter usage
1.22. rs_default_bandwidth parameter usage
1.23. rr_default_bandwidth parameter usage
-   1.24. Rx_AAR_Register
-   1.25. Rx_AAR
+   1.24. suspend_transaction parameter usage
+   1.25. Rx_AAR_Register
+   1.26. Rx_AAR
 
 Chapter 1. Admin Guide
 
@@ -139,6 +141,7 @@ Chapter 1. Admin Guide
 3.21. omit_flow_ports integer
 3.22. rs_default_bandwidth integer
 3.23. rr_default_bandwidth integer
+3.24. suspend_transaction integer
 
4. Functions
 
@@ -202,6 +205,7 @@ Chapter 1. Admin Guide
3.21. omit_flow_ports integer
3.22. rs_default_bandwidth integer
3.23. rr_default_bandwidth integer
+   3.24. suspend_transaction integer
 
 3.1. rx_dest_realm (string)
 
@@ -492,6 +496,17 @@ modparam("ims_qos", "rs_default_bandwidth", 600)
 modparam("ims_qos", "rr_default_bandwidth", 2000)
 ...
 
+3.24. suspend_transaction integer
+
+   If eneabled, suspends the tm transaction while doing the AAR.
+
+   Default value is 1 (enabled)
+
+   Example 1.24. suspend_transaction parameter usage
+...
+modparam("ims_qos", "suspend_transaction", 2000)
+...
+
 4. Functions
 
4.1. Rx_AAR_Register(route_block, domain)
@@ -522,7 +537,7 @@ modparam("ims_qos", "rr_default_bandwidth", 2000)
p.s. this is executed asynchronously. See example on how to retrieve
return value
 
-   Example 1.24. Rx_AAR_Register
+   Example 1.25. Rx_AAR_Register
 ...
 if(Rx_AAR_Register("REG_AAR_REPLY","location")==0){
 exit;
@@ -566,7 +581,7 @@ route[REG_AAR_REPLY]
p.s. this is executed asynchronously. See example on how to retrieve
return value
 
-   Example 1.25. Rx_AAR
+   Example 1.26. Rx_AAR
 ...
 if(Rx_AAR("ORIG_SESSION_AAR_REPLY","orig","",-1)==0){
 exit;

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:21a685a2: ims_qos: Rename new parameter's C variable

2023-09-28 Thread Stefan-Cristian Mititelu via sr-dev
Module: kamailio
Branch: master
Commit: 21a685a200e1ff638358dbbee607d4ab55c57359
URL: 
https://github.com/kamailio/kamailio/commit/21a685a200e1ff638358dbbee607d4ab55c57359

Author: Stefan-Cristian Mititelu 
Committer: Stefan-Cristian Mititelu 
Date: 2023-09-28T16:43:47+03:00

ims_qos: Rename new parameter's C variable

---

Modified: src/modules/ims_qos/ims_qos_mod.c
Modified: src/modules/ims_qos/rx_aar.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/21a685a200e1ff638358dbbee607d4ab55c57359.diff
Patch: 
https://github.com/kamailio/kamailio/commit/21a685a200e1ff638358dbbee607d4ab55c57359.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] ims_qos: Add suspend_transaction parameter (PR #3581)

2023-09-28 Thread Stefan Mititelu via sr-dev
Merged #3581 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3581#event-10499665427
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] ims_qos: Add suspend_transaction parameter (PR #3581)

2023-09-28 Thread Stefan Mititelu via sr-dev
Ok, will push a new commit to rename the C var, directly on master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3581#issuecomment-1739202919
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:d0262f82: ims_qos: Add suspend_transaction parameter

2023-09-28 Thread Stefan Mititelu via sr-dev
Module: kamailio
Branch: master
Commit: d0262f82fd9cee8670ac01e4f06eb35626b34714
URL: 
https://github.com/kamailio/kamailio/commit/d0262f82fd9cee8670ac01e4f06eb35626b34714

Author: Stefan-Cristian Mititelu 
Committer: Stefan Mititelu 
Date: 2023-09-28T16:35:52+03:00

ims_qos: Add suspend_transaction parameter

---

Modified: src/modules/ims_qos/doc/ims_qos_admin.xml
Modified: src/modules/ims_qos/ims_qos_mod.c
Modified: src/modules/ims_qos/rx_aar.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/d0262f82fd9cee8670ac01e4f06eb35626b34714.diff
Patch: 
https://github.com/kamailio/kamailio/commit/d0262f82fd9cee8670ac01e4f06eb35626b34714.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Nonexisted route in KEMI python causes "ksr_request_route not found or is not callable" (Issue #3572)

2023-09-28 Thread ShadoWalkeR31 via sr-dev
I build kamailio from master
```
 $ /usr/local/sbin/kamailio -v
version: kamailio 5.8.0-dev1 (x86_64/linux) 27f87c
```

and reproduce problem:
```
  modparam("dispatcher", "event_callback", "ksr_evnt_dispatcher") # route 
actually named ksr_event_dispatcher
  KSR.tm.t_on_reply('ksr_onreply_MANAGE') # route not existed.
  KSR.tm.t_on_failure('ksr_failure_ROUTE') # route actually named 
ksr_failure_MANAGE
```
  
Patch work great - i get messages like 
```
0bdb87a767b52b60-1028569@10.100.32.228 OPTIONS app_python3 [python_exec.c:100]: 
apy_exec(): ksr_evnt_dispatcher not found or is not callable ((nil))
DEBUG: 766520133 INVITE app_python3 [python_exec.c:100]: apy_exec(): 
ksr_onreply_MANAGE not found or is not callable ((nil))
DEBUG: 2039759053 INVITE app_python3 [python_exec.c:100]: apy_exec(): 
ksr_failure_ROUTE not found or is not callable ((nil))
```

and all forks still availible. But can those messages be at log level 'ERROR'? 
Without log level 'DEBUG' it's still hard to detect non-existed KEMI route

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3572#issuecomment-1738882337
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Kamailio Behind nat. How Record-Route should be added ? (Issue #3586)

2023-09-28 Thread Daniel-Constantin Mierla via sr-dev
Closed #3586 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3586#event-10497299174
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Kamailio Behind nat. How Record-Route should be added ? (Issue #3586)

2023-09-28 Thread Daniel-Constantin Mierla via sr-dev
Questions about using/configuring kamailio have to be addressed to sr-users 
mailing list (which it seems you did, so wait for answers there). The tracker 
is for issue related to the C code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3586#issuecomment-1738866983
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] Kamailio Behind nat. How Record-Route should be added ? (Issue #3586)

2023-09-28 Thread Lv Xiaobu via sr-dev
UA1(192.168.0.1)  --> kamailio (internal:192.168.0.2  public:1.1.1.1) -->  
UA2(2.2.2.2)
if in  UA1 INVITE, I write KSR.rr.record_route().  
so  UA2(2.2.2.2) received sip msg (Record-Route: ), so 
Kamailio can received BYE/ACK from UA2.
but,Kamailio can't received BYE/ACK  from UA1.

if in UA1 INVITE, i write 
KSR.rr.record_route_advertised_address("192.168.0.2"), then Kamailio can 
received  BYE/ACK  from UA1, but not from UA2.

what can i do, let Kamailio receive BYE/ACK  from both sides ?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3586
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Memory leak in dns_cache.c / dns_cache_mk_rd_entry (Issue #3523)

2023-09-28 Thread Daniel-Constantin Mierla via sr-dev
I went a few times over the code but I could not spot anything. Do you have a 
test system where this can be reproduced and run git master branch?

Can you estimate with how many DNS records the system may have to deal with 
(i.e., how many domains are involved in SIP routing that have to be resolved 
and stored in the cache)?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3523#issuecomment-1738597182
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:1bb1ba60: core: dns cache - warnings on put for unlinked items

2023-09-28 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 1bb1ba60992ffa35e8d36ed1dab98fdc36a2ea30
URL: 
https://github.com/kamailio/kamailio/commit/1bb1ba60992ffa35e8d36ed1dab98fdc36a2ea30

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2023-09-28T09:03:50+02:00

core: dns cache - warnings on put for unlinked items

---

Modified: src/core/dns_cache.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/1bb1ba60992ffa35e8d36ed1dab98fdc36a2ea30.diff
Patch: 
https://github.com/kamailio/kamailio/commit/1bb1ba60992ffa35e8d36ed1dab98fdc36a2ea30.patch

---

diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c
index 4ad478ba88d..7ff085b0300 100644
--- a/src/core/dns_cache.c
+++ b/src/core/dns_cache.c
@@ -164,9 +164,13 @@ inline static void dns_destroy_entry_shm_unsafe(struct 
dns_hash_entry *e)
 /* dec. the internal refcnt and if 0 deletes the entry */
 void dns_hash_put(struct dns_hash_entry *e)
 {
-   if(e && atomic_dec_and_test(>refcnt)) {
-   /* atomic_sub_long(dns_cache_total_used, e->total_size); */
-   dns_destroy_entry(e);
+   if(e != NULL) {
+   if(atomic_dec_and_test(>refcnt)) {
+   /* atomic_sub_long(dns_cache_total_used, 
e->total_size); */
+   dns_destroy_entry(e);
+   } else if(e->next == NULL && e->prev == NULL) {
+   LM_WARN("unlinked item %p\n", e);
+   }
}
 }
 
@@ -175,9 +179,13 @@ void dns_hash_put(struct dns_hash_entry *e)
  *  optimization) */
 void dns_hash_put_shm_unsafe(struct dns_hash_entry *e)
 {
-   if(e && atomic_dec_and_test(>refcnt)) {
-   /* atomic_sub_long(dns_cache_total_used, e->total_size); */
-   dns_destroy_entry_shm_unsafe(e);
+   if(e != NULL) {
+   if(atomic_dec_and_test(>refcnt)) {
+   /* atomic_sub_long(dns_cache_total_used, 
e->total_size); */
+   dns_destroy_entry_shm_unsafe(e);
+   } else if(e->next == NULL && e->prev == NULL) {
+   LM_WARN("unlinked item %p\n", e);
+   }
}
 }
 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org