[sr-dev] git:master:b5003620: core: keep listen socket even if advertise address does not resolve

2024-01-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: b50036200c5bc09fd2d412a18585b42d63763b27
URL: 
https://github.com/kamailio/kamailio/commit/b50036200c5bc09fd2d412a18585b42d63763b27

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-11T08:21:00+01:00

core: keep listen socket even if advertise address does not resolve

- the core advertise_address parameter works in the same fashion
- previously it was starting by skipping the listen, which resulted in
  unexpected runtime list of sockets

---

Modified: src/core/socket_info.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/b50036200c5bc09fd2d412a18585b42d63763b27.diff
Patch: 
https://github.com/kamailio/kamailio/commit/b50036200c5bc09fd2d412a18585b42d63763b27.patch

---

diff --git a/src/core/socket_info.c b/src/core/socket_info.c
index 3f67f16981b..e048e0e2c4b 100644
--- a/src/core/socket_info.c
+++ b/src/core/socket_info.c
@@ -361,11 +361,13 @@ static inline struct socket_info *new_sock_info(char 
*name,
 
he = resolvehost(si->useinfo.name.s);
if(he == 0) {
-   LM_ERR("unable to resolve advertised name %s\n",
+   LM_WARN("unable to resolve advertised name %s\n",
si->useinfo.name.s);
-   goto error;
+   si->useinfo.address.len = 0;
+   si->useinfo.address.af = 0;
+   } else {
+   hostent2ip_addr(>useinfo.address, he, 0);
}
-   hostent2ip_addr(>useinfo.address, he, 0);
}
return si;
 error:

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtp_media_server module hard codes contact header to "rms" (Issue #3380)

2024-01-10 Thread github-actions[bot] via sr-dev
Closed #3380 as not planned.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3380#event-11450812854
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] tls: (historical) root cause analysis of per-worker SSL_CTX during OpenSSL 1.1.1 integration (Issue #3709)

2024-01-10 Thread space88man via sr-dev
### Description
During OpenSSL 1.1.1 integration it was necessary to use per-worker SSL_CTX 
—instantiated in `tls/tls_mod.c`. This is still required for OpenSSL 3.x 
integration.

This is a retrospective root cause analysis of why this duplicated SSL_CTX is 
needed.

 Reproduction

1. Instead of creating repeating SSL_CTX (one-per-worker) have all workers use 
a single SSL_CTX
2. Observation: intermittent connection failures
3. Observation: if `tls` is using only EC keys, the connections will succeed


 Root Cause Analysis

OpenSSL RSA BN operations are multi-threaded ready (can be used in 
single-process multi-threaded applications). However the BN operations depend 
crucially on each thread reporting different `pthread_self()` values. At 
runtime `pthread_self()` values can be reused and are only different for all 
running threads in a single process.

When rank 0 forks the worker processes their `pthread_self()` values will 
overlap. This will result in invalid BN computations and lead to failure of RSA 
connections. In a sense the workers perform “identify theft”.

There is no mechanism in pthreads to reset the thread ids; they are opaque 
handles.

In contrast, OpenSSL ECDSA operations do not invoke `pthread_self()` and do not 
require unique thread IDs.

Notes

- no action is required; this is purely a historical note
- I have added a code comment: 
https://github.com/kamailio/kamailio/commit/29007ada5bc9e07ede3cdbce285f04d1298c0612
- I will leave this issue up for a few days knowledge sharing

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3709
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:5.7:c5ed0e65: tls: historical code comment on repeating SSL_CTX per worker

2024-01-10 Thread S-P Chan via sr-dev
Module: kamailio
Branch: 5.7
Commit: c5ed0e65b2530443b1367986dac2b3da111c0701
URL: 
https://github.com/kamailio/kamailio/commit/c5ed0e65b2530443b1367986dac2b3da111c0701

Author: S-P Chan 
Committer: S-P Chan 
Date: 2024-01-11T08:04:58+08:00

tls: historical code comment on repeating SSL_CTX per worker

(cherry-pick from 29007ada5bc9e07ede3cdbce285f04d1298c0612)

---

Modified: src/modules/tls/tls_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/c5ed0e65b2530443b1367986dac2b3da111c0701.diff
Patch: 
https://github.com/kamailio/kamailio/commit/c5ed0e65b2530443b1367986dac2b3da111c0701.patch

---

diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index 7cad1b046e4..beaf1b7b70b 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -433,6 +433,16 @@ static int tls_engine_init();
 int tls_fix_engine_keys(tls_domains_cfg_t *, tls_domain_t *, tls_domain_t *);
 #endif
 
+/*
+ * OpenSSL 1.1.1+: SSL_CTX is repeated in each worker
+ *
+ * OpenSSL RSA blinding works in single-process multi-threaded mode
+ * and depends on pthread_self() to separate threads. In Kamailio 
multi-process workers
+ * pthread_self() will not necessarily be unique, this will result in 
incorrect BN
+ * operations???hence we create a separate SSL_CTX for each worker
+ *
+ * EC operations do not use pthread_self(), so could use shared SSL_CTX
+ */
 static int mod_child(int rank)
 {
if(tls_disable || (tls_domains_cfg == 0))

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:29007ada: tls: historical code comment on repeating SSL_CTX per worker

2024-01-10 Thread S-P Chan via sr-dev
Module: kamailio
Branch: master
Commit: 29007ada5bc9e07ede3cdbce285f04d1298c0612
URL: 
https://github.com/kamailio/kamailio/commit/29007ada5bc9e07ede3cdbce285f04d1298c0612

Author: S-P Chan 
Committer: S-P Chan 
Date: 2024-01-11T08:03:07+08:00

tls: historical code comment on repeating SSL_CTX per worker

---

Modified: src/modules/tls/tls_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/29007ada5bc9e07ede3cdbce285f04d1298c0612.diff
Patch: 
https://github.com/kamailio/kamailio/commit/29007ada5bc9e07ede3cdbce285f04d1298c0612.patch

---

diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index 7cad1b046e4..beaf1b7b70b 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -433,6 +433,16 @@ static int tls_engine_init();
 int tls_fix_engine_keys(tls_domains_cfg_t *, tls_domain_t *, tls_domain_t *);
 #endif
 
+/*
+ * OpenSSL 1.1.1+: SSL_CTX is repeated in each worker
+ *
+ * OpenSSL RSA blinding works in single-process multi-threaded mode
+ * and depends on pthread_self() to separate threads. In Kamailio 
multi-process workers
+ * pthread_self() will not necessarily be unique, this will result in 
incorrect BN
+ * operations???hence we create a separate SSL_CTX for each worker
+ *
+ * EC operations do not use pthread_self(), so could use shared SSL_CTX
+ */
 static int mod_child(int rank)
 {
if(tls_disable || (tls_domains_cfg == 0))

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] http_async_client: exit mod_init if tm is not loaded (PR #3706)

2024-01-10 Thread Дилян Палаузов via sr-dev
@dilyanpalauzov commented on this pull request.

I think the line above LM_ERROR is bettet than LM_INFO.

> @@ -295,7 +295,7 @@ static int mod_init(void)
 
if(load_tm_api() < 0) {
LM_INFO("cannot load the TM-functions - async relay 
disabled\n");
-   memset(, 0, sizeof(tm_api_t));
+   return -1;

I think the line above LM_ERROR is bettet than LM_INFO.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3706#pullrequestreview-1813978183
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] xlog: add kemi xlog_facility function (PR #3708)

2024-01-10 Thread Stefan Mititelu via sr-dev
@smititelu pushed 1 commit.

51bc40de2bebf4ca224b7eb61153837e5e221f6e  xlog: add kemi xlog_facility function

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3708/files/1a8e3a6ab722f44583b7872d6266efd6d075592d..51bc40de2bebf4ca224b7eb61153837e5e221f6e
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] xlog: add kemi xlog_facility function (PR #3708)

2024-01-10 Thread Stefan Mititelu via sr-dev
!-- Kamailio Pull Request Template --

!--
IMPORTANT:
  - for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
  - backports to stable branches must be done with git cherry-pick -x 
...
  - code is contributed under BSD for core and main components (tm, sl, auth, 
tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
--

 Pre-Submission Checklist
!-- Go over all points below, and after creating the PR, tick all the 
checkboxes that apply --
!-- All points should be verified, otherwise, read the CONTRIBUTING 
guidelines from above--
!-- If youre unsure about any of these, dont hesitate to ask on 
sr-dev mailing list --
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, 
...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
!-- Go over all points below, and after creating the PR, tick the 
checkboxes that apply --
- [X] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
!-- Describe your changes in detail --
Add kemi xlog function to be able to log in other facilities other than the 
default one. Can this be backported to 5.6 and 5.7?
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3708

-- Commit Summary --

  * xlog: add kemi xlog_facility function

-- File Changes --

M src/modules/xlog/xlog.c (51)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3708.patch
https://github.com/kamailio/kamailio/pull/3708.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3708
You are receiving this because you are subscribed to this thread.

Message ID: kamailio/kamailio/pull/3...@github.com
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:42bae2a6: registrar: cumpute randmized-range expire value as float and then cast

2024-01-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 42bae2a634249fe7d8ba174ea0ee547f6d2b
URL: 
https://github.com/kamailio/kamailio/commit/42bae2a634249fe7d8ba174ea0ee547f6d2b

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-10T13:45:30+01:00

registrar: cumpute randmized-range expire value as float and then cast

---

Modified: src/modules/registrar/sip_msg.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/42bae2a634249fe7d8ba174ea0ee547f6d2b.diff
Patch: 
https://github.com/kamailio/kamailio/commit/42bae2a634249fe7d8ba174ea0ee547f6d2b.patch

---

diff --git a/src/modules/registrar/sip_msg.c b/src/modules/registrar/sip_msg.c
index 9ef2c37db47..69e8606fbc1 100644
--- a/src/modules/registrar/sip_msg.c
+++ b/src/modules/registrar/sip_msg.c
@@ -48,15 +48,17 @@ static struct hdr_field *act_contact;
  */
 static inline int randomize_expires(int expires, int range)
 {
-   int range_min;
+   float range_min;
 
/* if no range is given just return expires */
if(range == 0)
return expires;
 
-   range_min = expires - (float)range / 100 * expires;
+   range_min = (float)expires * (1.0 - ((float)range / 100));
 
-   return range_min + (float)(kam_rand() % 100) / 100 * (expires - 
range_min);
+   return (int)(range_min
++ ((float)(kam_rand() % 100) / 100)
+  * ((float)expires - 
range_min));
 }
 
 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:403ed489: modules: readme files regenerated - usrloc ... [skip ci]

2024-01-10 Thread Kamailio Dev via sr-dev
Module: kamailio
Branch: master
Commit: 403ed48995e5eec5a795edd1748f9fe8a9ee520d
URL: 
https://github.com/kamailio/kamailio/commit/403ed48995e5eec5a795edd1748f9fe8a9ee520d

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2024-01-10T13:32:13+01:00

modules: readme files regenerated - usrloc ... [skip ci]

---

Modified: src/modules/usrloc/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/403ed48995e5eec5a795edd1748f9fe8a9ee520d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/403ed48995e5eec5a795edd1748f9fe8a9ee520d.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] htable dmq can not get the expected result (Issue #3674)

2024-01-10 Thread sznoname via sr-dev
Closed #3674 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3674#event-11442628873
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] htable dmq can not get the expected result (Issue #3674)

2024-01-10 Thread sznoname via sr-dev
 it works, thanks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3674#issuecomment-1884759499
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:5bf1a7ab: usrloc: option to randomize when keepalive is sent

2024-01-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 5bf1a7ab30f14d989ab185585427c868429224fa
URL: 
https://github.com/kamailio/kamailio/commit/5bf1a7ab30f14d989ab185585427c868429224fa

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-10T13:20:34+01:00

usrloc: option to randomize when keepalive is sent

- default adds a range from 0 to 20 seconds to ka_interval

---

Modified: src/modules/usrloc/ul_keepalive.c
Modified: src/modules/usrloc/usrloc_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/5bf1a7ab30f14d989ab185585427c868429224fa.diff
Patch: 
https://github.com/kamailio/kamailio/commit/5bf1a7ab30f14d989ab185585427c868429224fa.patch

---

diff --git a/src/modules/usrloc/ul_keepalive.c 
b/src/modules/usrloc/ul_keepalive.c
index 435f84d7c71..eba6bec5c0d 100644
--- a/src/modules/usrloc/ul_keepalive.c
+++ b/src/modules/usrloc/ul_keepalive.c
@@ -44,6 +44,7 @@
 
 extern int ul_keepalive_timeout;
 extern int ul_ka_interval;
+extern int ul_ka_randomize;
 
 static int ul_ka_send(str *kamsg, dest_info_t *kadst);
 
@@ -110,6 +111,7 @@ int ul_ka_urecord(urecord_t *ur)
int i;
struct timeval tv;
time_t tnow = 0;
+   int ka_limit = 0;
 
if(ul_ka_mode == ULKA_NONE) {
return 0;
@@ -160,10 +162,12 @@ int ul_ka_urecord(urecord_t *ur)
}
}
}
-   if(ul_ka_interval > 0 && uc->last_keepalive > 0
-   && (uc->last_keepalive + ul_ka_interval) < 
tnow) {
-   /* not yet the time for keepalive */
-   continue;
+   if(ul_ka_interval > 0 && uc->last_keepalive > 0) {
+   ka_limit = ul_ka_interval - (fastrand() % 
ul_ka_randomize);
+   if((uc->last_keepalive + ka_limit) < tnow) {
+   /* not yet the time for keepalive */
+   continue;
+   }
}
if(uc->received.len > 0) {
sdst = uc->received;
diff --git a/src/modules/usrloc/usrloc_mod.c b/src/modules/usrloc/usrloc_mod.c
index f493915a564..b14fe7273e1 100644
--- a/src/modules/usrloc/usrloc_mod.c
+++ b/src/modules/usrloc/usrloc_mod.c
@@ -128,6 +128,7 @@ str ul_ka_method = str_init("OPTIONS");
 int ul_ka_mode = 0;
 int ul_ka_filter = 0;
 int ul_ka_interval = 40;
+int ul_ka_randomize = 20;
 int ul_ka_loglevel = 255;
 str ul_ka_logmsg = str_init(" to-uri: [$tu] remote-addr: [$sas]");
 pv_elem_t *ul_ka_logfmt = NULL;
@@ -302,6 +303,7 @@ static param_export_t params[] = {
{"ka_method", PARAM_STR, _ka_method},
{"ka_filter", PARAM_INT, _ka_filter},
{"ka_interval", PARAM_INT, _ka_interval},
+   {"ka_randomize", PARAM_INT, _ka_randomize},
{"ka_timeout", PARAM_INT, _keepalive_timeout},
{"ka_loglevel", PARAM_INT, _ka_loglevel},
{"ka_logmsg", PARAM_STR, _ka_logmsg},

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:bbb81e5f: usrloc: docs for ka_randomize parameter

2024-01-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: bbb81e5f6ef5744cc9b74302e8ecee6687199872
URL: 
https://github.com/kamailio/kamailio/commit/bbb81e5f6ef5744cc9b74302e8ecee6687199872

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-10T13:20:34+01:00

usrloc: docs for ka_randomize parameter

---

Modified: src/modules/usrloc/doc/usrloc_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/bbb81e5f6ef5744cc9b74302e8ecee6687199872.diff
Patch: 
https://github.com/kamailio/kamailio/commit/bbb81e5f6ef5744cc9b74302e8ecee6687199872.patch

---

diff --git a/src/modules/usrloc/doc/usrloc_admin.xml 
b/src/modules/usrloc/doc/usrloc_admin.xml
index 77b18989b4b..d7d78ae7b00 100644
--- a/src/modules/usrloc/doc/usrloc_admin.xml
+++ b/src/modules/usrloc/doc/usrloc_admin.xml
@@ -1481,6 +1481,31 @@ modparam("usrloc", "ka_interval", 30)


 
+   
+   ka_randomize (int)
+   
+   The parameter sets the the upper limit to the range of random 
seconds
+   to be added to ka_interval before checking if a new keepalive 
request
+   has to be sent. It should help to distribute better the sending 
of
+   keepalive requests. The keepalive for a location record is 
going to be
+   sent in a random fashion between (ka_interval + 0) and
+   (ka_interval + ka_randomize).
+   
+   
+   
+   Default value is 20.
+   
+   
+   
+   Set ka_randomize parameter
+   
+...
+modparam("usrloc", "ka_interval", 30)
+...
+
+   
+   
+

ka_loglevel (int)


___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:03f939e3: modules: readme files regenerated - usrloc ... [skip ci]

2024-01-10 Thread Kamailio Dev via sr-dev
Module: kamailio
Branch: master
Commit: 03f939e3d1a0dbf56791943f90942984984f2d72
URL: 
https://github.com/kamailio/kamailio/commit/03f939e3d1a0dbf56791943f90942984984f2d72

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2024-01-10T12:47:06+01:00

modules: readme files regenerated - usrloc ... [skip ci]

---

Modified: src/modules/usrloc/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/03f939e3d1a0dbf56791943f90942984984f2d72.diff
Patch: 
https://github.com/kamailio/kamailio/commit/03f939e3d1a0dbf56791943f90942984984f2d72.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:53ace443: usrloc: added keepalive interval to set the step for sending

2024-01-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 53ace443020075f7ecd12c72f154193c6cfa6af3
URL: 
https://github.com/kamailio/kamailio/commit/53ace443020075f7ecd12c72f154193c6cfa6af3

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-10T12:42:43+01:00

usrloc: added keepalive interval to set the step for sending

- the keepalive is not going to be sent before the interval elapsed
- the keepalive is no longer sent on every timer callback
- default 40 seconds

---

Modified: src/modules/usrloc/ul_keepalive.c
Modified: src/modules/usrloc/usrloc_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/53ace443020075f7ecd12c72f154193c6cfa6af3.diff
Patch: 
https://github.com/kamailio/kamailio/commit/53ace443020075f7ecd12c72f154193c6cfa6af3.patch

---

diff --git a/src/modules/usrloc/ul_keepalive.c 
b/src/modules/usrloc/ul_keepalive.c
index 02c21c0837e..435f84d7c71 100644
--- a/src/modules/usrloc/ul_keepalive.c
+++ b/src/modules/usrloc/ul_keepalive.c
@@ -43,6 +43,7 @@
 #include "ul_keepalive.h"
 
 extern int ul_keepalive_timeout;
+extern int ul_ka_interval;
 
 static int ul_ka_send(str *kamsg, dest_info_t *kadst);
 
@@ -159,6 +160,11 @@ int ul_ka_urecord(urecord_t *ur)
}
}
}
+   if(ul_ka_interval > 0 && uc->last_keepalive > 0
+   && (uc->last_keepalive + ul_ka_interval) < 
tnow) {
+   /* not yet the time for keepalive */
+   continue;
+   }
if(uc->received.len > 0) {
sdst = uc->received;
} else {
diff --git a/src/modules/usrloc/usrloc_mod.c b/src/modules/usrloc/usrloc_mod.c
index e6aa591bbce..f493915a564 100644
--- a/src/modules/usrloc/usrloc_mod.c
+++ b/src/modules/usrloc/usrloc_mod.c
@@ -127,6 +127,7 @@ str ul_ka_domain = str_init("kamailio.org");
 str ul_ka_method = str_init("OPTIONS");
 int ul_ka_mode = 0;
 int ul_ka_filter = 0;
+int ul_ka_interval = 40;
 int ul_ka_loglevel = 255;
 str ul_ka_logmsg = str_init(" to-uri: [$tu] remote-addr: [$sas]");
 pv_elem_t *ul_ka_logfmt = NULL;
@@ -300,6 +301,7 @@ static param_export_t params[] = {
{"ka_domain", PARAM_STR, _ka_domain},
{"ka_method", PARAM_STR, _ka_method},
{"ka_filter", PARAM_INT, _ka_filter},
+   {"ka_interval", PARAM_INT, _ka_interval},
{"ka_timeout", PARAM_INT, _keepalive_timeout},
{"ka_loglevel", PARAM_INT, _ka_loglevel},
{"ka_logmsg", PARAM_STR, _ka_logmsg},

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:36608af8: usrloc: docs for ka_interval parameter

2024-01-10 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 36608af81b3ed64b3800be1625647ed0a9e5031d
URL: 
https://github.com/kamailio/kamailio/commit/36608af81b3ed64b3800be1625647ed0a9e5031d

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-10T12:42:43+01:00

usrloc: docs for ka_interval parameter

---

Modified: src/modules/usrloc/doc/usrloc_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/36608af81b3ed64b3800be1625647ed0a9e5031d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/36608af81b3ed64b3800be1625647ed0a9e5031d.patch

---

diff --git a/src/modules/usrloc/doc/usrloc_admin.xml 
b/src/modules/usrloc/doc/usrloc_admin.xml
index 5c0796935c7..77b18989b4b 100644
--- a/src/modules/usrloc/doc/usrloc_admin.xml
+++ b/src/modules/usrloc/doc/usrloc_admin.xml
@@ -1460,6 +1460,27 @@ modparam("usrloc", "ka_timeout", 120)


 
+   
+   ka_interval (int)
+   
+   The parameter sets the interval in seconds after which a new 
keepalive
+   request should be sent for a location record.
+   
+   
+   
+   Default value is 40.
+   
+   
+   
+   Set ka_interval parameter
+   
+...
+modparam("usrloc", "ka_interval", 30)
+...
+
+   
+   
+

ka_loglevel (int)


___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-10 Thread Dennis via sr-dev
I have changed the flag name and added docs to xml.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3699#issuecomment-1884558285
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-10 Thread Dennis via sr-dev
@Den4t pushed 1 commit.

53ae14294f021ae615c0fae6ec9b48758d9a051e  dispatcher: added two new flags to 
mode parameter of ds_is_from_list function for more strictly matching

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3699/files/9ef53dd70fb412a8c0754b523253be9478951a06..53ae14294f021ae615c0fae6ec9b48758d9a051e
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Roadmap to next major Kamailio release series v5.8.x

2024-01-10 Thread Daniel-Constantin Mierla via sr-dev
Hello,

discussed a bit during the online Kamailio devel meeting, it is time to
set the milestones towards the next major Kamailio release series v5.8.x.

If no other suggestions that suit more developers, I would propose to
freeze by end of this month or early February, then test for about 4
weeks as usual and release by end of February or during March.

If anyone wants to add new features/modules, they have to be published
till freezing date, either pushed in the git repository or proposed as
pull request.

Cheers,
Daniel

-- 
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio Advanced Training, February 20-22, 2024 -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] http_async_client: exit mod_init if tm is not loaded (PR #3706)

2024-01-10 Thread Henning Westerholt via sr-dev
Merged #3706 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3706#event-11440393557
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:5a40d1ef: http_async_client: exit mod_init if tm is not loaded

2024-01-10 Thread Henning Westerholt via sr-dev
Module: kamailio
Branch: master
Commit: 5a40d1ef1b484c4fc437a3f0183a101241e80313
URL: 
https://github.com/kamailio/kamailio/commit/5a40d1ef1b484c4fc437a3f0183a101241e80313

Author: Federico Cabiddu 
Committer: Henning Westerholt 
Date: 2024-01-10T10:06:05+01:00

http_async_client: exit mod_init if tm is not loaded

---

Modified: src/modules/http_async_client/http_async_client_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/5a40d1ef1b484c4fc437a3f0183a101241e80313.diff
Patch: 
https://github.com/kamailio/kamailio/commit/5a40d1ef1b484c4fc437a3f0183a101241e80313.patch

---

diff --git a/src/modules/http_async_client/http_async_client_mod.c 
b/src/modules/http_async_client/http_async_client_mod.c
index 3064a5491d6..e9f6cb0d26b 100644
--- a/src/modules/http_async_client/http_async_client_mod.c
+++ b/src/modules/http_async_client/http_async_client_mod.c
@@ -295,7 +295,7 @@ static int mod_init(void)
 
if(load_tm_api() < 0) {
LM_INFO("cannot load the TM-functions - async relay 
disabled\n");
-   memset(, 0, sizeof(tm_api_t));
+   return -1;
}
 
/* allocate workers array */

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] http_async_client: exit mod_init if tm is not loaded (PR #3706)

2024-01-10 Thread Henning Westerholt via sr-dev
Thanks for the PR, merged

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3706#issuecomment-1884446598
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] UAC module :uac_reg_tm_callback(): got sip response 408 (Issue #3707)

2024-01-10 Thread QWERTY via sr-dev
Register with remote,if there is no response to request,get in the logs an 
error message like:

ERROR: uac [uac_reg.c:1001]: uac_reg_tm_callback(): got sip response 408 while 
registering

How to get this timeout information in routing ?  event_route[ ] ?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3707
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org