[sr-dev] Re: [kamailio/kamailio] tls: (historical) root cause analysis of per-worker SSL_CTX during OpenSSL 1.1.1 integration (Issue #3709)

2024-01-11 Thread space88man via sr-dev
The code is in `tls_domain.c`  where `d->ctx` is an **array of SSL_CTX** 
instead of a single SSL_CTX.
Each worker has a personal copy of the SSL_CTX and uses `d->ctx[process_no]` .

In theory for each domain we could use a single SSL_CTX instead of duplicating 
it max_procs times, so this issue answers the question : Why is `d->ctx` an 
array of the same SSL_CTX instead of a single copy of an SSL_CTX?

The roots of this go back 1.1.1 where OpenSSL removed the ability of 
`CRYPTO_set_id_callback` (from 1.0.2). Then a process could generate a unique 
ID and "pretend" to be a different thread.

In OpenSSL 1.1.1+ the id is reported using `pthread_self()` - while this is 
unique within a process it is not unique across multiple workers.


> Do you refer to the next code block?
> 
> * 
> https://github.com/kamailio/kamailio/blob/master/src/modules/tls/tls_mod.c#L451-L471
> 
> 
> If yes, as I can see it, the `tls_fix_domains_cfg()` is executed for `rank == 
> PROC_SIPINIT` when libssl is >=1.1.x, which means it is done only for the 
> first SIP worker process (with the rank 1).



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3709#issuecomment-1888131406
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Henning Westerholt via sr-dev
Thanks, if there is a workaround there its of course not necessary to backport.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887564694
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Richard Fuchs via sr-dev
> Unfortunately it does not seems to work at least with "codec-accept=XXX": 
> kam02 rtpengine[570041]: WARNING: [jKOBctrRd-]: [core] Unknown dictionary key 
> encountered: 'codec-accept'

Right, you have to use `codec-flag-...` (dash instead of equals) for this to 
work.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887560358
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Henning Westerholt via sr-dev
Unfortunately it does not seems to work at least with "codec-accept=XXX":
kam02 rtpengine[570041]: WARNING: [jKOBctrRd-]: [core] Unknown dictionary key 
encountered: 'codec-accept'


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887540631
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Richard Fuchs via sr-dev
These flags should work without this patch, as they would just be put into the 
`flags` list of strings and rtpengine does parse them out of there.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887531455
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Henning Westerholt via sr-dev
Thanks for the fast review and merge. I would like to cherry-pick this to 5.7 
stable branch, as it should be available according to the module readme (at 
least codec-accept). If necessary I can also create a dedicated commit only for 
the codec-accept.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887528115
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:1671c964: modules: readme files regenerated - rtpengine ... [skip ci]

2024-01-11 Thread Kamailio Dev via sr-dev
Module: kamailio
Branch: master
Commit: 1671c96462f76d902b4c331c2f51e99cd2e33af1
URL: 
https://github.com/kamailio/kamailio/commit/1671c96462f76d902b4c331c2f51e99cd2e33af1

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2024-01-11T17:17:12+01:00

modules: readme files regenerated - rtpengine ... [skip ci]

---

Modified: src/modules/rtpengine/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/1671c96462f76d902b4c331c2f51e99cd2e33af1.diff
Patch: 
https://github.com/kamailio/kamailio/commit/1671c96462f76d902b4c331c2f51e99cd2e33af1.patch

---

diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README
index 96693dcd018..7cfc4772863 100644
--- a/src/modules/rtpengine/README
+++ b/src/modules/rtpengine/README
@@ -2419,6 +2419,9 @@ rtpengine_offer();
 still be accepted towards the original offerer and then used
 for transcoding. It is a more selective version of what the
 `always transcode` flag does.
+  + codec-consume=... - Identical to mask but enables the
+transcoding engine even if no other transcoding related
+options are given.
   + T.38=decode - If the offered SDP contains a media section
 advertising T.38 over UDPTL, translate it to a regular audio
 media section over RTP. By default, PCMU and PCMA will be used

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [Kamailio-Business] Roadmap to next major Kamailio release series v5.8.x

2024-01-11 Thread Henning Westerholt via sr-dev
Hello,

early February as a freezing date sounds good to me, just to have one full 
month after the holiday season/vacation period to allow other people to finish 
eventual contributions.

Cheers,

Henning

-- 
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com

> -Original Message-
> From: Daniel-Constantin Mierla via business 
> Sent: Mittwoch, 10. Januar 2024 10:11
> To: Kamailio (SER) - Users Mailing List ; 
> Kamailio
> (SER) - Devel Mailing List ;
> busin...@lists.kamailio.org
> Subject: [Kamailio-Business] Roadmap to next major Kamailio release series
> v5.8.x
> 
> Hello,
> 
> discussed a bit during the online Kamailio devel meeting, it is time to set 
> the
> milestones towards the next major Kamailio release series v5.8.x.
> 
> If no other suggestions that suit more developers, I would propose to freeze
> by end of this month or early February, then test for about 4 weeks as usual
> and release by end of February or during March.
> 
> If anyone wants to add new features/modules, they have to be published till
> freezing date, either pushed in the git repository or proposed as pull 
> request.
> 
> Cheers,
> Daniel
> 
> --
> Daniel-Constantin Mierla (@ asipto.com)
> twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy,
> Training and Development Services -- asipto.com Kamailio Advanced Training,
> February 20-22, 2024 -- asipto.com Kamailio World Conference, April 18-19,
> 2024, Berlin -- kamailioworld.com
> 
> ___
> Kamailio (OpenSER) - business mailing list -- busin...@lists.kamailio.org To
> unsubscribe send an email to business-le...@lists.kamailio.org
> http://lists.openser-project.org/cgi-
> bin/mailman/listinfo%(cgiext)s/%(_internal_name)s
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] tls: (historical) root cause analysis of per-worker SSL_CTX during OpenSSL 1.1.1 integration (Issue #3709)

2024-01-11 Thread Daniel-Constantin Mierla via sr-dev
Do you refer to the next code block?

  - 
https://github.com/kamailio/kamailio/blob/master/src/modules/tls/tls_mod.c#L451-L471

If yes, as I can see it, the `tls_fix_domains_cfg()` is executed for `rank == 
PROC_SIPINIT` when libssl is >=1.1.x, which means it is done only for the first 
SIP worker process (with the rank 1).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3709#issuecomment-1887489516
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:1aec0c13: rtpengine/docs: Add codec-consume docs

2024-01-11 Thread Victor Seva via sr-dev
Module: kamailio
Branch: master
Commit: 1aec0c1397e4230e52f2b9427fdb32b10f649ecb
URL: 
https://github.com/kamailio/kamailio/commit/1aec0c1397e4230e52f2b9427fdb32b10f649ecb

Author: Xenofon Karamanos 
Committer: Victor Seva 
Date: 2024-01-11T17:04:07+01:00

rtpengine/docs: Add codec-consume docs

---

Modified: src/modules/rtpengine/doc/rtpengine_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/1aec0c1397e4230e52f2b9427fdb32b10f649ecb.diff
Patch: 
https://github.com/kamailio/kamailio/commit/1aec0c1397e4230e52f2b9427fdb32b10f649ecb.patch

---

diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml 
b/src/modules/rtpengine/doc/rtpengine_admin.xml
index 1e394453493..fea67a665a2 100644
--- a/src/modules/rtpengine/doc/rtpengine_admin.xml
+++ b/src/modules/rtpengine/doc/rtpengine_admin.xml
@@ -2746,6 +2746,11 @@ rtpengine_offer();
version of what the `always transcode` flag 
does.

 
+   
+   codec-consume=... - 
Identical to mask but enables the transcoding engine even if no other 
transcoding
+   related options are given.
+   
+

T.38=decode - If the 
offered &sdp; contains a media section
advertising T.38 over UDPTL, translate it to a 
regular audio media section

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Victor Seva via sr-dev
Merged #3710 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#event-11458613293
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:a40d5b7d: rtpengine: Add support for codec-accept and codec-consume

2024-01-11 Thread Victor Seva via sr-dev
Module: kamailio
Branch: master
Commit: a40d5b7d65394606f2200a5932284b874e196063
URL: 
https://github.com/kamailio/kamailio/commit/a40d5b7d65394606f2200a5932284b874e196063

Author: Xenofon Karamanos 
Committer: Victor Seva 
Date: 2024-01-11T17:04:07+01:00

rtpengine: Add support for codec-accept and codec-consume

---

Modified: src/modules/rtpengine/rtpengine.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/a40d5b7d65394606f2200a5932284b874e196063.diff
Patch: 
https://github.com/kamailio/kamailio/commit/a40d5b7d65394606f2200a5932284b874e196063.patch

---

diff --git a/src/modules/rtpengine/rtpengine.c 
b/src/modules/rtpengine/rtpengine.c
index 11745d6b863..e3e4c6e1d50 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -126,7 +126,8 @@ struct ng_flags_parse {
int via, to, packetize, transport, directional;
bencode_item_t *dict, *flags, *direction, *replace, *rtcp_mux, *sdes, 
*t38,
*received_from, *codec, *codec_strip, *codec_offer,
-   *codec_transcode, *codec_mask, *codec_set, 
*codec_except;
+   *codec_transcode, *codec_mask, *codec_set, 
*codec_except, *codec_accept,
+   *codec_consume;
str call_id, from_tag, to_tag;
 };
 
@@ -2735,6 +2736,12 @@ static int parse_flags(struct ng_flags_parse *ng_flags, 
struct sip_msg *msg,
if(parse_codec_flag(ng_flags, &key, &val, "codec-except", NULL,
   "except", &ng_flags->codec_except))
goto next;
+   if(parse_codec_flag(ng_flags, &key, &val, "codec-accept", NULL,
+  "accept", &ng_flags->codec_accept))
+   goto next;
+   if(parse_codec_flag(ng_flags, &key, &val, "codec-consume", NULL,
+  "consume", &ng_flags->codec_consume))
+   goto next;
 
/* check for specially handled items */
switch(key.len) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)

2024-01-11 Thread Richard Fuchs via sr-dev
LGTM

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887427690
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] UAC module :uac_reg_tm_callback(): got sip response 408 (Issue #3707)

2024-01-11 Thread Daniel-Constantin Mierla via sr-dev
For questions about using kamailio, you have to email to 
sr-us...@lists.kamailio.org list. This tracker is for reporting bugs in the C 
code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3707#issuecomment-1887332655
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] UAC module :uac_reg_tm_callback(): got sip response 408 (Issue #3707)

2024-01-11 Thread Daniel-Constantin Mierla via sr-dev
Closed #3707 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3707#event-11457595015
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] Rtpengine fixes (PR #3710)

2024-01-11 Thread Xenofon Karamanos via sr-dev




 Pre-Submission Checklist



- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

This PR add support for the `codec-accept` and `codec-consume` flags of 
rtpengine (supported since 
[mr9.2.1](https://github.com/sipwise/rtpengine/commit/336cb5b280079b0e7b24127ef987e10293604490)).
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3710

-- Commit Summary --

  * rtpengine: Add support for codec-accept and codec-consume
  * rtpengine/docs: Add codec-consume docs

-- File Changes --

M src/modules/rtpengine/doc/rtpengine_admin.xml (5)
M src/modules/rtpengine/rtpengine.c (9)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3710.patch
https://github.com/kamailio/kamailio/pull/3710.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3710
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:b678e66a: p_usrloc: rename short global variable

2024-01-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: b678e66a974f3f88f5ed05e57e5d898e4715fe0a
URL: 
https://github.com/kamailio/kamailio/commit/b678e66a974f3f88f5ed05e57e5d898e4715fe0a

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-11T15:34:33+01:00

p_usrloc: rename short global variable

---

Modified: src/modules/p_usrloc/ul_db_handle.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/b678e66a974f3f88f5ed05e57e5d898e4715fe0a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/b678e66a974f3f88f5ed05e57e5d898e4715fe0a.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:302231bf: ratelimit: rename variables to prevent global structure shadowing

2024-01-11 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio
Branch: master
Commit: 302231bf2262ef73a6aad4a2f476df7c9a3c05f0
URL: 
https://github.com/kamailio/kamailio/commit/302231bf2262ef73a6aad4a2f476df7c9a3c05f0

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-01-11T15:23:55+01:00

ratelimit: rename variables to prevent global structure shadowing

---

Modified: src/modules/ratelimit/ratelimit.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/302231bf2262ef73a6aad4a2f476df7c9a3c05f0.diff
Patch: 
https://github.com/kamailio/kamailio/commit/302231bf2262ef73a6aad4a2f476df7c9a3c05f0.patch

---

diff --git a/src/modules/ratelimit/ratelimit.c 
b/src/modules/ratelimit/ratelimit.c
index 4e327460044..5cac92464db 100644
--- a/src/modules/ratelimit/ratelimit.c
+++ b/src/modules/ratelimit/ratelimit.c
@@ -924,7 +924,7 @@ static int init_params(void)
  * parses a "pipe_no:algorithm:bandwidth" line
  * \return  0 on success
  */
-static int parse_pipe_params(char *line, pipe_params_t *params)
+static int parse_pipe_params(char *line, pipe_params_t *pparams)
 {
regmatch_t m[4];
str algo_str;
@@ -938,12 +938,12 @@ static int parse_pipe_params(char *line, pipe_params_t 
*params)
LM_DBG("pipe: [%.*s|%.*s|%.*s]\n", RXLS(m, line, 1), RXLS(m, line, 2),
RXLS(m, line, 3));
 
-   params->no = atoi(RXS(m, line, 1));
-   params->limit = atoi(RXS(m, line, 3));
+   pparams->no = atoi(RXS(m, line, 1));
+   pparams->limit = atoi(RXS(m, line, 3));
 
algo_str.s = RXS(m, line, 2);
algo_str.len = RXL(m, line, 2);
-   if(str_map_str(algo_names, &algo_str, ¶ms->algo))
+   if(str_map_str(algo_names, &algo_str, &pparams->algo))
return -1;
 
return 0;
@@ -953,7 +953,7 @@ static int parse_pipe_params(char *line, pipe_params_t 
*params)
  * parses a "pipe_no:method" line
  * \return  0 on success
  */
-static int parse_queue_params(char *line, rl_queue_params_t *params)
+static int parse_queue_params(char *line, rl_queue_params_t *qparams)
 {
regmatch_t m[3];
int len;
@@ -966,16 +966,16 @@ static int parse_queue_params(char *line, 
rl_queue_params_t *params)
}
LM_DBG("queue: [%.*s|%.*s]\n", RXLS(m, line, 1), RXLS(m, line, 2));
 
-   params->pipe = atoi(RXS(m, line, 1));
+   qparams->pipe = atoi(RXS(m, line, 1));
 
len = RXL(m, line, 2);
-   params->method.s = (char *)pkg_malloc(len + 1);
-   if(params->method.s == 0) {
+   qparams->method.s = (char *)pkg_malloc(len + 1);
+   if(qparams->method.s == 0) {
LM_ERR("no memory left for method in params\n");
return -1;
}
-   params->method.len = len;
-   memcpy(params->method.s, RXS(m, line, 2), len + 1);
+   qparams->method.len = len;
+   memcpy(qparams->method.s, RXS(m, line, 2), len + 1);
 
return 0;
 }
@@ -1017,19 +1017,19 @@ static int check_feedback_setpoints(int modparam)
 static int add_pipe_params(modparam_t type, void *val)
 {
char *param_line = val;
-   pipe_params_t params;
+   pipe_params_t pparams;
 
-   if(parse_pipe_params(param_line, ¶ms))
+   if(parse_pipe_params(param_line, &pparams))
return -1;
 
-   if(params.no < 0 || params.no >= MAX_PIPES) {
+   if(pparams.no < 0 || pparams.no >= MAX_PIPES) {
LM_ERR("pipe number %d not allowed (MAX_PIPES=%d, 0-based)\n",
-   params.no, MAX_PIPES);
+   pparams.no, MAX_PIPES);
return -1;
}
 
-   pipes[params.no].algo_mp = params.algo;
-   pipes[params.no].limit_mp = params.limit;
+   pipes[pparams.no].algo_mp = pparams.algo;
+   pipes[pparams.no].limit_mp = pparams.limit;
 
return check_feedback_setpoints(1);
 }
@@ -1037,24 +1037,24 @@ static int add_pipe_params(modparam_t type, void *val)
 static int add_queue_params(modparam_t type, void *val)
 {
char *param_line = val;
-   rl_queue_params_t params;
+   rl_queue_params_t qparams;
 
if(nqueues_mp >= MAX_QUEUES) {
LM_ERR("MAX_QUEUES reached (%d)\n", MAX_QUEUES);
return -1;
}
 
-   if(parse_queue_params(param_line, ¶ms))
+   if(parse_queue_params(param_line, &qparams))
return -1;
 
-   if(params.pipe >= MAX_PIPES) {
+   if(qparams.pipe >= MAX_PIPES) {
LM_ERR("pipe number %d not allowed (MAX_PIPES=%d, 0-based)\n",
-   params.pipe, MAX_PIPES);
+   qparams.pipe, MAX_PIPES);
return -1;
}
 
-   queues[nqueues_mp].pipe_mp = params.pipe;
-   queues[nqueues_mp].method_mp = params.method;
+   queues[nqueues_mp].pipe_mp = qparams.pipe;
+   queues[nqueues_mp].method_mp = qparams.method;
nqueues_mp++;
 
return 0;

___
Kamailio (SER) - De

[sr-dev] Re: [kamailio/kamailio] Dispatcher: added two new flags to mode parameter of ds_is_from_list function for more strictly matching (PR #3699)

2024-01-11 Thread Daniel-Constantin Mierla via sr-dev
If I understand the code correctly, a destination record that matches only the 
socket is selected against one that matches address/port/proto? Is it like that 
and if yes, is it the expected result?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3699#issuecomment-1886943341
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] git:master:72595fe4: http_async_client: use error log level (GH #3706)

2024-01-11 Thread Henning Westerholt via sr-dev
Module: kamailio
Branch: master
Commit: 72595fe42d28d3e4a12341b405af63d41f827dc4
URL: 
https://github.com/kamailio/kamailio/commit/72595fe42d28d3e4a12341b405af63d41f827dc4

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-01-11T10:30:40Z

http_async_client: use error log level (GH #3706)

---

Modified: src/modules/http_async_client/http_async_client_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/72595fe42d28d3e4a12341b405af63d41f827dc4.diff
Patch: 
https://github.com/kamailio/kamailio/commit/72595fe42d28d3e4a12341b405af63d41f827dc4.patch

---

diff --git a/src/modules/http_async_client/http_async_client_mod.c 
b/src/modules/http_async_client/http_async_client_mod.c
index e9f6cb0d26b..983a9e387f1 100644
--- a/src/modules/http_async_client/http_async_client_mod.c
+++ b/src/modules/http_async_client/http_async_client_mod.c
@@ -294,7 +294,7 @@ static int mod_init(void)
}
 
if(load_tm_api(&tmb) < 0) {
-   LM_INFO("cannot load the TM-functions - async relay 
disabled\n");
+   LM_ERR("cannot load the TM-functions - async relay disabled\n");
return -1;
}
 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] http_async_client: exit mod_init if tm is not loaded (PR #3706)

2024-01-11 Thread Henning Westerholt via sr-dev
@dilyanpalauzov You are right, done in the commit above.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3706#issuecomment-1886815392
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] unistr.h: No such file or directory (#2020)

2024-01-11 Thread ljql2001 via sr-dev
Also, should install "libunistring-devel" instead of "libunistring-dev" on 
CentOS.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2020#issuecomment-1886746980
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org