[sr-dev] git:master:b85471a7: Makefile.defs: version set to 5.8.0-pre0

[Daniel-Constantin Mierla via sr-dev]

Module: kamailio
Branch: master
Commit: b85471a7c28324fcb890961a1ad67810bfbb8ac4
URL: 
https://github.com/kamailio/kamailio/commit/b85471a7c28324fcb890961a1ad67810bfbb8ac4

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-02-02T08:56:52+01:00

Makefile.defs: version set to 5.8.0-pre0

- mark start of testing for v5.8.x series

---

Modified: src/Makefile.defs

---

Diff:  
https://github.com/kamailio/kamailio/commit/b85471a7c28324fcb890961a1ad67810bfbb8ac4.diff
Patch: 
https://github.com/kamailio/kamailio/commit/b85471a7c28324fcb890961a1ad67810bfbb8ac4.patch

---

diff --git a/src/Makefile.defs b/src/Makefile.defs
index b3067c493d3..0b6086d0a3d 100644
--- a/src/Makefile.defs
+++ b/src/Makefile.defs
@@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR)
 VERSION = 5
 PATCHLEVEL = 8
 SUBLEVEL =  0
-EXTRAVERSION = -dev3
+EXTRAVERSION = -pre0
 
 # memory manager switcher
 # 0 - f_malloc (fast malloc)

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:8c5e9758: Makefile.defs: version set to 5.8.0-dev3

[Daniel-Constantin Mierla via sr-dev]

Module: kamailio
Branch: master
Commit: 8c5e97589fc0fed121ee6e8ca4adbf9ec63ad2eb
URL: 
https://github.com/kamailio/kamailio/commit/8c5e97589fc0fed121ee6e8ca4adbf9ec63ad2eb

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-02-02T08:55:38+01:00

Makefile.defs: version set to 5.8.0-dev3

- mark end of development for v5.8.x series

---

Modified: src/Makefile.defs

---

Diff:  
https://github.com/kamailio/kamailio/commit/8c5e97589fc0fed121ee6e8ca4adbf9ec63ad2eb.diff
Patch: 
https://github.com/kamailio/kamailio/commit/8c5e97589fc0fed121ee6e8ca4adbf9ec63ad2eb.patch

---

diff --git a/src/Makefile.defs b/src/Makefile.defs
index b088bcfffe2..b3067c493d3 100644
--- a/src/Makefile.defs
+++ b/src/Makefile.defs
@@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR)
 VERSION = 5
 PATCHLEVEL = 8
 SUBLEVEL =  0
-EXTRAVERSION = -dev2
+EXTRAVERSION = -dev3
 
 # memory manager switcher
 # 0 - f_malloc (fast malloc)
@@ -2212,4 +2212,3 @@ export $(saved_chg_vars)
 
 endif # ifneq ($(exported_vars),1)
 endif # ifeq ($(makefile_defs),1)
-

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:03e60c80: Makefile.groups: added file_out to extra group

[Daniel-Constantin Mierla via sr-dev]

Module: kamailio
Branch: master
Commit: 03e60c809a0ac26b402bdf1154d6ec7b0476f26a
URL: 
https://github.com/kamailio/kamailio/commit/03e60c809a0ac26b402bdf1154d6ec7b0476f26a

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-02-02T07:35:48+01:00

Makefile.groups: added file_out to extra group

---

Modified: src/Makefile.groups

---

Diff:  
https://github.com/kamailio/kamailio/commit/03e60c809a0ac26b402bdf1154d6ec7b0476f26a.diff
Patch: 
https://github.com/kamailio/kamailio/commit/03e60c809a0ac26b402bdf1154d6ec7b0476f26a.patch

---

diff --git a/src/Makefile.groups b/src/Makefile.groups
index a9b7d16133f..fec21d47bdd 100644
--- a/src/Makefile.groups
+++ b/src/Makefile.groups
@@ -22,7 +22,7 @@ mod_list_basic=async auth benchmark blst cfg_rpc cfgutils 
corex counters \
 mod_list_extra=avp auth_diameter call_control call_obj dmq domainpolicy msrp \
carrierroute pdb qos sca seas sms sst timer tmrec 
uac_redirect \
xhttp xhttp_rpc xprint jsonrpcs nosip dmq_usrloc statsd 
rtjson \
-   log_custom keepalive ss7ops acc_diameter evrexec \
+   log_custom keepalive ss7ops acc_diameter evrexec 
file_out \
sipjson lrkproxy math posops xhttp_prom dlgs sworker 
influxdbc
 
 # - common modules depending on database

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] [pua] reginfo_increase_version does nothing (Issue #3234)

[github-actions[bot] via sr-dev]

This issue is stale because it has been open 6 weeks with no activity. Remove 
stale label or comment or this will be closed in 2 weeks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3234#issuecomment-1922685515
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] db_unixodbc: MariaDB partition is a reserved word and not quoted (Issue #3742)

[space88man via sr-dev]

### Description
partition is now a reserved word in MariaDB 10.
the column name is correctly quoted with native libmysqlclient/libmariadb so 
works

the column name is not quoted with unixodbc+(libmyodbc8|libmaodbc) and so fails

### Troubleshooting
try unquoted insert

-- fails unixodbc+libmaodbc
insert into location (partition) values (1000);  

-- works native libmysqlclient|libmariadb
insert into location (`partition`) values (1000);

 Reproduction
1. config enable usrloc / registrar with unixodbc + MySQL/MariaDB connector

 Debugging Data

SQL insert into statement fails

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3742
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:40b73521: rtpengine: optional ping parameter for rpc reload command

[Daniel-Constantin Mierla via sr-dev]

Module: kamailio
Branch: master
Commit: 40b735216c610cae2da5b0758af31b1d3ade4731
URL: 
https://github.com/kamailio/kamailio/commit/40b735216c610cae2da5b0758af31b1d3ade4731

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-02-01T21:38:25+01:00

rtpengine: optional ping parameter for rpc reload command

- specify if ping should be done to rtpengines at reload time

---

Modified: src/modules/rtpengine/rtpengine.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/40b735216c610cae2da5b0758af31b1d3ade4731.diff
Patch: 
https://github.com/kamailio/kamailio/commit/40b735216c610cae2da5b0758af31b1d3ade4731.patch

---

diff --git a/src/modules/rtpengine/rtpengine.c 
b/src/modules/rtpengine/rtpengine.c
index e3e4c6e1d50..74983124964 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -1609,6 +1609,8 @@ static int rtpp_test_ping(struct rtpp_node *node)
 static void rtpengine_rpc_reload(rpc_t *rpc, void *ctx)
 {
time_t tnow;
+   int rping = 1;
+   int n = 0;
 
if(rtpp_db_url.s == NULL) {
// no database
@@ -1621,6 +1623,13 @@ static void rtpengine_rpc_reload(rpc_t *rpc, void *ctx)
return;
}
 
+   n = rpc->scan(ctx, "*d", );
+   if(n != 1) {
+   rping = 1;
+   } else if(rping != 0) {
+   rping = 1;
+   }
+
tnow = time(NULL);
if(tnow - _rtpe_list_version->vertime < RTPE_LIST_VERSION_DELAY) {
rpc->fault(ctx, 500, "Too short reload interval - try later");
@@ -1634,7 +1643,7 @@ static void rtpengine_rpc_reload(rpc_t *rpc, void *ctx)
return;
}
 
-   if(build_rtpp_socks(1, 1)) {
+   if(build_rtpp_socks(1, rping)) {
rpc->fault(ctx, 500, "Failed to build rtpengine sockets");
return;
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:49bc5b26: rtpengine: new modparam to disable pinging rtpengines at startup

[Daniel-Constantin Mierla via sr-dev]

Module: kamailio
Branch: master
Commit: 49bc5b266dad33e418e8895e9ed7ead46e254016
URL: 
https://github.com/kamailio/kamailio/commit/49bc5b266dad33e418e8895e9ed7ead46e254016

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-02-01T21:38:25+01:00

rtpengine: new modparam to disable pinging rtpengines at startup

---

Modified: src/modules/rtpengine/rtpengine.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/49bc5b266dad33e418e8895e9ed7ead46e254016.diff
Patch: 
https://github.com/kamailio/kamailio/commit/49bc5b266dad33e418e8895e9ed7ead46e254016.patch

---

diff --git a/src/modules/rtpengine/rtpengine.c 
b/src/modules/rtpengine/rtpengine.c
index 74983124964..c0727ed4e19 100644
--- a/src/modules/rtpengine/rtpengine.c
+++ b/src/modules/rtpengine/rtpengine.c
@@ -347,6 +347,7 @@ static enum hash_algo_t hash_algo = RTP_HASH_CALLID;
 static str rtpengine_dtmf_event_sock;
 static int rtpengine_dtmf_event_fd;
 int dtmf_event_rt = -1; /* default disabled */
+static int rtpengine_ping_mode = 1;
 
 /* clang-format off */
 typedef struct rtpp_set_link {
@@ -465,6 +466,7 @@ static param_export_t params[] = {
_rtpengine_cfg.rtpengine_tout_ms},
{"rtpengine_allow_op", INT_PARAM, _allow_op},
{"control_cmd_tos", INT_PARAM, _cmd_tos},
+   {"ping_mode", PARAM_INT, _ping_mode},
{"db_url", PARAM_STR, _db_url},
{"table_name", PARAM_STR, _table_name},
{"setid_col", PARAM_STR, _setid_col},
@@ -2519,7 +2521,7 @@ static int child_init(int rank)
/* Iterate known RTPEngine instances - create sockets */
if(rank == PROC_SIPINIT) {
/* probe rtpengines only in first worker */
-   if(build_rtpp_socks(0, 1))
+   if(build_rtpp_socks(0, rtpengine_ping_mode))
return -1;
else {
if(build_rtpp_socks(0, 0))

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Daniel-Constantin Mierla via sr-dev]

Adding a few more details, previous comment was done on mobile, typing there on 
the web form is not the easiest.

I think that log_file would be a candidate for the name of a module that writes 
all the logs in a file, similar to log_custom that sends all the log to an udp 
target. Then having a module named log_file and another one file_log would 
looks rather confusing.

Renaming can still be done till the branch 5.8 is created, even if it is past 
the freezing time. First part of testing phase is to tune accordingly the new 
features to be more suitable for long term maintenance.

Names that came meanwhile in my mind would be: fqwrite (file-queued-write); 
fqout (fout being rather commonly used to name output file variables, adding q 
for queuing). This just ideas if renaming is still considered, of course other 
variant can be used.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1922127906
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:4c144ac1: file_out: small doc adaptions

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 4c144ac1ad40008b5bd9396aa18d7630145b4c4c
URL: 
https://github.com/kamailio/kamailio/commit/4c144ac1ad40008b5bd9396aa18d7630145b4c4c

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-02-01T19:22:53Z

file_out: small doc adaptions

---

Modified: src/modules/file_out/doc/file_out_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/4c144ac1ad40008b5bd9396aa18d7630145b4c4c.diff
Patch: 
https://github.com/kamailio/kamailio/commit/4c144ac1ad40008b5bd9396aa18d7630145b4c4c.patch

---

diff --git a/src/modules/file_out/doc/file_out_admin.xml 
b/src/modules/file_out/doc/file_out_admin.xml
index ed6b18268d0..a701156ccba 100644
--- a/src/modules/file_out/doc/file_out_admin.xml
+++ b/src/modules/file_out/doc/file_out_admin.xml
@@ -17,15 +17,15 @@

Overview

-   This is a simple module to support fast streaming output to 
file name
-   and handle that changes on an interval. It implements only one 
function
-   that streams a chunk of text to the current output file handle.
+   This is a small module to support fast streaming output to files
+   and process this changes depending on an interval. It 
implements only one
+   function that streams a chunk of text to the current output 
file handle.


The module can be used to write logs for up to 10 different log 
files.
Each log file can be configured to have a different name and 
extension.
-   String can contain pseudo-variables. The module will replace the
-   pseudo-variables with the actual values. The module will also 
rotate
+   The processed string can contain pseudo-variables. The module 
will replace
+   the pseudo-variables with the actual values. The module will 
also rotate
the log files at a specified interval. The interval is 
specified in seconds.



___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:df3d1e5c: file_out: use name instead of index for file_out function parameter

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: df3d1e5cb80b7a6ac6ce93b582352aaa8e6fd369
URL: 
https://github.com/kamailio/kamailio/commit/df3d1e5cb80b7a6ac6ce93b582352aaa8e6fd369

Author: Xenofon Karamanos 
Committer: Henning Westerholt 
Date: 2024-02-01T19:41:22Z

file_out: use name instead of index for file_out function parameter

---

Modified: src/modules/file_out/doc/file_out_admin.xml
Modified: src/modules/file_out/file_out.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/df3d1e5cb80b7a6ac6ce93b582352aaa8e6fd369.diff
Patch: 
https://github.com/kamailio/kamailio/commit/df3d1e5cb80b7a6ac6ce93b582352aaa8e6fd369.patch

---

diff --git a/src/modules/file_out/doc/file_out_admin.xml 
b/src/modules/file_out/doc/file_out_admin.xml
index b59efdad79f..3054af61672 100644
--- a/src/modules/file_out/doc/file_out_admin.xml
+++ b/src/modules/file_out/doc/file_out_admin.xml
@@ -166,8 +166,8 @@ modparam("file_out", "base_filename", "accounting")
 modparam("file_out", "base_filename", "missed_calls")
 
 request_route {
-   file_out("0", "Writing to accounting.out file $rm from $fu");
-   file_out("1", "Writing to missed_calls.out file $rm from $fu");
+   file_out("accounting", "Writing to accounting.out file $rm from $fu");
+   file_out("missed_calls", "Writing to missed_calls.out file $rm from 
$fu");
 }
 ...

diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c
index 04cc041aa86..1b9bfba7bb0 100644
--- a/src/modules/file_out/file_out.c
+++ b/src/modules/file_out/file_out.c
@@ -51,6 +51,7 @@ static int fo_init_file(const int index);
 static int fo_close_file(const int index);
 static int fo_check_interval();
 static int fo_fixup_int_pvar(void **param, int param_no);
+static int fo_fixup_str_index(void **param, int param_no);
 static int fo_count_assigned_files();
 static void fo_log_writer_process(int rank);
 static int fo_add_filename(modparam_t type, void *val);
@@ -201,6 +202,37 @@ static void fo_log_writer_process(int rank)
}
 }
 
+static int fo_fixup_str_index(void **param, int param_no)
+{
+
+   fparam_t *p;
+   int index = 0;
+
+   p = (fparam_t *)pkg_malloc(sizeof(fparam_t));
+   if(!p) {
+   PKG_MEM_ERROR;
+   return E_OUT_OF_MEM;
+   }
+   memset(p, 0, sizeof(fparam_t));
+   p->orig = *param;
+
+   /* Map string to index */
+   while(index < *fo_number_of_files) {
+   if(strcmp(fo_base_filename[index], (char *)*param) == 0) {
+   LM_DBG("Found index %d for %s\n", index, (char 
*)*param);
+   p->v.i = (int)index;
+   p->fixed = (void *)(long)index;
+   p->type = FPARAM_INT;
+   *param = (void *)p;
+   return 0;
+   }
+   index++;
+   }
+
+   LM_ERR("Couldn't find index for %s\n", (char *)*param);
+   pkg_free(p);
+   return -1;
+}
 /*
 * fixup function for two parameters
 * 1st param: int
@@ -209,7 +241,7 @@ static void fo_log_writer_process(int rank)
 static int fo_fixup_int_pvar(void **param, int param_no)
 {
if(param_no == 1) {
-   return fixup_igp_null(param, param_no);
+   return fo_fixup_str_index(param, param_no);
} else if(param_no == 2) {
return fixup_var_pve_str_12(param, param_no);
}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:6478ac00: file_out: adjust syntax of examples to standard

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: 6478ac00e9bf1180092010b0df4656630d4550c2
URL: 
https://github.com/kamailio/kamailio/commit/6478ac00e9bf1180092010b0df4656630d4550c2

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-02-01T19:33:38Z

file_out: adjust syntax of examples to standard

---

Modified: src/modules/file_out/doc/file_out_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/6478ac00e9bf1180092010b0df4656630d4550c2.diff
Patch: 
https://github.com/kamailio/kamailio/commit/6478ac00e9bf1180092010b0df4656630d4550c2.patch

---

diff --git a/src/modules/file_out/doc/file_out_admin.xml 
b/src/modules/file_out/doc/file_out_admin.xml
index a701156ccba..b59efdad79f 100644
--- a/src/modules/file_out/doc/file_out_admin.xml
+++ b/src/modules/file_out/doc/file_out_admin.xml
@@ -76,9 +76,9 @@

Set base_folder 
parameter

-   ...
-   modparam("file_out", "base_folder", "/tmp/file_out/")
-   ...
+...
+modparam("file_out", "base_folder", "/tmp/file_out/")
+...


 
@@ -95,9 +95,9 @@

Set base_filename 
parameter

-   ...
-   modparam("file_out", "base_filename", "accounting")
-   ...
+...
+modparam("file_out", "base_filename", "accounting")
+...


 
@@ -114,9 +114,9 @@

Set extension 
parameter

-   ...
-   modparam("file_out", "extension", ".txt")
-   ...
+...
+modparam("file_out", "extension", ".txt")
+...


 
@@ -133,9 +133,9 @@

Set interval_seconds 
parameter

-   ...
-   modparam("file_out", "interval_seconds", "300")
-   ...
+...
+modparam("file_out", "interval_seconds", "300")
+...


 
@@ -161,16 +161,15 @@

file_out 
usage

-   ...
-   modparam("file_out", "base_filename", "accounting")
-   modparam("file_out", "base_filename", "missed_calls")
-   ...
-   request_route {
-
-   file_out("0", "Writing  to accounting.out file $rm from 
$fu (IP:$si:$sp)");
-   file_out("1", "Writing  to missed_calls.out file $rm 
from $fu (IP:$si:$sp)");
-   ...
-   }
+...
+modparam("file_out", "base_filename", "accounting")
+modparam("file_out", "base_filename", "missed_calls")
+
+request_route {
+   file_out("0", "Writing to accounting.out file $rm from $fu");
+   file_out("1", "Writing to missed_calls.out file $rm from $fu");
+}
+...




___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:a6892009: file_out: fix error in XML include for README

[Henning Westerholt via sr-dev]

Module: kamailio
Branch: master
Commit: a6892009361ceff1475b568a2317b5d8a7c889cc
URL: 
https://github.com/kamailio/kamailio/commit/a6892009361ceff1475b568a2317b5d8a7c889cc

Author: Henning Westerholt 
Committer: Henning Westerholt 
Date: 2024-02-01T19:25:12Z

file_out: fix error in XML include for README

---

Modified: src/modules/file_out/doc/file_out.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/a6892009361ceff1475b568a2317b5d8a7c889cc.diff
Patch: 
https://github.com/kamailio/kamailio/commit/a6892009361ceff1475b568a2317b5d8a7c889cc.patch

---

diff --git a/src/modules/file_out/doc/file_out.xml 
b/src/modules/file_out/doc/file_out.xml
index 16f15f7f9c5..d55415bef86 100644
--- a/src/modules/file_out/doc/file_out.xml
+++ b/src/modules/file_out/doc/file_out.xml
@@ -34,6 +34,6 @@


 
-   
+   
 
 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Henning Westerholt via sr-dev]

Merged it like this for now as the freeze is coming up
* smaller refactorings will be done afterwards (use string in function for 
names with internal matching, make worker sleep also configurable
* a round of tests has been done, but it will be certainly tested more in the 
next days

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921823318
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:dd5c9a52: file_out: Module to log custom strings to files (GH #3741)

[GitHub via sr-dev]

Module: kamailio
Branch: master
Commit: dd5c9a5204eb946e731550a0ee7f3046c7065515
URL: 
https://github.com/kamailio/kamailio/commit/dd5c9a5204eb946e731550a0ee7f3046c7065515

Author: Xenofon Karamanos 
Committer: GitHub 
Date: 2024-02-01T18:15:17+01:00

file_out: Module to log custom strings to files (GH #3741)

* add new module to log custom strings to files (GH #3741)
* support for multiple files and also file balancing
* smaller refactorings will be done afterwards (use string in function for 
names with internal matching, make worker sleep also configurable
* a round of tests has been done, but it will be certainly tested more in the 
next days

---

Added: src/modules/file_out/Makefile
Added: src/modules/file_out/doc/Makefile
Added: src/modules/file_out/doc/file_out.xml
Added: src/modules/file_out/doc/file_out_admin.xml
Added: src/modules/file_out/file_out.c
Added: src/modules/file_out/types.c
Added: src/modules/file_out/types.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/dd5c9a5204eb946e731550a0ee7f3046c7065515.diff
Patch: 
https://github.com/kamailio/kamailio/commit/dd5c9a5204eb946e731550a0ee7f3046c7065515.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Henning Westerholt via sr-dev]

Merged #3741 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#event-11673226574
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Ovidiu Sas via sr-dev]

How about `f_print` or `file_print`?
In the end, it doesn't really matter, but `file_out` doesn't seem to be very 
intuitive ... or maybe that's just me :)
Thanks for contributing this, it is a nice addition!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921731227
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Henning Westerholt via sr-dev]

Ok, keep it like this then, no special preference from our side. :-)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921712262
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Ovidiu Sas via sr-dev]

If performance is crucial, we can keep the index as a first parameter for the 
`file_out` function and we can change the definition of the `file_out` modparam:
```
modparam("file_out", "base_filename", "0:accounting")
modparam("file_out", "base_filename", "1:missed_calls")
```
Populate slot `0` with `accounting` and slot `1` with `missed_calls`.
If a slot is re-used, throw an error and exit.
If a slot is bigger then `9`, throw an error and exit.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921702988
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Daniel-Constantin Mierla via sr-dev]

I would not recommend using the word `log` in the name. It has nothing to do 
wit the internal logging frawork. The module is purely writings text to a file. 
The core module has basic similar functionality, those functions are not 
related to logging and this module should also keep away from bringing any 
confusion with the prefix or suffix. The current name is better for the purpose 
of the module. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921703420
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Henning Westerholt via sr-dev]

Thanks for the feedback as well @ovidiusas. The name file_log sounds also good. 
Regarding the use of an actual file name, its a good idea and can be probably 
done without performance impact with a fixup function. We will look into that. 

I would merge the module manually in some hours (to do the quick rename), and 
then the further changes can be done directly in the repository.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921686679
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] TLS Module Regression (ee key too small) (Issue #3737)

[Tyler Moore via sr-dev]

Sounds like the code path that is causing the error is not being run.  
Is that on Debian 12?  
Try with the following tls.cfg:

```
[server:default]
method = TLSv1.2+
verify_certificate = yes
require_certificate = yes
private_key = /etc/ssl/private/dsiprouter-key.pem
certificate = /etc/ssl/private/dsiprouter-cert.pem
ca_list = /etc/ssl/certs/ca-certificates.crt
ca_path = /etc/ssl/certs

[client:default]
method = TLSv1.2+
verify_certificate = yes
require_certificate = yes
private_key = /etc/ssl/private/dsiprouter-key.pem
certificate = /etc/ssl/private/dsiprouter-cert.pem
ca_list = /etc/ssl/certs/ca-certificates.crt
ca_path = /etc/ssl/certs
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3737#issuecomment-1921667068
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Xenofon Karamanos via sr-dev]

@miconda Thanks for the feedback, fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921623583
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Xenofon Karamanos via sr-dev]

@xkaraman pushed 2 commits.

ae4752366d5a558c54461ca86cdabbd3c3e13f14  file_out: Add copyright
7d08b018e5e54b998366b704c1d82f6c1ce643e4  file_out: Refactor to mach naming 
conventions

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3741/files/fb03cdc2d266e4b128b197c4261a4922c97d8068..7d08b018e5e54b998366b704c1d82f6c1ce643e4
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] TLS Module Regression (ee key too small) (Issue #3737)

[space88man via sr-dev]

Hmmm ... not reproducible here

kamailio version 5.7.4 (x86_64/linux)
kamcmd tls.reload leads to

```
 7(126739) INFO: tls [tls_domain.c:371]: ksr_tls_fill_missing(): TLSc: 
ca_path='(null)'
 7(126739) INFO: tls [tls_domain.c:378]: ksr_tls_fill_missing(): TLSc: 
crl='(null)'
 7(126739) INFO: tls [tls_domain.c:382]: ksr_tls_fill_missing(): TLSc: 
require_certificate=1
 7(126739) INFO: tls [tls_domain.c:390]: ksr_tls_fill_missing(): TLSc: 
cipher_list='(null)'
 7(126739) INFO: tls [tls_domain.c:397]: ksr_tls_fill_missing(): TLSc: 
private_key='/etc/kamailio/certs/myself-key.pem'
 7(126739) INFO: tls [tls_domain.c:401]: ksr_tls_fill_missing(): TLSc: 
verify_certificate=1
 7(126739) INFO: tls [tls_domain.c:406]: ksr_tls_fill_missing(): TLSc: 
verify_depth=9
 7(126739) INFO: tls [tls_domain.c:410]: ksr_tls_fill_missing(): TLSc: 
verify_client=0
 7(126739) INFO: tls [tls_domain.c:750]: set_verification(): TLSc: 
Server MUST present valid certificate
...




-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3737#issuecomment-1921564403
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Ovidiu Sas via sr-dev]

How about `f_log` or `file_log` instead of `file_out`?
Also, the first parameter of `file_out` function seems to be an index to the 
defined filenames. If the order of the `file_out` modparams is changed, then 
the script has to be updated. It would be more intuitive to use the actual 
filename instead of the index.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921550822
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Henning Westerholt via sr-dev]

Thanks for the feedback, the copyright will be added uniformly, and also extend 
the prefix, sure. Then lets keep the file_out name for now until somebody else 
has a better idea.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921528841
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Daniel-Constantin Mierla via sr-dev]

I have no suggesting about a better name right now, I can think about. Probably 
`log_` prefix is not suitable, because it does not divert all the log messages 
like log_custom.

Otherwise upon a quick look, some files are missing the copyright at the top. 
And I would suggest to add prefix (rename) to the structures used by the 
module, because Node, Queue ... are too common names.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921513868
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] TLS Module Regression (ee key too small) (Issue #3737)

[Tyler Moore via sr-dev]

@space88man I shared a link below with an example key/cert pair from an 
ephemeral VM.  
I can provide access to that VM for testing if needed as well.

https://drive.google.com/drive/folders/1255E1iSUKaKbElwDsC8o3qsh6YTN5jrJ?usp=drive_link

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3737#issuecomment-1921492362
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

[space88man via sr-dev]

> I of course also appreciate the work @space88man put here into that. Maybe I 
> am wrong, but right now the db_* modules in stable branches are not using the 
> pthread approach. My question was about if its really necessary to apply this 
> pthread logic to the DB modules. If the db_* modules are not using TLS, I 
> would expect no problems, or I am wrong?
When troubleshooting #3727 the behaviour of 
the MySQL and MariaDB ODBC connectors is that they will initialise 
libssl/libcrypto even if not using TLS subsequently.  However this will 
cascading effects on `tls.so` and other modules that use TLS since the 
thread-locals will be init'ed in process_no = 0.

I.e. the database modules, while not using SSL themselves, can contaminate the 
thread-locals of main process and the workers will be affected.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3740#issuecomment-1921459905
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Henning Westerholt via sr-dev]

@miconda any suggestions regarding the name? Maybe going for the existing 
"log_" prefix, like log_file, log_file_out or similar?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741#issuecomment-1921450975
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] New module/file_out: Module to log custom strings to file (PR #3741)

[Xenofon Karamanos via sr-dev]

!-- Kamailio Pull Request Template --

!--
IMPORTANT:
  - for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
  - backports to stable branches must be done with git cherry-pick -x 
...
  - code is contributed under BSD for core and main components (tm, sl, auth, 
tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
--

 Pre-Submission Checklist
!-- Go over all points below, and after creating the PR, tick all the 
checkboxes that apply --
!-- All points should be verified, otherwise, read the CONTRIBUTING 
guidelines from above--
!-- If youre unsure about any of these, dont hesitate to ask on 
sr-dev mailing list --
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
!-- Go over all points below, and after creating the PR, tick the 
checkboxes that apply --
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
!-- Describe your changes in detail --
This pull request is intended to introduce a new, straightforward module that 
can efficiently stream output to files while also handling changes based on a 
specific interval. The module contains only one function that streams a chunk 
of text to the current output file handle associated with the given file index.

Its not 100% completed but the basic features are there. Any reviews and 
of course naming of the module, much appreciated.

---

How the module works:

- Set parameter `base_folder` to define where you want your logs to be saved.
- Set `base_filename` (up to 10) to define the names of your files. Each is 
associated with an index according to the order you defined it. First 
`base_filename`s index is 0, seconds index is 1 and so on. This is 
appended with a new timestamp when `interval_seconds` are passed.
- Set `interval_seconds` to define how much time before the file is closed and 
a new one is opened. Right now shared for all files.
- Set `extension` to define what should be the extension of files.  Right now 
shared for all files. 

Use the provided function `file_out` to write any text (including pvs) to a 
specific file you want.

---
**Example:** 

Define parameters such as:
```
# kamailio.cfg
...
loadmodule file_out.so
modparam(file_out, base_folder, 
/tmp/kamailio/file_out/)
modparam(file_out, base_filename, 
accounting)
modparam(file_out, base_filename, 
missed_calls)
modparam(file_out,interval_seconds, 600)
modparam(file_out,extension, .txt)
...

request_route {
...
file_out(0, Writing  to accounting.txt file $rm from 
$fu (IP:$si:$sp));
file_out(1, Writing  to missed_calls.txt file $rm 
from $fu (IP:$si:$sp));
...
}
```
 
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3741

-- Commit Summary --

  * file_out: Add new module
  * file_out: Add docs

-- File Changes --

A src/modules/file_out/Makefile (8)
A src/modules/file_out/doc/Makefile (4)
A src/modules/file_out/doc/file_out.xml (39)
A src/modules/file_out/doc/file_out_admin.xml (191)
A src/modules/file_out/file_out.c (380)
A src/modules/file_out/types.c (88)
A src/modules/file_out/types.h (25)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3741.patch
https://github.com/kamailio/kamailio/pull/3741.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3741
You are receiving this because you are subscribed to this thread.

Message ID: kamailio/kamailio/pull/3...@github.com
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] db modules: init libssl in a thread (PR #3739)

[space88man via sr-dev]

 Pre-Submission Checklist
!-- Go over all points below, and after creating the PR, tick all the 
checkboxes that apply --
!-- All points should be verified, otherwise, read the CONTRIBUTING 
guidelines from above--
!-- If youre unsure about any of these, dont hesitate to ask on 
sr-dev mailing list --
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, 
...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
!-- Go over all points below, and after creating the PR, tick the 
checkboxes that apply --
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ X] Related to issue #3738 (replace  with an open issue number)

 Description
5.7.4 has OpenSSL fixes for tls and outbound but missed out the db modules—the 
most common users of libssl

This PR updates db_mysql, db_unixodbc, db_postgres to init libssl in a thread 
to handle more configurations (tls + db module)



You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3739

-- Commit Summary --

  * geoip: docs - removed trailing spaces
  * geoip2: docs - removed trailing spaces
  * group: docs - removed trailing spaces
  * gzcompress: docs - removed trailing spaces
  * h350: docs - removed trailing spaces
  * htable: docs - removed trailing spaces
  * http_async_client: docs - removed trailing spaces
  * imc: docs - removed trailing spaces
  * ims_auth: docs - removed trailing spaces
  * ims_charging: docs - removed trailing spaces
  * ims_diameter_server: docs - removed trailing spaces
  * ims_icscf: docs - removed trailing spaces
  * ims_isc: docs - removed trailing spaces
  * ims_ocs: docs - removed trailing spaces
  * ims_qos: docs - removed trailing spaces
  * ims_registrar_pcscf: docs - removed trailing spaces
  * ims_registrar_scscf: docs - removed trailing spaces
  * ims_usrloc_pcscf: docs - removed trailing spaces
  * ims_usrloc_scscf: docs - removed trailing spaces
  * ipops: docs - removed trailing spaces
  * jansson: docs - removed trailing spaces
  * janssonrpcc: docs - removed trailing spaces
  * json: docs - removed trailing spaces
  * jsonrpcc: docs - removed trailing spaces
  * kafka: docs - removed trailing spaces
  * kazoo: docs - removed trailing spaces
  * keepalive: docs - removed trailing spaces
  * kex: docs - removed trailing spaces
  * lcr: docs - removed trailing spaces
  * ldap: docs - removed trailing spaces
  * log_custom: docs - removed trailing spaces
  * log_systemd: docs - removed trailing spaces
  * lost: docs - removed trailing spaces
  * lrkproxy: docs - removed trailing spaces
  * mangler: docs - removed trailing spaces
  * matrix: docs - removed trailing spaces
  * maxfwd: docs - removed trailing spaces
  * memcached: docs - removed trailing spaces
  * misc_radius: docs - removed trailing spaces
  * misctest: docs - removed trailing spaces
  * mqtt: docs - removed trailing spaces
  * mqueue: docs - removed trailing spaces
  * msilo: docs - removed trailing spaces
  * msrp: docs - removed trailing spaces
  * mtree: docs - removed trailing spaces
  * nat_traversal: docs - removed trailing spaces
  * nathelper: docs - removed trailing spaces
  * ndb_cassandra: docs - removed trailing spaces
  * ndb_mongodb: docs - removed trailing spaces
  * ndb_redis: docs - removed trailing spaces
  * nosip: docs - removed trailing spaces
  * nsq: docs - removed trailing spaces
  * osp: docs - removed trailing spaces
  * outbound: docs - removed trailing spaces
  * p_usrloc: docs - removed trailing spaces
  * path: docs - removed trailing spaces
  * pdb: docs - removed trailing spaces
  * pdt: docs - removed trailing spaces
  * peering: docs - removed trailing spaces
  * permissions: docs - removed trailing spaces
  * pike: docs - removed trailing spaces
  * pipelimit: docs - removed trailing spaces
  * prefix_route: docs - removed trailing spaces
  * presence: docs - removed trailing spaces
  * presence_conference: docs - removed trailing spaces
  * presence_dialoginfo: docs - removed trailing spaces
  * presence_mwi: docs - removed trailing spaces
  * presence_profile: docs - removed trailing spaces
  * presence_reginfo: docs - removed trailing spaces
  * presence_xml: docs - removed trailing spaces
  * print: docs - removed trailing spaces
  * print_lib: docs - removed trailing spaces
  * pua: docs - removed trailing spaces
  * pua_bla: docs - removed trailing spaces
  * pua_dialoginfo: docs - removed trailing spaces
  * pua_json: docs - 

[sr-dev] Build failed in Jenkins: kamailiodev-nightly-binaries » amd64,xenial #2588

[kamailio--- via sr-dev]

See 


Changes:


--
[...truncated 1.44 MB...]
Makefile.defs defs skipped
Makefile.defs defs skipped
gcc -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops 
-falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -pthread 
-DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
-fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE   
-DNAME='"kamailio"' -DVERSION='"5.8.0-dev2"' -DARCH='"x86_64"' -DOS='linux_' 
-DOS_QUOTED='"linux"' -DCOMPILER='"gcc 5.4.0"' -D__CPU_x86_64 -D__OS_linux 
-DVERSIONVAL=5008000 -DCFG_DIR='"/etc/kamailio/"' 
-DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' 
-DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE 
-DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST 
-DUSE_NAPTR -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY 
-DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP 
-DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM 
-DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL 
-DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM 
-DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL 
-DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT  
-D_FILE_OFFSET_BITS=64 -I/usr/include/hiredis -DMOD_NAME='"topos_redis"' 
-DMOD_NAMEID='topos_redis' -c topos_redis_mod.c -o topos_redis_mod.o -MMD -MP
gcc -shared -g -m64 -Wl,-O2 -Wl,-E  -Wl,-Bsymbolic-functions -Wl,-z,relro 
-pthread -rdynamic "-ldl" -Wl,-Bsymbolic-functions geoip_pv.o geoip_mod.o  
-lGeoIP   -o geoip.so
make[2]: Leaving directory 
'/build/kamailio-5.8.0~dev2+ubuntu16.04.20240201005642.2611/src'
make[1]: Leaving directory 
'/build/kamailio-5.8.0~dev2+ubuntu16.04.20240201005642.2611'
/usr/bin/make every-module group_include="kgeoip2" quiet=verbose
make[1]: Entering directory 
'/build/kamailio-5.8.0~dev2+ubuntu16.04.20240201005642.2611'
/usr/bin/make -C src/ every-module 
make[2]: Entering directory 
'/build/kamailio-5.8.0~dev2+ubuntu16.04.20240201005642.2611/src'
config.mak loaded
Makefile.defs defs skipped
Makefile.defs defs skipped
Makefile.defs defs skipped
gcc -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops 
-falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -pthread 
-DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
-fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE   
-DNAME='"kamailio"' -DVERSION='"5.8.0-dev2"' -DARCH='"x86_64"' -DOS='linux_' 
-DOS_QUOTED='"linux"' -DCOMPILER='"gcc 5.4.0"' -D__CPU_x86_64 -D__OS_linux 
-DVERSIONVAL=5008000 -DCFG_DIR='"/etc/kamailio/"' 
-DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' 
-DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE 
-DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST 
-DUSE_NAPTR -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY 
-DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP 
-DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM 
-DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL 
-DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM 
-DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL 
-DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT  
-DMOD_NAME='"geoip2"' -DMOD_NAMEID='geoip2' -c geoip2_mod.c -o geoip2_mod.o 
-MMD -MP
gcc -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops 
-falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -pthread 
-DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
-fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE   
-DNAME='"kamailio"' -DVERSION='"5.8.0-dev2"' -DARCH='"x86_64"' -DOS='linux_' 
-DOS_QUOTED='"linux"' -DCOMPILER='"gcc 5.4.0"' -D__CPU_x86_64 -D__OS_linux 
-DVERSIONVAL=5008000 -DCFG_DIR='"/etc/kamailio/"' 
-DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' 
-DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE 
-DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST 
-DUSE_NAPTR -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY 
-DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP 
-DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM 
-DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL 
-DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM 
-DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL 
-DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT  
-D_FILE_OFFSET_BITS=64 

[sr-dev] git:master:ff94b5a6: influxdbc: added functions to push string and double values

[Daniel-Constantin Mierla via sr-dev]

Module: kamailio
Branch: master
Commit: ff94b5a691c525ed5687ad76bbf5436a8d877768
URL: 
https://github.com/kamailio/kamailio/commit/ff94b5a691c525ed5687ad76bbf5436a8d877768

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-02-01T13:49:17+01:00

influxdbc: added functions to push string and double values

---

Modified: src/modules/influxdbc/influxdbc_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/ff94b5a691c525ed5687ad76bbf5436a8d877768.diff
Patch: 
https://github.com/kamailio/kamailio/commit/ff94b5a691c525ed5687ad76bbf5436a8d877768.patch

---

diff --git a/src/modules/influxdbc/influxdbc_mod.c 
b/src/modules/influxdbc/influxdbc_mod.c
index 713540fe8d4..b1c79b4b494 100644
--- a/src/modules/influxdbc/influxdbc_mod.c
+++ b/src/modules/influxdbc/influxdbc_mod.c
@@ -49,6 +49,8 @@ static int w_influxdbc_measure(sip_msg_t *msg, char *pname, 
char *p2);
 static int w_influxdbc_measureend(sip_msg_t *msg, char *p1, char *p2);
 static int w_influxdbc_push(sip_msg_t *msg, char *p1, char *p2);
 static int w_influxdbc_long(sip_msg_t *msg, char *pname, char *pvalue);
+static int w_influxdbc_string(sip_msg_t *msg, char *pname, char *pvalue);
+static int w_influxdbc_double(sip_msg_t *msg, char *pname, char *pvalue);
 
 static int mod_init(void);
 static int child_init(int);
@@ -64,6 +66,10 @@ static cmd_export_t cmds[] = {
0, 0, 0, ANY_ROUTE},
{"influxdbc_long", (cmd_function)w_influxdbc_long,
2, fixup_spve_igp, 0, ANY_ROUTE},
+   {"influxdbc_string", (cmd_function)w_influxdbc_string,
+   2, fixup_spve_spve, 0, ANY_ROUTE},
+   {"influxdbc_double", (cmd_function)w_influxdbc_double,
+   2, fixup_spve_spve, 0, ANY_ROUTE},
 
{0, 0, 0, 0, 0, 0}
 };
@@ -195,6 +201,53 @@ static int w_influxdbc_long(sip_msg_t *msg, char *pname, 
char *pvalue)
return 1;
 }
 
+/**
+ *
+ */
+static int w_influxdbc_string(sip_msg_t *msg, char *pname, char *pvalue)
+{
+   str sname;
+   str sval;
+
+   if(fixup_get_svalue(msg, (gparam_t *)pname, ) != 0) {
+   LM_ERR("unable to get name parameter\n");
+   return -1;
+   }
+   if(fixup_get_svalue(msg, (gparam_t *)pvalue, ) != 0) {
+   LM_ERR("unable to get value parameter\n");
+   return -1;
+   }
+
+   ic_string(sname.s, sval.s);
+
+   return 1;
+}
+
+
+/**
+ *
+ */
+static int w_influxdbc_double(sip_msg_t *msg, char *pname, char *pvalue)
+{
+   str sname;
+   str sval;
+   double dval = 0.0;
+
+   if(fixup_get_svalue(msg, (gparam_t *)pname, ) != 0) {
+   LM_ERR("unable to get name parameter\n");
+   return -1;
+   }
+   if(fixup_get_svalue(msg, (gparam_t *)pvalue, ) != 0) {
+   LM_ERR("unable to get value parameter\n");
+   return -1;
+   }
+
+   ic_double(sname.s, dval);
+
+   return 1;
+}
+
+
 /**
  *
  */

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:f0ef9d29: Makefile.groups: added influxdbc module to extra group

[Daniel-Constantin Mierla via sr-dev]

Module: kamailio
Branch: master
Commit: f0ef9d29e8736e7eb7e7e2c62485704d3506fbdd
URL: 
https://github.com/kamailio/kamailio/commit/f0ef9d29e8736e7eb7e7e2c62485704d3506fbdd

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-02-01T13:49:17+01:00

Makefile.groups: added influxdbc module to extra group

---

Modified: src/Makefile.groups

---

Diff:  
https://github.com/kamailio/kamailio/commit/f0ef9d29e8736e7eb7e7e2c62485704d3506fbdd.diff
Patch: 
https://github.com/kamailio/kamailio/commit/f0ef9d29e8736e7eb7e7e2c62485704d3506fbdd.patch

---

diff --git a/src/Makefile.groups b/src/Makefile.groups
index df1fde094af..a9b7d16133f 100644
--- a/src/Makefile.groups
+++ b/src/Makefile.groups
@@ -23,7 +23,7 @@ mod_list_extra=avp auth_diameter call_control call_obj dmq 
domainpolicy msrp \
carrierroute pdb qos sca seas sms sst timer tmrec 
uac_redirect \
xhttp xhttp_rpc xprint jsonrpcs nosip dmq_usrloc statsd 
rtjson \
log_custom keepalive ss7ops acc_diameter evrexec \
-   sipjson lrkproxy math posops xhttp_prom dlgs sworker
+   sipjson lrkproxy math posops xhttp_prom dlgs sworker 
influxdbc
 
 # - common modules depending on database
 mod_list_db=acc alias_db auth_db avpops cfg_db db_text db_flatstore \

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Freezing development for 5.8.x series

[Daniel-Constantin Mierla via sr-dev]

Hello,

short reply to refresh on freezing plan and bump the message at the top
for everyone.

Cheers,
Daniel

On 30.01.24 08:16, Daniel-Constantin Mierla wrote:
> Hello,
>
> I propose to aim freezing the development for 5.8.x series at the end of
> the 1st of February 2024 (Thursday).
>
> New features that one wants to get in this release series have to be
> pushed to git repository or pull requests made for them. Afterwards
> usually follows a 4-6 weeks of testing till the first release 5.8.0.
> Unfreezing will happen earlier, after the first weeks of testing when
> the 5.8 branch will be created.
>
> Cheers,
> Daniel

-- 
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy, Training and Development Services -- asipto.com
Kamailio Advanced Training, February 20-22, 2024 -- asipto.com
Kamailio World Conference, April 18-19, 2024, Berlin -- kamailioworld.com

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:4efd1fc3: p_usrloc: Add new modparam 'preload'

[Stefan-Cristian Mititelu via sr-dev]

Module: kamailio
Branch: master
Commit: 4efd1fc33ceb5dc33b01020968b0d7281e902d1f
URL: 
https://github.com/kamailio/kamailio/commit/4efd1fc33ceb5dc33b01020968b0d7281e902d1f

Author: Stefan-Cristian Mititelu 
Committer: Stefan-Cristian Mititelu 
Date: 2024-02-01T14:00:17+02:00

p_usrloc: Add new modparam 'preload'

Useful when using kemi with p_usrloc, in order to preload
location table.

---

Modified: src/modules/p_usrloc/p_usrloc_mod.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/4efd1fc33ceb5dc33b01020968b0d7281e902d1f.diff
Patch: 
https://github.com/kamailio/kamailio/commit/4efd1fc33ceb5dc33b01020968b0d7281e902d1f.patch

---

diff --git a/src/modules/p_usrloc/p_usrloc_mod.c 
b/src/modules/p_usrloc/p_usrloc_mod.c
index 8179d12ae14..539ad31b031 100644
--- a/src/modules/p_usrloc/p_usrloc_mod.c
+++ b/src/modules/p_usrloc/p_usrloc_mod.c
@@ -88,6 +88,11 @@ static int child_init(int rank); /*!< Per-child init 
function */
 extern int bind_usrloc(usrloc_api_t *api);
 extern int ul_locks_no;
 
+#define UL_PRELOAD_SIZE 8
+static char *ul_preload_list[UL_PRELOAD_SIZE];
+static int ul_preload_index = 0;
+static int ul_preload_param(modparam_t type, void *val);
+
 /*
  * Module parameters and their default values
  */
@@ -269,6 +274,7 @@ static param_export_t params[] = {{"ruid_column", 
PARAM_STR, _col},
{"db_update_as_insert", INT_PARAM,
_p_usrloc_cfg.db_update_as_insert},
{"mdb_availability_control", INT_PARAM, 
_availability_control},
+   {"preload", PARAM_STRING | USE_FUNC_PARAM, (void 
*)ul_preload_param},
{0, 0, 0}};
 
 
@@ -310,6 +316,8 @@ struct module_exports exports = {
  */
 static int mod_init(void)
 {
+   int i = 0;
+   udomain_t *d;
int matching_mode_cfg = cfg_get(p_usrloc, p_usrloc_cfg, matching_mode);
 
 #ifdef STATISTICS
@@ -352,6 +360,14 @@ static int mod_init(void)
return -1;
}
 
+   /* preload tables */
+   for(i = 0; i < ul_preload_index; i++) {
+   if(register_udomain((const char *)ul_preload_list[i], ) < 0) {
+   LM_ERR("cannot register preloaded table %s\n", 
ul_preload_list[i]);
+   return -1;
+   }
+   }
+
if(db_mode != DB_ONLY) {
LM_ERR("DB_ONLY is the only mode possible for partitioned 
usrloc. "
   "Please set db_mode to 3\n");
@@ -513,3 +529,23 @@ time_t ul_db_datetime_get(time_t v)
return v;
}
 }
+
+/*! \brief
+ * preload module parameter handler
+ */
+static int ul_preload_param(modparam_t type, void *val)
+{
+   if(val == NULL) {
+   LM_ERR("invalid parameter\n");
+   goto error;
+   }
+   if(ul_preload_index >= UL_PRELOAD_SIZE) {
+   LM_ERR("too many preloaded tables\n");
+   goto error;
+   }
+   ul_preload_list[ul_preload_index] = (char *)val;
+   ul_preload_index++;
+   return 0;
+error:
+   return -1;
+}

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

[Daniel-Constantin Mierla via sr-dev]

Well, that's the problem actually, because the db module can use tls if, for 
example, connection to MySQL/MariaDB is done over TLS. That was reported for 
db_unixodbc when connecting to Microsoft SQL Server via TLS. Any other module 
that eventually ends up using libssl3 though chain of dependencies can have 
similar impact. Also in the past there were reports that can be related:

  - https://github.com/kamailio/kamailio/issues/3115
  - https://github.com/kamailio/kamailio/issues/2560

Solutions were found at the times for respective versions, but with libssl3 
this might be the right approach, or at least the one we could explore now.

Anyhow, I expected those patches to be backported to have the fix completed, 
right now at least the db_unixodbc is reported to be broken.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3740#issuecomment-1921127455
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

[Henning Westerholt via sr-dev]

I of course also appreciate the work @space88man put here into that. Maybe I am 
wrong, but right now the db_* modules in stable branches are not using the 
pthread approach. My question was about if its really necessary to apply this 
pthread logic to the DB modules. If the db_* modules are not using TLS, I would 
expect no problems, or I am wrong?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3740#issuecomment-1921071498
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] 5.7 db modules: init libssl in a thread (PR #3740)

[Daniel-Constantin Mierla via sr-dev]

Unfortunately adapting to work properly with changes brought by libssl3+ was 
not easy, but it might not be a simpler way for avoiding those random crashes. 
I really appreciate the time and effort @space88man spent on it.

This backported PR is not doing any fundamental change, it just makes common 
wrappers that can be used from the modules directly, instead of having those 
wrappers in each module. Those functions are not used in core, just placed 
there to be available everywhere. For consistency with devel version (upcoming 
5.8 as well) , I think it should be merged.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3740#issuecomment-1921039355
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org