[sr-dev] git:master:0054b875: Avoid 'qm_strnstr' defined but not used warning
Module: kamailio
Branch: master
Commit: 0054b875045b4badfedd3e8424bf4772d6a9bc6b
URL:
https://github.com/kamailio/kamailio/commit/0054b875045b4badfedd3e8424bf4772d6a9bc6b
Author: Juha Heinanen
Committer: Juha Heinanen
Date: 2024-03-12T22:18:20+02:00
Avoid 'qm_strnstr' defined but not used warning
---
Modified: src/core/mem/q_malloc.c
---
Diff:
https://github.com/kamailio/kamailio/commit/0054b875045b4badfedd3e8424bf4772d6a9bc6b.diff
Patch:
https://github.com/kamailio/kamailio/commit/0054b875045b4badfedd3e8424bf4772d6a9bc6b.patch
---
diff --git a/src/core/mem/q_malloc.c b/src/core/mem/q_malloc.c
index aa68debdf30..5850c07a018 100644
--- a/src/core/mem/q_malloc.c
+++ b/src/core/mem/q_malloc.c
@@ -993,6 +993,7 @@ void qm_status(void *qmp)
}
+#ifdef DBG_QM_MALLOC
static void *qm_strnstr(const void *b1, int l1, const void *b2, int l2)
{
char *sp = (char *)b1;
@@ -1012,6 +1013,7 @@ static void *qm_strnstr(const void *b1, int l1, const
void *b2, int l2)
return NULL;
}
+#endif
void qm_status_filter(void *qmp, str *fmatch, FILE *fp)
{
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.8:2122afae: Avoid 'qm_strnstr' defined but not used warning
Module: kamailio
Branch: 5.8
Commit: 2122afae2a6604c0bc44a43ab37ee274a15a700a
URL:
https://github.com/kamailio/kamailio/commit/2122afae2a6604c0bc44a43ab37ee274a15a700a
Author: Juha Heinanen
Committer: Juha Heinanen
Date: 2024-03-12T22:16:23+02:00
Avoid 'qm_strnstr' defined but not used warning
---
Modified: src/core/mem/q_malloc.c
---
Diff:
https://github.com/kamailio/kamailio/commit/2122afae2a6604c0bc44a43ab37ee274a15a700a.diff
Patch:
https://github.com/kamailio/kamailio/commit/2122afae2a6604c0bc44a43ab37ee274a15a700a.patch
---
diff --git a/src/core/mem/q_malloc.c b/src/core/mem/q_malloc.c
index aa68debdf30..5850c07a018 100644
--- a/src/core/mem/q_malloc.c
+++ b/src/core/mem/q_malloc.c
@@ -993,6 +993,7 @@ void qm_status(void *qmp)
}
+#ifdef DBG_QM_MALLOC
static void *qm_strnstr(const void *b1, int l1, const void *b2, int l2)
{
char *sp = (char *)b1;
@@ -1012,6 +1013,7 @@ static void *qm_strnstr(const void *b1, int l1, const
void *b2, int l2)
return NULL;
}
+#endif
void qm_status_filter(void *qmp, str *fmatch, FILE *fp)
{
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> > ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid
> > provided ,This error was noticed before the last commit
> > [[9769806](https://github.com/kamailio/kamailio/commit/9769806b96148a2ede4612605c6d4af047c137f7)].
> > After this update it was fine. I have tested with more than 135000 active
> > registrations and many failures.
>
> I'm also getting this with your latest commit. Do you have a bare minimum
> config that works for you, so I can verify?
>
> Also, I've tested with contact_mode=1 too, but for an INVITE, topos adds a
> `tps=btpsh-`, do you do this manually?
It is not required to add btph/atph to contact as Registration will not create
a Dialog for another Indialog Method will not be orginated with this contact.
For registration no change is done in the contact field by Topos.
modparam("topoh", "mask_key", "THIS_IS_TEST_KEY")
modparam("topoh", "mask_callid", 1)
modparam("topoh", "callid_prefix", "TXX")
modparam("topoh", "use_mode", 1)
modparam("topos", "storage", "redis")
modparam("topos_redis", "serverid", "tps")
modparam("topos", "contact_mode", 1)
modparam("topos", "rr_update", 1)
modparam("topos", "contact_host", EXTIP )
modparam("topos", "mask_callid", 1)
modparam("topos", "enable_register_publish",1)
This works perfectly for me, where TOPOS hide Via and mask Call-ID. Form. To
and Requst URI chages as done manually/ through Dispatcher
ds_select_domaincall in dispatcher.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3766#issuecomment-1992397254
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid > provided ,This error was noticed before the last commit > [[9769806](https://github.com/kamailio/kamailio/commit/9769806b96148a2ede4612605c6d4af047c137f7)]. > After this update it was fine. I have tested with more than 135000 active > registrations and many failures. I'm also getting this with your latest commit. Do you have a bare minimum config that works for you, so I can verify? Also, I've tested with contact_mode=1 too, but for an INVITE, topos adds a `tps=btpsh-`, do you do this manually? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1992310266 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> > I tested it for REGISTER, and it seems to break if the registrar sends e.g. > > a 4xx with no contact back, causing the log line > > ``` > > ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid > > provided > > ``` > > > > > > > > > > > > > > > > > > > > > > > > Is this something you've experienced, @toharish ? > > Thinking of it: if the Contact is not handled by topos, where is the lookup > key `cparam_name` stored? Could it be that this only works with > `contact_mode=2`? If so, could you please provide a full example to > reprooduce it? ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid provided ,This error was noticed before the last commit [9769806]. After this update it was fine. I have tested with more than 135000 active registrations and many failures. I have used contact_mode=1. In this case contact is stored but not replaced. This can be further worked out to replace the contact, however I felt it may vary based on the user requirement, hence it was left to the users to modify it in the kamailio script as required. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1992152386 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> I tested it for REGISTER, and it seems to break if the registrar sends e.g. a > 4xx with no contact back, causing the log line > > ``` > ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid > provided > ``` > > Is this something you've experienced, @toharish ? Thinking of it: if the Contact is not handled by topos, where is the lookup key `cparam_name` stored? Could it be that this only works with `contact_mode=2`? If so, could you please provide a full example to reprooduce it? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1992001900 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
I tested it for REGISTER, and it seems to break if the registrar sends e.g. a 4xx with no contact back, causing the log line ``` ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid provided ``` Is this something you've experienced, @toharish ? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1991720869 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> From description I understand that only Via is removed for REGISTER (and > PUBLISH). The Contact stays the same, in that case Path still has to be used > in order to get the traffic back to topos-instance. Also, the incoming Path > headers are kept. Is it right? Yes, Via and Call-ID mask is done in this pull request, other headers can be managed in kamailio native script/ksr as per the end user requirement. Registration will have the location information and authentication information, hence it needs to be handled as per requirement. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1991522529 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
Interested in that one, as I by chance have an immediate need for it. Will test it today. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1991461000 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
