[sr-dev] [kamailio/kamailio] kamcmd keepalive.list the last up and down time reversed (Issue #3790)
kamailio 5.7.0
kamcmd keepalive.list
{
uri: sip:192.168.10.12:8877
owner: drouting
last checked: Mon Mar 18 17:45:39 2024
last up: Mon Mar 18 17:45:59 2024 //err
last down: Thu Jan 1 08:00:00 1970 //err
state: 2
}
{
uri: sip:192.168.10.124:5080
owner: drouting
last checked: Tue Mar 19 10:34:39 2024
last up: Thu Jan 1 08:00:00 1970 //err
last down: Tue Mar 19 10:34:39 2024//err
state: 1
}
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3790
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] branch_failure route in case 503 and dns failover (PR #3138)
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3138#issuecomment-2005640606 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] github: [skip ci]: bump tj-actions/changed-files from 42 to 43 (PR #3789)
Merged #3789 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3789#event-12159886821 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:9ae99b3d: github: [skip ci]: bump tj-actions/changed-files from 42 to 43
Module: kamailio
Branch: master
Commit: 9ae99b3dfc6eb538ea93d6775a283096fe17384c
URL:
https://github.com/kamailio/kamailio/commit/9ae99b3dfc6eb538ea93d6775a283096fe17384c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Committer: Victor Seva
Date: 2024-03-18T22:47:14+01:00
github: [skip ci]: bump tj-actions/changed-files from 42 to 43
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files)
from 42 to 43.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](https://github.com/tj-actions/changed-files/compare/v42...v43)
---
updated-dependencies:
- dependency-name: tj-actions/changed-files
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot]
---
Modified: .github/workflows/devcontainer.yaml
---
Diff:
https://github.com/kamailio/kamailio/commit/9ae99b3dfc6eb538ea93d6775a283096fe17384c.diff
Patch:
https://github.com/kamailio/kamailio/commit/9ae99b3dfc6eb538ea93d6775a283096fe17384c.patch
---
diff --git a/.github/workflows/devcontainer.yaml
b/.github/workflows/devcontainer.yaml
index 2da1e56c742..a237e2a0338 100644
--- a/.github/workflows/devcontainer.yaml
+++ b/.github/workflows/devcontainer.yaml
@@ -33,14 +33,14 @@ jobs:
- name: Get changed files
if: ${{ ! inputs.force }}
id: changed-files
-uses: tj-actions/changed-files@v42
+uses: tj-actions/changed-files@v43
with:
since_last_remote_commit: true
- name: changes in relevant files
if: ${{ ! inputs.force }}
id: changed-files-builder
-uses: tj-actions/changed-files@v42
+uses: tj-actions/changed-files@v43
with:
files: |
.devcontainer/**
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] github: [skip ci]: bump tj-actions/changed-files from 42 to 43 (PR #3789)
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files)
from 42 to 43.
details
summaryRelease notes/summary
pemSourced from a
href=https://github.com/tj-actions/changed-files/releasestj-actions/changed-filess
releases/a./em/p
blockquote
h2v43/h2
h1Changes in v43.0.0/h1
h2 BREAKING CHANGE /h2
ul
licodeany_{changed, modified, deleted}/code outputs now
return codetrue/code when no file/directory patterns are
specified./li
/ul
h2Whats Changed/h2
ul
liUpgraded to v42.1.0 by a
href=https://github.com/tj-actions-botcode@tj-actions-bot/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1977tj-actions/changed-files#1977/a/li;
lichore(deps): lock file maintenance by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1979tj-actions/changed-files#1979/a/li;
lichore(deps): update dependency
code@typescript-eslint/parser/code to v7.2.0 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1980tj-actions/changed-files#1980/a/li;
lichore(deps): update dependency code@types/node/code
to v20.11.26 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1981tj-actions/changed-files#1981/a/li;
lichore(deps): update dependency
code@typescript-eslint/eslint-plugin/code to v7.2.0 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1982tj-actions/changed-files#1982/a/li;
lichore(deps): update dependency
code@types/lodash/code to v4.17.0 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1983tj-actions/changed-files#1983/a/li;
lichore(deps): update peter-evans/create-pull-request action to v6.0.2
by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1984tj-actions/changed-files#1984/a/li;
lichore(deps): update dependency code@types/node/code
to v20.11.27 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1987tj-actions/changed-files#1987/a/li;
lifeat: add support for returning true for codeany_{changed,
modified, deleted}/code outputs when no patterns are specified by a
href=https://github.com/jackton1code@jackton1/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1988tj-actions/changed-files#1988/a/li;
liUpdated README.md by a
href=https://github.com/tj-actions-botcode@tj-actions-bot/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1989tj-actions/changed-files#1989/a/li;
/ul
pstrongFull Changelog/strong: a
href=https://github.com/tj-actions/changed-files/compare/v42...v43.0.0https://github.com/tj-actions/changed-files/compare/v42...v43.0.0/a/p;
hr /
h2v43.0.0/h2
h2 BREAKING CHANGE /h2
ul
licodeany_{changed, modified, deleted}/code outputs now
return codetrue/code when no file/directory patterns are
specified./li
/ul
h2Whats Changed/h2
ul
liUpgraded to v42.1.0 by a
href=https://github.com/tj-actions-botcode@tj-actions-bot/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1977tj-actions/changed-files#1977/a/li;
lichore(deps): lock file maintenance by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1979tj-actions/changed-files#1979/a/li;
lichore(deps): update dependency
code@typescript-eslint/parser/code to v7.2.0 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1980tj-actions/changed-files#1980/a/li;
lichore(deps): update dependency code@types/node/code
to v20.11.26 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1981tj-actions/changed-files#1981/a/li;
lichore(deps): update dependency
code@typescript-eslint/eslint-plugin/code to v7.2.0 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1982tj-actions/changed-files#1982/a/li;
lichore(deps): update dependency
code@types/lodash/code to v4.17.0 by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1983tj-actions/changed-files#1983/a/li;
lichore(deps): update peter-evans/create-pull-request action to v6.0.2
by a
href=https://github.com/renovatecode@renovate/code/a;
in a
href=https://redirect.github.com/tj-actions/changed-files/pull/1984tj-actions/changed-files#1984/a/li;
lichore(deps): update dependency code@types/node/code
to v20.11.27 by a
[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)
@sergey-safarov pushed 3 commits. 929854ef7cb194b138c2e9a28b98f920f17d6bc0 core: updated TCP connection selection for haproxy and Via header processing 25960ff1873ece98172c660c96c9f61140e044f8 siptrace: fixed siptrace when tcp haproxy is used 444e42229b2ffeeb34547894966708047b2b90fa siprec for haproxy fix -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3731/files/4e70f50c8d644426e204ce533cff9f7c18d95740..444e42229b2ffeeb34547894966708047b2b90fa You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)
@sergey-safarov pushed 5 commits. bf71af1811710c06a425d3e45245960b25b87922 core, rr, path: updated relaying logic when haproxy is used 383015a2c6fcd23fb1ebac1e1ae44839a616d3d8 fixed transport via haproxy b1496c493208f62bc784a699eb3e9ac2be471691 core: updated TCP connection selection for haproxy and Via header processing be77bbafad54a509a7d0ed40fad507e9ecb2bd52 siptrace: fixed siptrace when tcp haproxy is used 4e70f50c8d644426e204ce533cff9f7c18d95740 siprec for haproxy fix -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3731/files/b0efcbe6de8ec46e7720e8dbcb77467bad699962..4e70f50c8d644426e204ce533cff9f7c18d95740 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)
@sergey-safarov pushed 1 commit. 361326d0827cd795a3d276e4b67a37214d78c87a WIP: format-4 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3731/files/d81c1fed7233b8117998022bd5725e920078c753..361326d0827cd795a3d276e4b67a37214d78c87a You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)
@sergey-safarov pushed 1 commit. d81c1fed7233b8117998022bd5725e920078c753 WIP: format-3 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3731/files/f8f0b7198badfac6741fbfdbd202cdf0043ad57c..d81c1fed7233b8117998022bd5725e920078c753 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)
@sergey-safarov pushed 1 commit. f8f0b7198badfac6741fbfdbd202cdf0043ad57c WIP: format-2 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3731/files/90e2cfc1eb90b881e021e85f60aaf5551d69f286..f8f0b7198badfac6741fbfdbd202cdf0043ad57c You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)
@sergey-safarov pushed 1 commit. 90e2cfc1eb90b881e021e85f60aaf5551d69f286 WIP: format-1 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3731/files/96795acd315c423aa4b5186151be7cffdba71cbc..90e2cfc1eb90b881e021e85f60aaf5551d69f286 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)
@sergey-safarov pushed 5 commits. 33087b06c578679d9c54c90dd5a871306fcc4036 core, rr, path: updated relaying logic when haproxy is used 8c4627555f5b6eed802238a6a24c0579d1ce48f0 fixed transport via haproxy 43452b75e45303d4a00078730256246ffeebbcd7 core: updated TCP connection selection for haproxy and Via header processing 7613b5171ec1d1c77bcd46a368937182cde3501f siptrace: fixed siptrace when tcp haproxy is used 96795acd315c423aa4b5186151be7cffdba71cbc siprec for haproxy fix -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3731/files/8f43a599f233a47d1cf0efda7c3d66c99cc491a2..96795acd315c423aa4b5186151be7cffdba71cbc You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: add flags processing on the daemon side (PR #3788)
@zenichev pushed 1 commit. c281bcd682faac379437a2bd240ab69f1383 rtpengine: add flags processing on the daemon side -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3788/files/e2c1a0f57201d04e437e02ddb1cc7dd1ab1bbc2e..c281bcd682faac379437a2bd240ab69f1383 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Not enough parameters for htable.seti (Issue #3774)
```
version: kamailio 5.9.0-dev0 (x86_64/linux) 04a73a
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE,
USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC,
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT,
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES,
TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE
262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 04a73a
compiled on 13:49:48 Mar 18 2024 with gcc 13.2.1
```
Tested with the above version (commit
04a73ace6572dd5c95a8f50b39b2ce712f7ebe84), and it no longer gives the 500 error
with `htable.seti`:
```
$ kamcmd htable.seti rconfig foo 1
Ok. Key set to new value.
$ kamcmd htable.get rconfig foo
{
item: {
name: foo
value: 1
flags: 0
expire: NEVER
}
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3774#issuecomment-2003838981
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Discrepancies in migration of commits from herlesupreeth/kamailio to upstream (Issue #3772)
Closed #3772 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3772#event-12151538701 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Discrepancies in migration of commits from herlesupreeth/kamailio to upstream (Issue #3772)
PR was merged. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3772#issuecomment-2003822603 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Not enough parameters for htable.seti (Issue #3774)
Can you test with latest master branch? There was a commit pushed to address it in the ctl module. If it works fine, then the commit will be backported. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3774#issuecomment-2003821361 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Wrong Route header order in called party re-INVITE when using topos (Issue #3778)
Can you attach a pcap with SIP traffic from such a call? Also, provide the kamailio version and the operating system you are using. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3778#issuecomment-2003818793 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] PKG Memory Leak with RTPEngine Module with WebSocket (Issue #3777)
Can you test with latest version of 5.7 branch, there were many fixes since 5.7.0 in that branch and the logs messages do not match anymore the source code. Reproduce with latest 5.7.x and then paste again the relevant logs in order to be able to troubleshoot properly. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3777#issuecomment-2003815285 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] rtpengine: add flags processing on the daemon side (PR #3788)
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description !-- Describe your changes in detail -- Introduce a versatile behavior of the rtpengine module in terms of ability to parse flags on rtpengine side, instead of module. Previous behavior is also kept (so backwards compatibility). General points: - rtpengine daemon supports rtpp flags processing from now on - module still provides in the bencode (when calling daemon): call-id, to/from tags, viabranch (so identification call data) - even though the modules interface is updated, a backwards compatibility is given, so no obligatory changes from kamailio script users required - each rtpengine modules function where its reasonable to use rtpp flags as a parameter, now is able to get a third parameter `viabranch`, which is used to detect, which approach to use (older/newer): - without the viabranch - older one used - with the viabrnach - new one used, so rtpp flags parsing on rtpengine side The reason why the `via-branch` has been selected as a point of behavior differentiation is that currently its only given via option flags list (raw string), meanwhile with a newer behavior option flags will not be parsed by the module. Since the module still has to provide all the basic identifiers, such as: call-id, From/To tags and via-branch, via-branch now is moved to a separate parameter, and gives to the module a clue a newer behavior is to be applied. The goal (for the future) is to deprecate processing of option flags on the module side and only parse them using rtpengine. This brings a list of benifits, such as: - no need to keep in sync rtpengine and module (for specific flags) - support of different rtpp flag string formats (raw), so that, for example, kamailio script users can use plain text or bencode dictionary like format, when providing flags from the kamailio script Current change is only applicable with rtpengine versions equal or later than mr12.3 Backwards compatibility provided, so users are not forced to change anything. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3788 -- Commit Summary -- * rtpengine: add flags processing on the daemon side * rtpengine: update documentation in regards of flags processing -- File Changes -- M src/modules/rtpengine/doc/rtpengine.xml (8) M src/modules/rtpengine/doc/rtpengine_admin.xml (45) M src/modules/rtpengine/rtpengine.c (847) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3788.patch https://github.com/kamailio/kamailio/pull/3788.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3788 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.8:6410f375: pdb: Return negative carrierid for failures
Module: kamailio
Branch: 5.8
Commit: 6410f375cd6d1e357afeb9e100bd3a3c51321280
URL:
https://github.com/kamailio/kamailio/commit/6410f375cd6d1e357afeb9e100bd3a3c51321280
Author: Stefan-Cristian Mititelu
Committer: Stefan-Cristian Mititelu
Date: 2024-03-18T13:35:05+02:00
pdb: Return negative carrierid for failures
(cherry-picked from commit bf78b619ae28924361fb2c757a4d09eb1a39f5cd)
---
Modified: src/modules/pdb/pdb.c
---
Diff:
https://github.com/kamailio/kamailio/commit/6410f375cd6d1e357afeb9e100bd3a3c51321280.diff
Patch:
https://github.com/kamailio/kamailio/commit/6410f375cd6d1e357afeb9e100bd3a3c51321280.patch
---
diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c
index 6889e63b915..1398f7574f8 100644
--- a/src/modules/pdb/pdb.c
+++ b/src/modules/pdb/pdb.c
@@ -393,20 +393,20 @@ static int pdb_query(struct sip_msg *_msg, struct
multiparam_t *_number,
goto found;
}
break;
- case
PDB_CODE_NOT_NUMBER:
-
LM_NOTICE("Number %s has letters in it\n",
-
number.s);
-
carrierid = 0;
- goto
found;
case
PDB_CODE_NOT_FOUND:
LM_NOTICE("Number %s pdb_id not found\n",
number.s);
-
carrierid = 0;
+
carrierid = -1;
+ goto
found;
+ case
PDB_CODE_NOT_NUMBER:
+
LM_NOTICE("Number %s has letters in it\n",
+
number.s);
+
carrierid = -2;
goto
found;
default:
LM_NOTICE("Invalid code %d received\n",
msg.hdr.code);
-
carrierid = 0;
+
carrierid = -3;
goto
found;
}
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.8:0af55b0e: pdb server: Return negative carrierid for failures. Clang format
Module: kamailio Branch: 5.8 Commit: 0af55b0eac8c3457db859a9c37fea211ece91b8a URL: https://github.com/kamailio/kamailio/commit/0af55b0eac8c3457db859a9c37fea211ece91b8a Author: Stefan-Cristian Mititelu Committer: Stefan-Cristian Mititelu Date: 2024-03-18T13:36:10+02:00 pdb server: Return negative carrierid for failures. Clang format (cherry-picked from commit 88b698e0f62c39ed60af9f0a4fb3ca2dc6867d8f) --- Modified: utils/pdbt/pdb_server.c Modified: utils/pdbt/pdb_server_backend.c --- Diff: https://github.com/kamailio/kamailio/commit/0af55b0eac8c3457db859a9c37fea211ece91b8a.diff Patch: https://github.com/kamailio/kamailio/commit/0af55b0eac8c3457db859a9c37fea211ece91b8a.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:e8150f78: pdb: Return negative carrierid for failures
Module: kamailio
Branch: 5.7
Commit: e8150f78630f7991ea31a385c899c32c0e330a26
URL:
https://github.com/kamailio/kamailio/commit/e8150f78630f7991ea31a385c899c32c0e330a26
Author: Stefan-Cristian Mititelu
Committer: Stefan-Cristian Mititelu
Date: 2024-03-18T13:23:29+02:00
pdb: Return negative carrierid for failures
(cherry picked from commit bf78b619ae28924361fb2c757a4d09eb1a39f5cd)
---
Modified: src/modules/pdb/pdb.c
---
Diff:
https://github.com/kamailio/kamailio/commit/e8150f78630f7991ea31a385c899c32c0e330a26.diff
Patch:
https://github.com/kamailio/kamailio/commit/e8150f78630f7991ea31a385c899c32c0e330a26.patch
---
diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c
index 75013cccb7a..3c37e5971ea 100644
--- a/src/modules/pdb/pdb.c
+++ b/src/modules/pdb/pdb.c
@@ -386,20 +386,20 @@ static int pdb_query(struct sip_msg *_msg, struct
multiparam_t *_number,
goto found;
}
break;
- case
PDB_CODE_NOT_NUMBER:
-
LM_NOTICE("Number %s has letters in it\n",
-
number.s);
-
carrierid = 0;
- goto
found;
case
PDB_CODE_NOT_FOUND:
LM_NOTICE("Number %s pdb_id not found\n",
number.s);
-
carrierid = 0;
+
carrierid = -1;
+ goto
found;
+ case
PDB_CODE_NOT_NUMBER:
+
LM_NOTICE("Number %s has letters in it\n",
+
number.s);
+
carrierid = -2;
goto
found;
default:
LM_NOTICE("Invalid code %d received\n",
msg.hdr.code);
-
carrierid = 0;
+
carrierid = -3;
goto
found;
}
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:c717c016: pdb server: Return negative carrierid for failures. Clang format
Module: kamailio
Branch: 5.7
Commit: c717c016b70a82566dfc58d8d9dee3d3f51ddb01
URL:
https://github.com/kamailio/kamailio/commit/c717c016b70a82566dfc58d8d9dee3d3f51ddb01
Author: Stefan-Cristian Mititelu
Committer: Stefan-Cristian Mititelu
Date: 2024-03-18T13:25:21+02:00
pdb server: Return negative carrierid for failures. Clang format
(cherry-picked from commit 88b698e0f62c39ed60af9f0a4fb3ca2dc6867d8f)
---
Modified: utils/pdbt/pdb_server.c
Modified: utils/pdbt/pdb_server_backend.c
---
Diff:
https://github.com/kamailio/kamailio/commit/c717c016b70a82566dfc58d8d9dee3d3f51ddb01.diff
Patch:
https://github.com/kamailio/kamailio/commit/c717c016b70a82566dfc58d8d9dee3d3f51ddb01.patch
---
diff --git a/utils/pdbt/pdb_server.c b/utils/pdbt/pdb_server.c
index 6ce32557cc7..2de2ba789d7 100644
--- a/utils/pdbt/pdb_server.c
+++ b/utils/pdbt/pdb_server.c
@@ -151,7 +151,7 @@ int udp_server(int so)
carrierid = lookup_number(msg.bdy.payload);
/* check if not found pdb_id */
- if(carrierid == 0) {
+ if(carrierid == -1) {
pdb_msg_format_send(,
PDB_VERSION_1, PDB_TYPE_REPLY_ID,
PDB_CODE_NOT_FOUND,
htons(msg.hdr.id), NULL, 0);
goto msg_send;
diff --git a/utils/pdbt/pdb_server_backend.c b/utils/pdbt/pdb_server_backend.c
index dc4028bee19..931e28d7603 100644
--- a/utils/pdbt/pdb_server_backend.c
+++ b/utils/pdbt/pdb_server_backend.c
@@ -44,8 +44,8 @@ carrier_t lookup_number(char *number)
carrier_t carrierid;
int nmatch = dtm_longest_match(mroot, number, strlen(number),
);
if(nmatch <= 0) {
- /* nothing found - return id 0 */
- carrierid = 0;
+ /* nothing found - return id -1 */
+ carrierid = -1;
}
LINFO("request='%s', nmatch=%ld, carrier=%ld\n", number, (long
int)nmatch,
(long int)carrierid);
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.6:16f053f5: pdb server: Return negative carrierid for failures. Clang format
Module: kamailio
Branch: 5.6
Commit: 16f053f5eb3a36992225c1a72db3575165bb68a8
URL:
https://github.com/kamailio/kamailio/commit/16f053f5eb3a36992225c1a72db3575165bb68a8
Author: Stefan-Cristian Mititelu
Committer: Stefan-Cristian Mititelu
Date: 2024-03-18T13:21:18+02:00
pdb server: Return negative carrierid for failures. Clang format
(cherry picked from commit 88b698e0f62c39ed60af9f0a4fb3ca2dc6867d8f)
---
Modified: utils/pdbt/pdb_server.c
Modified: utils/pdbt/pdb_server_backend.c
---
Diff:
https://github.com/kamailio/kamailio/commit/16f053f5eb3a36992225c1a72db3575165bb68a8.diff
Patch:
https://github.com/kamailio/kamailio/commit/16f053f5eb3a36992225c1a72db3575165bb68a8.patch
---
diff --git a/utils/pdbt/pdb_server.c b/utils/pdbt/pdb_server.c
index 6ce32557cc7..2de2ba789d7 100644
--- a/utils/pdbt/pdb_server.c
+++ b/utils/pdbt/pdb_server.c
@@ -151,7 +151,7 @@ int udp_server(int so)
carrierid = lookup_number(msg.bdy.payload);
/* check if not found pdb_id */
- if(carrierid == 0) {
+ if(carrierid == -1) {
pdb_msg_format_send(,
PDB_VERSION_1, PDB_TYPE_REPLY_ID,
PDB_CODE_NOT_FOUND,
htons(msg.hdr.id), NULL, 0);
goto msg_send;
diff --git a/utils/pdbt/pdb_server_backend.c b/utils/pdbt/pdb_server_backend.c
index dc4028bee19..931e28d7603 100644
--- a/utils/pdbt/pdb_server_backend.c
+++ b/utils/pdbt/pdb_server_backend.c
@@ -44,8 +44,8 @@ carrier_t lookup_number(char *number)
carrier_t carrierid;
int nmatch = dtm_longest_match(mroot, number, strlen(number),
);
if(nmatch <= 0) {
- /* nothing found - return id 0 */
- carrierid = 0;
+ /* nothing found - return id -1 */
+ carrierid = -1;
}
LINFO("request='%s', nmatch=%ld, carrier=%ld\n", number, (long
int)nmatch,
(long int)carrierid);
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.6:831b8329: pdb: Return negative carrierid for failures
Module: kamailio
Branch: 5.6
Commit: 831b832916083900d1426e53518f34ed77aa28ad
URL:
https://github.com/kamailio/kamailio/commit/831b832916083900d1426e53518f34ed77aa28ad
Author: Stefan-Cristian Mititelu
Committer: Stefan-Cristian Mititelu
Date: 2024-03-18T13:20:09+02:00
pdb: Return negative carrierid for failures
(cherry picked from commit bf78b619ae28924361fb2c757a4d09eb1a39f5cd)
---
Modified: src/modules/pdb/pdb.c
---
Diff:
https://github.com/kamailio/kamailio/commit/831b832916083900d1426e53518f34ed77aa28ad.diff
Patch:
https://github.com/kamailio/kamailio/commit/831b832916083900d1426e53518f34ed77aa28ad.patch
---
diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c
index bfe31b4e8eb..e310d43acae 100644
--- a/src/modules/pdb/pdb.c
+++ b/src/modules/pdb/pdb.c
@@ -386,20 +386,20 @@ static int pdb_query(struct sip_msg *_msg, struct
multiparam_t *_number,
goto found;
}
break;
- case
PDB_CODE_NOT_NUMBER:
-
LM_NOTICE("Number %s has letters in it\n",
-
number.s);
-
carrierid = 0;
- goto
found;
case
PDB_CODE_NOT_FOUND:
LM_NOTICE("Number %s pdb_id not found\n",
number.s);
-
carrierid = 0;
+
carrierid = -1;
+ goto
found;
+ case
PDB_CODE_NOT_NUMBER:
+
LM_NOTICE("Number %s has letters in it\n",
+
number.s);
+
carrierid = -2;
goto
found;
default:
LM_NOTICE("Invalid code %d received\n",
msg.hdr.code);
-
carrierid = 0;
+
carrierid = -3;
goto
found;
}
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:04a73ace: acc: more log messages of failure arsing extra acc string
Module: kamailio
Branch: master
Commit: 04a73ace6572dd5c95a8f50b39b2ce712f7ebe84
URL:
https://github.com/kamailio/kamailio/commit/04a73ace6572dd5c95a8f50b39b2ce712f7ebe84
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-03-18T11:02:07+01:00
acc: more log messages of failure arsing extra acc string
---
Modified: src/modules/acc/acc_extra.c
---
Diff:
https://github.com/kamailio/kamailio/commit/04a73ace6572dd5c95a8f50b39b2ce712f7ebe84.diff
Patch:
https://github.com/kamailio/kamailio/commit/04a73ace6572dd5c95a8f50b39b2ce712f7ebe84.patch
---
diff --git a/src/modules/acc/acc_extra.c b/src/modules/acc/acc_extra.c
index 255057a99c4..a84f02bbe02 100644
--- a/src/modules/acc/acc_extra.c
+++ b/src/modules/acc/acc_extra.c
@@ -127,8 +127,10 @@ struct acc_extra *parse_acc_extra(char *extra_str)
foo = s;
while(*s && !isspace((int)*s) && EQUAL != *s)
s++;
- if(*s == 0)
+ if(*s == 0) {
+ LM_ERR("unexpected end of string\n");
goto parse_error;
+ }
if(*s == EQUAL) {
extra->name.len = (s++) - foo;
} else {
@@ -136,8 +138,10 @@ struct acc_extra *parse_acc_extra(char *extra_str)
/* skip spaces */
while(*s && isspace((int)*s))
s++;
- if(*s != EQUAL)
+ if(*s != EQUAL) {
+ LM_ERR("unexpected char '%c' instead of '='\n",
*s);
goto parse_error;
+ }
s++;
}
extra->name.s = foo;
@@ -149,15 +153,19 @@ struct acc_extra *parse_acc_extra(char *extra_str)
/* get value type */
stmp.s = s;
stmp.len = strlen(s);
- if((foo = pv_parse_spec(, >spec)) == 0)
+ if((foo = pv_parse_spec(, >spec)) == 0) {
+ LM_ERR("failed to parse variable name\n");
goto parse_error;
+ }
s = foo;
/* skip spaces */
while(*s && isspace((int)*s))
s++;
- if(*s && (*(s++) != SEPARATOR || *s == 0))
+ if(*s && (*(s++) != SEPARATOR || *s == 0)) {
+ LM_ERR("unexpected char at end of name=var group\n");
goto parse_error;
+ }
}
/* go throught all extras and make the names null terminated */
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ERROR: acc [acc_extra.c:169]: parse_acc_extra() (Issue #3785)
Have you tried with 5.8.0 release (tag) or with latest 5.8 branch? There were some fixes since the release of 5.8.0 and it is better to test with latest 5.8 branch to be sure this is not a side effect of a bug that was already fixed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3785#issuecomment-2003337051 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] pdb: Return negative carrierid for failures (PR #3775)
Merged #3775 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3775#event-12148054471 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:8cf5892c: pdb server: Return negative carrierid for failures. Clang format
Module: kamailio Branch: master Commit: 8cf5892cb34248cea2deea606a0f7d46d574404b URL: https://github.com/kamailio/kamailio/commit/8cf5892cb34248cea2deea606a0f7d46d574404b Author: Stefan-Cristian Mititelu Committer: Stefan Mititelu Date: 2024-03-18T10:55:24+02:00 pdb server: Return negative carrierid for failures. Clang format --- Modified: utils/pdbt/pdb_server.c Modified: utils/pdbt/pdb_server_backend.c --- Diff: https://github.com/kamailio/kamailio/commit/8cf5892cb34248cea2deea606a0f7d46d574404b.diff Patch: https://github.com/kamailio/kamailio/commit/8cf5892cb34248cea2deea606a0f7d46d574404b.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] pdb: Return negative carrierid for failures (PR #3775)
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3775#issuecomment-2003233414 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:0fd1516b: pdb: Return negative carrierid for failures
Module: kamailio
Branch: master
Commit: 0fd1516b9519f84a0f24b3c9a2c643e74f1dc527
URL:
https://github.com/kamailio/kamailio/commit/0fd1516b9519f84a0f24b3c9a2c643e74f1dc527
Author: Stefan-Cristian Mititelu
Committer: Stefan Mititelu
Date: 2024-03-18T10:55:24+02:00
pdb: Return negative carrierid for failures
---
Modified: src/modules/pdb/pdb.c
---
Diff:
https://github.com/kamailio/kamailio/commit/0fd1516b9519f84a0f24b3c9a2c643e74f1dc527.diff
Patch:
https://github.com/kamailio/kamailio/commit/0fd1516b9519f84a0f24b3c9a2c643e74f1dc527.patch
---
diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c
index 6889e63b915..1398f7574f8 100644
--- a/src/modules/pdb/pdb.c
+++ b/src/modules/pdb/pdb.c
@@ -393,20 +393,20 @@ static int pdb_query(struct sip_msg *_msg, struct
multiparam_t *_number,
goto found;
}
break;
- case
PDB_CODE_NOT_NUMBER:
-
LM_NOTICE("Number %s has letters in it\n",
-
number.s);
-
carrierid = 0;
- goto
found;
case
PDB_CODE_NOT_FOUND:
LM_NOTICE("Number %s pdb_id not found\n",
number.s);
-
carrierid = 0;
+
carrierid = -1;
+ goto
found;
+ case
PDB_CODE_NOT_NUMBER:
+
LM_NOTICE("Number %s has letters in it\n",
+
number.s);
+
carrierid = -2;
goto
found;
default:
LM_NOTICE("Invalid code %d received\n",
msg.hdr.code);
-
carrierid = 0;
+
carrierid = -3;
goto
found;
}
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:1380a4a0: ctl: handle int input for double storage
Module: kamailio
Branch: master
Commit: 1380a4a0d18159c7130b70c0216134a253ad83f7
URL:
https://github.com/kamailio/kamailio/commit/1380a4a0d18159c7130b70c0216134a253ad83f7
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-03-18T08:16:44+01:00
ctl: handle int input for double storage
---
Modified: src/modules/ctl/binrpc.h
---
Diff:
https://github.com/kamailio/kamailio/commit/1380a4a0d18159c7130b70c0216134a253ad83f7.diff
Patch:
https://github.com/kamailio/kamailio/commit/1380a4a0d18159c7130b70c0216134a253ad83f7.patch
---
diff --git a/src/modules/ctl/binrpc.h b/src/modules/ctl/binrpc.h
index fd247bc603a..7909bc930d4 100644
--- a/src/modules/ctl/binrpc.h
+++ b/src/modules/ctl/binrpc.h
@@ -719,10 +719,12 @@ inline static unsigned char *binrpc_read_record(struct
binrpc_parse_ctx *ctx,
*err = E_BINRPC_MORE_DATA;
goto error;
}
- if((v->type != type) && (v->type != BINRPC_T_ALL)) {
- goto error_type;
+ if(!(v->type == BINRPC_T_DOUBLE && type == BINRPC_T_INT)) {
+ if((v->type != type) && (v->type != BINRPC_T_ALL)) {
+ goto error_type;
+ }
+ v->type = type;
}
- v->type = type;
switch(type) {
case BINRPC_T_STRUCT:
if(ctx->in_struct) {
@@ -779,7 +781,12 @@ inline static unsigned char *binrpc_read_record(struct
binrpc_parse_ctx *ctx,
case BINRPC_T_INT:
if(ctx->in_struct && smode == 0)
goto error_record;
- p = binrpc_read_int(>u.intval, len, p, end, err);
+ if(v->type == BINRPC_T_DOUBLE) {
+ p = binrpc_read_int(, len, p, end, err);
+ v->u.fval = tmp;
+ } else {
+ p = binrpc_read_int(>u.intval, len, p, end,
err);
+ }
break;
case BINRPC_T_STR:
if(ctx->in_struct && smode == 0)
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] pdb: Return negative carrierid for failures (PR #3775)
@smititelu: you can merge it, thanks! Usually, if there is no comment in a couple of days and you (or your company) are one of the maintainers for the module, you can go ahead and merge. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3775#issuecomment-2003068541 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_ipsec_pcscf: TLS support in ipsec_forward() improved (PR #3780)
Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3780#issuecomment-2003062620 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_ipsec_pcscf: TLS support in ipsec_forward() improved (PR #3780)
Merged #3780 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3780#event-12146827013 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:3154a0ab: ims_ipsec_pcscf: TLS support in ipsec_forward() improved
Module: kamailio
Branch: master
Commit: 3154a0aba5543cab75153429bc8ec617c3484f71
URL:
https://github.com/kamailio/kamailio/commit/3154a0aba5543cab75153429bc8ec617c3484f71
Author: Axel Sommerfeldt
Committer: Daniel-Constantin Mierla
Date: 2024-03-18T08:03:56+01:00
ims_ipsec_pcscf: TLS support in ipsec_forward() improved
This patch was initially done by Herle Supreeth in his fork but isn't present
upstream yet:
https://github.com/kamailio/kamailio/commit/8b9a2977e111d9adb8595d98ab59f8c8eb033120
See also: https://github.com/kamailio/kamailio/issues/3772
---
Modified: src/modules/ims_ipsec_pcscf/cmd.c
---
Diff:
https://github.com/kamailio/kamailio/commit/3154a0aba5543cab75153429bc8ec617c3484f71.diff
Patch:
https://github.com/kamailio/kamailio/commit/3154a0aba5543cab75153429bc8ec617c3484f71.patch
---
diff --git a/src/modules/ims_ipsec_pcscf/cmd.c
b/src/modules/ims_ipsec_pcscf/cmd.c
index 47f9e401702..4f7301b56c1 100644
--- a/src/modules/ims_ipsec_pcscf/cmd.c
+++ b/src/modules/ims_ipsec_pcscf/cmd.c
@@ -1126,6 +1126,10 @@ int ipsec_forward(struct sip_msg *m, udomain_t *d, int
_cflags)
buf_len =
snprintf(buf, sizeof(buf) - 1,
"sip:%.*s:%d;transport=tcp",
ci.via_host.len,
ci.via_host.s, dst_port);
+ } else if((_cflags & IPSEC_SETDSTURI_FULL) && (dst_proto ==
PROTO_TLS)) {
+ buf_len =
+ snprintf(buf, sizeof(buf) - 1,
"sip:%.*s:%d;transport=tls",
+ ci.via_host.len,
ci.via_host.s, dst_port);
} else {
buf_len = snprintf(buf, sizeof(buf) - 1, "sip:%.*s:%d",
ci.via_host.len, ci.via_host.s,
dst_port);
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
