[sr-dev] Re: [kamailio/kamailio] Dialog DMQ sync: Timer needs fixing, firing on wrong node! (Issue #3656)
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3656#issuecomment-2121602014 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Warnings emitted when calling functions from dialplan module (Issue #3851)
> I was able to "get around" that warning by changing the memory manager. > > Not sure if this is the correct solution/workaround, but having the constant > warnings in the logs seems wrong. > > I added `-x fm -X fm` to the kamailio run command. > > Any downside to this change? Well, the issue is still there, the other memory manager just did not log a warning message for it. I personally would not recommend to switch to a much less used memory manager which might cause unknown issues for your workload just for getting rid of a few warnings. As said already, the issue needs to be analyzed in the dialplan module and fixed there. If you are annoyed from the warnings, just increase the log level to ERROR level for now. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3851#issuecomment-2121070212 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local AC (3a34b46)
Victor Seva via sr-dev writes: > @juha-h please use ``cherry-pick -x `` when back-porting I used `git cherry-pick . This gets too complicated for me so better that I leave the git stuff to those who know. ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local AC (3a34b46)
@juha-h please use ``cherry-pick -x `` when back-porting -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b25321807f#commitcomment-142208292 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Daniel-Constantin Mierla writes: > Yes, it can be cherry-picked, it is about a mandatory header. Done. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120834113 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.8:3a34b468: tm: add mandatory Max-Forwards header to local AC
Module: kamailio Branch: 5.8 Commit: 3a34b468ad93904c507bd0fc7ef592b25321807f URL: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b25321807f Author: Juha Heinanen Committer: Juha Heinanen Date: 2024-05-20T19:54:45+03:00 tm: add mandatory Max-Forwards header to local AC --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b25321807f.diff Patch: https://github.com/kamailio/kamailio/commit/3a34b468ad93904c507bd0fc7ef592b25321807f.patch --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 362ff6c5eb5..1aa680aa9a4 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1246,7 +1246,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + CRLF_LEN; + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + CRLF_LEN; /* copy'n'paste Route headers */ @@ -1291,6 +1292,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, append_str(p, Trans->callid_hdr.s, Trans->callid_hdr.len); append_str(p, to->s, to->len); + append_str(p, MAXFWD_HEADER, MAXFWD_HEADER_LEN); + append_str(p, Trans->cseq_hdr_n.s, Trans->cseq_hdr_n.len); append_str(p, " ", 1); append_str(p, ACK, ACK_LEN); ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Yes, it can be cherry-picked, it is about a mandatory header. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120822692 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Warnings emitted when calling functions from dialplan module (Issue #3851)
I was able to "get around" that warning by changing the memory manager. Not sure if this is the correct solution/workaround, but having the constant warnings in the logs seems wrong. I added `-x fm -X fm` to the kamailio run command. Any downside to this change? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3851#issuecomment-2120550940 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Is it OK to cherry-pick this to 5.8 branch? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120256287 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
Also used in lua with no problems. Using the `app_lua` module, the provided
configs and sending a test message multiple times produces the output you have
described with no crash on kamalio 5.6.3 and 5.8.1.
kamailio.cfg
```
...
dns_cache_init=off
use_dns_cache=off # I tried all the config you stated with no crashes
loadmodule "enum"
loadmodule "kemix"
loadmodule "app_lua"
modparam("app_lua", "load", "/etc/kamailio/kamailio.lua")
cfgengine "lua"
```
kamailio.lua
```
function ksr_route_sipout()
KSR.info("= sipout - from kamailio lua script\n");
local y = KSR.enum.enum_query()
KSR.err('ENUM RESULT ' .. tostring(y) .. ' :RURI ' .. KSR.kx.get_ruri() ..
'\n')
if KSR.is_myself_ruri() then return 1; end
KSR.hdr.append("P-Hint: outbound\r\n");
end
-- Kamailio - equivalent of routing blocks in Lua
-- KSR - the new dynamic object exporting Kamailio functions
-- sr - the old static object exporting Kamailio functions
--
-- SIP request routing
-- equivalent of request_route{}
function ksr_request_route()
KSR.info("= request - from kamailio lua script\n");
ksr_route_sipout();
if KSR.maxfwd.process_maxfwd(10) < 0 then
KSR.sl.send_reply(483, "Too Many Hops");
return;
end
-- KSR.sl.sreply(200, "OK Lua");
KSR.pv.sets("$du", "sip:127.0.0.1:5080")
KSR.tm.t_on_branch("ksr_branch_route_one");
KSR.tm.t_on_reply("ksr_onreply_route_one");
KSR.tm.t_on_failure("ksr_failure_route_one");
if KSR.tm.t_relay() < 0 then
KSR.sl.send_reply(500, "Server error")
end
end
-- SIP response routing
-- equivalent of reply_route{}
function ksr_reply_route()
KSR.info("= response - from kamailio lua script\n");
end
-- branch route callback
-- equivalent of a branch_route{}
function ksr_branch_route_one()
KSR.info("= branch route - from kamailio lua script\n");
end
-- onreply route callback
-- equivalent of an onreply_route{}
function ksr_onreply_route_one()
KSR.info("= onreply route - from kamailio lua script\n");
end
-- failure route callback
-- equivalent of a failure_route{}
function ksr_failure_route_one()
KSR.info("= failure route - from kamailio lua script\n");
end
```
test_message.sh
```
CSeq=$((RANDOM%1+1))
REGISTER_MSG="INVITE sip:+437200101...@sip.example.org SIP/2.0
Via: SIP/2.0/UDP 192.168.0.199:40867;rport;branch=z9hG4bKU2Fc14H2NX4Kc
Max-Forwards: 70
From: ;tag=vmjX7H12KrH1B
To:
Call-ID: 8956e785-1905-123c-24bb-e4aaeae9dd8b
CSeq: $CSeq INVITE
Contact:
User-Agent: calls sofia-sip/1.13.12
Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, PRACK, MESSAGE, SUBSCRIBE, NOTIFY,
REFER, UPDATE
Supported: timer, 100rel, replaces, gruu, outbound
Content-Type: application/sdp
Content-Disposition: session
Content-Length: 240
v=0
o=- 9163509233734166984 5909793187606445082 IN IP4 192.168.0.199
s=-
c=IN IP4 22.222.222.222
t=0 0
m=audio 43264 RTP/AVP 9 8 0 3
a=rtpmap:9 G722/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:0 PCMU/8000
a=rtpmap:3 GSM/8000
a=rtcp:33730\r\n
"
printf "$REGISTER_MSG" | timeout 0.3 nc -u -4 $SIP_SERVER $SIP_PORT
```
These are the logs produced when I call the `test_message.sh` multiple times,
with no crash provided the setting you suggested.
```
May 20 11:00:34 app01 kamailio[708931]: INFO: {1 3165 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:106]:
sr_kemi_core_info(): = request - from kamailio lua script
May 20 11:00:34 app01 kamailio[708931]: INFO: {1 3165 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:106]:
sr_kemi_core_info(): = sipout - from kamailio lua script
May 20 11:00:34 app01 kamailio[708931]: ERROR: {1 3165 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:96]:
sr_kemi_core_err(): ENUM RESULT 1 :RURI sip:enum-t...@sip.nemox.net
May 20 11:00:34 app01 kamailio[708931]: INFO: {1 3165 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:106]:
sr_kemi_core_info(): = branch route - from kamailio lua script
May 20 11:00:35 app01 kamailio[708928]: INFO: {1 1378 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:106]:
sr_kemi_core_info(): = request - from kamailio lua script
May 20 11:00:35 app01 kamailio[708928]: INFO: {1 1378 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:106]:
sr_kemi_core_info(): = sipout - from kamailio lua script
May 20 11:00:35 app01 kamailio[708928]: ERROR: {1 1378 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:96]:
sr_kemi_core_err(): ENUM RESULT 1 :RURI sip:enum-t...@sip.nemox.net
May 20 11:00:35 app01 kamailio[708928]: INFO: {1 1378 INVITE
8956e785-1905-123c-24bb-e4aaeae9dd8b} [core/kemi.c:106]:
sr_kemi_core_info(): = branch route - from kamailio lua script
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3350#issuecomment-2120225954
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) -
[sr-dev] [kamailio/kamailio] Possible memory leak in siputils module (Issue #3857)
### Description
I think that a memory leak accur when call **get_uri_params** function to get
the params in Invite RURI. If RURI haven't params I don't see memory leaking,
but yes if RURI have one or more params.
### Troubleshooting
Reproduction
1. In kamailio script load siputils module;
2. Invoke get_uri_params in request_route;
3. Make call traffic with params in Invite RURI;
4. Check memory using pkg_stat kamcmd command during call traffic.
### Possible Solutions
Looking the source code, it seems that the function doesn't free the memory
allocated during parsing params (parse_params function), infact invoke the free
procedure always with null value in params pointer.
I trying a simple modify saving the params poiter after parsing e use it in
free function, than the memory don't accur!
```
int get_uri_param(struct sip_msg* _msg, char* _param, char* _value)
{
str *param, t;
pv_spec_t* dst;
pv_value_t val;
param_hooks_t hooks;
param_t* params;
param_t* parsed_params; // --> pointer declaretion
param = (str*)_param;
dst = (pv_spec_t *) _value;
if (parse_sip_msg_uri(_msg) < 0) {
LM_ERR("ruri parsing failed\n");
return -1;
}
t = _msg->parsed_uri.params;
if (parse_params(, CLASS_ANY, , ) < 0) {
LM_ERR("ruri parameter parsing failed\n");
return -1;
}
parsed_params = params; // -> pointer assignment
while (params) {
if ((params->name.len == param->len)
&& (strncmp(params->name.s, param->s,
param->len) == 0)) {
memset(, 0, sizeof(pv_value_t));
val.rs.s = params->body.s;
val.rs.len = params->body.len;
val.flags = PV_VAL_STR;
dst->setf(_msg, >pvp, (int)EQ_T, );
goto found;
} else {
params = params->next;
}
}
free_params(parsed_params); // ---> use
parsed_pointer to free memory
return -1;
found:
free_params(parsed_params); // > use parsed_pointer
to free memory
return 1;
}
```
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
version: kamailio 5.3.1 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE,
USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC,
DBG_SR_MEMORY, DBG_QM_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT,
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024,
BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3857
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: multipart content dropped when used read_sdp_pv (Issue #3854)
@rfuchs could you look at this? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3854#issuecomment-2120158695 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Merged #3856 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#event-12864279478 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:d4629be2: tm: add mandatory Max-Forwards header to local AC
Module: kamailio Branch: master Commit: d4629be286fc6d3cf61574e34ee877b2c5e9ee4a URL: https://github.com/kamailio/kamailio/commit/d4629be286fc6d3cf61574e34ee877b2c5e9ee4a Author: Juha Heinanen Committer: Victor Seva Date: 2024-05-20T12:18:38+02:00 tm: add mandatory Max-Forwards header to local AC --- Modified: src/modules/tm/t_msgbuilder.c --- Diff: https://github.com/kamailio/kamailio/commit/d4629be286fc6d3cf61574e34ee877b2c5e9ee4a.diff Patch: https://github.com/kamailio/kamailio/commit/d4629be286fc6d3cf61574e34ee877b2c5e9ee4a.patch --- diff --git a/src/modules/tm/t_msgbuilder.c b/src/modules/tm/t_msgbuilder.c index 362ff6c5eb5..1aa680aa9a4 100644 --- a/src/modules/tm/t_msgbuilder.c +++ b/src/modules/tm/t_msgbuilder.c @@ -1246,7 +1246,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, /* headers */ *len += Trans->from_hdr.len + Trans->callid_hdr.len + to->len - + Trans->cseq_hdr_n.len + 1 + ACK_LEN + CRLF_LEN; + + Trans->cseq_hdr_n.len + 1 + ACK_LEN + +MAXFWD_HEADER_LEN + + CRLF_LEN; /* copy'n'paste Route headers */ @@ -1291,6 +1292,8 @@ char *build_dlg_ack(struct sip_msg *rpl, struct cell *Trans, append_str(p, Trans->callid_hdr.s, Trans->callid_hdr.len); append_str(p, to->s, to->len); + append_str(p, MAXFWD_HEADER, MAXFWD_HEADER_LEN); + append_str(p, Trans->cseq_hdr_n.s, Trans->cseq_hdr_n.len); append_str(p, " ", 1); append_str(p, ACK, ACK_LEN); ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
The idea behind it's that all commits are properly formatted. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120117882 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
since it's a branch in kamailio repo I did it myself. ``` git rebase -i origin/master ``` squashed both commits and added the tm prefix -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120114049 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
@dilyanpalauzov Hey can you confirm if this only happens on LUA config or also on the native config file? I've tried on native config file and it seems to be operating fine for both dns_cache_init=off/on. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3350#issuecomment-2120112630 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
juha-h writes: > Goes beyond me. In baresip project, nothing like that needs to be > done. If there is new commit to PR, all checks are automatically > re-run. ... and red marks turn green without any extra action. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120106704 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Victor Seva writes: > Just create one commit with the proper commit message prefix squashing > both previous commits in the branch. Goes beyond me. In baresip project, nothing like that needs to be done. If there is new commit to PR, all checks are automatically re-run. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120096511 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
@juha-h is not a bug. The format checks each commit. I already told you how to properly do it. Just create one commit with the proper commit message prefix squashing both previous commits in the branch. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120073595 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)
Same checks bug as earlier: according to Details, check-format PASSED, but there still claim that `Some checks were not successful`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120012806 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)
Remember that the git commit message first line has to be formatted as per contributing guidelines, it has to be prefixed with the component name: - https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format The commit messages are used for generating the changelog for releases as well as making easier to figure out what was impacted by a commit. Having the commit message in the proper format makes it easier to merge as well directly from the git PR portal. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120007340 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)
@juha-h pushed 1 commit. 91747524b2e4b34fa1b68c8d5b0e0473cf2f2ff8 Run clang-format on the file -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3856/files/b9b90eb6ea5cb20466a74a739338d6fe25226438..91747524b2e4b34fa1b68c8d5b0e0473cf2f2ff8 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)
Type Of Change - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [x ] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Add mandatory Max-Forwards header to local ACK You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3856 -- Commit Summary -- * Add mandatory Max-Forwards header to local AC -- File Changes -- M src/modules/tm/t_msgbuilder.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3856.patch https://github.com/kamailio/kamailio/pull/3856.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
