[sr-dev] Re: [kamailio/kamailio] tcpops module event_route[tcp:closed] route block $conid is null (Issue #3767)
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3767#issuecomment-2148753877 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Kamailio 5.6 (and 5.7) core dumps with uac_req_send() from uac module (Issue #3725)
This issue is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3725#issuecomment-2148753864 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] PR 3828 Request For Comments
Hey Team,
I submitted a PR a while back that has not had much discussion:
https://github.com/kamailio/kamailio/pull/3828
The intention was to allow loading in unsigned integer IDs from DB into PVs.
Currently converting unsigned integers from DB to PVs will error by
default unless the module specifically handles the ease use case.
When the following parameter is enabled the srdb interface will allow
the conversion to an integer PV value (possibly overflowing):
|modparam("db_mysql", "unsigned_type", 1) |
This PR allows the srdb APIs to convert the unsigned integer to an
unsigned integer PV value.
This can be quite useful in modules such as |auth_db| / |permissions|
that can load an arbitrary column into a PV (|load_credentials|,
|tag_col|/|peer_tag_avp|, etc..).
Since most ID columns are auto incrementing unsigned integers this just
makes sense for referring to customer data.
Elevator pitch over..
What I need help with is reviewing the srdb changes, since I am unsure
what side effects that would have on other modules.
Comments are welcome here, on the PR, or find me on the matrix channel
(@devopsec).
Happy Coding..
Regards,
Tyler Moore
Full Stack Software Engineer
dOpenSource
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:e9481214: dmq_usrloc: reformat exported structures
Module: kamailio
Branch: master
Commit: e94812149c6f2867a5b23f1218a9af139590bf51
URL:
https://github.com/kamailio/kamailio/commit/e94812149c6f2867a5b23f1218a9af139590bf51
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-06-04T16:29:50+02:00
dmq_usrloc: reformat exported structures
---
Modified: src/modules/dmq_usrloc/dmq_usrloc.c
---
Diff:
https://github.com/kamailio/kamailio/commit/e94812149c6f2867a5b23f1218a9af139590bf51.diff
Patch:
https://github.com/kamailio/kamailio/commit/e94812149c6f2867a5b23f1218a9af139590bf51.patch
---
diff --git a/src/modules/dmq_usrloc/dmq_usrloc.c
b/src/modules/dmq_usrloc/dmq_usrloc.c
index d7715ff10e4..61b6286a392 100644
--- a/src/modules/dmq_usrloc/dmq_usrloc.c
+++ b/src/modules/dmq_usrloc/dmq_usrloc.c
@@ -48,29 +48,33 @@ usrloc_api_t dmq_ul;
MODULE_VERSION
-static param_export_t params[] = {{"enable", INT_PARAM, _usrloc_enable},
- {"sync", INT_PARAM, &_dmq_usrloc_sync},
- {"replicate_socket_info", INT_PARAM,
- &_dmq_usrloc_replicate_socket_info},
- {"batch_msg_contacts", INT_PARAM,
&_dmq_usrloc_batch_msg_contacts},
- {"batch_msg_size", INT_PARAM, &_dmq_usrloc_batch_msg_size},
- {"batch_size", INT_PARAM, &_dmq_usrloc_batch_size},
- {"batch_usleep", INT_PARAM, &_dmq_usrloc_batch_usleep},
- {"usrloc_domain", PARAM_STR, &_dmq_usrloc_domain},
- {"usrloc_delete", INT_PARAM, &_dmq_usrloc_delete}, {0, 0, 0}};
+/* clang-format off */
+static param_export_t params[] = {
+ {"enable", INT_PARAM, _usrloc_enable},
+ {"sync", INT_PARAM, &_dmq_usrloc_sync},
+ {"replicate_socket_info", INT_PARAM,
&_dmq_usrloc_replicate_socket_info},
+ {"batch_msg_contacts", INT_PARAM, &_dmq_usrloc_batch_msg_contacts},
+ {"batch_msg_size", INT_PARAM, &_dmq_usrloc_batch_msg_size},
+ {"batch_size", INT_PARAM, &_dmq_usrloc_batch_size},
+ {"batch_usleep", INT_PARAM, &_dmq_usrloc_batch_usleep},
+ {"usrloc_domain", PARAM_STR, &_dmq_usrloc_domain},
+ {"usrloc_delete", INT_PARAM, &_dmq_usrloc_delete},
+ {0, 0, 0}
+};
struct module_exports exports = {
- "dmq_usrloc",/* module name */
- DEFAULT_DLFLAGS, /* dlopen flags */
- 0, /* exported functions */
- params, /* exported parameters */
- 0, /* RPC method exports */
- 0, /* exported pseudo-variables */
- 0, /* response handling function
*/
- mod_init,/* module initialization function */
- child_init, /* per-child init function */
- 0/* module destroy function */
+ "dmq_usrloc",/* module name */
+ DEFAULT_DLFLAGS, /* dlopen flags */
+ 0, /* exported functions */
+ params, /* exported parameters */
+ 0, /* RPC method exports */
+ 0, /* exported pseudo-variables */
+ 0, /* response handling function */
+ mod_init,/* module initialization function */
+ child_init, /* per-child init function */
+ 0/* module destroy function */
};
+/* clang-format on */
static int mod_init(void)
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] fixed handle_ruri_alias_mode(1) cannot proper handle multi alias (PR #3863)
Merged #3863 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3863#event-13034200171 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Fix handling of pending reg contacts in P-CSCF (PR #3868)
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description !-- Describe your changes in detail -- You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3868 -- Commit Summary -- * Revert ims_registrar_pcscf: update registered state to pending registration if contact exists * ims_registrar_pcscf: fix typo in comments * ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (12) M src/modules/ims_registrar_pcscf/save.c (13) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3868.patch https://github.com/kamailio/kamailio/pull/3868.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3868 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
Thanks for reporting and testing! #3858 Merged to master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3350#issuecomment-2147092245 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
Closed #3350 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3350#event-13033482386 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core/resolve: Check dns_cache_init and choose appropriate functions (PR #3858)
Merged #3858 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3858#event-13033452964 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core/resolve: Check dns_cache_init and choose appropriate functions (PR #3858)
Thanks, merging! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3858#issuecomment-2147088159 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] fixed handle_ruri_alias_mode(1) cannot proper handle multi alias (PR #3863)
@miconda Yeap, i did some experiments with the patch and it works as intended now. Rebased to master, removed the `+4` magic constant and will merge when checks pass. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3863#issuecomment-2147087445 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] fixed handle_ruri_alias_mode(1) cannot proper handle multi alias (PR #3863)
@xkaraman pushed 2 commits. 642dd10c3968468a4a1201e5a39f138f5bcf510f nathelper: fixed handle_ruri_alias_mode(1) cannot proper handle multi alias 32c73c34c8eaaa703693de414a72058db8423f23 nathelper: remove magic constant -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3863/files/1a8b474b00e53e12326eb53b0113f82758e65d2a..32c73c34c8eaaa703693de414a72058db8423f23 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core/resolve: Check dns_cache_init and choose appropriate functions (PR #3858)
@xkaraman: fine to merge it from my point of view, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3858#issuecomment-2146991340 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] fixed handle_ruri_alias_mode(1) cannot proper handle multi alias (PR #3863)
@xkaraman: I am fine to merge it if you reviewed it and fixes it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3863#issuecomment-2146980949 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] p_usrloc: Add update/delete based on uniq (PR #3865)
Not using this module to comment more on the patch, but I guess this can be merged as there were no other comments so far. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3865#issuecomment-2146977235 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
