[sr-dev] [kamailio/kamailio] ndb_redis: Error when receiving 'MOVED' response from redis-cluster with TLS (Issue #3894)

2024-06-25 Thread uv-2722 via sr-dev 


### Description

Hello, I am using ndb_redis module with TLS and redis-cluster.  kamailio 
connects to the cluster endpoint when getting data, gets a 'MOVED' response and 
prints below error, it does not get data from the new host.

### Troubleshooting
I have verified that I can connect to the cluster endpoint and the host in 
'MOVED' using redis-cli on the system that kamailio is running on. I tried to 
connect to a self hosted cluster without TLS, it works as expected. It also 
works as expected with TLS and a single redis host. 

 Reproduction
Connect to a redis-cluster over TLS

 Log Messages



```
2024-06-25T20:48:53.626708963Z 2024-06-25 20:48:53.626584  3(17) NOTICE: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:437]: 
redisc_get_server(): Hash 31807 (ra)
2024-06-25T20:48:53.626710053Z 2024-06-25 20:48:53.626600  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:440]: 
redisc_get_server(): Entry 31807 (ra)
2024-06-25T20:48:53.626711073Z 2024-06-25 20:48:53.626636  3(17) NOTICE: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:444]: 
redisc_get_server(): Using entry 31807 (ra)
2024-06-25T20:48:53.626712073Z 2024-06-25 20:48:53.626651  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis 
[redis_client.c:1030]: redisc_exec(): rsrv->ctxRedis = 0x556b4456dc20
2024-06-25T20:48:53.626713073Z 2024-06-25 20:48:53.626667  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis 
[redis_client.c:1036]: redisc_exec(): rsrv->ctxRedis = 0x556b4456dc20
2024-06-25T20:48:53.626810463Z 2024-06-25 20:48:53.626762  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:896]: 
check_cluster_reply(): Redis replied: "MOVED 3667 
testdbredis-masked-hostname.00111000.130-characters-long.1.availability-zone.amazonaws.com:6379"
2024-06-25T20:48:53.626811523Z 2024-06-25 20:48:53.626777  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:904]: 
check_cluster_reply(): Port "6379" [4] => 6379
2024-06-25T20:48:53.626816413Z 2024-06-25 20:48:53.626793  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:914]: 
check_cluster_reply(): Host 
"testdbredis-masked-hostname.00111000.130-characters-long.1.availability-zone.amazonaws.com"
 [130]
2024-06-25T20:48:53.626846113Z 2024-06-25 20:48:53.626810  3(17) NOTICE: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:925]: 
check_cluster_reply(): Name of new connection: 
testdbredis-masked-hostname.00111000.130-characters-long.1.
2024-06-25T20:48:53.626851443Z 2024-06-25 20:48:53.626827  3(17) NOTICE: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:437]: 
redisc_get_server(): Hash 968070864 
(testdbredis-masked-hostname.00111000.130-characters-long.1.)
2024-06-25T20:48:53.626896173Z 2024-06-25 20:48:53.626844  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:440]: 
redisc_get_server(): Entry 31807 (ra)
2024-06-25T20:48:53.626897503Z 2024-06-25 20:48:53.626861  3(17) NOTICE: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:450]: 
redisc_get_server(): No entry found.
2024-06-25T20:48:53.626955363Z 2024-06-25 20:48:53.626877  3(17) ERROR: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis [redis_client.c:947]: 
check_cluster_reply(): failed to print server spec string
2024-06-25T20:48:53.626957263Z 2024-06-25 20:48:53.626893  3(17) DEBUG: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis 
[redis_client.c:1115]: redisc_exec(): rpl->rplRedis->type:6
2024-06-25T20:48:53.626958443Z 2024-06-25 20:48:53.626908  3(17) ERROR: {Kam 
192.168.20.4 503874790_98536808 1 753067 INVITE}ndb_redis 
[redis_client.c:1117]: redisc_exec(): Redis error:MOVED 3667 
testdbredis-masked-hostname.00111000.130-characters-long.1.availability-zone.amazonaws.com:6379
```

### Additional Information

  * **Kamailio Version** - output of `kamailio -v`

```
version: kamailio 5.8.1 (x86_64/linux) 384843
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, 
USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, 
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, 
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, 
TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 
262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 384843 
compiled on 19:05:30 Jun 25 2024 with gcc 12.2.0

[sr-dev] [kamailio/kamailio] db_redis: compile issues with TLS + redis-cluster (Issue #3893)

2024-06-25 Thread uv-2722 via sr-dev 


### Description

Hello, I am trying to setup db_redis with TLS and redis-cluster support, I get 
the following errors during installation.

### Troubleshooting

 Reproduction
Install hiredis(v1.2.0) and hiredis-cluster(v0.13.0) from source, both with ssl 
support.
Then install kamailio 5.8.1 from source with db_redis module




 Log Messages



```
37.77 CC (gcc) [M db_redis.so]  db_redis_mod.o
37.85 CC (gcc) [M db_redis.so]  redis_connection.o
37.90 redis_connection.c: In function 'db_redis_connect':
37.90 redis_connection.c:129:9: error: unknown type name 'redisSSLContext'; did 
you mean 'redisContext'?
37.90   129 | redisSSLContext *ssl = NULL;
37.90   | ^~~
37.90   | redisContext
37.90 redis_connection.c:166:17: warning: implicit declaration of function 
'redisInitOpenSSL' [-Wimplicit-function-declaration]
37.90   166 | redisInitOpenSSL();
37.90   | ^~~~
37.90 redis_connection.c:167:23: warning: implicit declaration of function 
'redisCreateSSLContext' [-Wimplicit-function-declaration]
37.90   167 | ssl = redisCreateSSLContext(
37.90   |   ^
37.90 redis_connection.c:167:21: warning: assignment to 'int *' from 'int' 
makes pointer from integer without a cast [-Wint-conversion]
37.90   167 | ssl = redisCreateSSLContext(
37.90   | ^
37.91 redis_connection.c:196:17: warning: implicit declaration of function 
'redisClusterSetOptionEnableSSL'; did you mean 'redisClusterSetOptionMaxRetry'? 
[-Wimplicit-function-declaration]
37.91   196 | redisClusterSetOptionEnableSSL(con->con, ssl);
37.91   | ^~
37.91   | redisClusterSetOptionMaxRetry
37.93 make[2]: *** [../../Makefile.rules:100: redis_connection.o] Error 1
37.93 make[1]: *** [Makefile:508: modules] Error 1
37.93 make[1]: Leaving directory '/root/build/kamailio/src'
37.93 make: *** [Makefile:34: all] Error 2
```

### Additional Information

  * **Kamailio Version**:

```
Kamailio 5.8.1
```

* **Operating System**: 



```
Debian 12
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3893
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Initial Support for CMake in Kamailio - Feedback Needed!

2024-06-25 Thread Xenofon Karamanos via sr-dev 
Hey Daniel,

Thanks for the feedback.

You are right, since i was just trying to set CMake up, i didn't include the 
options necessary for aarch64 arch build steps only for x86_64.

I pushed some new commits including the one necessary to build for aarch64, 
modules and docs.

I can now cross-compile to aarch64 from x86_64 system now as well.

A big note is that no additional compile options are given nor in the Makefiles 
nor in CMakelists (look 
Makefile.defs.
 there are no options for aarch64). Is this intentional or not implemented by 
mistake?

If you can give it another try, it would be appreciated. If you have any more 
troubles just let me know.

Thanks,
Xenofon
[https://repository-images.githubusercontent.com/15101579/2d895000-e695-11e9-943e-d6dd9ef49a41]
kamailio/src/Makefile.defs at cmake · 
kamailio/kamailio
Kamailio - The Open Source SIP Server for large VoIP and real-time 
communication platforms - - kamailio/kamailio
github.com


From: Daniel-Constantin Mierla 
Sent: Tuesday, June 25, 2024 14:41
To: Kamailio (SER) - Development Mailing List 
Cc: Xenofon Karamanos 
Subject: Re: [sr-dev] Re: Initial Support for CMake in Kamailio - Feedback 
Needed!

Hello,

got a bit of time to look at it, but it fails on Ubuntu arm64:

$ uname -a
Linux u2204 5.15.0-107-generic #117-Ubuntu SMP Mon Apr 29 14:37:09 UTC 2024 
aarch64 aarch64 aarch64 GNU/Linux

This is my usual development environment lately and it compiles fine with the 
usual Makefiles. The errors (after: mkdir build, cd build, cmake ..)​ are:

$ make
[  0%] Generating cfg.tab.c and cfg.tab.h from cfg.y
[  0%] Generating lex.yy.c from cfg.lex
[  0%] Built target GenerateParser
[  0%] Building C object src/core/CMakeFiles/kamailio.dir/action.c.o
cc: error: unrecognized command-line option ‘-m64’
cc: error: unrecognized command-line option ‘-minline-all-stringops’
make[2]: *** [src/core/CMakeFiles/kamailio.dir/build.make:88: 
src/core/CMakeFiles/kamailio.dir/action.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:887: src/core/CMakeFiles/kamailio.dir/all] 
Error 2
make: *** [Makefile:136: all] Error 2

I am not familiar with cmake and no much time to dig in at this moment, so I 
thought to just report it.

Cheers,
Daniel

On 17.06.24 09:49, Xenofon Karamanos via sr-dev wrote:
Hey Daniel and all,

I have updated the branch to compile some of the modules and libs, so we can 
have a fully runnable default configuration.

Same steps as before:
mkdir build && cd build​
Then run CMake for the configuration and any options you would like.
cmake ..​  (you can also then use  ccmake .​for a visual of the offered 
options).
I am currently using  the following commands to have it installed in 
build/kam-6 folder but you of course can use any prefix and definitions you 
like (hopefully):
  cmake -DCMAKE_INSTALL_PREFIX=./kam-6 -DINCLUDE_MODULES="async" ..​
Build and install using make
 make -j4​ install

There should now be a kamailio​ binary in build/kam-6/sbin that you can run 
directly ./sbin/kamailio​.
Also, you have to make sure the build/kam-6/var/run folder exists so it can run 
normally even no file is required to be create there with the default config.
Any reviews and feedback is deeply appreciated,

Thanks
Xenofon



From: Xenofon Karamanos 
Sent: Wednesday, June 12, 2024 11:09
To: Kamailio (SER) - Development Mailing List 
; 
mico...@gmail.com 

Subject: Re: [sr-dev] Initial Support for CMake in Kamailio - Feedback Needed!

Hey Daniel,

Thank you for your taking the time to provide feedback.
CMake is the de-facto "build" system (it's actually a generator for 
buildsystems like make, ninja and so on) for C and C++ programs as far as i 
know. There are some alternatives, like Meson i think, that i am really not 
familiar with and not seen it in the wild enough.
So to answer your questions:
  - CMake currently builds only the files found in the src/core folder. For 
the modules, we will probably have to adopt each module separately to CMake. 
Not something difficult, i would say but there are lots of modules. Maybe you 
can suggest some modules we want to get it up and running for some initial 
set-up and to see how to properly adjust the workflow to CMake.
  - Most probably yes, i have seen CMake build docs with doxygen. I am not 
really familiar with our docs generator but i think as long as we use a 
well-know generator, we can have seperate targets for generating the Docs and 
probably custom files from the xml like Readme files.
  - At the end of the CMake integration, there should be no need for any of 
the Makefiles. CMake will generate

[sr-dev] Re: [kamailio/kamailio] crypto related crash in 5.8.2 (Issue #3885)

2024-06-25 Thread Sebastian Damm via sr-dev 
Closed #3885 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3885#event-13281590019
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] crypto related crash in 5.8.2 (Issue #3885)

2024-06-25 Thread Sebastian Damm via sr-dev 
Looks like `tls_threads_mode = 2` solved the issue. Has been running for more 
than 4 days now.

BTW: We found out that the crash could actually be triggered by running `nmap 
--script ssl-enum-ciphers -p 5061 example.com`, too. After some requests, 
Kamailio crashed and nmap returned with an incomplete number of ciphers.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3885#issuecomment-2188994027
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)

2024-06-25 Thread Supreeth Herle via sr-dev 
@herlesupreeth commented on this pull request.



>   && (ignore_contact_rxport_check
-   || (c->received_port == 
_m->rcv.src_port)

> My opinion is that in IMS the IPsec SA is negotiated for all transport 
> protocols (so in practice UDP and TCP), hence if a UE managed to correctly 
> encrypt whatever UDP/TCP packet correctly and send it to us on the correct 
> Security-Association flows, we should allow it.

I agree

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3891#discussion_r1652761243
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)

2024-06-25 Thread Dragos Vingarzan via sr-dev 
@vingarzan commented on this pull request.



> - && (ignore_contact_rxport_check
-   || (c->received_proto == 
_m->rcv.proto))) {

For context - the `ignore_contact_rxproto_check` parameter fixes this logical 
condition group. I don't know if this was on purpose, or a copy-paste mistake 
(checking proto for port flag).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3891#pullrequestreview-2138506512
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)

2024-06-25 Thread Dragos Vingarzan via sr-dev 
@vingarzan commented on this pull request.



>   && (ignore_contact_rxport_check
-   || (c->received_port == 
_m->rcv.src_port)

With `ignore_contact_rxport_check=1`  the protocol (not port! 
:upside_down_face:) hit me hard today, when REGISTER happened over TCP and then 
an MO MESSAGE kept being rejected because ... UDP.

I added a parameter `ignore_contact_rxproto_check` with default `1` (so 
changing behavior!). My opinion is that in IMS the IPsec SA is negotiated for 
all transport protocols (so in practice UDP and TCP), hence if a UE managed to 
correctly encrypt whatever UDP/TCP packet correctly and send it to us on the 
correct Security-Association flows, we should allow it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3891#discussion_r1652705551
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)

2024-06-25 Thread Dragos Vingarzan via sr-dev 
@vingarzan pushed 1 commit.

62c091d156f7b20415b0297a7c8bb2f0add03127  ims_registrar_pcscf: added 
ignore_contact_rxproto_check parameter, to solve the issue of failing from 
other protocol

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3891/files/abc8f33bc71d8def998f08e514f960d41c95fca7..62c091d156f7b20415b0297a7c8bb2f0add03127
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)

2024-06-25 Thread Henning Westerholt via sr-dev 
If there is indeed a performance implication in this table scans with key, 
maybe we should not silence it completely by using DBG and using INFO instead. 
But maybe @agranig like to comment as well here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3892#issuecomment-2188742720
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Any web management tools suggestions (Issue #3881)

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
This tracker is for reporting issues in the C code of Kamailio, to discuss 
about configuring or using Kamailio, use the sr-us...@lists.kamailio.org 
mailing list.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3881#issuecomment-2188743124
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Any web management tools suggestions (Issue #3881)

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Closed #3881 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3881#event-13280106992
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Initial Support for CMake in Kamailio - Feedback Needed!

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Hello,

got a bit of time to look at it, but it fails on Ubuntu arm64:

$ uname -a
Linux u2204 5.15.0-107-generic #117-Ubuntu SMP Mon Apr 29 14:37:09 UTC
2024 aarch64 aarch64 aarch64 GNU/Linux

This is my usual development environment lately and it compiles fine
with the usual Makefiles. The errors (after: mkdir build, cd build,
cmake ..)​ are:

$ make
[  0%] Generating cfg.tab.c and cfg.tab.h from cfg.y
[  0%] Generating lex.yy.c from cfg.lex
[  0%] Built target GenerateParser
[  0%] Building C object src/core/CMakeFiles/kamailio.dir/action.c.o
cc: error: unrecognized command-line option ‘-m64’
cc: error: unrecognized command-line option ‘-minline-all-stringops’
make[2]: *** [src/core/CMakeFiles/kamailio.dir/build.make:88:
src/core/CMakeFiles/kamailio.dir/action.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:887:
src/core/CMakeFiles/kamailio.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I am not familiar with cmake and no much time to dig in at this moment,
so I thought to just report it.

Cheers,
Daniel

On 17.06.24 09:49, Xenofon Karamanos via sr-dev wrote:
> Hey Daniel and all, 
>
> I have updated the branch to compile some of the modules and libs, so
> we can have a fully runnable default configuration.
>
> Same steps as before:
> |mkdir build && cd build|​
> Then run CMake for the configuration and any options you would like.
> |cmake ..|​  (you can also then use  |ccmake .|​    for a visual of
> the offered options).
> I am currently using  the following commands to have it installed in
> build/kam-6 folder but you of course can use any prefix and
> definitions you like (hopefully):
> |  cmake -DCMAKE_INSTALL_PREFIX=./kam-6 -DINCLUDE_MODULES="async"
> ..|​  
> Build and install using make
> | make -j4|​ install
>
> There should now be a |kamailio|​ binary in build/kam-6/sbin that you
> can run directly |./sbin/kamailio|​. 
> Also, you have to make sure the build/kam-6/var/run folder exists so
> it can run normally even no file is required to be create there with
> the default config.
> Any reviews and feedback is deeply appreciated,
>
> Thanks
> Xenofon 
>
>
> 
> *From:* Xenofon Karamanos 
> *Sent:* Wednesday, June 12, 2024 11:09
> *To:* Kamailio (SER) - Development Mailing List
> ; mico...@gmail.com 
> *Subject:* Re: [sr-dev] Initial Support for CMake in Kamailio -
> Feedback Needed!
>  
> Hey Daniel,
>
> Thank you for your taking the time to provide feedback.
> CMake is the de-facto "build" system (it's actually a generator for
> buildsystems like make, ninja and so on) for C and C++ programs as far
> as i know. There are some alternatives, like Meson i think, that i am
> really not familiar with and not seen it in the wild enough.
> So to answer your questions:
>   - CMake currently builds only the files found in the src/core
> folder. For the modules, we will probably have to adopt each
> module separately to CMake. Not something difficult, i would say but
> there are lots of modules. Maybe you can suggest some modules we want
> to get it up and running for some initial set-up and to see how to
> properly adjust the workflow to CMake.
>   - Most probably yes, i have seen CMake build docs with doxygen.
> I am not really familiar with our docs generator but i think as long
> as we use a well-know generator, we can have seperate targets for
> generating the Docs and probably custom files from the xml like Readme
> files.
>   - At the end of the CMake integration, there should be no need
> for any of the Makefiles. CMake will generate the appropriate ones for
> make, ninja, Visual Studio or whatever build you choose (as long as
> it's supported by CMake) and use that for building the targets. At
> this point also, no makefiles  from repositort where used to build the
> core. When you run CMake in the build folder, it creates a new set of
> makefiles in there, that do the job.
>
> I hope these clear some of your questions. If you need any
> more information or have any suggestions regarding modules/docs
> please let me know,
> Xenofon
>
> 
> *From:* Daniel-Constantin Mierla 
> *Sent:* Wednesday, June 12, 2024 09:21
> *To:* Kamailio (SER) - Development Mailing List
> 
> *Cc:* Xenofon Karamanos 
> *Subject:* Re: [sr-dev] Initial Support for CMake in Kamailio -
> Feedback Needed!
>  
>
> Hello,
>
>
> thanks for spending time in this direction! Makefiles were for long
> supposed to get a review.
>
>
> I am not familiar for CMake, but if it is considered a good option, I
> am fine with it. For now, a few questions:
>
>
>   - is it already building the modules as well, or only the core for now?
>
>   - can it be used also for building the docs (e.g., README files for
> modules)?
>
>   - any of the old Makefiles need to be kept, or all of them will be
> replaced?
>
>
> Cheers,
> Daniel
>
>
> On 11.06.24 18:11, Xenofon Karamanos via

[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)

2024-06-25 Thread Stefan Mititelu via sr-dev 
I never get clang formatting right, unless using the clang-format tool :D

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3892#issuecomment-2188700713
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)

2024-06-25 Thread Stefan Mititelu via sr-dev 
@smititelu pushed 1 commit.

fa202d1112c9df29358c261e670b6bbfff9fc856  db_redis: change logs on delete

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3892/files/34b15758bd4ec9b1f09174e981af0675b9068c7d..fa202d1112c9df29358c261e670b6bbfff9fc856
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)

2024-06-25 Thread Stefan Mititelu via sr-dev 
@smititelu pushed 1 commit.

34b15758bd4ec9b1f09174e981af0675b9068c7d  db_redis: change logs on delete

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3892/files/85c244e6a55a8391c744624b5d3678d550481d1a..34b15758bd4ec9b1f09174e981af0675b9068c7d
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)

2024-06-25 Thread Stefan Mititelu via sr-dev 
@smititelu pushed 1 commit.

85c244e6a55a8391c744624b5d3678d550481d1a  db_redis: change logs on delete

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3892/files/06aac1608f6bf87c2eb760c1402566760a6380a7..85c244e6a55a8391c744624b5d3678d550481d1a
You are receiving this because you are subscribed to this thread.

Message ID: 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] db_redis: change logs on delete (PR #3892)

2024-06-25 Thread Stefan Mititelu via sr-dev 
!-- Kamailio Pull Request Template --

!--
IMPORTANT:
  - for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
  - backports to stable branches must be done with git cherry-pick -x 
...
  - code is contributed under BSD for core and main components (tm, sl, auth, 
tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
--

 Pre-Submission Checklist
!-- Go over all points below, and after creating the PR, tick all the 
checkboxes that apply --
!-- All points should be verified, otherwise, read the CONTRIBUTING 
guidelines from above--
!-- If youre unsure about any of these, dont hesitate to ask on 
sr-dev mailing list --
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, 
...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
!-- Go over all points below, and after creating the PR, tick the 
checkboxes that apply --
- [ ] PR should be backported to stable branches
- [X] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
!-- Describe your changes in detail --
Issue: when using usrloc with db_redis, I get constant WARNING logs for 
delete via usrloc timer. The real WARNING, in my opinion, is when 
doing full table scans(which is already logged as so).

Make logs less important when performing table scans using a match key.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3892

-- Commit Summary --

  * db_redis: change logs on delete

-- File Changes --

M src/modules/db_redis/redis_dbase.c (4)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3892.patch
https://github.com/kamailio/kamailio/pull/3892.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3892
You are receiving this because you are subscribed to this thread.

Message ID: kamailio/kamailio/pull/3...@github.com
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:8df69ebc: pv: docs for xavp_xparams_explode(...)

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 8df69ebca23bde071b08b0ed5b8cd34b2d28446b
URL: 
https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34b2d28446b

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-06-25T13:00:08+02:00

pv: docs for xavp_xparams_explode(...)

---

Modified: src/modules/pv/doc/pv_admin.xml

---

Diff:  
https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34b2d28446b.diff
Patch: 
https://github.com/kamailio/kamailio/commit/8df69ebca23bde071b08b0ed5b8cd34b2d28446b.patch

---

diff --git a/src/modules/pv/doc/pv_admin.xml b/src/modules/pv/doc/pv_admin.xml
index 1f91e633a00..6a06bb717de 100644
--- a/src/modules/pv/doc/pv_admin.xml
+++ b/src/modules/pv/doc/pv_admin.xml
@@ -387,6 +387,39 @@ xavp_params_explode("a=b;c=d;e=d", "x");
 #$xavp(x=a) = "b";
 #$xavp(x=c) = "d";
 #$xavp(x=e) = "f";
+...
+   
+   
+   
+   
+   
+   xavp_xparams_explode(sparams, sep, xname)
+   
+   
+   Convert a parameters string in xavp attributes.
+   
+   
+   The first parameter has to be a string in 
similar format of SIP header
+   parameters (name1=value1;...;nameN=valueN), but 
the separator can
+   be other character than ';'. The second 
parameter is the separator
+   for the parameters list. The third parameter is 
the name of the
+   root xavp to hold the pairs (nameX,valueX).
+   
+   
+   The values are stored as string type.
+   
+   
+   Function can be used from ANY ROUTE.
+   
+   
+   
xavp_xparams_explode usage
+   
+...
+xavp_xparams_explode("a=b,c=d,e=d", ",", "x");
+# results in:
+#$xavp(x=a) = "b";
+#$xavp(x=c) = "d";
+#$xavp(x=e) = "f";
 ...


@@ -1132,4 +1165,3 @@ $  pv.shvGet debug

 
 
-

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:3d2849ae: pv: added xavp_xparams_explode(params, sep, xname)

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 3d2849aee788fd3b33d80d9d72ef0cdcdd1c9f87
URL: 
https://github.com/kamailio/kamailio/commit/3d2849aee788fd3b33d80d9d72ef0cdcdd1c9f87

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-06-25T12:53:32+02:00

pv: added xavp_xparams_explode(params, sep, xname)

- option to specify the separator for parameters list

---

Modified: src/modules/pv/pv.c
Modified: src/modules/pv/pv_xavp.c
Modified: src/modules/pv/pv_xavp.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/3d2849aee788fd3b33d80d9d72ef0cdcdd1c9f87.diff
Patch: 
https://github.com/kamailio/kamailio/commit/3d2849aee788fd3b33d80d9d72ef0cdcdd1c9f87.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:385c054a: modules: readme files regenerated - pv ... [skip ci]

2024-06-25 Thread Kamailio Dev via sr-dev 
Module: kamailio
Branch: master
Commit: 385c054a5d96b4d2b888e62dd26ca7d563d93f61
URL: 
https://github.com/kamailio/kamailio/commit/385c054a5d96b4d2b888e62dd26ca7d563d93f61

Author: Kamailio Dev 
Committer: Kamailio Dev 
Date: 2024-06-25T13:01:10+02:00

modules: readme files regenerated - pv ... [skip ci]

---

Modified: src/modules/pv/README

---

Diff:  
https://github.com/kamailio/kamailio/commit/385c054a5d96b4d2b888e62dd26ca7d563d93f61.diff
Patch: 
https://github.com/kamailio/kamailio/commit/385c054a5d96b4d2b888e62dd26ca7d563d93f61.patch

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:d4ef9f26: core: parse_param2() - continue if the separator matches comma or bracket

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: d4ef9f268fd1b645fc1846db1fd7a6e814792921
URL: 
https://github.com/kamailio/kamailio/commit/d4ef9f268fd1b645fc1846db1fd7a6e814792921

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-06-25T12:48:28+02:00

core: parse_param2() - continue if the separator matches comma or bracket

---

Modified: src/core/parser/parse_param.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/d4ef9f268fd1b645fc1846db1fd7a6e814792921.diff
Patch: 
https://github.com/kamailio/kamailio/commit/d4ef9f268fd1b645fc1846db1fd7a6e814792921.patch

---

diff --git a/src/core/parser/parse_param.c b/src/core/parser/parse_param.c
index 698c0a9b47d..b7df14d9f88 100644
--- a/src/core/parser/parse_param.c
+++ b/src/core/parser/parse_param.c
@@ -508,9 +508,9 @@ static inline int parse_param2(
t->len = t->name.len;
}
 
-   if(_s->s[0] == ',')
+   if(separator != ',' && _s->s[0] == ',')
goto ok; /* To be able to parse header parameters */
-   if(_s->s[0] == '>')
+   if(separator != '>' && _s->s[0] == '>')
goto ok; /* To be able to parse URI parameters */
 
if(_s->s[0] != separator) {

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:e956ae7b: pv: support all spaces separator for {s.select}

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: e956ae7b83971c50cbdf1a4db8db9929f02e3b19
URL: 
https://github.com/kamailio/kamailio/commit/e956ae7b83971c50cbdf1a4db8db9929f02e3b19

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-06-25T11:03:01+02:00

pv: support all spaces separator for {s.select}

---

Modified: src/modules/pv/pv_trans.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/e956ae7b83971c50cbdf1a4db8db9929f02e3b19.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e956ae7b83971c50cbdf1a4db8db9929f02e3b19.patch

---

diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c
index dcf5479a105..b0eba93eed8 100644
--- a/src/modules/pv/pv_trans.c
+++ b/src/modules/pv/pv_trans.c
@@ -256,7 +256,8 @@ int tr_eval_string(
for(i = 0; i < val->rs.len; i++) {
if(val->rs.s[i] == '\r' || val->rs.s[i] == 
'\n') {
c = 1;
-   } else if(c != 0 && (val->rs.s[i] == ' ' || 
val->rs.s[i] == '\t')) {
+   } else if(c != 0
+ && (val->rs.s[i] == ' ' || 
val->rs.s[i] == '\t')) {
if(c == 1) {
_tr_buffer[j] = ' ';
j++;
@@ -284,7 +285,8 @@ int tr_eval_string(
for(i = 0; i < val->rs.len; i++) {
if(val->rs.s[i] == '\r' || val->rs.s[i] == 
'\n') {
c = 1;
-   } else if(c != 0 && (val->rs.s[i] == ' ' || 
val->rs.s[i] == '\t')) {
+   } else if(c != 0
+ && (val->rs.s[i] == ' ' || 
val->rs.s[i] == '\t')) {
c = 2;
} else {
_tr_buffer[j] = val->rs.s[i];
@@ -816,6 +818,9 @@ int tr_eval_string(
case 't':
c = '\t';
break;
+   case 's':
+   c = ' ';
+   break;
default:
LM_ERR("invalid select escape 
char (cfg line: %d)\n",

get_cfg_crt_line());
@@ -832,7 +837,10 @@ int tr_eval_string(
i = -i;
i--;
while(p >= val->rs.s) {
-   if(*p == c) {
+   if(((c == 1)
+  && (*p == ' ' || *p 
== '\t' || *p == '\n'
+  || 
*p == '\r'))
+   || (*p == c)) {
if(i == 0)
break;
s = p - 1;
@@ -850,7 +858,10 @@ int tr_eval_string(
s = val->rs.s;
p = s;
while(p < val->rs.s + val->rs.len) {
-   if(*p == c) {
+   if(((c == 1)
+  && (*p == ' ' || *p 
== '\t' || *p == '\n'
+  || 
*p == '\r'))
+   || (*p == c)) {
if(i == 0)
break;
s = p + 1;

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:e4a65922: rabbitmq: don't fail on init if connection fails

2024-06-25 Thread Victor Seva via sr-dev 
Module: kamailio
Branch: master
Commit: e4a65922649c1db8edcb8fa18b421620c899b25f
URL: 
https://github.com/kamailio/kamailio/commit/e4a65922649c1db8edcb8fa18b421620c899b25f

Author: Victor Seva 
Committer: Victor Seva 
Date: 2024-06-25T10:35:09+02:00

rabbitmq: don't fail on init if connection fails

* there's a reconnect functionality already in place

Change-Id: I88320fc64aef802a1bcdd753fe7d22402ca4b18c

---

Modified: src/modules/rabbitmq/rabbitmq.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/e4a65922649c1db8edcb8fa18b421620c899b25f.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e4a65922649c1db8edcb8fa18b421620c899b25f.patch

---

diff --git a/src/modules/rabbitmq/rabbitmq.c b/src/modules/rabbitmq/rabbitmq.c
index a1e95ad55b3..9b57e7a834c 100644
--- a/src/modules/rabbitmq/rabbitmq.c
+++ b/src/modules/rabbitmq/rabbitmq.c
@@ -178,8 +178,7 @@ static int mod_child_init(int rank)
 
// routing process
if(rabbitmq_connect(_conn) != RABBITMQ_OK) {
-   LM_ERR("FAIL rabbitmq_connect()");
-   return -1;
+   LM_WARN("FAIL rabbitmq_connect()");
}
LM_DBG("SUCCESS initialization of rabbitmq module in child [%d]\n", 
rank);
 

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:31daee18: pv: new transformation {s.rmhdws}

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 31daee1800cb301d705524a56e7466abfa62e5d9
URL: 
https://github.com/kamailio/kamailio/commit/31daee1800cb301d705524a56e7466abfa62e5d9

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-06-24T11:38:14+02:00

pv: new transformation {s.rmhdws}

- remove header-like duplicated whitespaces (i.e., end of line followed
  by whitespaces are replaced by a single whitespace)

---

Modified: src/modules/pv/pv_trans.c
Modified: src/modules/pv/pv_trans.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/31daee1800cb301d705524a56e7466abfa62e5d9.diff
Patch: 
https://github.com/kamailio/kamailio/commit/31daee1800cb301d705524a56e7466abfa62e5d9.patch

---

diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c
index a3ce0f0ace3..4418234ddb5 100644
--- a/src/modules/pv/pv_trans.c
+++ b/src/modules/pv/pv_trans.c
@@ -246,6 +246,34 @@ int tr_eval_string(
val->rs.s = _tr_buffer;
val->rs.len = j;
break;
+   case TR_S_RMHDWS:
+   if(!(val->flags & PV_VAL_STR))
+   val->rs.s = int2str(val->ri, >rs.len);
+   if(val->rs.len >= TR_BUFFER_SIZE - 1)
+   return -1;
+   j = 0;
+   c = 0;
+   for(i = 0; i < val->rs.len; i++) {
+   if(val->rs.s[i] == '\r' || val->rs.s[i] == 
'\n') {
+   c = 1;
+   } else if(c != 0 && (val->rs.s[i] == ' ' || 
val->rs.s[i] == '\t')) {
+   if(c == 1) {
+   _tr_buffer[j] = ' ';
+   j++;
+   c = 2;
+   }
+   } else {
+   _tr_buffer[j] = val->rs.s[i];
+   j++;
+   c = 0;
+   }
+   }
+   _tr_buffer[j] = '\0';
+   val->flags = PV_VAL_STR;
+   val->ri = 0;
+   val->rs.s = _tr_buffer;
+   val->rs.len = j;
+   break;
case TR_S_MD5:
if(!(val->flags & PV_VAL_STR))
val->rs.s = int2str(val->ri, >rs.len);
@@ -2721,6 +2749,9 @@ char *tr_parse_string(str *in, trans_t *t)
} else if(name.len == 4 && strncasecmp(name.s, "rmws", 4) == 0) {
t->subtype = TR_S_RMWS;
goto done;
+   } else if(name.len == 6 && strncasecmp(name.s, "rmhdws", 6) == 0) {
+   t->subtype = TR_S_RMHDWS;
+   goto done;
} else if(name.len == 6 && strncasecmp(name.s, "sha256", 6) == 0) {
t->subtype = TR_S_SHA256;
goto done;
diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h
index 662d5a2b578..9eebe1da9d1 100644
--- a/src/modules/pv/pv_trans.h
+++ b/src/modules/pv/pv_trans.h
@@ -96,6 +96,7 @@ enum _tr_s_subtype
TR_S_ENCODEBASE64URLT,
TR_S_DECODEBASE64URLT,
TR_S_RMWS,
+   TR_S_RMHDWS,
TR_S_BEFORE,
TR_S_AFTER,
TR_S_RBEFORE,

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] git:master:75b5325c: pv: new transformation {s.rmhlws}

2024-06-25 Thread Daniel-Constantin Mierla via sr-dev 
Module: kamailio
Branch: master
Commit: 75b5325c3b125b8adc551591cd82b67cd3cab167
URL: 
https://github.com/kamailio/kamailio/commit/75b5325c3b125b8adc551591cd82b67cd3cab167

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2024-06-25T09:41:56+02:00

pv: new transformation {s.rmhlws}

- remove header line split white spaces (i.e., end of lines and
  following white spaces in a multi-line header value)

---

Modified: src/modules/pv/pv_trans.c
Modified: src/modules/pv/pv_trans.h

---

Diff:  
https://github.com/kamailio/kamailio/commit/75b5325c3b125b8adc551591cd82b67cd3cab167.diff
Patch: 
https://github.com/kamailio/kamailio/commit/75b5325c3b125b8adc551591cd82b67cd3cab167.patch

---

diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c
index 4418234ddb5..dcf5479a105 100644
--- a/src/modules/pv/pv_trans.c
+++ b/src/modules/pv/pv_trans.c
@@ -274,6 +274,30 @@ int tr_eval_string(
val->rs.s = _tr_buffer;
val->rs.len = j;
break;
+   case TR_S_RMHLWS:
+   if(!(val->flags & PV_VAL_STR))
+   val->rs.s = int2str(val->ri, >rs.len);
+   if(val->rs.len >= TR_BUFFER_SIZE - 1)
+   return -1;
+   j = 0;
+   c = 0;
+   for(i = 0; i < val->rs.len; i++) {
+   if(val->rs.s[i] == '\r' || val->rs.s[i] == 
'\n') {
+   c = 1;
+   } else if(c != 0 && (val->rs.s[i] == ' ' || 
val->rs.s[i] == '\t')) {
+   c = 2;
+   } else {
+   _tr_buffer[j] = val->rs.s[i];
+   j++;
+   c = 0;
+   }
+   }
+   _tr_buffer[j] = '\0';
+   val->flags = PV_VAL_STR;
+   val->ri = 0;
+   val->rs.s = _tr_buffer;
+   val->rs.len = j;
+   break;
case TR_S_MD5:
if(!(val->flags & PV_VAL_STR))
val->rs.s = int2str(val->ri, >rs.len);
@@ -2752,6 +2776,9 @@ char *tr_parse_string(str *in, trans_t *t)
} else if(name.len == 6 && strncasecmp(name.s, "rmhdws", 6) == 0) {
t->subtype = TR_S_RMHDWS;
goto done;
+   } else if(name.len == 6 && strncasecmp(name.s, "rmhlws", 6) == 0) {
+   t->subtype = TR_S_RMHLWS;
+   goto done;
} else if(name.len == 6 && strncasecmp(name.s, "sha256", 6) == 0) {
t->subtype = TR_S_SHA256;
goto done;
diff --git a/src/modules/pv/pv_trans.h b/src/modules/pv/pv_trans.h
index 9eebe1da9d1..6fab2c4233c 100644
--- a/src/modules/pv/pv_trans.h
+++ b/src/modules/pv/pv_trans.h
@@ -97,6 +97,7 @@ enum _tr_s_subtype
TR_S_DECODEBASE64URLT,
TR_S_RMWS,
TR_S_RMHDWS,
+   TR_S_RMHLWS,
TR_S_BEFORE,
TR_S_AFTER,
TR_S_RBEFORE,

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org