[sr-dev] Re: [kamailio/kamailio] core/resolve: Check dns_cache_init and choose appropriate functions (PR #3858)
@dilyanpalauzov commented on this pull request.
> @@ -1833,6 +1847,23 @@ ip_addr_t *str2ip(str *st)
return ipb;
}
+struct hostent *__resolvehost(char *name)
+{
+ if(dns_cache_init) {
+ return dns_resolvehost(name);
+ } else {
+ return _resolvehost(name);
+ }
+}
+
+struct hostent *__sip_resolvehost(str *name, unsigned short *port, char *proto)
+{
+ if(dns_cache_init) {
+ return dns_sip_resolvehost(name, port, proto);
+ } else {
This `else` can be skipped:
```c
if (x) return y;
/*skipped else*/ return z;
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3858#pullrequestreview-2091493759
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core/resolve: Check dns_cache_init and choose appropriate functions (PR #3858)
@dilyanpalauzov commented on this pull request.
> @@ -1623,7 +1623,12 @@ struct hostent *no_naptr_srv_sip_resolvehost(
srv_name.s = tmp_srv;
srv_name.len = strlen(tmp_srv);
#ifdef USE_DNS_CACHE
- he = dns_srv_get_he(_name, port, dns_flags);
+ if(dns_cache_init) {
+ he = dns_srv_get_he(_name, port, dns_flags);
+ } else {
+ LM_WARN("USE_DNS_CACHE is defined but
dns_cache_init=off\n");
Why is this a run-time warning, depending on how Kamailio is compiled and
current settings. I mean the distributions compile Kamailio and let the users
select, `dns_cache_init` ON or OFF. With this change users will get a warning,
they do not to fix, as it will be up to the distribution to fix the warning, by
preventing the users to toggle `dns_cache_init`.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3858#pullrequestreview-2091484258
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
I meant that in the past on 5.6 branch with my configuration Kamailio has not crashed immediately after start. Kamailio 5.8 crashes immediately after start. With your first version of the patch Kamailio does not crash anymore immediately after start. The problem report here is that Kamailio 5.6.3 crashed in my configuration when I try to call an ENUM resolved number +437200101012. With your second patch applied on the 5.8 branch, the call is performed and there is no crash. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3350#issuecomment-2142770847 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
Thank you very much for looking into this! The setup I had in the past, six months ago, with 5.7, has connected me to +437200101012. When dns_cache_init=off without this patch applied on the 5.8 branch, with the configuration files I have, Kamailio crashes more or less immediately after it is started, or whenever a WebSocket connection is established. When dns_cache_init=off with this patch applied on the 5.8 branch, Kamailio crashes after I try to call +437200101012 over WebSocket. When dns_cache_init=on with this patch applied and I dial +437200101012 Kamailio does not crash, but does not connect me neither, with the latter being irrelevant here. So I think the initial problem is not solved, but your patch addreses a problem, which has not existed at the time I reported about this crash. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3350#issuecomment-2130891286 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
With Kamailio 5.8 it still crashes. I use in the meantime the bytecode of
luajit as KEMI.
kamailio.cfg
#.x!xKAMAILI2O
# *** To enable presence server execute:
# - define WITH_PRESENCE
# - if modified headers or body in config must be used by presence handling:
# - define WITH_MSGREBUILD
#
# *** To block 3XX redirect replies execute:
#!define WITH_BLOCK3XX
#
# *** To block 401 and 407 authentication replies execute:
# - define WITH_BLOCK401407
server_signature=off
# force_rport=on # made in routling_logic.lua
# local_rport=on
log_stderror=yes
corelog=-1
/* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */
debug=1
dns_try_ipv6=off
dns_retr_time=2
use_dns_failover=on
dns_srv_lb=on
dns_try_naptr=on
dns_cache_flags=1
#next line crashes, unless =on
dns_cache_init=on
use_dns_cache=on
server_id=2
rundir="/conf"
children=8
enable_sctp = 1
sctp_children = 2
tcp_children = 4
enable_tls=yes
listen=tls:144.76.142.78:5061
listen=tcp:144.76.142.78:5060
listen=udp:144.76.142.78:5060
listen=sctp:144.76.142.78:5060
#onsend_route_reply=yes
user="kamailio"
group="kamailio"
real_time = 3
#tcp_defer_accept = 3
#!define DBURLRO "sqlite:///conf/kamailio-ro.db"
#!define DBURLRW "sqlite:///conf/kamailio.db"
### Defined Values #
# *** Value defines - IDs used later in config
# - flags
# FLT_ - per transaction (message) flags
#!define FLT_ACC 1
#!define FLT_ACCMISSED 2
#!define FLT_ACCFAILED 3
#!define FLT_NATS 5
# FLB_ - per branch flags
#!define FLB_NATB 6
#!define FLB_NATSIPPING 7
#!define FLT_DIALOG 10
#!define FLT_SST 11
### Global Parameters #
mlock_pages=yes
auto_aliases=no
#alias=sip.bapha.be:5060
#alias=sip.bapha.be:5061
#alias=sip.aegee.org:5060
#alias=sip.aegee.org:5061
#alias=mail.aegee.org:5060
#alias=mail.aegee.org:5061
/* life time of TCP connection when there is no traffic
* - a bit higher than registration expires to cope with UA behind NAT */
tcp_connection_lifetime=3605
tcp_accept_no_cl=yes
#tcp_keepalive=yes
tcp_keepcnt=6
tcp_keepidle=60
tcp_keepintvl=10
loadmodule "db_sqlite.so"
loadmodule "permissions.so"
loadmodule "sctp.so"
loadmodule "enum.so"
loadmodule "kex.so"
loadmodule "kemix.so"
loadmodule "corex.so"
loadmodule "tm.so"
loadmodule "tmx.so"
loadmodule "sl.so"
loadmodule "usrloc.so"
loadmodule "tls.so"
loadmodule "stun.so"
loadmodule "outbound.so"
loadmodule "rr.so"
loadmodule "pv.so"
loadmodule "sipdump"
loadmodule "dialog.so"
loadmodule "sst.so"
loadmodule "uac.so"
loadmodule "acc.so"
loadmodule "maxfwd.so"
loadmodule "registrar.so"
loadmodule "textops.so"
loadmodule "tcpops.so"
# loadmodule "textopsx.so" ## unused
loadmodule "siputils.so"
loadmodule "xlog.so"
loadmodule "sanity.so"
loadmodule "nathelper.so"
loadmodule "ctl.so"
loadmodule "cfg_rpc.so"
loadmodule "counters.so"
loadmodule "rtpengine.so"
loadmodule "auth.so"
loadmodule "auth_db.so"
loadmodule "alias_db.so"
loadmodule "domain.so"
#!ifdef WITH_PRESENCE
loadmodule "presence.so"
loadmodule "presence_xml.so"
#!endif
loadmodule "htable.so"
loadmodule "pike.so"
loadmodule "xhttp.so"
loadmodule "websocket.so"
loadmodule "app_lua.so"
loadmodule "statsc.so"
modparam("sipdump", "enable", 1)
modparam("sipdump", "mode", 2)
modparam("sipdump", "event_callback", "ksr_sipdump_event")
#modparam("sipdump", "folder", "/conf")
modparam("auth", "auth_checks_register", 11)
modparam("auth", "qop", "auth")
modparam("auth", "auth_checks_no_dlg", 9)
modparam("auth", "auth_checks_in_dlg", 15)
modparam("auth", "qop", "auth")
modparam("auth", "use_domain", yes);
# modparam("auth", "algorithm", "SHA-256") # gnome-calls does not support
algorithm=sha-256
modparam("auth", "add_authinfo_hdr", yes)
modparam("permissions", "load_backends", 1)
modparam("permissions", "db_url", DBURLRO)
# - auth_db params -
modparam("auth_db", "db_url", DBURLRO)
modparam("auth_db", "calculate_ha1", 1)
modparam("auth_db", "password_column", "password")
modparam("auth_db", "load_credentials", "$avp(credentials)=password")
modparam("auth_db", "use_domain", 1)
modparam("dialog", "timeout_avp", "$avp(dlgtimeout)")
modparam("dialog", "bridge_controller", "sip:control...@aegee.org")
modparam("dialog", "bridge_contact", "sip:controller@144.76.142.78:5060")
modparam("dialog", "send_bye", 1)
modparam("dialog", "dlg_flag", FLT_DIALOG)
modparam("sst", "timeout_avp", "$avp(dlgtimeout)")
modparam("sst", "sst_flag", FLT_SST)
modparam("xhttp", "event_callback", "ksr_xhttp_event")
modparam("rtpengine", "rtpengine_sock", "udp:127.0.0.1:1555")
modparam("ctl", "binrpc", "unix:/conf/kamailio_ctl")
modparam("sanity", "uri_checks", 15)
modparam("uac", "restore_passwd", "my_secret_EIA99iatruai")
# modparam("uac", "default_socket", "udp:144.76.142.78:5060")
modparam("uac", "reg_use_domain", 1)
modparam("uac", "reg_db_url", DBURLRO)
# - tm params -
# auto-discard branches from previous serial forking leg
modparam("tm", "failure_reply_mode", 3)
# default retransmission timeout: 30sec
modparam("tm", "fr_timer", 3)
[sr-dev] [kamailio/kamailio] src/Makefile.defs: recognize GCC 14 as recent ⇔ not too old compiler (PR #3711)
similar to 87ed3d9c3ae3ecfabe6 GCC 14 will be released in April or May 2024. Adding this now will avoid backporting the change to the 5.8 branch. (Not that 87ed3d9c3ae3ecfabe6 was backported to 5.7.) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3711 -- Commit Summary -- * src/Makefile.defs: recognize GCC 14 as recent ⇔ not too old compiler -- File Changes -- M src/Makefile.defs (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3711.patch https://github.com/kamailio/kamailio/pull/3711.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3711 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] http_async_client: exit mod_init if tm is not loaded (PR #3706)
@dilyanpalauzov commented on this pull request.
I think the line above LM_ERROR is bettet than LM_INFO.
> @@ -295,7 +295,7 @@ static int mod_init(void)
if(load_tm_api() < 0) {
LM_INFO("cannot load the TM-functions - async relay
disabled\n");
- memset(, 0, sizeof(tm_api_t));
+ return -1;
I think the line above LM_ERROR is bettet than LM_INFO.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3706#pullrequestreview-1813978183
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
/notexpired -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3350#issuecomment-1837147025 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)
> I guess the option of the reporter to reopen the issue/pr is still available. I do not see such option. Currently the only way to prevent automatic closing is to write (probably periodically) any text. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826897196 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)
> An issue or PR marked `stale` can have the label removed by reporter… This is not correct. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826889285 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)
> From that point of view, I think it is fair that the reporter reacts on a > stale or close notification and indicate that the issue is still there or the > PR is still relevant. Writing repeatedly any text just for the sake of keeping a ticket open does not help anyhow. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826879056 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Crash in dns_cache.c with dns_cache_init=off (Issue #3350)
Closing valid bugs, without fixing the real problem, results very few current reports for real problems in the software. This practice leads to the wrong impression, that Kamailio has no known problems, and therefore is good software. This is misleading and nobody has interest in having such misleading context. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3350#issuecomment-1826777276 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Silence “make: --libs: No such file or directory” warnings (PR #3475)
The proposed here change does fix problems (warnings). I object that this PR is closed, instead of fixing the underlying warnings by the suggested or other ways. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3475#issuecomment-1826776355 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Typos at https://www.kamailio.org/docs/modules/devel/ (Issue #3596)
At https://www.kamailio.org/docs/modules/devel/ is spelled CALL_CONTROL | Conector to call_control application -- | -- EVREXEC | Execut event routes at startup on dedicated processes It shall be co**NN**ector and execut**E**. Likewise for https://www.kamailio.org/docs/modules/5.8.x/ , https://www.kamailio.org/docs/modules/5.7.x/, https://www.kamailio.org/docs/modules/5.6.x/ … -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3596 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] examples/kamailio-basic-kemi-lua.lua: Add example for rtpengine (PR #3587)
A while ago I wanted to adjust my Lua configuration to work with rtpengine and I have adjusted this example accordingly. I have not tried the example, but if there are no obvious bugs with it, I think it will be useful. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3587 -- Commit Summary -- * examples/kamailio-basic-kemi-lua.lua: Add example for rtpengine -- File Changes -- M misc/examples/kemi/kamailio-basic-kemi-lua.lua (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3587.patch https://github.com/kamailio/kamailio/pull/3587.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3587 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
