[sr-dev] Re: [kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)

2023-11-17 Thread Frédéric Gaisnon via sr-dev
Thanks

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3644#issuecomment-1816561423
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] Re: [kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)

2023-11-17 Thread Frédéric Gaisnon via sr-dev
can it be added in kamailio 5.7.3 ?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3644#issuecomment-1816076229
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


[sr-dev] [kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)

2023-11-16 Thread Frédéric Gaisnon via sr-dev




 Pre-Submission Checklist



- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

When caller sent a BYE instead a CANCEL into a non connected call, route are 
badly reappend by topos.
regression introduced by patch 091dc9a76bcec5c8a4bc73e863ed10b1b9d76c92
   topos: fix early-dialog b-side UPDATE requests routing (GH #3437)
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3644

-- Commit Summary --

  * topos: BYE sent by caller before call was connected was badly managed

-- File Changes --

M src/modules/topos/tps_msg.c (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3644.patch
https://github.com/kamailio/kamailio/pull/3644.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3644
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org


Re: [sr-dev] [kamailio/kamailio] jwt: token may have a validity period (number of seconds) (#2722)

2021-05-03 Thread Frédéric Gaisnon
Thanks for your generic developpement, it is better than my quickly dev and 
responds to my needs.
I note your remark for further pull request.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2722#issuecomment-831129721___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] jwt: token may have a validity period (number of seconds) (#2722)

2021-04-30 Thread Frédéric Gaisnon




 Pre-Submission Checklist



- [x ] Commit message has the format required by CONTRIBUTING guide
- [ x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x ] Each component has a single commit (if not, squash them into one commit)
- [x ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [x ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [x ] PR should be backported to stable branches
- [x ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

Add a new parameter validity to jwt_generate(prvkey, alg, claims) in order to 
set a validity period for generated jwt token.
I know branch 5.5 is almost released but I think that this functionality is 
very important for this new module and I hope it can be added to this release.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2722

-- Commit Summary --

  * cplc: add a configuration route before redirected call (key: redirect_route)
  * pua_dialoginfo: disable publish notifications for subsequent requests (key: 
publish_dialog_req_within)
  * Merge branch 'master' of https://github.com/kamailio/kamailio
  * jwt: token may have a validity period (number of seconds)

-- File Changes --

M src/modules/jwt/doc/jwt.xml (9)
M src/modules/jwt/doc/jwt_admin.xml (5)
M src/modules/jwt/jwt_mod.c (17)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2722.patch
https://github.com/kamailio/kamailio/pull/2722.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2722
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] [kamailio/kamailio] cplc and pua_dialoginfo enhancement (#2676)

2021-03-19 Thread Frédéric Gaisnon
Ok sorry, I note it for future commits.
However is this validation may be done before 5.5 release?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2676#issuecomment-802888954___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


[sr-dev] [kamailio/kamailio] cplc and pua_dialoginfo enhancement (#2676)

2021-03-16 Thread Frédéric Gaisnon




 Pre-Submission Checklist



- [x ] Commit message has the format required by CONTRIBUTING guide
- [x ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x ] Each component has a single commit (if not, squash them into one commit)
- [x ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [x ] Small bug fix (non-breaking change which fixes an issue)
- [x ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [x ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

cplc: add a configuration route before redirected call (key: redirect_route)
same behaviour as proxy_route
cplc: deactivate 3XX responses handling (key: ignore3xx)
cplc: time based cpl did not work if several are set
cplc: add return result to kamcmd commands
cplc: documentation update (new keys, new module name, proxy_route modification)

pua_dialoginfo: disable publish notifications for subsequent requests (key: 
publish_dialog_req_within)
Generally all these PUBLISH generated are not usefull.

pua_dialoginfo: add new key to really deactivate caller or callee notification 
when the deactivated party was supervised (key: 
caller_entity_when_publish_disabled key: callee_entity_when_publish_disabled)
If Alice calls Bob with Alice and Bob already supervised by watchers and 
disable_caller_publish_flag set, PUBLISH generated for Bob will generate NOTIFY 
for Alice's watchers and Bob's watchers instead of just Bob's 
watchers.
Note that dlginfo_cell structure is updated because flag set for disabling 
party (disable_caller_publish_flag or disable_callee_publish_flag ) are not 
always present in subsequent request received by pua_dialoginfo module. So flag 
set on initial request are stored and used during the dialog.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2676

-- Commit Summary --

  * cplc: add a configuration route before redirected call (key: redirect_route)
  * pua_dialoginfo: disable publish notifications for subsequent requests (key: 
publish_dialog_req_within)

-- File Changes --

M src/modules/cplc/cpl_db.c (2)
M src/modules/cplc/cpl_env.h (2)
M src/modules/cplc/cpl_loader.c (14)
M src/modules/cplc/cpl_proxy.h (5)
M src/modules/cplc/cpl_run.c (6)
M src/modules/cplc/cpl_switches.h (2)
M src/modules/cplc/cplc.c (14)
M src/modules/cplc/doc/cplc.xml (9)
M src/modules/cplc/doc/cplc_admin.xml (84)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo.xml (9)
M src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml (66)
M src/modules/pua_dialoginfo/pua_dialoginfo.c (188)
M src/modules/pua_dialoginfo/pua_dialoginfo.h (3)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2676.patch
https://github.com/kamailio/kamailio/pull/2676.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2676
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev