[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> Would love to get this merged, but didn't succeed testing it successfully on > my machine. Maybe I did something wrong? A second pair of eyes would be > highly appreciated. Yes for sure one more round of check will be good so that anything missed out can be checked. But for my Application I am using for REGISTER with call-ID mask and it works perfectly and its more than 8 months working with more than 16 registrations -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-2174186105 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos:added get_callid_mask/get_callid_unmask funtion for handeling Refer-To header (PR #3872)
@toharish pushed 1 commit. 14a9aeed8a223c3de8524a502632537ce04704a4 Update topos_mod.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3872/files/03d14b342e7802b06936b8bcbd32db1d06995257..14a9aeed8a223c3de8524a502632537ce04704a4 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos:added get_callid_mask/get_callid_unmask funtion for handeling Refer-To header (PR #3872)
@toharish pushed 1 commit. 03d14b342e7802b06936b8bcbd32db1d06995257 Update topos_mod.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3872/files/82946a2b45bc1c2a153e03a26b0a540576adf2c2..03d14b342e7802b06936b8bcbd32db1d06995257 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] topos:added get_callid_mask/get_callid_unmask funtion for handeling Refer-To header (PR #3872)
Topos: Added get_callid_mask functin which will give the masked callID if actual callID is given and get_callid_unmask function which will unmask the given call-ID. This funtion is useful when the client sends a refer methord with refer-to header containing call-id Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3872 -- Commit Summary -- * add funtion to mask/unmask callID * get_callid_mask /get_callid_unmask Document Update -- File Changes -- M src/modules/topos/doc/topos_admin.xml (87) M src/modules/topos/topos_mod.c (183) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3872.patch https://github.com/kamailio/kamailio/pull/3872.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3872 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
@toharish pushed 1 commit. 86402aee2f1730922000902e15a095b54c5a6b4d Update tps_msg.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3766/files/9769806b96148a2ede4612605c6d4af047c137f7..86402aee2f1730922000902e15a095b54c5a6b4d You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> > > ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid
> > > provided ,This error was noticed before the last commit
> > > [[9769806](https://github.com/kamailio/kamailio/commit/9769806b96148a2ede4612605c6d4af047c137f7)].
> > > After this update it was fine. I have tested with more than 135000
> > > active registrations and many failures.
> >
> >
> > I'm also getting this with your latest commit. Do you have a bare minimum
> > config that works for you, so I can verify?
> > Also, I've tested with contact_mode=1 too, but for an INVITE, topos adds a
> > `tps=btpsh-`, do you do this manually?
>
> It is not required to add btph/atph to contact as Registration will not
> create a Dialog for another Indialog Method will not be orginated with this
> contact. For registration no change is done in the contact field by Topos.
>
> modparam("topoh", "mask_key", "THIS_IS_TEST_KEY") modparam("topoh",
> "mask_callid", 1) modparam("topoh", "callid_prefix", "TXX") modparam("topoh",
> "use_mode", 1)
>
> modparam("topos", "storage", "redis") modparam("topos_redis", "serverid",
> "tps")
>
> modparam("topos", "contact_mode", 1) modparam("topos", "rr_update", 1)
> modparam("topos", "contact_host", EXTIP )
>
> modparam("topos", "mask_callid", 1) modparam("topos",
> "enable_register_publish",1) This works perfectly for me, where TOPOS hide
> Via and mask Call-ID. Form. To and Requst URI chages as done manually/
> through Dispatcher ds_select_domaincall in dispatcher.
@agranig any updates form you testing
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3766#issuecomment-2030269656
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Consider adding socket options SO_BINDTODEVICE when the interface name is given for listen in the config file (Issue #3716)
Closed #3716 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3716#event-12313929780 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> > ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid
> > provided ,This error was noticed before the last commit
> > [[9769806](https://github.com/kamailio/kamailio/commit/9769806b96148a2ede4612605c6d4af047c137f7)].
> > After this update it was fine. I have tested with more than 135000 active
> > registrations and many failures.
>
> I'm also getting this with your latest commit. Do you have a bare minimum
> config that works for you, so I can verify?
>
> Also, I've tested with contact_mode=1 too, but for an INVITE, topos adds a
> `tps=btpsh-`, do you do this manually?
It is not required to add btph/atph to contact as Registration will not create
a Dialog for another Indialog Method will not be orginated with this contact.
For registration no change is done in the contact field by Topos.
modparam("topoh", "mask_key", "THIS_IS_TEST_KEY")
modparam("topoh", "mask_callid", 1)
modparam("topoh", "callid_prefix", "TXX")
modparam("topoh", "use_mode", 1)
modparam("topos", "storage", "redis")
modparam("topos_redis", "serverid", "tps")
modparam("topos", "contact_mode", 1)
modparam("topos", "rr_update", 1)
modparam("topos", "contact_host", EXTIP )
modparam("topos", "mask_callid", 1)
modparam("topos", "enable_register_publish",1)
This works perfectly for me, where TOPOS hide Via and mask Call-ID. Form. To
and Requst URI chages as done manually/ through Dispatcher
ds_select_domaincall in dispatcher.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3766#issuecomment-1992397254
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> > I tested it for REGISTER, and it seems to break if the registrar sends e.g. > > a 4xx with no contact back, causing the log line > > ``` > > ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid > > provided > > ``` > > > > > > > > > > > > > > > > > > > > > > > > Is this something you've experienced, @toharish ? > > Thinking of it: if the Contact is not handled by topos, where is the lookup > key `cparam_name` stored? Could it be that this only works with > `contact_mode=2`? If so, could you please provide a full example to > reprooduce it? ERROR: topos [tps_storage.c:1407]: tps_db_load_dialog(): invalid dlg uuid provided ,This error was noticed before the last commit [9769806]. After this update it was fine. I have tested with more than 135000 active registrations and many failures. I have used contact_mode=1. In this case contact is stored but not replaced. This can be further worked out to replace the contact, however I felt it may vary based on the user requirement, hence it was left to the users to modify it in the kamailio script as required. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1992152386 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
> From description I understand that only Via is removed for REGISTER (and > PUBLISH). The Contact stays the same, in that case Path still has to be used > in order to get the traffic back to topos-instance. Also, the incoming Path > headers are kept. Is it right? Yes, Via and Call-ID mask is done in this pull request, other headers can be managed in kamailio native script/ksr as per the end user requirement. Registration will have the location information and authentication information, hence it needs to be handled as per requirement. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766#issuecomment-1991522529 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
@toharish pushed 1 commit. 9769806b96148a2ede4612605c6d4af047c137f7 topos:Update tps_msg.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3766/files/1ba8444c45698d2e5d7944d8597abc5af17b80d9..9769806b96148a2ede4612605c6d4af047c137f7 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
@toharish pushed 1 commit. 1ba8444c45698d2e5d7944d8597abc5af17b80d9 Update tps_storage.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3766/files/56bfbdfa659f7bc33ecafa35217cd3861f6451a3..1ba8444c45698d2e5d7944d8597abc5af17b80d9 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
@toharish pushed 1 commit. 56bfbdfa659f7bc33ecafa35217cd3861f6451a3 Update tps_msg.c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3766/files/3e66fc6b654b56e15687db075b3bce710e893969..56bfbdfa659f7bc33ecafa35217cd3861f6451a3 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] topos: add enable_register_publish (PR #3766)
Added enable_register_publish parameter to enable REGISTER and PUBLISH method for topos If set to 1 REGISTER and PUBLISH will be enabled for topos Currently only via header will be applied for topos and if mask_callid is set to 1 call-ID will be masked. Other headers should be manged by the user as required. Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3766 -- Commit Summary -- * add enable_register_publish -- File Changes -- M src/modules/topos/topos_mod.c (2) M src/modules/topos/tps_msg.c (132) M src/modules/topos/tps_msg.h (2) M src/modules/topos/tps_storage.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3766.patch https://github.com/kamailio/kamailio/pull/3766.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3766 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Consider adding socket options SO_BINDTODEVICE when the interface name is given for listen in the config file (Issue #3716)
### Description Consider adding socket options SO_BINDTODEVICE when the interface name is given for listening in the config file. This will be useful in listening to linux VRF interfaces, especially when there are two different VRFs and it is required to proxy SIP messages between the VRFs -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3716 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
