from:"Joey Golan"

[sr-dev] Kamailio jwt module or Lua script

2019-10-05 Thread Joey Golan

Hi all,

I would like to authenticate subscribers using JWT tokens and I wonder which 
approach is better:
1. Writhing a dedicated kamailio module.
2. Writing a Lua script.

What would work better performance wise?

Thanks,

Joey.


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] Kamailio jwt module or Lua script

2019-10-07 Thread Joey Golan

I’ve implemented the token verification in Lua script and I’m using app_lua 
module to call the script from the configuration script inside the [AUTH] block.
It works fine but I want to be sure that I will not face performance 
degradation.
I’ve used the benchmark module to the log the execution duration. The results 
shows 130~ microseconds avg.
Do you think it will have impact on performance?
Regarding app_lua, is it running on the same call context or a different one?

Thanks


From: Daniel-Constantin Mierla 
Sent: Monday, October 7, 2019 12:29 PM
To: Kamailio (SER) - Development Mailing List; Joey Golan
Subject: Re: [sr-dev] Kamailio jwt module or Lua script


Hello,

On 05.10.19 16:07, Joey Golan wrote:
Hi all,

I would like to authenticate subscribers using JWT tokens and I wonder which 
approach is better:
1. Writhing a dedicated kamailio module.
2. Writing a Lua script.

What would work better performance wise?

In terms of executing the same Kamailio C function exported to kamailio.cfg 
routing blocks or to Lua API/kemi, there is not any significant difference.

However, if you execute Lua code written by third party, it is not easy to say 
if it matches the same performances as an equivalent C function that you write.

You can go with the option you consider faster for development and then see if 
you are pleased with the results.

Cheers,
Daniel

-- Daniel-Constantin Mierla -- 
www.asipto.com<http://www.asipto.com>www.twitter.com/miconda<http://www.twitter.com/miconda>
 -- www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>Kamailio 
Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] Kamailio jwt module or Lua script

2019-10-12 Thread Joey Golan

My question is, while making the call to the app_lua does the context of the 
sip call hangs and wait for the Lua script to end or It can handle other calls 
in that time and the route script will get invoked and resume from that point?
I hope it is more clear now.

From: Daniel-Constantin Mierla 
Sent: Monday, October 7, 2019 4:02 PM
To: Joey Golan; Kamailio (SER) - Development Mailing List
Subject: Re: [sr-dev] Kamailio jwt module or Lua script

On 07.10.19 14:36, Joey Golan wrote:
I’ve implemented the token verification in Lua script and I’m using app_lua 
module to call the script from the configuration script inside the [AUTH] block.
It works fine but I want to be sure that I will not face performance 
degradation.
I’ve used the benchmark module to the log the execution duration. The results 
shows 130~ microseconds avg.
Do you think it will have impact on performance?
If you get the numbers you want (calls per second or registrations per second), 
then it is fine.
Regarding app_lua, is it running on the same call context or a different one?

What do you mean here? Like "sip/voip call context", or "function call context"?

Cheers,
Daniel

Thanks

From: Daniel-Constantin Mierla <mailto:mico...@gmail.com>
Sent: Monday, October 7, 2019 12:29 PM
To: Kamailio (SER) - Development Mailing List; Joey Golan
Subject: Re: [sr-dev] Kamailio jwt module or Lua script

Hello,

On 05.10.19 16:07, Joey Golan wrote:
Hi all,

I would like to authenticate subscribers using JWT tokens and I wonder which 
approach is better:
1. Writhing a dedicated kamailio module.
2. Writing a Lua script.

What would work better performance wise?

In terms of executing the same Kamailio C function exported to kamailio.cfg 
routing blocks or to Lua API/kemi, there is not any significant difference.

However, if you execute Lua code written by third party, it is not easy to say 
if it matches the same performances as an equivalent C function that you write.

You can go with the option you consider faster for development and then see if 
you are pleased with the results.

Cheers,
Daniel

-- Daniel-Constantin Mierla -- 
www.asipto.com<http://www.asipto.com>www.twitter.com/miconda<http://www.twitter.com/miconda>
 -- www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>Kamailio 
Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat

--
Daniel-Constantin Mierla -- www.asipto.com<http://www.asipto.com>
www.twitter.com/miconda<http://www.twitter.com/miconda> -- 
www.linkedin.com/in/miconda<http://www.linkedin.com/in/miconda>
Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- 
https://asipto.com/u/kat
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-01 Thread Joey Golan



### Description

After upgrading Debian from stretch to buster, kamailio service keeps crashing 
on service stat.
Same kamailio configuration file worked fine on Debian stretch.
If I disable TLS the service starts successfully.

### Troubleshooting

Looks like a TLS issue

 Reproduction

Debian buster
TLS enabled

 Debugging Data



```
root@kamailio11:/# gdb /usr/sbin/kamailio /core
GNU gdb (Debian 8.2.1-2+b3) 8.2.1
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
.
Find the GDB manual and other documentation resources online at:
.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/sbin/kamailio...Reading symbols from 
/usr/lib/debug/.build-id/ed/15dbbb24fb309311e7a6a16cf9222a82afb102.debug...done.
done.
[New LWP 7259]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f 
/etc/kamailio/kamailio.cfg'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x7f17c0877e26 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
(gdb) bt full
#0  0x7f17c0877e26 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#1  0x7f17c087812f in OPENSSL_cleanup () from 
/usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#2  0x7f17c46aad8c in __run_exit_handlers (status=1, listp=0x7f17c482c718 
<__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, 
run_dtors=run_dtors@entry=true) at exit.c:108
atfct = 
onfct = 
cxafct = 
f = 
new_exitfn_called = 3
cur = 0x7f17c482dd80 
#3  0x7f17c46aaeba in __GI_exit (status=) at exit.c:139
No locals.
#4  0x55c479a9c502 in handle_sigs () at main.c:808
chld = 0
chld_status = 139
any_chld_stopped = 1
memlog = 0
__func__ = "handle_sigs"
#5  0x55c479aa8053 in main_loop () at main.c:1817
i = 8
pid = 7301
si = 0x0
si_desc = "udp receiver child=7 
sock=172.19.140.101:5060\000\000\000\003\000\000\000+\000\000\000\000\253pP\333\351\322a\320-\221z\304U\000\000\210`\354y\304U\000\000\000\000\000\000\000\000\000\000\260Lv\304\027\177\000\000\363N\361y\304U\000\000\000\000\000\200\000\000\000\000\060P\254$\375\177\000\000hm\322y\304U\000"
nrprocs = 8
woneinit = 1
__func__ = "main_loop"
#6  0x55c479ab1516 in main (argc=9, argv=0x7ffd24ac5578) at main.c:2856
cfg_stream = 0x55c47a82b260
c = -1
r = 0
tmp = 0x7ffd24ac6de3 ""
tmp_len = 32535
port = -995964432
proto = 32535
ahost = 0x0
aport = 0
options = 0x55c479ec8d38 
":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:"
--Type  for more, q to quit, c to continue without paging--
ret = -1
seed = 1032197731
rfd = 4
debug_save = 0
debug_flag = 0
dont_fork_cnt = 0
n_lst = 0x0
p = 0x0
st = {st_dev = 21, st_ino = 79137, st_nlink = 2, st_mode = 16832, 
st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 
4096, st_blocks = 0, st_atim = {tv_sec = 1599027572, tv_nsec = 735090396}, 
st_mtim = {tv_sec = 1599027608,
tv_nsec = 820311152}, st_ctim = {tv_sec = 1599027608, tv_nsec = 
820311152}, __glibc_reserved = {0, 0, 0}}
tbuf = 
"\000\000\000\000\000\000\000\000\b\000\000\000\000\000\000\000\060ע\304\027\177\000\000\000\000\000\000\000\000\000\000\240A\271$\375\177\000\000\364ڠ\304\027\177\000\000\b\000\000\000\000\000\000\000\230B\271$\375\177\000\000\060ע\304\027\177\000\000\030S\254$\375\177\000\000\024S\254$\375\177",
 '\000' , 
"\230B\271$\375\177\000\000\250A\271$\375\177\000\000'\036\177\304\027\177\000\000&\260be\000\000\000\000\200T\254$\375\177\000\000\300\212\225\001\000\000\000\000\340S\254$\375\177\000\000\320S\254$\375\177\000\000\030S\254$\375\177\000\000Xע\304\027\177\000\000\001",
 '\000' ...
option_index = 0
long_options = {{name = 0x55c479ecadc6 "help", has_arg = 0, flag = 0x0, 
val = 104}, {name = 0x55c479ec650c "version", has_arg = 0, flag = 0x0, val = 
118}, {name = 0x55c479ecadcb "alias", has_arg = 1, flag = 0x0, val = 1024}, 
{name = 0x55c479ecadd1 "subst",
has_arg = 1, flag = 0x0, val = 1025}, {name = 0x55c479ecadd7 
"substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x5

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-03 Thread Joey Golan

Still crashes for me.
I installed Kamailio v5.4.2 nightly build

kamailio-dbg/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 [installed]
kamailio-extra-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 
[installed]
kamailio-json-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 
[installed]
kamailio-lua-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 [installed]
kamailio-mysql-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 
[installed]
kamailio-redis-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 
[installed]
kamailio-systemd-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 
[installed]
kamailio-tls-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 [installed]
kamailio-utils-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 
[installed]
kamailio-websocket-modules/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 
[installed]
kamailio/unknown,now 5.4.2~bpo10.20200903013416.27 amd64 [installed]

**Kamailio log:**

Sep  3 07:04:40 kamailio12 kamailio: INFO:  [core/tcp_main.c:4982]: 
init_tcp(): using epoll_lt as the io watch method (auto detected)
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: rr 
[../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module 
is not loaded
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: rr [rr_mod.c:185]: 
mod_init(): outbound module not available
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: dmq_usrloc 
[dmq_usrloc.c:81]: mod_init(): dmq usrloc replication mode = 1
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: cfgutils 
[cfgutils.c:869]: mod_init(): no hash_file given, disable hash functionality
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: http_async_client 
[http_async_client_mod.c:222]: mod_init(): Initializing Http Async module
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: auth 
[auth_mod.c:345]: mod_init(): qop set, but nonce-count (nonce_count) support 
disabled
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: permissions 
[permissions.c:601]: mod_init(): default allow file 
(/etc/kamailio/permissions.allow) not found => empty rule set
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: permissions 
[permissions.c:615]: mod_init(): default deny file 
(/etc/kamailio/permissions.deny) not found => empty rule set
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: pike [pike.c:97]: 
pike_init(): PIKE - initializing
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: pike 
[ip_tree.c:81]: init_lock_set(): probing 256 set size
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: tls 
[tls_mod.c:389]: mod_init(): With ECDH-Support!
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: tls 
[tls_mod.c:392]: mod_init(): With Diffie Hellman
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: WARNING: tls 
[tls_init.c:784]: tls_h_mod_init_f(): openssl bug #1491 (crash/mem leaks on low 
memory) workaround enabled (on low memory tls operations will fail 
preemptively) with free memory thresholds 22544384 and 11272192 bytes
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO:  
[core/cfg/cfg_ctx.c:595]: cfg_set_now(): tls.low_mem_threshold1 has been 
changed to 22544384
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO:  
[core/cfg/cfg_ctx.c:595]: cfg_set_now(): tls.low_mem_threshold2 has been 
changed to 11272192
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO:  
[main.c:2833]: main(): processes (at least): 43 - shm size: 2147483648 - pkg 
size: 33554432
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO:  
[core/udp_server.c:154]: probe_max_receive_buffer(): SO_RCVBUF is initially 
212992
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO:  
[core/udp_server.c:206]: probe_max_receive_buffer(): SO_RCVBUF is finally 425984
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: http_async_client 
[async_http.c:101]: async_http_init_sockets(): inter-process event notification 
sockets initialized
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: http_async_client 
[async_http.c:101]: async_http_init_sockets(): inter-process event notification 
sockets initialized
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: http_async_client 
[async_http.c:101]: async_http_init_sockets(): inter-process event notification 
sockets initialized
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: http_async_client 
[async_http.c:101]: async_http_init_sockets(): inter-process event notification 
sockets initialized
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: tls 
[tls_domain.c:305]: ksr_tls_fill_missing(): TLSs: tls_method=18
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: tls 
[tls_domain.c:317]: ksr_tls_fill_missing(): TLSs: 
certificate='/etc/kamailio/ssl/widebridge.pem'
Sep  3 07:04:40 kamailio12 /usr/sbin/kamailio[24676]: INFO: tls 
[tls_domain.c:324]: ksr_tls_fill_missing(): TLSs: 
ca_list='/

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-06 Thread Joey Golan

After some investigation I found out that the cause for the problem is 
modparam("http_async_client", "workers", **4**).
Starting kamailio with modparam("http_async_client", "workers", **1**) works 
fine.
I also tested it on v5.4.1 before @linuxmaniac reverts and it works fine with 
modparam("http_async_client", "workers", **1**)

Here are the bt full of all the core files:

root@kamailio12:/# gdb /usr/sbin/kamailio /core.32155
GNU gdb (Debian 8.2.1-2+b3) 8.2.1
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
stopType "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
.
Find the GDB manual and other documentation resources online at:
.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/sbin/kamailio...Reading symbols from 
/usr/lib/debug/.build-id/ed/15dbbb24fb309311e7a6a16cf9222a82afb102.debug...done.
done.
[New LWP 32155]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/sbin/kamailio -f /etc/kamailio/kamailio.cfg -m 2048 
-M 32'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x7fb49968e61f in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
(gdb) bt full
#0  0x7fb49968e61f in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#1  0x7fb49968dfb5 in CONF_modules_finish () from 
/usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#2  0x7fb49968e139 in ?? () from /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#3  0x7fb4997231e0 in OPENSSL_cleanup () from 
/usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
No symbol table info available.
#4  0x7fb49993af45 in tls_h_mod_destroy_f () at tls_init.c:870
__func__ = "tls_h_mod_destroy_f"
#5  0x559822cbf4d1 in destroy_tls () at core/tls_hooks.c:75
No locals.
#6  0x559822b66358 in cleanup (show_status=1) at main.c:584
memlog = 0
__func__ = "cleanup"
#7  0x559822b67ef3 in shutdown_children (sig=15, show_status=1) at 
main.c:706
__func__ = "shutdown_children"
#8  0x559822b6b4e6 in handle_sigs () at main.c:806
chld = 0
chld_status = 139
any_chld_stopped = 1
memlog = 0
__func__ = "handle_sigs"
#9  0x559822b77053 in main_loop () at main.c:1817
i = 8
pid = 32195
si = 0x0
si_desc = "udp receiver child=7 
sock=172.19.140.102:5060\000\000\000\003\000\000\000)\000\000\000\000\274[\351\352ZP\207`\027\v%\230U\000\000\210P\371\"\230U\000\000\000\000\000\000\000\000\000\000\260|\255\233\264\177\000\000\363>\376\"\230U\000\000\000\000\000\200\000\000\000\000\320\177N\204\377\177\000\000h]\337\"\230U\000"
nrprocs = 8
woneinit = 1
--Type  for more, q to quit, c to continue without paging--
__func__ = "main_loop"
#10 0x559822b80516 in main (argc=7, argv=0x7fff844e8518) at main.c:2856
cfg_stream = 0x559824fcb260
c = -1
r = 0
tmp = 0x7fff844e8def ""
tmp_len = 0
port = 0
proto = 1
ahost = 0x0
aport = 0
options = 0x559822f97d38 
":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:"
ret = -1
seed = 3411128981
rfd = 4
debug_save = 0
debug_flag = 0
dont_fork_cnt = 0
n_lst = 0x1f80
p = 0x0
st = {st_dev = 21, st_ino = 428223, st_nlink = 2, st_mode = 16832, 
st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 
4096, st_blocks = 0, st_atim = {tv_sec = 1599374984, tv_nsec = 763308205}, 
st_mtim = {tv_sec = 1599374995,
tv_nsec = 555647093}, st_ctim = {tv_sec = 1599374995, tv_nsec = 
555647093}, __glibc_reserved = {0, 0, 0}}
tbuf = 
"\000\000\000\000\000\000\000\000\b\000\000\000\000\000\000\000\060\367\331\233\264\177\000\000\000\000\000\000\000\000\000\000\240\301U\204\377\177\000\000\364\372\327\233\264\177\000\000\b\000\000\000\000\000\000\000\230\302U\204\377\177\000\000\060\367\331\233\264\177\000\000\270\202N\204\377\177\000\000\264\202N\204\377\177",
 '\000' , 
"\230\302U\204\377\177\000\000\250\301U\204\377\177\000\000'N\266\233\264\177\000\000&\260be\000\000\000\000
 
\204N\204\377\177\000\000\300\212\225\001\000\000\000\000\200\203N\204\377\177\000\000p\203N\204\377\177\000\000\270\202N\204\377\177\000\000X\367\331\233\264\177\000\000\001",
 '\000' ...
option_index = 0
long_options = {{name = 0x559822f99dc6 "

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-08 Thread Joey Golan

Yes, tls module loaded first.
I created a minimal config file that reproduces the problem.
The crash is because of this line: modparam("http_async_client", "workers", 4)
comment out this line makes the crash disappear.

#!KAMAILIO

### Global Parameters #

/* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */
debug=2
log_stderror=no
memdbg=5
memlog=5

log_facility=LOG_LOCAL0
log_prefix="{$mt $hdr(CSeq) $ci} "

children=8
tcp_children=16
auto_aliases=no
alias="example.com"

listen=udp:eth0
server_signature=no
tcp_connection_lifetime=3605
tcp_max_connections=40960
tcp_accept_no_cl=yes
enable_tls=yes
listen=tls:eth0
tls_max_connections=4
enable_sctp=no

### Modules Section 

loadmodule "kex.so"
loadmodule "corex.so"
loadmodule "tm.so"
loadmodule "tmx.so"
loadmodule "sl.so"
loadmodule "rr.so"
loadmodule "pv.so"
loadmodule "tls.so"
loadmodule "http_async_client.so"

# - setting module-specific parameters ---

# - tls params -
modparam("tls", "config", "/etc/kamailio/tls.cfg")

# - http client 
modparam("http_async_client", "workers", 4)

### Routing Logic 

request_route {
exit;
}

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2466#issuecomment-688831449___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-09 Thread Joey Golan

Closed #2466.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2466#event-3744983161___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.4.1 - Crash on startup when TLS is enabled after upgrading from stretch to buster (#2466)

2020-09-09 Thread Joey Golan

Hi @grumvalski, I have tested the branch with your changes and it looks like it 
fixes the problem.
Very well.. Thank you!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2466#issuecomment-689455733___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] imc module enhancements (PR #3291)

2022-12-02 Thread Joey Golan





 Pre-Submission Checklist



- [V] Commit message has the format required by CONTRIBUTING guide
- [V] Commits are split per component (core, individual modules, libs, utils, 
...)
- [V] Each component has a single commit (if not, squash them into one commit)
- [V] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [V] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [V] PR should be backported to stable branches
- [V] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description

I modified the imc module as follows:
1. propagate content-type header
2. add the option to modify member role
3. added support to db_mode. all changes are synch to db in case db_mode is set 
to 2.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3291

-- Commit Summary --

  * imc: add support to modify member role
  * imc: call handle_modify
  * imc: db_mode support
  * Merge branch 'kamailio:master' into master
  * imc: destroy db only if db_mode is not 0
  * Merge remote-tracking branch 'joeygo/master'
  * imc: propagate content-type header
  * Merge branch 'kamailio:master' into master

-- File Changes --

M src/modules/imc/doc/imc.xml (7)
M src/modules/imc/doc/imc_admin.xml (35)
M src/modules/imc/imc.c (326)
M src/modules/imc/imc.h (1)
M src/modules/imc/imc_cmd.c (260)
M src/modules/imc/imc_cmd.h (9)
M src/modules/imc/imc_mng.c (405)
M src/modules/imc/imc_mng.h (28)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3291.patch
https://github.com/kamailio/kamailio/pull/3291.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3291
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-28 Thread Joey Golan





 Pre-Submission Checklist



- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3470

-- Commit Summary --

  * imc: add support to modify member role
  * imc: call handle_modify
  * imc: db_mode support
  * Merge branch 'kamailio:master' into master
  * imc: destroy db only if db_mode is not 0
  * Merge remote-tracking branch 'joeygo/master'
  * imc: propagate content-type header
  * Merge branch 'kamailio:master' into master
  * Merge remote-tracking branch 'joeygo/master'
  * Merge branch 'kamailio:master' into master
  * rtpengine: support receiving dtmf events from rtpengine and raise an event

-- File Changes --

M src/modules/rtpengine/doc/rtpengine.xml (7)
M src/modules/rtpengine/doc/rtpengine_admin.xml (117)
M src/modules/rtpengine/rtpengine.c (405)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3470.patch
https://github.com/kamailio/kamailio/pull/3470.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3470
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-29 Thread Joey Golan

@joeygo pushed 1 commit.

ecfec78bf38e17f96f6b01ec79bc89d7a63b797d  Initialize uninitialized local 
variable

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3470/files/5bfc028bb1149eadd9b687ce400423ddff690c64..ecfec78bf38e17f96f6b01ec79bc89d7a63b797d
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-29 Thread Joey Golan

@joeygo pushed 1 commit.

df3cce755c5538c9d60775716902720bcbabe2a7  Pass 0 to pvar setf in case of an 
event raised

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3470/files/ecfec78bf38e17f96f6b01ec79bc89d7a63b797d..df3cce755c5538c9d60775716902720bcbabe2a7
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3470)

2023-05-29 Thread Joey Golan

Closed #3470.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3470#event-9366701378
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-29 Thread Joey Golan


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3471

-- Commit Summary --

  * imc: add support to modify member role
  * imc: call handle_modify
  * imc: db_mode support
  * Merge branch 'kamailio:master' into master
  * imc: destroy db only if db_mode is not 0
  * Merge remote-tracking branch 'joeygo/master'
  * imc: propagate content-type header
  * Merge branch 'kamailio:master' into master
  * Merge remote-tracking branch 'joeygo/master'
  * Merge branch 'kamailio:master' into master
  * rtpengine: support receiving dtmf events from rtpengine and raise an event
  * Initialize uninitialized local variable
  * Pass 0 to pvar setf in case of an event raised

-- File Changes --

M src/modules/rtpengine/doc/rtpengine.xml (7)
M src/modules/rtpengine/doc/rtpengine_admin.xml (117)
M src/modules/rtpengine/rtpengine.c (405)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3471.patch
https://github.com/kamailio/kamailio/pull/3471.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3471
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-31 Thread Joey Golan

@joeygo pushed 0 commits.


-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3471/files/df3cce755c5538c9d60775716902720bcbabe2a7..bc544daea2ee4bb568cf0314f6d32b8aa0c81ecc
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-31 Thread Joey Golan

Closed #3471.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3471#event-9390927195
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-05-31 Thread Joey Golan





 Pre-Submission Checklist



- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3473

-- Commit Summary --

  * rtpengine: support receiving dtmf events from rtpengine and raise an event

-- File Changes --

M src/modules/rtpengine/doc/rtpengine.xml (7)
M src/modules/rtpengine/doc/rtpengine_admin.xml (117)
M src/modules/rtpengine/rtpengine.c (403)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3473.patch
https://github.com/kamailio/kamailio/pull/3473.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving dtmf events from rtpengine and raise an event (PR #3471)

2023-05-31 Thread Joey Golan

Done.

Thank you,
Joey.
On 31 May 2023 at 9:03 +0300, Daniel-Constantin Mierla ***@***.***>, wrote:
> You have to pull and rebase before making the pull request (or force push 
> again) because the PR has commits not related to the change of rtpengine.
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you authored the thread.Message ID: 
> ***@***.***>


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3471#issuecomment-1570383900
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-09 Thread Joey Golan

Hi,

Anything else is needed from my end or is it just waiting for spare time?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1584543228
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo commented on this pull request.



> @@ -2147,6 +2401,9 @@ static int child_init(int rank)
/* probe rtpengines only in first worker */
if(build_rtpp_socks(0, 1))
return -1;
+   
+   if (rtpengine_dtmf_event_sock.len > 0)
+   rtpengine_dtmf_events_loop(rank);

Thanks for the example.
I fixed the code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1226675881
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo commented on this pull request.



>  
-static int fixup_set_id(void **param, int param_no)
+static void rtpengine_dtmf_events_loop(int rank)

You are right. I removed it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1226675084
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo pushed 1 commit.

7c2d64ffa57bb8ebe6ce46311ca98a100b09a997  Register a new worker process for 
dtmf event listener

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/87253c36f1b42f5d707ac4d2aeeda2f842f4d46d..7c2d64ffa57bb8ebe6ce46311ca98a100b09a997
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo commented on this pull request.



> + s_port.len = rtpengine_dtmf_event_sock.s + 
> rtpengine_dtmf_event_sock.len - s_port.s;
+
+   if (s_port.len <= 0 || str2int(&s_port, &port) < 0 || port > 65535) {
+   LM_ERR("failed to initialize dtmf event listener because port 
is invalid %.*s\n", rtpengine_dtmf_event_sock.len, rtpengine_dtmf_event_sock.s);
+   return;
+   }
+   rtpengine_dtmf_event_sock.len -= s_port.len + 1;
+   trim(&rtpengine_dtmf_event_sock);
+   rtpengine_dtmf_event_sock.s[rtpengine_dtmf_event_sock.len] = '\0';
+
+   memset(&udp_addr, 0, sizeof(udp_addr));
+
+   if (rtpengine_dtmf_event_sock.s[0] == '[') {
+   udp_addr.sin6.sin6_family = AF_INET6;
+   udp_addr.sin6.sin6_port = htons(port);
+   ret = inet_pton(AF_INET, rtpengine_dtmf_event_sock.s, 
&udp_addr.sin6.sin6_addr);

Fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1226819073
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo commented on this pull request.



> +
+end:   
+   close(rtpengine_dtmf_event_fd);
+}
+
+static int rtpengine_raise_dtmf_event(char *buffer, int len) {
+   srjson_doc_t jdoc;
+   srjson_t *it = NULL;
+   struct sip_msg *fmsg = NULL;
+   struct run_act_ctx ctx;
+   int rtb;
+
+   LM_DBG("executing event_route[rtpengine:dtmf-event] (%d)\n", 
dtmf_event_rt);
+   LM_DBG("dispatching buffer: %s\n", buffer);
+
+   srjson_InitDoc(&jdoc, NULL);

Fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1227002156
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo commented on this pull request.



> + }
+
+   if (dtmf_event_rt == -1) {
+   LM_NOTICE("nothing to do - nobody is listening!\n");
+   goto end;
+   }
+
+   p = shm_malloc(ret + 1);
+   if (!p) {
+   LM_ERR("could not allocate %d for buffer %.*s\n", ret, 
ret, buffer);
+   goto end;
+   }
+   memcpy(p, buffer, ret);
+   p[ret] = '\0';  
+
+   if (rtpengine_raise_dtmf_event(p, ret) < 0) {

Fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1227001921
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo commented on this pull request.



> @@ -261,7 +262,7 @@ static int add_rtpp_node_info(
void *ptrs, struct rtpp_node *crt_rtpp, struct rtpp_set 
*rtpp_list);
 static int rtpp_test_ping(struct rtpp_node *node);
 
-static void rtpengine_dtmf_events_loop(int rank);
+static void rtpengine_dtmf_events_loop();

Fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1227004361
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo commented on this pull request.



> + }   
+
+   if(rank == PROC_MAIN) {
+   if(rtpengine_dtmf_event_sock.len > 0) {
+   LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid);
+   /* fork worker process */
+   mypid = fork_process(PROC_RPC, "RTPENGINE DTMF WORKER", 
1);
+   if(mypid < 0) {
+   LM_ERR("failed to fork RTPENGINE DTMF WORKER 
process %d\n", mypid);
+   return -1;
+   } else if(mypid == 0) {
+   if(cfg_child_init())
+   return -1;
+   /* this will loop forever */
+   rtpengine_dtmf_events_loop();
+   } 

Maybe @miconda can comment on that?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1227006547
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo pushed 1 commit.

2ddab46263db2ae94038e672c79faaa769d9c306  rtpengine: Fix rfuchs's PR comments

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/7c2d64ffa57bb8ebe6ce46311ca98a100b09a997..2ddab46263db2ae94038e672c79faaa769d9c306
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-12 Thread Joey Golan

@joeygo pushed 1 commit.

3df99a84a33d1dcdb064f96e6edd36b75f9e7166  rtpengine: fix build failed on 
specific distribution

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/2ddab46263db2ae94038e672c79faaa769d9c306..3df99a84a33d1dcdb064f96e6edd36b75f9e7166
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-13 Thread Joey Golan

@joeygo commented on this pull request.



> +
+   fmsg = faked_msg_next();
+   rtb = get_route_type();
+   set_route_type(REQUEST_ROUTE);
+   init_run_actions_ctx(&ctx);
+   run_top_route(event_rt.rlist[dtmf_event_rt], fmsg, &ctx);
+   set_route_type(rtb);
+   if(ctx.run_flags & DROP_R_F) {
+   LM_ERR("exit due to 'drop' in event route\n");
+   goto error;
+   }
+
+   return 0;
+
+error:
+   srjson_DestroyDoc(&jdoc);

You are right.
Fixed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1228452802
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-13 Thread Joey Golan

@joeygo pushed 1 commit.

9d563b820b82bdda49e8c4ad5ef0e82e09d8d535  rtpengine: release json document 
object

-- 
View it on GitHub:
https://github.com/kamailio/kamailio/pull/3473/files/3df99a84a33d1dcdb064f96e6edd36b75f9e7166..9d563b820b82bdda49e8c4ad5ef0e82e09d8d535
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-13 Thread Joey Golan

@joeygo commented on this pull request.



> + }   
+
+   if(rank == PROC_MAIN) {
+   if(rtpengine_dtmf_event_sock.len > 0) {
+   LM_DBG("Register RTPENGINE DTMF WORKER %d\n", mypid);
+   /* fork worker process */
+   mypid = fork_process(PROC_RPC, "RTPENGINE DTMF WORKER", 
1);
+   if(mypid < 0) {
+   LM_ERR("failed to fork RTPENGINE DTMF WORKER 
process %d\n", mypid);
+   return -1;
+   } else if(mypid == 0) {
+   if(cfg_child_init())
+   return -1;
+   /* this will loop forever */
+   rtpengine_dtmf_events_loop();
+   } 

I don't think it is right to kill the entire kamailio process due to an exit in 
such function.
I print error logs in case of failure in the function. isn't it enough?
If you prefer that I'll kill the process just let me know and I'll do that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#discussion_r1229071053
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-20 Thread Joey Golan

Hi @miconda,
Is there anything else I should do or join wait for someone to merge the PR?

Thanks

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1600089504
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] jwt: propagate decoded jwt payload after successful jwt_verify() (PR #3492)

2023-06-22 Thread Joey Golan





 Pre-Submission Checklist



- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:

- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3492

-- Commit Summary --

  * jwt: propagate decoded jwt payload after successful jwt_verify()

-- File Changes --

M src/modules/jwt/doc/jwt.xml (7)
M src/modules/jwt/doc/jwt_admin.xml (5)
M src/modules/jwt/jwt_mod.c (18)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3492.patch
https://github.com/kamailio/kamailio/pull/3492.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3492
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] jwt: propagate decoded jwt payload after successful jwt_verify() (PR #3492)

2023-06-22 Thread Joey Golan

Hi @miconda,

You are right. I wasn't thinking about that option.
Sorry about that  :-)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3492#issuecomment-1602566526
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] jwt: propagate decoded jwt payload after successful jwt_verify() (PR #3492)

2023-06-22 Thread Joey Golan

Closed #3492.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3492#event-9606148379
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] rtpengine: support receiving events from rtpengine and raise an event (PR #3473)

2023-06-26 Thread Joey Golan

Hi @miconda,
I was wondering, if I wish to back-port this to 5.7.1, what is the right way of 
doing so?

Thanks,
Joey.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3473#issuecomment-1607279322
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

38 matches

Mail list logo