[sr-dev] Re: [kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)
@herlesupreeth approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3914#pullrequestreview-2176613787 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)
Thanks @vingarzan. Looks good to me. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3914#issuecomment-2226995347 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)
@herlesupreeth commented on this pull request.
> int app_id = 0, vendor_id = 0;
+ // 1. Destination-Host routing to adjacent peer
+ avp = AAAFindMatchingAVP(m, 0, AVP_Destination_Host, 0,
AAA_FORWARD_SEARCH);
+ if(avp)
+ destination_host = avp->data;
+
+ if(destination_host.len) {
cant we remove this check here as its already done in `get_peer_by_fqdn` ??
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3914#pullrequestreview-2176473764
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)
@herlesupreeth commented on this pull request.
> + avp = AAAFindMatchingAVP(m, 0, AVP_Destination_Host, 0,
> AAA_FORWARD_SEARCH);
+ if(avp)
+ destination_host = avp->data;
+
+ if(destination_host.len) {
+ /* There is a destination host present in the message try and
route directly there */
+ p = get_peer_by_fqdn(&destination_host);
+ if(p && (p->state == I_Open || p->state == R_Open)
+ && peer_handles_application(p, app_id,
vendor_id)) {
+ p->last_selected = time(NULL);
+ return p;
+ }
+ /* the destination host peer is not connected at the moment,
try a normal route then */
+ }
+
+ if(!config->r_table) {
cant we remove this check here as its already done in `get_peer_by_fqdn` ??
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3914#pullrequestreview-2176473762
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: improved routing and removed useless warning/errors in authstatemachine (PR #3914)
@herlesupreeth requested changes on this pull request.
> case AUTH_EV_RECV_ANS_SUCCESS:
x->state = AUTH_ST_OPEN;
update_auth_session_timers(x, msg);
- //LM_INFO("state machine: i was in open
and i am going to open\n");
+ //LM_INFO("state machine: I was in open
and I am going to open\n");
I thin we can remove this commented code
> break;
case AUTH_EV_RECV_ANS_UNSUCCESS:
x->state = AUTH_ST_DISCON;
- //LM_INFO("state machine: i was in open
and i am going to discon\n");
+ //LM_INFO("state machine: I was in open
and I am going to discon\n");
same as above. remove the commented code
> break;
case AUTH_EV_SESSION_TIMEOUT:
case AUTH_EV_SERVICE_TERMINATED:
case AUTH_EV_SESSION_GRACE_TIMEOUT:
x->state = AUTH_ST_DISCON;
- //LM_INFO("state machine: i was in open
and i am going to discon\n");
+ //LM_INFO("state machine: I was in open
and I am going to discon\n");
same as above
>
Send_STR(s, msg);
break;
case AUTH_EV_SEND_ASA_SUCCESS:
x->state = AUTH_ST_DISCON;
- //LM_INFO("state machine: i was in open
and i am going to discon\n");
+ //LM_INFO("state machine: I was in open
and I am going to discon\n");
same as above
> Send_STR(s, msg);
break;
case AUTH_EV_SEND_ASA_UNSUCCESS:
x->state = AUTH_ST_OPEN;
update_auth_session_timers(x, msg);
- //LM_INFO("state machine: i was in open
and i am going to open\n");
+ //LM_INFO("state machine: I was in open
and I am going to open\n");
remove commented code
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3914#pullrequestreview-2176445533
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_registrar_pcscf,ims_qos: support for trusting bottom via (PR #3901)
@herlesupreeth approved this pull request. Looks good to me -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3901#pullrequestreview-2161807430 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] misc/examples/ims/icscf: fix bad prefix added on all incoming requests (PR #3900)
@herlesupreeth approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3900#pullrequestreview-2153156454 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: drop subscription on notification failure (PR #3895)
@herlesupreeth approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3895#pullrequestreview-2151236217 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: drop subscription on notification failure (PR #3895)
@herlesupreeth commented on this pull request.
> tmb.t_request_within(&uac_r);
}
- if(h.s)
- pkg_free(h.s);
- if(content.s) {
- pkg_free(content.s);
+ watcher_contact = 0;
isnt this leaking memory here?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3895#pullrequestreview-2150049374
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_registrar_scscf: fix for location AOR with empty host (PR #3897)
@herlesupreeth commented on this pull request. Looks good to me. Thanks for the fix. Have you tested this PR with URI without host part? If so, how did the S-CSCF react? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3897#pullrequestreview-2150047549 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)
@herlesupreeth commented on this pull request. > && (ignore_contact_rxport_check - || (c->received_port == _m->rcv.src_port) > My opinion is that in IMS the IPsec SA is negotiated for all transport > protocols (so in practice UDP and TCP), hence if a UE managed to correctly > encrypt whatever UDP/TCP packet correctly and send it to us on the correct > Security-Association flows, we should allow it. I agree -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3891#discussion_r1652761243 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)
@herlesupreeth commented on this pull request. > && (ignore_contact_rxport_check - || (c->received_port == _m->rcv.src_port) I am not sure about this change.. why was the check for SIP message received source port removed? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3891#pullrequestreview-2135876698 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)
Thanks again!! Here are my further comments. Sorry for nitpicking, but here is my two cents, I would probably issue a PR addressing the `List of non-functional fixes:` mentioned above first and keep the implementation of `trust_bottom_via` in another PR so that its easier to review and rollback if we face issues at a later point. There are some doubts related to some of the changes in this PR which I will raise shortly -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3891#issuecomment-2186616483 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)
Thanks for the explanation.
> I'm actually offloading the IPsec work to an external entity, which
> guarantees that the bottom Via is not spoofed. So I'm adding an optional
> "trust-the-bottom-Via" flag.
I didnt understand what you mean by offloading the IPsec work to an external
entity. You mean IPSec creation is done by other entity (other than
ims_ipsec_pcscf module)?
Also, the naming "trust-the-bottom-Via" doesnt go well in my opinion
("bottom-via" part I mean). While handling SIP REQUEST the first Via needs to
be considered and in case SIP REPLY I think last Via needs to be considered
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3891#issuecomment-2186500019
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] [WIP] ims_registrar_pcscf,ims_qos: added a parameter for trusting the bottom Via header on requests (PR #3891)
Hey @vingarzan > Normally, the IMS P-CSCF should identify the clients (UEs) by the received IP > address and ports on Rx Can you please point me to a specification where it states this? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3891#issuecomment-2186343680 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:d17b97a8: ims_registrar_pcscf: fix typo in comments
Module: kamailio
Branch: master
Commit: d17b97a864585782e03eedada6d226550630f7bb
URL:
https://github.com/kamailio/kamailio/commit/d17b97a864585782e03eedada6d226550630f7bb
Author: herlesupreeth
Committer: Supreeth Herle
Date: 2024-06-17T13:37:12+02:00
ims_registrar_pcscf: fix typo in comments
---
Modified: src/modules/ims_registrar_pcscf/save.c
---
Diff:
https://github.com/kamailio/kamailio/commit/d17b97a864585782e03eedada6d226550630f7bb.diff
Patch:
https://github.com/kamailio/kamailio/commit/d17b97a864585782e03eedada6d226550630f7bb.patch
---
diff --git a/src/modules/ims_registrar_pcscf/save.c
b/src/modules/ims_registrar_pcscf/save.c
index 679abc99ca5..025cb78a5d8 100644
--- a/src/modules/ims_registrar_pcscf/save.c
+++ b/src/modules/ims_registrar_pcscf/save.c
@@ -289,7 +289,7 @@ static inline int update_contacts(struct sip_msg *req,
struct sip_msg *rpl,
LM_DBG("Error
subscribing for contact\n");
}
- // After successful
registration try to unregister all callbacks for pending contacts ralated to
this contact.
+ // After successful
registration try to unregister all callbacks for pending contacts related to
this contact.
ul.unreg_pending_contacts_cb(
_d,
pcontact, PCSCF_CONTACT_EXPIRE);
}
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:bf863877: ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact
Module: kamailio
Branch: master
Commit: bf863877f666dd8350e855bf933270b2fd8ad0fd
URL:
https://github.com/kamailio/kamailio/commit/bf863877f666dd8350e855bf933270b2fd8ad0fd
Author: herlesupreeth
Committer: Supreeth Herle
Date: 2024-06-17T13:37:12+02:00
ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact
---
Modified: src/modules/ims_ipsec_pcscf/cmd.c
---
Diff:
https://github.com/kamailio/kamailio/commit/bf863877f666dd8350e855bf933270b2fd8ad0fd.diff
Patch:
https://github.com/kamailio/kamailio/commit/bf863877f666dd8350e855bf933270b2fd8ad0fd.patch
---
diff --git a/src/modules/ims_ipsec_pcscf/cmd.c
b/src/modules/ims_ipsec_pcscf/cmd.c
index 05079834252..3ce36d27952 100644
--- a/src/modules/ims_ipsec_pcscf/cmd.c
+++ b/src/modules/ims_ipsec_pcscf/cmd.c
@@ -900,12 +900,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int
_cflags)
goto cleanup;
}
- if(ul.update_pcontact(d, &ci, pcontact) != 0) {
- LM_ERR("Error updating contact\n");
- goto cleanup;
- }
-
if(ci.via_port == SIP_PORT) {
+ if(req_sec_params != NULL) {
+ pcontact->security_temp->data.ipsec = s;
+ }
// Update temp security parameters
if(ul.update_temp_security(d, pcontact->security_temp->type,
pcontact->security_temp, pcontact)
@@ -914,6 +912,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int
_cflags)
}
}
+ if(ul.update_pcontact(d, &ci, pcontact) != 0) {
+ LM_ERR("Error updating contact\n");
+ goto cleanup;
+ }
if(add_supported_secagree_header(m) != 0) {
goto cleanup;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Fix handling of pending reg contacts in P-CSCF (PR #3869)
Merged #3869 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3869#event-13184396732 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Fix handling of pending reg contacts in P-CSCF (PR #3869)
@miconda Do I merge it or will you/others will be merging it? If I am merging it, do I have to squash and merge or rebase and merge ? Thanks -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3869#issuecomment-2173101600 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Mem leak in smsops which leads to the udp receiver process leak memory continuously (Issue #3833)
@paresh-panda can you give this commit (https://github.com/kamailio/kamailio/commit/eccff1738ef074aa9fae08e4b10c851e12e04d39) a try and see if you still face the memory issue? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3833#issuecomment-2152263850 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Fix handling of pending reg contacts in P-CSCF (PR #3869)
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3869 -- Commit Summary -- * ims_registrar_pcscf: fix typo in comments * ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (12) M src/modules/ims_registrar_pcscf/save.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3869.patch https://github.com/kamailio/kamailio/pull/3869.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3869 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Fix handling of pending reg contacts in P-CSCF (PR #3868)
Closed #3868. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3868#event-13046729455 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Fix handling of pending reg contacts in P-CSCF (PR #3868)
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3868 -- Commit Summary -- * Revert "ims_registrar_pcscf: update registered state to pending registration if contact exists" * ims_registrar_pcscf: fix typo in comments * ims_ipsec_pcscf: update security params of newly created ipsec tunnel in contact -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (12) M src/modules/ims_registrar_pcscf/save.c (13) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3868.patch https://github.com/kamailio/kamailio/pull/3868.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3868 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Discrepancies in migration of commits from herlesupreeth/kamailio to upstream (Issue #3772)
Thank you @axelsommerfeldt -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3772#issuecomment-1986863239 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Discrepancies in migration of commits from herlesupreeth/kamailio to upstream (Issue #3772)
> For point 2, you are right that the part in fill_contact() are missing
I had another look at the code and i think the changes may not be needed since
the contact information would definitely be present as the below code in
kamailio master ensures it
```
memset(&tmsg, 0, sizeof(sip_msg_t));
tmsg.buf = tbuf;
memcpy(tmsg.buf, t->uas.request->buf, t->uas.request->len);
tmsg.buf[t->uas.request->len] = '\0';
tmsg.len = t->uas.request->len;
if(parse_msg(tmsg.buf, tmsg.len, &tmsg) != 0) {
LM_ERR("buffer parsing failed!");
goto error;
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3772#issuecomment-1973447101
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Discrepancies in migration of commits from herlesupreeth/kamailio to upstream (Issue #3772)
Thanks @axelsommerfeldt for taking time to compare the changes. For point 1, I think its fine because I have not seen any COTS UE using TLS but for completeness, yes we can add it For point 2, you are right that the part in fill_contact() are missing but regarding the changes under ipsec_forward() I am not sure whether they are relevant since that function got changed in several commits. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3772#issuecomment-1973415656 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] Fixes related to contact updation and searching in P-CSCF modules (PR #3771)
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3771 -- Commit Summary -- * ims_usrloc: make matching of username in contact conditional * ims_registrar_pcscf: update registered state to pending registration if contact exists -- File Changes -- M src/modules/ims_registrar_pcscf/save.c (11) M src/modules/ims_usrloc_pcscf/udomain.c (58) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3771.patch https://github.com/kamailio/kamailio/pull/3771.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3771 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] cdp: add destination realm avp only if not present (PR #3692)
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description This PR fixes duplicate "Destination-Realm" AVP being added to Session Termination Request Diameter message sent over Rx interface You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3692 -- Commit Summary -- * cdp: add destination realm avp only if not present -- File Changes -- M src/modules/cdp/authstatemachine.c (32) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3692.patch https://github.com/kamailio/kamailio/pull/3692.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3692 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] cdp: fix disabled parts for openssl version newer than 1.1.0 (PR #3691)
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description This PR fixes the disabled parts of the TLS code in cdp module which resulted in getting an error (**undefined symbol init_ssl_methods**) whenever cdp module was loaded and following openssl version was used. ``` openssl version OpenSSL 1.1.1f 31 Mar 2020 ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3691 -- Commit Summary -- * cdp: fix disabled parts for openssl version newer than 1.1.0 -- File Changes -- M src/modules/cdp/cdp_tls.c (18) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3691.patch https://github.com/kamailio/kamailio/pull/3691.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3691 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] smsops: fix utf8 to ucs2 conversion (PR #3690)
Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Fixes the conversion fro UTF-8 to UCS-2 conversion when SMS is sent with emojis You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3690 -- Commit Summary -- * smsops: fix utf8 to ucs2 conversion -- File Changes -- M src/modules/smsops/smsops_impl.c (10) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3690.patch https://github.com/kamailio/kamailio/pull/3690.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3690 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_ipsec_pcscf: reset destination URI after value is used to decide … (PR #3689)
@herlesupreeth pushed 1 commit. 655fc0745965a1a6a10319be411535d583433baf ims_ipsec_pcscf: reset destination URI after value is used to decide destination protocol to use -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3689/files/c84c1e0b4dd5cde264854df4977cf15ac8cd3bde..655fc0745965a1a6a10319be411535d583433baf You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_ipsec_pcscf: reset destination URI after value is used to decide … (PR #3689)
Looks like CI is failing due to some missing module (auth_identity), which is not part of my merge request. Can someone please take a look? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3689#issuecomment-1868527851 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] ims_ipsec_pcscf: reset destination URI after value is used to decide … (PR #3689)
…destination protocol to use Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description This commits rearrange the place where destination URI was resetted. This was needed because the value was used to decide destination protocol to use. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3689 -- Commit Summary -- * ims_ipsec_pcscf: reset destination URI after value is used to decide destination protocol to use -- File Changes -- M src/modules/ims_ipsec_pcscf/cmd.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3689.patch https://github.com/kamailio/kamailio/pull/3689.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3689 You are receiving this because you are subscribed to this thread. Message ID:___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
