[sr-dev] [kamailio/kamailio] tm: T_ASYNC_SUSPENDED flag not removed when cancelling a suspension (PR #3629)
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Ive been testing the ims_charging module which relies on a diameter request and async reply. If theres no available diameter server, Ro_CCR() calls t_cancel_suspend() to cancel suspension of the transaction and return an error. Based on my understanding, it should now be possible to continue script logic as if the transaction was not suspended at all. In our case we want the call to go through anyway, as a fallback. The INVITE is being sent to the destination, but all replies are filtered since the suspended flag is still set. Tested this change locally, and its now working according to our needs. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3629 -- Commit Summary -- * tm: T_ASYNC_SUSPENDED flag not removed when cancelling a suspension -- File Changes -- M src/modules/tm/t_suspend.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3629.patch https://github.com/kamailio/kamailio/pull/3629.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3629 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] ims_charging: Implemented restore of Ro sessions from database (PR #3622)
- realtime and shutdown mode support - removed duplicate entry in doc about ro_auth_expiry - RO_TABLE_VERSION constant did not match inserted value in db schema !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Fixed the module so it also use information written to database to restore Ro sessions on startup/restart. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3622 -- Commit Summary -- * ims_charging: Implemented restore of Ro sessions from database -- File Changes -- M src/modules/ims_charging/dialog.c (6) M src/modules/ims_charging/doc/ims_charging_admin.xml (21) M src/modules/ims_charging/ims_charging_mod.c (15) M src/modules/ims_charging/ims_ro.c (2) M src/modules/ims_charging/ro_db_handler.c (444) M src/modules/ims_charging/ro_db_handler.h (11) M src/modules/ims_charging/ro_timer.c (2) M utils/kamctl/mysql/ims_charging-create.sql (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3622.patch https://github.com/kamailio/kamailio/pull/3622.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3622 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)
Sorry - closed by mistake. Reopened. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#issuecomment-1778680443 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)
There's a big "#if OPENSSL_VERSION_NUMBER >= 0x1010L" in cdp_tls.c, basically making the whole file empty for older versions. sp->tls_conn would never be true in do_read() and do_write() if there was no supported openssl, so I didn't find any need to change those functions - until your mod yesterday which included a function defined in cdp_tls.c :) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#issuecomment-1778672445 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)
Reopened #3616. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#event-10763326569 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)
Closed #3616. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616#event-10763322155 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)
This was originaly fixed in #3601, but that did not handle the change in #3612 very well. !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Fix for undefined symbols when using older/unsupported OpenSSL. This was originaly fixed in #3601, but that did not handle the change in #3612 very well. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3616 -- Commit Summary -- * cdp: Fix for undefined symbols when using older/unsupported OpenSSL -- File Changes -- M src/modules/cdp/receiver.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3616.patch https://github.com/kamailio/kamailio/pull/3616.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] ims_dialog: Add function to get dialog by hash entry and id (PR #3613)
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Add function to get dialog by internal hash entry and id. This is needed by my other ongoing changes to the ims_charging module for restoring records from database. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3613 -- Commit Summary -- * ims_dialog: Add function to get dialog by hash entry and id -- File Changes -- M src/modules/ims_dialog/dlg_handlers.c (19) M src/modules/ims_dialog/dlg_handlers.h (8) M src/modules/ims_dialog/dlg_load.h (5) M src/modules/ims_dialog/ims_dialog.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3613.patch https://github.com/kamailio/kamailio/pull/3613.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3613 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)
My plan is to have this merged and then continue working on db operations for the ims_charging module. I just wanted to have this completed first, since the other part will not work without it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603#issuecomment-1770933526 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)
Like I wrote in the ticket related to this task, most of the stuff was there
already - but it both caused a crash and was not fully functional. Entries were
being written to the database, but was not restored correctly on startup.
I assume the old dialog module was used as a basis and that the code for db
operations was not finalized with the new structure.
The missing delete was probably a result of that, since this new module got two
tables ("in" and "out") compared to only one in the old module.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3603#issuecomment-1770930515
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)
Seems like there's some issue with the CodeQL Analyzer (runner image out of disk space)? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603#issuecomment-1761472985 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3602 Description Added missing code for database backend to work. Tested basic scenarios locally for all db modes. DB schema could be tweaked according to my thoughts in issue #3602, but that also applies to several other modules which are done in the same matter. Because of that, I didnt consider such a change now. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3603 -- Commit Summary -- * ims_dialog: Add support for database backend -- File Changes -- M src/modules/ims_dialog/dlg_db_handler.c (9) M src/modules/ims_dialog/dlg_handlers.c (52) M src/modules/ims_dialog/dlg_hash.c (5) M src/modules/ims_dialog/doc/ims_dialog_admin.xml (93) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3603.patch https://github.com/kamailio/kamailio/pull/3603.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] ims_dialog: Support for db storage (Issue #3602)
### Description
I've been looking at the ims_dialog module and notice that the documentation
states that db storage is not yet supported.
According to the source code that only partial true. Not sure if it's residues
from the other dialog module, or some unfinished work.
After some initial testing and small adjustments, the main issue seems to that
for my use the "Dialog-iD"/did is not filled. I can not see this being set for
calls that are not "concurrently confirmed".
The field in the database for this id is NON NULL, so the insert fails. It's
also used as WHERE-criteria when restarting and fetching the dialog_out
entries, belonging to each dialog_in, so it needs to be set for this to work.
This is not really a feature request. It's more about a confirmation that my
assumptions are correct, before trying to do the proposed changes.
### Expected behavior
I do assume that this "did"-field should be or be linked to the same did added
as Record-Route parameter, identifying each dialog.
Actual observed behavior
kamcmd dlg2.list displays NULL for Dialog-ID.
```
kamcmd dlg2.list
{
Size: 4096
Dialogs: {
Dialog: {
Entry: 1096
Id: 8069
RURI: sip:+4791500025@10.111.64.16;user=phone
From: sip:+4746180445@10.111.64.16;user=phone
Call-ID:
34c5d9f15ff42a0564f809cb35e19c75@10.111.64.16:5060
Caller Contact: sip:+4746180445@10.111.64.16:5060
Caller Route Set:
Dialog-ID:
From Tag: as4df55540
State: Confirmed
Ref: 2
dlg_outs: {
dlg_out: {
Entry: 2680
Id: 0
}
}
}
}
}
```
### Possible Solutions
Always set this did field when a new dialog is created.
I've also been studying the DB schema. All operations for the dialog_in table
are done using hash_entry and hash_id as keys. Why are they not used as primary
key instead, which would be much more efficient?
Also, having an integer with auto_increment as primary key would make this stop
when the integer hits max value, if it's not reset regularly. I can not see
this field used anywhere in the code either, so it could probably just be
removed.
The same applies to dialog_out, but this one should have an index on the did
field used for looking up the corresponding entries too.
Altering this could have negative impact if there are old entries from a
previous running process laying around. A duplicate key on an insert should be
handled, and updated instead. The current behaviour would mean that Kamailio
instead updates two records with the same values.
### Additional Information
* **Kamailio Version** - output of `kamailio -v`
```
master
```
* **Operating System**:
```
CentOS 7.9
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3602
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: Disable TLS support for openssl versions older than 1.1.0 (PR #3601)
I fixed the errors report by check-format in a new commit, but it stills seems to be marked as failed because of the first one. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3601#issuecomment-1757450838 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: Disable TLS support for openssl versions older than 1.1.0 (PR #3601)
@mtryfoss pushed 1 commit. 841d774dc1670987a6610ae1fe8f70b7b045f5d2 cdp: changed format -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3601/files/6bd5c508bb536efb516a608ffbcbd11f8e6dba89..841d774dc1670987a6610ae1fe8f70b7b045f5d2 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] cdp: Not possible to load module with older openssl version than 1.1.0 (Issue #3600)
PR created. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3600#issuecomment-1757373110 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] cdp: Disable TLS support for openssl versions older than 1.1.0 (PR #3601)
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3600 Description Disabled parts of code if installed openssl version is older than 1.1.0 based on feedback in issue #3600. Tested non-TLS connection locally. Not tested with TLS. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3601 -- Commit Summary -- * cdp: Disable TLS support for openssl versions older than 1.1.0 -- File Changes -- M src/modules/cdp/cdp_mod.c (7) M src/modules/cdp/cdp_tls.c (2) M src/modules/cdp/receiver.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3601.patch https://github.com/kamailio/kamailio/pull/3601.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3601 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] cdp: Not possible to load module with older openssl version than 1.1.1 (Issue #3600)
### Description After adding TLS support to the CDP module, it's no longer possible to load on systems running a version of openssl older than 1.1.1. Reproduction Run on system with openssl older than 1.1.1. Log Messages ``` ERROR: [core/sr_module.c:599]: ksr_load_module(): could not open module : /usr/local/kamailio-devel/lib64/kamailio/modules/cdp.so: undefined symbol: SSL_CTX_set_max_proto_version ``` ### Possible Solutions I've made a local change based on the approach used in the tls module for different versions of openssl. Do you want me to open a PR for this, or do you want this module clean? Currently I do not have any possibility to test it's actually working, but at least it compiles/loads and makes to module possible to use without encryption. Another solution might be to just include TLS support if the openssl version on the system is 1.1.1 or newer. Else, just do not support it. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` master ``` * **Operating System**: ``` CentOS 7.9 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3600 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] smsops: avoid c99 error (PR #3597)
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Small adjustment to avoid C99 error from older compiler. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3597 -- Commit Summary -- * smsops: avoid c99 error -- File Changes -- M src/modules/smsops/smsops_impl.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3597.patch https://github.com/kamailio/kamailio/pull/3597.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3597 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
