[sr-dev] Re: [kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

[ovoshlook]

Hi 
I think,  I just forgot to update this part of the doc.
It should be working fine for any connection type and yes. It should be only a 
debug-level message

But feel free to test it and let us know if something is wrong.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2206#issuecomment-1490421048
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] [kamailio/kamailio] uac: allow uac_auth* functions call from t_on_branch_failure event route (PR #3360)

[ovoshlook]

!-- Kamailio Pull Request Template --

!--
IMPORTANT:
  - for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
  - backports to stable branches must be done with git cherry-pick -x 
...
  - code is contributed under BSD for core and main components (tm, sl, auth, 
tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
--

 Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
!-- Go over all points below, and after creating the PR, tick the 
checkboxes that apply --
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue # (replace  with an open issue number)

 Description
Adds the possibility to call uac_auth* functions from the t_branch_on_failure 
event route
Useful in case of MID_REGISTRAR implementation, especially when REGISTER forked 
to multiple registrars and each one requests authentication requests separately 
Result example:
![image](https://user-images.githubusercontent.com/8499399/216847091-17f8b9f0-1a08-47d1-89ee-978007cef36b.png)




You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3360

-- Commit Summary --

  * uac: allow uac_auth* functions call from t_on_branch_failure event route

-- File Changes --

M src/modules/uac/doc/uac_admin.xml (4)
M src/modules/uac/uac.c (9)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3360.patch
https://github.com/kamailio/kamailio/pull/3360.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3360
You are receiving this because you are subscribed to this thread.

Message ID: kamailio/kamailio/pull/3...@github.com
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

Re: [sr-dev] [kamailio/kamailio] uac: contact_addr field added into db uacreg table (#2470)

[ovoshlook]

@ovoshlook pushed 1 commit.

b3f6e23280e72d790293b80ee752abd0079b7488  revert accidentaly removed empty 
lines and other formatting


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2470/files/9fbed998e03935193c05186325c188271a9f686e..b3f6e23280e72d790293b80ee752abd0079b7488
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] uac: contact_addr field added into db uacreg table (#2470)

[ovoshlook]

yes indeed
copied description from the socket field and forgot to remove "proto:" part

generated db with the dbschema script as  well

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2470#issuecomment-688186828___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] uac: contact_addr field added into db uacreg table (#2470)

[ovoshlook]

@ovoshlook pushed 2 commits.

ea36cddcb37e88488979c25ce477670f8483168a  dbschema updated
9fbed998e03935193c05186325c188271a9f686e  updated vie make dbschema


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2470/files/a1bde17266e7c75b6bd94c9232ce99b5cde9f22a..9fbed998e03935193c05186325c188271a9f686e
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] uac: contact_addr field added into db uacreg table (#2470)

[ovoshlook]

@ovoshlook pushed 1 commit.

a1bde17266e7c75b6bd94c9232ce99b5cde9f22a  fixed description of the contact_addr


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2470/files/16dce04ba2adfc9eeb9e82b7bcbb4962eccb8dcf..a1bde17266e7c75b6bd94c9232ce99b5cde9f22a
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] uac: contact_addr field added into db uacreg table (#2470)

[ovoshlook]

 Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, 
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally


 Description
Allows to pass unique address part into contact header for REGISTER requests 
for each uacreg entry
If contact_addr wasnt passed into uacreg for a particular entry default 
reg_contact_addr will be used instead.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2470

-- Commit Summary --

  * uacreg contact_addr added into db as configrable parameter for each entry
  * docs generated
  * formatting
  * Merge branch uacreg-contact_addr-field-in-db of 
https://github.com/ovoshlook/kamailio into uacreg-contact_addr-field-in-db
  * reverted readme
  * formatting
  * formatting

-- File Changes --

M src/modules/uac/doc/uac_admin.xml (11)
M src/modules/uac/uac_reg.c (43)
M src/modules/uac/uac_reg.h (2)
M utils/kamctl/db_berkeley/kamailio/uacreg (4)
M utils/kamctl/db_berkeley/kamailio/version (2)
M utils/kamctl/db_redis/kamailio/uacreg (2)
M utils/kamctl/db_sqlite/uac-create.sql (3)
M utils/kamctl/dbtext/kamailio/uacreg (2)
M utils/kamctl/mongodb/kamailio/uacreg.json (7)
M utils/kamctl/mysql/uac-create.sql (3)
M utils/kamctl/oracle/uac-create.sql (3)
M utils/kamctl/postgres/uac-create.sql (3)
M utils/kamctl/xhttp_pi/uac-mod (3)
M utils/kamctl/xhttp_pi/uac-table (1)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2470.patch
https://github.com/kamailio/kamailio/pull/2470.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2470
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

[ovoshlook]

tested - works fine. IS it possible to push it into 5.3.x branch as well? I 
know there more changes in the tcp_main a 5.4.0
I can prepare PR for 5.3 branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2206#issuecomment-584062282___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] sanity: use debug log level when content length header is missing (#2211)

[ovoshlook]

But WARNING looks correct behaviour because of 
[RFC](https://tools.ietf.org/html/rfc3261#page-169) specifications of 
content-length header, why it should be changed to DBG?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2211#issuecomment-581430456___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

[ovoshlook]

@ovoshlook pushed 1 commit.

55fa4da56f03839726762b5668c945ebd35ca9c5  core:tcp shwitched back to LM_ERR 
level for invalid PROXY header message


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2206/files/8918bd7657dde20325e368f928eeb31801b425d6..55fa4da56f03839726762b5668c945ebd35ca9c5
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

[ovoshlook]

Covers setups when kamailio behind the service with HAPROXY protocol support 
but in other hand it also serves requests from other services that available 
per direct connection (such as B2BUA in the same local network).

 Pre-Submission Checklist
- [*] Commit message has the format required by CONTRIBUTING guide
- [*] Commits are split per component (core, individual modules, libs, utils, 
...)
- [*] Each component has a single commit (if not, squash them into one commit)
- [*] No commits to README files for modules (changes must be done to docbook 
files
in `doc/` subfolder, the README file is autogenerated)

 Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [*] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

 Checklist:
- [*] PR should be backported to stable branches
- [*] Tested changes locally

 Description
- function tcpconn_read_haproxy() returns 2 if PROXY header NOT found. 
- Message about no header shown at the debug level.
- No errors
- TCP connection successfully establishes


You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2206

-- Commit Summary --

  * handle tcp request with tcp_accept_haproxy even no PROXY header found
  * core:tcp allow to handle TCP connections even message does not contain 
PROXY protocol header
  * core:tcp allow to handle TCP connections even message does not contain 
PROXY protocol header

-- File Changes --

M src/core/tcp_main.c (8)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2206.patch
https://github.com/kamailio/kamailio/pull/2206.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2206
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] jsonrpcs_exec for the rtpengine cache gives memory leak (#1778)

[ovoshlook]

Closed #1778.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1778#event-2043227523___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] jsonrpcs_exec for the rtpengine cache gives memory leak (#1778)

[ovoshlook]

found reason
It was about 
rtpeninge.rtp.manage()
we did not expect behavior that if not call manage for the BYE request - it 
will keep something in the memory of the kamailio

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1778#issuecomment-449750541___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] jsonrpcs_exec for the rtpengine cache gives memory leak (#1778)

[ovoshlook]

### Description


We are buidling some kind of our own rtpengine dispatcher based on our own 
algorithm using kemi Lua.

In one of the functions we are calling:

`local reqBody = function(command, params)

return json.encode({
jsonrpc = "2.0",
method = "rtpengine." .. command,
params = params
})

end

KSR.jsonrpcs.exec(reqBody("show", { "all" }))
local data = json.decode(KSR.pv.get("$jsonrpl(body)"))
`
And watching **free_mem** decrasing in case of  every call of this function

If we are commenting this - nothing happens

P.S. We are doing the same for the dispatcher module but did not find memory 
leak for it:

`local reqBody = function (command,params)

return  json.encode( { 
jsonrpc = "2.0", 
method  = "dispatcher." ..command, 
params  = params 
} )

end

KSR.jsonrpcs.exec(reqBody( "list" ) )
local data = json.decode( KSR.pv.get("$jsonrpl(body)") )
` 
### Troubleshooting

 Reproduction

To reproduce this issue suppose will be enough to call code above
 Debugging Data

test results for 1 calls total/300 per second (sipp based)

memory stats on the start

shmem:fragments = 2 |  
shmem:free_size = 63131408 
shmem:max_used_size = 3994704 
shmem:real_used_size = 3977456 
shmem:total_size = 67108864
shmem:used_size = 3205144

memory stats on the end

shmem:fragments = 5 |  
shmem:free_size = 60106232 
shmem:max_used_size = 7019952 
shmem:real_used_size = 7002632
shmem:total_size = 67108864
shmem:used_size = 4150008



### Additional Information

  * **Kamailio Version** - output of `kamailio -v`

```
version: kamailio 5.1.6 (x86_64/linux) 7d1964
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, 
DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, 
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, 
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, 
BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 7d1964
compiled on 03:23:23 Oct  5 2018 with gcc 6.3.0
```

* **Operating System**:



```
1 machine: SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux
2 machine: SMP Debian 4.9.110-3+deb9u2 (2018-08-13) x86_64 GNU/Linux
```
If will need any additional info just let me know
P.S. We also tried to find what can give this behavior on the rtpengine.c but 
didn't figured out yet

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1778___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] JSONRPCS replacing keys in params gives unexpected behaivor (#1550)

[ovoshlook]

Hi
Using kamailio with http jsonrpcs
found next trouble

When i making request like

curl -s -H 'Content-Type: application/json' --data-binary 
'{"method":"htable.get","params":{**"name":"mytable"**,"key":"myparam"},"jsonrpc":"2.0"}'
 http://127.0.0.1:5060/jsonrpc

all fine. I getting good response

But when I making
curl -s -H 'Content-Type: application/json' --data-binary 
'{"method":"htable.get","params":{"key":"myparam",**"name":"mytable"**},"jsonrpc":"2.0"}'
 http://127.0.0.1:5060/jsonrpc
i.e keys of object on different places

It gives me 

curl -s -H 'Content-Type: application/json' --data-binary '{"jsonrpc":"2.0", 
"method": "htable.get","params":{"key":"mykey","name": "mytable"}}' 
http://127.0.0.1:5060/jsonrpc
{
"jsonrpc":  "2.0",
"error":{
"code": 500,
"message":  "No such htable"
}
}

Means kamailio cant find needed htable

I supposed that position of the key should't have a matter for the JSON objects 
parsers
But here is looks like different

May be it is not a bug bug feature request because of it is just an unexpected 
behaivor

Im using kamailio 5.1.3 on the Debian 9

version: kamailio 5.1.3 (x86_64/linux)
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, 
USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, 
TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, 
USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled on 00:25:48 May  9 2018 with gcc 6.3.0


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1550___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] KSR.xhttp.xhttp_reply wrong code (#1544)

[ovoshlook]

Closed #1544.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1544#event-1646316177___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] KSR.xhttp.xhttp_reply wrong code (#1544)

[ovoshlook]

Yep fixed
For now responses are valid

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1544#issuecomment-392009516___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] KSR.xhttp.xhttp_reply wrong code (#1544)

[ovoshlook]

Sure
I will write here in a couple of hours

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1544#issuecomment-392002067___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] KSR.xhttp.xhttp_reply code cant understand type (#1544)

[ovoshlook]

Hi. 
I'm building small HTTP API using kemi lua on kamailio 5.1
version:

kamailio -v
version: kamailio 5.1.2 (x86_64/linux)
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, 
USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, 
TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, 
USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled on 18:16:53 Apr  7 2018 with gcc 4.8.5

On the system
Linux CentOS-74-64-minimal 3.10.0-693.17.1.el7.x86_64 #1 SMP Thu Jan 25 
20:13:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

When i sending xhttp_reply I getting wrong code that kamailio sends to the 
client instead of code I use
Im used as this exmaple as template
int xhttp_reply(int code, str "reason", str "ctype", str "body")
as classic (with code in string)

`KSR.xhttp.xhttp_reply("200", "OK", application/json, "")`

So in both cases I getting next trouble:

When i trying to set params to the xhttp_reply i getting this in the log (on 
debug layer)

DEBUG: app_lua [app_lua_sr.c:1500]: sr_kemi_lua_exec_func_ex(): param[0] for: 
xhttp_reply is int: 200
DEBUG: app_lua [app_lua_sr.c:1496]: sr_kemi_lua_exec_func_ex(): param[1] for: 
xhttp_reply is str: OK
DEBUG: app_lua [app_lua_sr.c:1496]: sr_kemi_lua_exec_func_ex(): param[2] for: 
xhttp_reply is str: application/json

but next string I shows
DEBUG: xhttp [xhttp_mod.c:443]: xhttp_send_reply(): sending out response: 
161110576 OK

This first 3 digits at the reslonse I see 
**161** 110576

Digits are random, as positive as negative (with "-" at the start)




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1544___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Double SPACE after in the VIA WSS (#1491)

[ovoshlook]

Yep
Looks like 
advertised_address="​1.2.3.4"​ was a trouble
sorry for wasting your time

Strange artefact of my working environment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1491#issuecomment-377981987___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Double SPACE after in the VIA WSS (#1491)

[ovoshlook]

Hi THx for response
listen=udp:10.1.1.38:5060 advertise 1.2.3.4:5060
listen=tcp:10.1.1.38:5060 advertise 1.2.3.4:5060
listen=tls:10.1.1.38:5061 advertise 1.2.3.4:5061
advertised_address="​1.2.3.4"​
So this is only 1 SPACE

 kamctl srv sockets
list listen sockets

Gives empty output

(started as kamctl start)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1491#issuecomment-377958157___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] Double SPACE after in the VIA WSS (#1491)

[ovoshlook]

### Description

Hi. Seems lime that after WSS in the VIA kamailio adds double SPACE
It makes kamailio incompatable with jssip.net (tried 5.1.2 and 5.0.6 versions) 

Looks like this happens with advertise address added on the interface

 Reproduction

Just connect to kamailio via WSS with advertized address and try to make 
incoming call into WSS client

 Debugging Data

I just put this link to JsSIP.net here
https://groups.google.com/forum/#!topic/jssip/2lDyqgvZgrY

Also here is a string of my VIA header that gives issue

SIP/2.0/WSS ​1.2.3.4:5061;branch=z9hG4bKd302.4c862421515641e7b59b9f3ba7f8eab4.1
Thant can be checked here
https://www.textmagic.com/free-tools/unicode-detector

Log INVITE from the browser (only added \r\n at the end of the each string 
because of notepad++ not shows it after copying):

INVITE sip:2hsq8ob4@daotd6p7hil4.invalid;transport=ws SIP/2.0\r\n
Record-Route: 
\r\n
Record-Route: \r\n
Via: SIP/2.0/WSS 
​1.2.3.4:5061;branch=z9hG4bK110e.476a7e8aa7db8de3a4d7b01aed1e7ef5.1\r\n
Via: SIP/2.0/UDP 10.1.1.138:5060;rport=5060;branch=z9hG4bK7122bcfb\r\n
Max-Forwards: 69\r\n
From: "test" ;tag=as7c4d457d\r\n
To: \r\n
Contact: \r\n
Call-ID: 2ec6d77f5a56ca0f59ab0d2118d2f7d5@10.1.1.138:5060\r\n
CSeq: 102 INVITE\r\n
User-Agent: Asterisk PBX 15.3.0\r\n
Date: Mon, 02 Apr 2018 10:30:57 GMT\r\n
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, 
PUBLISH, MESSAGE\r\n
Supported: replaces, timer\r\n
Content-Type: application/sdp\r\n
Content-Length: 642\r\n
\r\n
v=0\r\n
o=root 1538180518 1538180518 IN IP4 1.2.3.4\r\n
s=Asterisk PBX 15.3.0\r\n
c=IN IP4 1.2.3.4\r\n
t=0 0\r\n
a=group:BUNDLE audio\r\n
m=audio 31858 RTP/SAVPF 8 0 101\r\n
a=maxptime:150\r\n
a=rtpmap:8 PCMA/8000\r\n
a=rtpmap:0 PCMU/8000\r\n
a=rtpmap:101 telephone-event/8000\r\n
a=fmtp:101 0-16\r\n
a=sendrecv\r\n
a=rtcp:31859\r\n
a=rtcp-mux\r\n
a=setup:actpass\r\n
a=mid:audio\r\n
a=fingerprint:sha-1 
95:6F:40:F2:76:B3:E3:1E:DA:29:04:60:F1:F7:0A:DA:5E:D4:67:9F\r\n
a=ice-ufrag:eSuU9ztd\r\n
a=ice-pwd:j693abw9QWiaX81TlbvyHBD8FU\r\n
a=candidate:5Qp8pvPCHLmm6iUU 1 UDP 2130706431 1.2.3.4 31858 typ host\r\n
a=candidate:5Qp8pvPCHLmm6iUU 2 UDP 2130706430 1.2.3.4 31859 typ host\r\n


Actually i did not found any information about is it MUST be only one sace at 
the Grammar of SIP message based on RFC 2234 but I may be wrong.
```

 SIP Traffic



```
(paste your sip traffic here)
```

### Possible Solutions



### Additional Information

  * **Kamailio Version** - output of `kamailio -v`

```
(paste your output here)
```

* **Operating System**:



```
(paste your output here)
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1491___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev