[sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-19 Thread sagarmalam 


### Description


I am using keepalive module to send keepalives to all the destinations 
registered with an application server which sits behind kamailio. 
When Kamailio recieves 200 Ok. I take URI  contact from 200  OK and pass it as 
a param to ka_add_destination function.Most of the time it works fine but 
sometimes kamailio crashes when it recieves 200 OK of OPTIONS.
### Troubleshooting

 Reproduction
I am able to reproduce it easily in below scenario : 
All the URIs which we are feeding to KA module has this syntax : 
sip:2003@10.50.8.11:9090;alias=10.50.8.1~5060~1;pb-ip=35.185.177.49;pb-pt=5060;tp=udp

1. So request will be generate by KA module and it will be send to 
10.50.8.11:9090 ( which is another port of same kamailio instance ) via UDP 
protocol.
2. On recieving OPTION on 9090 port ,
  - We are calling handle_ruri_alias() function which will set $du 
=sip:10.50.8.1:5060;transport=udp
  - Modify RURI from
sip:2003@10.50.8.11:9090;alias=10.50.8.1~5060~1;pb-ip=35.185.177.49;pb-pt=5060;tp=udp
 to 

sip:2003@**35.185.177.49:5060**;pb-ip=35.185.177.49;pb-pt=5060;**transport**=udp
 - and relay to 10.50.8.1
3. 10.50.8.1 is another instance of Kamailio which will relay OPTION packet to 
final destination






 Debugging Data




```
[root@SBC-4-2 /]# gdb kamailio core.67771
GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-110.el7
  
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
...
Reading symbols from /usr/local/sbin/kamailio...done.
[New LWP 67771]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `/usr/local/sbin/kamailio -m 5000 -M 500 -P 
/run/kamailio/kamailio.pid'.
Program terminated with signal 11, Segmentation fault.
#0  0xabcdefed in ?? ()
Missing separate debuginfos, use: debuginfo-install 
cyrus-sasl-lib-2.1.26-23.el7.x86_64 glibc-2.17-222.el7.x86_64 
keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-19.el7.x86_64 
libcom_err-1.42.9-12.el7_5.x86_64 libcurl-7.29.0-51.el7.x86_64 
libevent-2.0.21-4.el7.x86_64 libgcc-4.8.5-36.el7_6.2.x86_64 
libidn-1.28-4.el7.x86_64 libselinux-2.5-12.el7.x86_64 
libssh2-1.4.3-10.el7_2.1.x86_64 libstdc++-4.8.5-36.el7_6.2.x86_64 
libuuid-2.23.2-52.el7_5.1.x86_64 mariadb-libs-5.5.64-1.el7.x86_64 
nspr-4.19.0-1.el7_5.x86_64 nss-3.36.0-5.el7_5.x86_64 
nss-softokn-freebl-3.36.0-5.el7_5.x86_64 nss-util-3.36.0-1.el7_5.x86_64 
openldap-2.4.44-15.el7_5.x86_64 openssl-libs-1.0.2k-16.el7_6.1.x86_64 
pcre-8.32-17.el7.x86_64 zlib-1.2.7-18.el7.x86_64
(gdb) bt full
#0  0xabcdefed in ?? ()
No symbol table info available.
#1  0x7f931dc69c7e in ka_options_callback (t=0x7f91e58f05c0, type=1024, 
ps=0x7ffda0977bd0) at keepalive_core.c:126
uri = {
  s = 0x7f91e58f63f0 
"sip:2003@10.50.8.11:9090;alias=10.50.8.1~5060~1;pb-ip=35.185.177.49;pb-pt=5060;tp=udp>\r\nFrom:
 ;tag=c7bfd876be500fff196414658218fc27-d6989f6d\r\nCSeq: 
10 OPTIONS\r\nCall-ID: 3f2c3c7c"..., len = 85}
msg = 0x0
state = 2
state_routes = {0x7f931dc6f844 "", 0x7f931dc6f93d "keepalive:dst-up", 
0x7f931dc6f94e "keepalive:dst-down"}
ka_dest = 0x7f91e5898988
__FUNCTION__ = "ka_options_callback"
#2  0x7f9324bfddd8 in run_trans_callbacks_internal (cb_lst=0x7f91e58f0638, 
type=1024, trans=0x7f91e58f05c0, params=0x7ffda0977bd0)
at t_hooks.c:258
cbp = 0x7f91e58f6590
backup_from = 0xb2a750 
backup_to = 0xb2a758 
backup_dom_from = 0xb2a760 
backup_dom_to = 0xb2a768 
backup_uri_from = 0xb2a740 
backup_uri_to = 0xb2a748 
backup_xavps = 0xb29fd0 <_xavp_list_head>
backup_xavus = 0xb29fd8 <_xavu_list_head>
backup_xavis = 0xb29fe0 <_xavi_list_head>
__FUNCTION__ = "run_trans_callbacks_internal"
#3  0x7f9324bfdf0a in run_trans_callbacks (type=1024, trans=0x7f91e58f05c0, 
req=0x0, rpl=0x, code=408) at t_hooks.c:285
params = {req = 0x0, rpl = 0x, param = 0x7f91e58f65a0, 
code = 408, flags = 0, branch = 0, t_rbuf = 0x0, dst = 0x0, 
  send_buf = {s = 0x0, len = 0}}
#4  0x7f9324b943f1 in local_reply (t=0x7f91e58f05c0, 
p_msg=0x, branch=0, msg_status=408, cancel_data=0x7ffda0977d50)
at t_reply.c:2265
local_store = 0
local_winner = 0
reply_status = RPS_COMPLETED
winning_msg = 0x
winning_code = 408
totag_retr = 0
---Type  to continue,

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-19 Thread Daniel-Constantin Mierla 
Do you use `ka_add_destination()` in kamailio configuration file? Or have you 
developed a module that uses internally this function?

Because looking at the code, when using the function in config, is not setting 
any state change callback function, which seems to be the one missing at the 
top of the backtrace (by looking what is at keepalive_core.c:126).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-676543445___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-19 Thread sagarmalam 
I have used ka_add_destination in config file.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-676616900___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-20 Thread sagarmalam 
Hi, @miconda 
So it a quick fix or complex one ? Can i expect it to get fixed in next stable 
version ? 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-677542203___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-20 Thread Daniel-Constantin Mierla 
I am not the developer of the module, I just looked quickly in the code and it 
seemed that it should not execute the callback that caused the crash if the 
function was used in the config. That's why I asked if you use it inside a 
custom module.

If I get some spare time, I will look again, but I cannot say if it is going to 
be fixed before the next minor release in 5.4 -- this is expected to happen 
soon, maximum 1-2 weeks and I expect to be quite busy getting Kamailio World 
online event organized.

The original developer changed the job and is no longer active, iirc, but there 
were other devs contributing to this module lately, maybe they can have a look 
as well -- pinging @luismartingil for it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-677576068___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-20 Thread sagarmalam 
@miconda , Thanks i understand. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-677599029___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-30 Thread Daniel-Constantin Mierla 
Supposing you still have the core file, can you get the output of next commands 
executed inside gdb:

```
frame 1
p * ka_dest
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683437869___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-30 Thread sagarmalam 
Hi,

(gdb) frame 1
#1  0x7ff5bbb2ddd8 in run_trans_callbacks_internal
(cb_lst=0x7ff47c9f86a8, type=1024, trans=0x7ff47c9f8630,
params=0x7ffdb5b643e0)
   at t_hooks.c:258
258 cbp->callback( trans, type, params );
(gdb) p * ka_dest
No symbol "ka_dest" in current context.
(gdb)

On Sun, Aug 30, 2020 at 9:31 PM Daniel-Constantin Mierla <
notificati...@github.com> wrote:

> Supposing you still have the core file, can you get the output of next
> commands executed inside gdb:
>
> frame 1
> p * ka_dest
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
> 
> .
>


-- 
Thanks,

Sagar


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683447460___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-30 Thread Daniel-Constantin Mierla 
In the first backtrace, the frame 1 was different:

```
#1  0x7f931dc69c7e in ka_options_callback (t=0x7f91e58f05c0, type=1024, 
ps=0x7ffda0977bd0) at keepalive_core.c:126
```

Did you get another core file? I need the output of `p *ka_dest` in the frame 
showing execution of `ka_options_callback()`. Get also the output of `list`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683558343___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread Luis Martin Gil 
@NGSegovia FYI

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683634852___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread sagarmalam 
I have generated fresh core dump : 

```
GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-110.el7
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
...
Reading symbols from /usr/local/sbin/kamailio...done.
[New LWP 77082]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `/usr/local/sbin/kamailio -m 5000 -M 500 -P 
/run/kamailio/kamailio.pid'.
Program terminated with signal 11, Segmentation fault.
#0  0x7fee0197dc7c in ka_options_callback (t=0x7fecc97f8450, type=1024, 
ps=0x7ffc051e10f0) at keepalive_core.c:126
126 ka_dest->statechanged_clb(&ka_dest->uri, state, 
ka_dest->user_attr);
Missing separate debuginfos, use: debuginfo-install 
cyrus-sasl-lib-2.1.26-23.el7.x86_64 glibc-2.17-222.el7.x86_64 
keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-19.el7.x86_64 
libcom_err-1.42.9-12.el7_5.x86_64 libcurl-7.29.0-51.el7.x86_64 
libevent-2.0.21-4.el7.x86_64 libgcc-4.8.5-36.el7_6.2.x86_64 
libidn-1.28-4.el7.x86_64 libselinux-2.5-12.el7.x86_64 
libssh2-1.4.3-10.el7_2.1.x86_64 libstdc++-4.8.5-36.el7_6.2.x86_64 
libuuid-2.23.2-52.el7_5.1.x86_64 mariadb-libs-5.5.64-1.el7.x86_64 
nspr-4.19.0-1.el7_5.x86_64 nss-3.36.0-5.el7_5.x86_64 
nss-softokn-freebl-3.36.0-5.el7_5.x86_64 nss-util-3.36.0-1.el7_5.x86_64 
openldap-2.4.44-15.el7_5.x86_64 openssl-libs-1.0.2k-16.el7_6.1.x86_64 
pcre-8.32-17.el7.x86_64 zlib-1.2.7-18.el7.x86_64
(gdb) bt full
#0  0x7fee0197dc7c in ka_options_callback (t=0x7fecc97f8450, type=1024, 
ps=0x7ffc051e10f0) at keepalive_core.c:126
uri = {
  s = 0x7fecc97fa612 
"sip:1006@10.50.8.11:9090;alias=10.50.8.1~5060~1;pb-ip=43.228.229.106;pb-pt=39524;tp=tcp>\r\nFrom:
 ;tag=c7bfd876be500fff196414658218fc27-ab6132c4\r\nCSeq: 
10 OPTIONS\r\nCall-ID: 7d20b9"..., len = 87}
msg = 0x0
state = 1
state_routes = {0x7fee01983844 "", 0x7fee0198393d "keepalive:dst-up", 
0x7fee0198394e "keepalive:dst-down"}
ka_dest = 0x7fecc98b1350
__FUNCTION__ = "ka_options_callback"
#1  0x7fee08911dd8 in run_trans_callbacks_internal (cb_lst=0x7fecc97f84c8, 
type=1024, trans=0x7fecc97f8450, params=0x7ffc051e10f0)
at t_hooks.c:258
cbp = 0x7fecc97fa7b8
backup_from = 0xb2a750 
backup_to = 0xb2a758 
backup_dom_from = 0xb2a760 
backup_dom_to = 0xb2a768 
backup_uri_from = 0xb2a740 
backup_uri_to = 0xb2a748 
backup_xavps = 0xb29fd0 <_xavp_list_head>
backup_xavus = 0xb29fd8 <_xavu_list_head>
backup_xavis = 0xb29fe0 <_xavi_list_head>
__FUNCTION__ = "run_trans_callbacks_internal"
#2  0x7fee08911f0a in run_trans_callbacks (type=1024, trans=0x7fecc97f8450, 
req=0x0, rpl=0x7fee0be2d230, code=200) at t_hooks.c:285
params = {req = 0x0, rpl = 0x7fee0be2d230, param = 0x7fecc97fa7c8, code 
= 200, flags = 0, branch = 0, t_rbuf = 0x0, dst = 0x0, send_buf = {
s = 0x0, len = 0}}
#3  0x7fee088a83f1 in local_reply (t=0x7fecc97f8450, p_msg=0x7fee0be2d230, 
branch=0, msg_status=200, cancel_data=0x7ffc051e14e0)
at t_reply.c:2265
local_store = 0
local_winner = 0
reply_status = RPS_COMPLETED
winning_msg = 0x7fee0be2d230
winning_code = 200
totag_retr = 0
__FUNCTION__ = "local_reply"
#4  0x7fee088ab28d in reply_received (p_msg=0x7fee0be2d230) at 
t_reply.c:2648
---Type  to continue, or q  to quit---
msg_status = 200
last_uac_status = 0
ack = 0x5adbb1  "\211E\374\213E\374\351\270\002"
ack_len = 198791384
branch = 0
reply_status = 198791440
onreply_route = 0
cancel_data = {cancel_bitmap = 0, reason = {cause = 200, u = {text = {s 
= 0x0, len = 11322688}, e2e_cancel = 0x0, packed_hdrs = {s = 0x0, 
len = 11322688
uac = 0x7fecc97f86e0
t = 0x7fecc97f8450
lack_dst = {send_sock = 0xacc673 , to = {s = {sa_family = 
50496, 
  sa_data = "\254\000\000\000\000\000@\025\036\005\374\177\000"}, 
sin = {sin_family = 50496, sin_port = 172, sin_addr = {s_addr = 0}, 
  sin_zero = "@\025\036\005\374\177\000"}, sin6 = {sin6_family = 
50496, sin6_port = 172, sin6_flowinfo = 0, sin6_addr = {__in6_u = {
  __u6_addr8 = 
"@\025\036\005\374\177\000\000\240\327o\000\000\000\000", __u6_addr16 = {5440, 
1310, 32764, 0, 55200, 111, 0, 0}, 
  __u6_addr32 = {85857600, 32764, 7329696, 0}}}, sin6_scope_id 
= 85857600}, sas = {ss_family = 50496, 
  __ss_padding = 
"\254\000\000\000\000\000@\025\036\005\

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread Daniel-Constantin Mierla 
Can you make a minimal kamailio config to reproduce this issue? The uri field 
is compromised, maybe due to a free/destroy of the keepalive structure. Are you 
adding/removing ka destinations on the fly/during runtime?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683688559___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread Nacho G. 
I'd say the reporter is adding the destination from another module, and not 
from .cfg. `statechanged_clb` should be null (and not run) when the destination 
is added through cfg.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683709667___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread Daniel-Constantin Mierla 
@NGSegovia - it is what I asked in my first comments, based on what I saw in 
the code.

But the last backtrace shows also URI field being invalid, so maybe the ka 
structure is compromised/overwritten -- like already freed/destroyed while the 
keepalive was ongoing, and another process got the memory zone and wrote there. 
That's why I asked to see if the destination is eventually removed from the KA 
list. I am not the developer of the module, but does not look like there is a 
protection for this case (provided that destinations can be removed at any 
time)...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683718353___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread Nacho G. 
In principle, there is a lock used for destination list: 
https://github.com/kamailio/kamailio/blob/master/src/modules/keepalive/keepalive_api.c#L178
and when freeing the destination the timer is being stopped, 
https://github.com/kamailio/kamailio/blob/master/src/modules/keepalive/keepalive_api.c#L255

mmm, I wonder why URI seems corrupted, but didn't get to corrupt "owner" in the 
backtrace. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683734862___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread Daniel-Constantin Mierla 
The timer for keepalive is stopped, but here it seems to come a pointer which 
was stored inside sip transaction structure and used when the transaction 
completes (on 408 timeout or 200ok response). If between the options and final 
response the ka destination structure is destroyed, then the tm callback will 
provide a pointer to an address that can be used for something else at that 
moment.

In such case it is better to store in transaction a unique id for ka 
destination structure and on tm transaction callback to search and see if it is 
found, locking the structure while is updated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683740148___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread sagarmalam 
@miconda , Yes i am adding and removing on the fly. I am adding(using 
ka_add_destination) to KA list on successful registration and removing(using 
ka_del_destination) when registration expires.
```

#KEEPALIVE###
modparam("keepalive", "ping_interval", 20)
modparam("keepalive", "delete_counter", 5)
modparam("keepalive", "ping_from", "sip:keepalive@fromsbc")

request_route {

##ON RECIEVING OPTIONS FROM KA MODULE ON 9090 PORT, Set $du using 
handle_ruri_alias , replace tp with transport and relay it to edge proxy from 
which we recieved register packet
if ($Rp == "9090" && is_method("OPTIONS")){
if (t_newtran()) {
if (handle_ruri_alias()){
$avp(request_uri)= $ru ;

$avp(pb-ip)=$(avp(request_uri){param.value,pb-ip});
if (is_ipv6($avp(pb-ip))) {
if 
(subst_uri('/^sip:(.*)@(.*);pb-ip=(.*);pb-pt=(.*);tp=(.*)$/sip:\1@[\3]:\4;pb-ip=\3;pb-pt=\4;transport=\5/i')){
  xlog("L_INFO","(KA 
OPTIONS) : ($avp(uuid)) : Destination URI <$du> created from alias.");
 t_relay();
  }

} else {
if 
(subst_uri('/^sip:(.*)@(.*);pb-ip=(.*);pb-pt=(.*);tp=(.*)$/sip:\1@\3:\4;pb-ip=\3;pb-pt=\4;transport=\5/i')){
  xlog("L_INFO","(KA 
OPTIONS) : ($avp(uuid)) : Destination URI <$du> created from alias.");
 t_relay();
}

}

}

exit;
}

$du=sip:APPLICATION_SERVER_IP:5060; ##IP of application server ( Freeswitch) to 
which kamailio will relay register packet add_contact_alias();
t_on_reply("reply_register")
if (!t_relay()) {
sl_reply_error();
}
exit;
} 
onreply_route[reply_register ]{
 if ((status=~"200") && $rm=="REGISTER" && $(avp(c_ct){param.value,expires}) != 
0)
{
## On receiving fresh registration (i.e with expires !=0) , Kamailio will 
register a contact address for that registration in KA module ping registry.
$avp(ka_contact) = 
'sip:'+$fU+'@LOCAL_IP:9090;alias='+$(avp(c_ct){param.value,alias})+';pb-ip='+$(avp(c_ct){param.value,pb-ip})+';pb-pt='+$(avp(c_ct){param.value,pb-pt})+';tp='+$(avp(c_ct){param.value,transport}{s.rm,>});
ka_add_destination("$avp(ka_contact)","config");
} 

if ((status=~"200") && $rm=="REGISTER" && $(avp(c_ct){param.value,expires}) == 
0)
 {

$avp(ka_contact) = 
'sip:'+$fU+'@LOCAL_IP:9090;alias='+$(avp(c_ct){param.value,alias})+';pb-ip='+$(avp(c_ct){param.value,pb-ip})+';pb-pt='+$(avp(c_ct){param.value,pb-pt})+';tp='+$(avp(c_ct){param.value,transport}{s.rm,>});
ka_del_destination("$avp(ka_contact)","config");
}

}
```

@NGSegovia , I am adding destinations from CFG file.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-683752918___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-08-31 Thread Daniel-Constantin Mierla 
@NGSegovia - not related to the issue itself, but is there any specific reason 
to do this complex logic for keepalives? If it is for registrations, the usrloc 
module in kamailio v5.4.x can do keepalive (storing also the round trip time).

Otherwise, the issue seems to be related to keeping the pointer to keepalive 
destinations structure in the transaction and can be destroyed until 
transaction completes. If no other devel looks at it, I will try to get 
familiar with the code of the module and come up with a fix after Kamailio 
World Online event.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-684487614___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-01 Thread sagarmalam 
I preferred this module over usrloc module because i dont store registrations 
on kamailio. It is stored on application server behind Kamailio. So it was easy 
for me to use keepalive module to send KA instead of usrloc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-684508194___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-01 Thread Nacho G. 
@miconda the problem you pointed is the same pointed in this message, right? 
https://github.com/kamailio/kamailio/blob/master/src/modules/keepalive/keepalive_core.c#L102

BTW I did some code, hopefully fixing this, but I didn't cleaned-up and test 
properly yet, but you can take a look. 
https://github.com/NGSegovia/kamailio/tree/keepalive_fix_race_condition_tm_request


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-684510622___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-01 Thread sagarmalam 
@NGSegovia , The changes you made has fixed the issue. Kamailio service is 
running since last 2 hours and I am not able to reproduce issue. 
Thanks so much.
 
@miconda , I understand you are busy with Kamailio world, Is there any chances 
for this fix to be available in next stable release ? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-684850139___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-01 Thread Daniel-Constantin Mierla 
@NGSegovia - yes, that kind of problem.

The approach in the fix is correct, just wondering if worth adding dependency 
on external libuuid library instead of using the internal 
core/utils/sruid.{c,h}, like it is done for other modules. I planned to extend 
the internal sruid code to be able to use libuuid via the `uuid` module, can be 
something to consider in this development cycle.

By using the internal sruid backporting will be smooth, because there is no 
extra dependency, so it does not break packaging (debs, rpms, ... stay the 
same).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-684888965___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-01 Thread Nacho G. 
Not a problem @miconda , updated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-685140654___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-02 Thread sagarmalam 
@NGSegovia , I tested latest changes under 
https://github.com/NGSegovia/kamailio/commit/aaded162a6523642873703f6b52e191c86d5aee6

Now it is crashing again but from different place : 
```
(gdb) bt full
#0  0x7f3153cd82cc in __strncpy_ssse3 () from /lib64/libc.so.6
No symbol table info available.
#1  0x7f312a7d5132 in ka_str_copy (src=0x7f2ff2441b38, dest=0x7f2ff2416380, 
prefix=0x0) at keepalive_core.c:203
lp = 0
__FUNCTION__ = "ka_str_copy"
#2  0x7f312a7d2d19 in ka_check_timer (ticks=931009473, tl=0x7f2ff2416618, 
param=0x7f2ff2416360) at keepalive_core.c:71
ka_dest = 0x7f2ff2416360
ka_ping_method = {s = 0x7f312a7d9740 "OPTIONS", len = 7}
ka_outbound_proxy = {s = 0x0, len = 0}
uac_r = {method = 0x140b788ad20, headers = 0x7f2ff24162c8, body = 0x0, 
ssock = 0x0, ssockname = 0x0, dialog = 0x0, cb_flags = 1024, 
  cb = 0x7f312a7d3174 , cbp = 0x7f2ff243f378, 
callid = 0x0}
__FUNCTION__ = "ka_check_timer"
uuid = 0x7f2ff2441b38
#3  0x004c3517 in slow_timer_main () at core/timer.c:1105
n = 12
ret = 320
tl = 0x7f2ff2416618
i = 1
__FUNCTION__ = "slow_timer_main"
#4  0x0042a5f3 in main_loop () at main.c:1737
i = 16
pid = 0
si = 0x0
si_desc = "udp receiver child=15 
sock=10.50.8.11:9090\000:0:0:11]:5060\000\061:5060)\000\000\000\000\000\000\000\000\000\220\374\361/\177\000\000\002\000\000\000\000\000\000\000\360\004-\362/\177\000\000\060\260\210\267\375\177\000\000\322CL\000\000\000\000\000\340\271A\000\000\000\000\000\250=\306\064\061\177\000"
nrprocs = 16
woneinit = 1
__FUNCTION__ = "main_loop"
#5  0x00433ba5 in main (argc=7, argv=0x7ffdb788b598) at main.c:2861
cfg_stream = 0x27e1010
c = -1
r = 0
tmp = 0x7ffdb788bf26 ""
tmp_len = 0
---Type  to continue, or q  to quit---
port = 0
proto = 0
ahost = 0x0
aport = 0
options = 0x7cfaa0 
":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:"
ret = -1
seed = 862902793
rfd = 4
debug_save = 0
debug_flag = 0
dont_fork_cnt = 0
n_lst = 0x0
p = 0x0
st = {st_dev = 23, st_ino = 30676, st_nlink = 2, st_mode = 16877, 
st_uid = 0, st_gid = 5001, __pad0 = 0, st_rdev = 0, st_size = 40, 
  st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1599034463, 
tv_nsec = 259945261}, st_mtim = {tv_sec = 1599034433, 
tv_nsec = 160818732}, st_ctim = {tv_sec = 1599034463, tv_nsec = 
259945261}, __unused = {0, 0, 0}}
tbuf = '\000' , 
"p\262\252\000\000\000\000\000\340\271A\000\000\000\000\000\220\265\210\267\375\177",
 '\000' , "\036\017gT1\177\000\000\001", '\000' , 
"\340c\270S1\177\000\000`\265\210\267\375\177\000\000*\213gT1\177\000\000\034\000\000\000\000\000\000\000"...
option_index = 0
long_options = {{name = 0x7d1c8f "help", has_arg = 0, flag = 0x0, val = 
104}, {name = 0x7cd2a1 "version", has_arg = 0, flag = 0x0, 
val = 118}, {name = 0x7d1c94 "alias", has_arg = 1, flag = 0x0, val 
= 1024}, {name = 0x7d1c9a "subst", has_arg = 1, flag = 0x0, 
val = 1025}, {name = 0x7d1ca0 "substdef", has_arg = 1, flag = 0x0, 
val = 1026}, {name = 0x7d1ca9 "substdefs", has_arg = 1, flag = 0x0, 
val = 1027}, {name = 0x7d1cb3 "server-id", has_arg = 1, flag = 0x0, 
val = 1028}, {name = 0x7d1cbd "loadmodule", has_arg = 1, flag = 0x0, 
val = 1029}, {name = 0x7d1cc8 "modparam", has_arg = 1, flag = 0x0, 
val = 1030}, {name = 0x7d1cd1 "log-engine", has_arg = 1, flag = 0x0, 
val = 1031}, {name = 0x7d1cdc "debug", has_arg = 1, flag = 0x0, val 
= 1032}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}}
__FUNCTION__ = "main"

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-685443487___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-02 Thread Nacho G. 
@sagarmalam I have updated the PR, please check again.

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-685867040___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-03 Thread sagarmalam 
@NGSegovia , It is working fine now. Thanks a lot. 

Question : 
As a developer do you think this module can handle load of sending keepalives 
to 50 K destinations every 20 seconds ? or you suggest to use ursloc module 
instead for such a load ?

 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-686428606___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-03 Thread Nacho G. 
No idea @sagarmalam 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-686612763___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-03 Thread sagarmalam 
ok. Thanks. I will share my results.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-68471___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-04 Thread sagarmalam 
Hello Again, 

I was able to reproduce again. It crashed from the same point and it seems that 
frequency of this issue has reduced but it is not fixed yet. 
As per my observation, it happens when entry of destination from KA list is 
removed during an ongoing KA transaction. I am removing destination from KA 
list when endpoint de registers so this case is possible. I have also observed 
same on pcaps. Below are the screenshots : 

OPTIONS : 
![Screenshot from 2020-09-04 
23-02-14](https://user-images.githubusercontent.com/47811226/92270611-fe620b00-ef03-11ea-8d95-d75c35cb8b9e.png)


REGISTER : 
![Screenshot from 2020-09-04 
23-01-25](https://user-images.githubusercontent.com/47811226/92270637-05891900-ef04-11ea-965b-774b6ee7fc72.png)


Kamailio has dispatched 200 OK for register at 06:33:58.187520 and it received 
200 OK for OPTIONS at 06:33:58.411501. Kamailio crashed exactly at a same time.

Core Dump : 
```
GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-110.el7
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
...
Reading symbols from /usr/local/sbin/kamailio...done.
[New LWP 12701]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `/usr/local/sbin/kamailio -m 5000 -M 500 -P 
/run/kamailio/kamailio.pid'.
Program terminated with signal 11, Segmentation fault.
#0  0x7f09c138dc7c in ka_options_callback (t=0x7f0896cc1530, type=1024, 
ps=0x7ffdb22e9d20) at keepalive_core.c:126
126 ka_dest->statechanged_clb(&ka_dest->uri, state, 
ka_dest->user_attr);
Missing separate debuginfos, use: debuginfo-install 
cyrus-sasl-lib-2.1.26-23.el7.x86_64 glibc-2.17-222.el7.x86_64 
keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-19.el7.x86_64 
libcom_err-1.42.9-12.el7_5.x86_64 libcurl-7.29.0-51.el7.x86_64 
libevent-2.0.21-4.el7.x86_64 libgcc-4.8.5-36.el7_6.2.x86_64 
libidn-1.28-4.el7.x86_64 libselinux-2.5-12.el7.x86_64 
libssh2-1.4.3-10.el7_2.1.x86_64 libstdc++-4.8.5-36.el7_6.2.x86_64 
libuuid-2.23.2-52.el7_5.1.x86_64 mariadb-libs-5.5.60-1.el7_5.x86_64 
nspr-4.19.0-1.el7_5.x86_64 nss-3.36.0-5.el7_5.x86_64 
nss-softokn-freebl-3.36.0-5.el7_5.x86_64 nss-util-3.36.0-1.el7_5.x86_64 
openldap-2.4.44-15.el7_5.x86_64 openssl-libs-1.0.2k-16.el7_6.1.x86_64 
pcre-8.32-17.el7.x86_64 zlib-1.2.7-18.el7.x86_64
(gdb) bt full
#0  0x7f09c138dc7c in ka_options_callback (t=0x7f0896cc1530, type=1024, 
ps=0x7ffdb22e9d20) at keepalive_core.c:126
uri = {
  s = 0x7f0896cc39b7 
"sip:7459@10.50.8.6:9090;alias=10.50.8.1~5060~1;pb-ip=174.198.221.83;pb-pt=3939;tp=tcp>\r\nFrom:
 ;tag=ee3b67b160621ee354865fd8162b5b29-1b81a45f\r\nCSeq: 
10 OPTIONS\r\nCall-ID: 2557bb53"..., len = 85}
msg = 0x0
state = 1
state_routes = {0x7f09c1393844 "", 0x7f09c139393d "keepalive:dst-up", 
0x7f09c139394e "keepalive:dst-down"}
ka_dest = 0x7f088ac83048
__FUNCTION__ = "ka_options_callback"
#1  0x7f09c8321dd8 in run_trans_callbacks_internal (cb_lst=0x7f0896cc15a8, 
type=1024, trans=0x7f0896cc1530, params=0x7ffdb22e9d20)
at t_hooks.c:258
cbp = 0x7f0896cc3b60
backup_from = 0xb1f170 
backup_to = 0xb1f178 
backup_dom_from = 0xb1f180 
backup_dom_to = 0xb1f188 
backup_uri_from = 0xb1f160 
backup_uri_to = 0xb1f168 
backup_xavps = 0xb1ea60 <_xavp_list_head>
backup_xavus = 0xb1ea68 <_xavu_list_head>
backup_xavis = 0xb1ea70 <_xavi_list_head>
__FUNCTION__ = "run_trans_callbacks_internal"
#2  0x7f09c8321f0a in run_trans_callbacks (type=1024, trans=0x7f0896cc1530, 
req=0x0, rpl=0x7f09cb832030, code=200) at t_hooks.c:285
params = {req = 0x0, rpl = 0x7f09cb832030, param = 0x7f0896cc3b70, code 
= 200, flags = 0, branch = 0, t_rbuf = 0x0, dst = 0x0, send_buf = {
s = 0x0, len = 0}}
#3  0x7f09c82b2bef in local_reply (t=0x7f0896cc1530, p_msg=0x7f09cb832030, 
branch=0, msg_status=200, cancel_data=0x7ffdb22ea110)
at t_reply.c:2265
local_store = 0
local_winner = 0
reply_status = RPS_COMPLETED
winning_msg = 0x7f09cb832030
winning_code = 200
totag_retr = 0
__FUNCTION__ = "local_reply"
#4  0x7f09c82b5a8b in reply_received (p_msg=0x7f09cb832030) at 
t_reply.c:2648
---Type  to continue, or q  to quit---
msg_status = 200
last_uac_status = 0
ack = 0x5a62bc  "\211E\374\213E\374\351)\003"
ack_len = 2989400432
branch = 0
reply_status = -881216520
onreply_route = 0
cancel_data = {cancel_bitmap = 0, reason = {cause =

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-07 Thread sagarmalam 
Hello 
Please ignore above comment.Fix is working.I picked up wrong branch while 
testing it. Sorry for confusion.
Thanks



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-688273643___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-09 Thread sagarmalam 
@NGSegovia , While testing latest fixes we have found that Keepalive module is 
leaking memory. We are testing with 7K destinations with time interval of 20 
seconds
This log file has output of : kamcmd mod.stats keepalive shm for every sec : 
[keepalive_memory_consumption.log](https://github.com/kamailio/kamailio/files/5194119/keepalive_memory_consumption.log)

At Wed Sep  9 09:02:07 GMT 2020 it is 3 MB 
At Wed Sep  9 09:33:47 GMT 2020 it is 47 MB
So 42 MB consumed within 30 mins and growing.

Kamailio core dumped after running for 24 hours with 5GB SHM memory.
core dump : 
[coredump.txt](https://github.com/kamailio/kamailio/files/5194043/coredump.txt)

Kamailio logs : 
[kamailio.log](https://github.com/kamailio/kamailio/files/5194055/kamailio.log)

Please get back to me in case you need any more information. 
Thanks a lot

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-689451262___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-22 Thread Nacho G. 
@sagarmalam merged PR fixing this problem.  Re-open if there are still issues. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-696811732___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-22 Thread Nacho G. 
Closed #2448.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#event-3794004692___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-24 Thread sagarmalam 
@NGSegovia , Thanks for all the efforts in fix this issue. I think i have found 
regression issue. KA timeout parameter is not working anymore with latest 
changes. It keeps on sending KA even after failing for number of times defined 
in ka_timeout mod param.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-698275128___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio-5.4.0 : Crashes from keepalive module (#2448)

2020-09-24 Thread Nacho G. 
Hi @sagarmalam , do you mean `delete_counter` parameter? I tried and seems to 
work for me (The truth is that if I set it to 3 I get 4 attempts but then 
stops).

BTW id you set that parameter to "0" means no limit. Not sure if that is the 
case. 

Anyway, I can't find the relation with changes done here and this parameter. 
Can you try again a open a new issue with more information if you still have 
problems?

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2448#issuecomment-698624451___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev