Re: [sr-dev] [kamailio/kamailio] str_hash: Option to allocate hash in shm (#1535)
Closed #1535. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1535#event-1713947352___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] str_hash: Option to allocate hash in shm (#1535)
Closing this one -- as discussed during IRC devel meeting, a separate implementation should be done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1535#issuecomment-402146014___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] str_hash: Option to allocate hash in shm (#1535)
I agree that another header file can be created, either leveraging the existing one for pkg or completely independent. I will catch up with you on IRC tomorrow or next week to see how to move forward. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1535#issuecomment-392267623___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] str_hash: Option to allocate hash in shm (#1535)
I am not sure yet about how to deal with this one. I agree that there is space to reuse some code for hash tables in shared memory, but I feel that we should have dedicated code for it, not to mix it with the one in pkg memory. It will avoid all these if checks to lock/unlock, as we use hash tables to speed up search, it feels we need to keep it optimised. Moreover, iirc and hope not to confuse with other api, some of the macros are even now used for hash tables in memory, just that the lock/unlock of the slot is done in the implementation code, not in the core code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1535#issuecomment-391630806___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] str_hash: Option to allocate hash in shm (#1535)
hi @henningw, I'm developing a module that requires to have a hash in memory to keep some user information it retrieves from another system via diameter. The use case is similar to tsilo or domain modules, the information needs to be available for all processes and accesible through a key. However, if you look at those modules (and I think there were others that I can't remember now) they all implement their own structures to handle the hash table, the collision slots, the entries, the linked lists, the accessor functions,... when it's not needed as kamailio already has a library that contains all of that. The only missing part is that until now it only worked in private memory -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1535#issuecomment-390129867___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Re: [sr-dev] [kamailio/kamailio] str_hash: Option to allocate hash in shm (#1535)
Thank you for the contribution. Just one question so far - what was your motivation in adding this functionality, where do you need this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1535#issuecomment-390113748___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[sr-dev] [kamailio/kamailio] str_hash: Option to allocate hash in shm (#1535)
Added an allocator function to allocate the hash in shared memory. Added also locking stuff Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description Added a new allocator function to str_hash.h. This new function allows to allocate the hash table in shared memory. Changes to struct str_hash_table: - Added a gen_lock_set_t (locks) to hold the lock set - Added an int (locks_no) to hold the number of locks - Added an indicator (memory) to know if the table was allocated in private memory (p) or shared memory(s) Changes to struct str_hash_head: - Added an int(lock_idx) that hold the index of the lock when the head is locked. Changes to struct str_hash_entry: - Added a pointer to the head the entry belongs to. This allows to unlock the head when needed. Added functions to lock and unlock the head when needed. Modified functions str_hash_add and str_hash_get to lock the head when needed Added function str_hash_destroy to remove the hash table and all its contents from memory. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1535 -- Commit Summary -- * str_hash: Option to allocate hash in shm -- File Changes -- M src/core/str_hash.h (100) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1535.patch https://github.com/kamailio/kamailio/pull/1535.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1535 ___ Kamailio (SER) - Development Mailing List sr-dev@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
