[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
Merged #3892 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3892#event-13382597550 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
Thanks for reviews. Merging this.
Actually if one designs the 'keys' right for a db_redis table, should get *no*
full table scans (I think, at least from my tests so far). So then will get no
warnings after this merge.
Full table scans are actually dangerous because consume alot of kamailio PKG
memory. So if one's db_redis table is big, and full scans are performed =>
kamailio processes won;t be able to load it in the first palce. So the WARNING
for performing full table scan is still there, because of this.
Tip: For location table in db_redis i got no full table scans anymore (e.g.
when contact expires or when user contacts is queried) when using this key
definition:
```
modparam("db_redis", "keys",
"location=entry:ruid:username,domain:expires")
```
... because index info is added in redis for 'user@domain' or for user's
contact 'expires' so only those ones need to be scanned and iterated => no full
scans needed
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3892#issuecomment-2206549864
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
Fine to merge it from my perspective, I guess that some full table scans can't be avoided always. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3892#issuecomment-2202277726 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
If there is indeed a performance implication in this table scans with key, maybe we should not silence it completely by using DBG and using INFO instead. But maybe @agranig like to comment as well here. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3892#issuecomment-2188742720 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
I never get clang formatting right, unless using the clang-format tool :D -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3892#issuecomment-2188700713 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
@smititelu pushed 1 commit. fa202d1112c9df29358c261e670b6bbfff9fc856 db_redis: change logs on delete -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3892/files/34b15758bd4ec9b1f09174e981af0675b9068c7d..fa202d1112c9df29358c261e670b6bbfff9fc856 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
@smititelu pushed 1 commit. 34b15758bd4ec9b1f09174e981af0675b9068c7d db_redis: change logs on delete -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3892/files/85c244e6a55a8391c744624b5d3678d550481d1a..34b15758bd4ec9b1f09174e981af0675b9068c7d You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] db_redis: change logs on delete (PR #3892)
@smititelu pushed 1 commit. 85c244e6a55a8391c744624b5d3678d550481d1a db_redis: change logs on delete -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3892/files/06aac1608f6bf87c2eb760c1402566760a6380a7..85c244e6a55a8391c744624b5d3678d550481d1a You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
