[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
The PR was reviewed and discussed together with Xenofon, some comments have been added and it was pushed in the referenced commits. Close this PR. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1892554550 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
Closed #3679. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#event-11490762237 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
@xkaraman pushed 2 commits. b4fbf7f9d120f835be8d906a3ac62e7de14f2e07 dmq_usrloc: Transfer attributes c57e1f21f35145ba6df93ea5db2d0a8ebe2ff36c usrloc: Modify destroy order and contact xavp -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3679/files/709fa172980f018a9ae2b502f2d3bdef531c3080..c57e1f21f35145ba6df93ea5db2d0a8ebe2ff36c You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
@xkaraman pushed 2 commits. b6e9fe81e4464d462dfb3b0dc5f469565cd63b1e dmq_usrloc: Transfer attributes 709fa172980f018a9ae2b502f2d3bdef531c3080 usrloc: Modify destroy order and contact xavp -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3679/files/5e486e0e87446ecb018878cd10f780f63b598643..709fa172980f018a9ae2b502f2d3bdef531c3080 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
@xkaraman: I meant to be kept for "long time" -- for example, if the list is needed for the duration of keeping a contact record till its expiration (or, just as another example, for dialog record till its end). In such case, the list has to be cloned, or the pointer to it from the core (or other structures) has to be reset, to avoid being linked from two places, because it can be destroyed from one place and still referenced from the other place. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1881198337 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
Hi @miconda, What does long mean in this case? What does `xavp_clone_level_nodata` achieve in this regard? Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1881065991 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
Thanks, yes this was basically the question also @xkaraman had earlier. The XAVPs will be used in the cfg script context later on I think. He will do another review. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1878409382 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
I haven't gotten the time to review if the list of XAVPs can be just linked or needs to be cloned. If it is just used temporarily in a function, then linking should be fine, but if it needs to be kept for long, then it could be that clone has to be done, otherwise the list stays linked from two places and attempted to be destroyed twice. If the above is clarified, I am fine to merge it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1878386870 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
Are there more comments or objections? If not I would merge it in the next days. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1878352646 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
Hey Daniel, Besides the order change of destroy, it copies to the new contact the `xavp` from incoming `ucontact_t` argument just like the rest of the fields. If the config variable `xavp_contact` is found and not empty, then `ucontact_xavp_store` destroy this xavp and fills it up with whatever is contained inside. Some doubts i had, is whether i shall `c->xavp = _ci->xavp;` or ` _c->xavp = xavp_clone_level_nodata(_ci->xavp);` or `xavp_add(_ci->xavp, &c->xavp)`. What is the difference between all these methods? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1866272393 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
@xkaraman commented on this pull request. > @@ -825,6 +837,16 @@ int usrloc_dmq_send_contact( srjson_AddNumberToObject(&jdoc, jdoc.root, "reg_id", ptr->reg_id); srjson_AddNumberToObject(&jdoc, jdoc.root, "server_id", ptr->server_id); + /* Loop through Χavp attributes of the contact and and create a json object */ + srjson_t *jdoc_xavp = srjson_CreateObject(&jdoc); Fixed on some other variables too on the newly static functions. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#discussion_r1434085417 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
@xkaraman pushed 2 commits. a192e503f58507fdca4dc5cb861a4dc309873e81 dmq_usrloc: Transfer attributes 6673124597eb94bcf00d81c5e2598d4eee7ee832 usrloc: Modify destroy order and contact xavp -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3679/files/3d79568e13f5fbc947ad1452244bf1cb527b45a2..6673124597eb94bcf00d81c5e2598d4eee7ee832 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
The commit for usrloc #3d79568 does not only change the destroy order, is it also fixing something? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#issuecomment-1866178136 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] dmq_usrloc: DMQ also copies and sends attributes related to contacts (PR #3679)
@miconda commented on this pull request. > @@ -825,6 +837,16 @@ int usrloc_dmq_send_contact( srjson_AddNumberToObject(&jdoc, jdoc.root, "reg_id", ptr->reg_id); srjson_AddNumberToObject(&jdoc, jdoc.root, "server_id", ptr->server_id); + /* Loop through Χavp attributes of the contact and and create a json object */ + srjson_t *jdoc_xavp = srjson_CreateObject(&jdoc); Variable should be declared at the beginning of the block to be coherent and also keep compliant with older C standards. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3679#pullrequestreview-1792886476 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
