[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global p_usrloc_columns variable in db_load* functions (PR #3845)
Hi @henningw, Will make a similar PR for usrloc. Thank you -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3845#issuecomment-2114142321 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global p_usrloc_columns variable in db_load* functions (PR #3845)
I think it would be also a good addition for the usrloc module. It certainly makes the code better understandable (some integer IDs vs. easy names). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3845#issuecomment-2112911458 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global p_usrloc_columns variable in db_load* functions (PR #3845)
Merged #3845 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3845#event-12815686632 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global p_usrloc_columns variable in db_load* functions (PR #3845)
Hello, squashing is for combining moro commits of the same PR in a single one (if I haven't gotten it wrong), but here is only one, so rebase and merge should do it. Even with more commits in same PR, rebasing and merge should be done when the commits are sort of independent. Squashing would be suitable when a commit amends another one (e.g., fixing fomratting of a previous commit). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3845#issuecomment-2112211021 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global p_usrloc_columns variable in db_load* functions (PR #3845)
Hi @miconda, Do I "Squash and merge" or "Rebase and merge" this PR? Do you consider worthwhile to do a similar PR for usrloc? Thank you -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3845#issuecomment-2112184585 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] p_usrloc: use a global p_usrloc_columns variable in db_load* functions (PR #3845)
Thank you for the comments, I made the static and renaming changes. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3845#issuecomment-2107552088 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
