[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)
Merged #3850 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3850#event-13056652042 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)
Thanks for updating the PR, merged. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3850#issuecomment-2150827595 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)
I guess it can be merged if no other comments. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3850#issuecomment-2150665635 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)
Hi, thanks for the feedback. I've updated the PR accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3850#issuecomment-2114247068 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] pdb: make 'timeout' runtime configurable (PR #3850)
@henningw commented on this pull request. Thanks for the PR. The run-time cfg option looks straight-forward, good addition. You've also change the log level of a bunch of NOTICEs messages related to the timeout to ERROR and log additional information, was this done intentionally? Because its not mentioned in the commit message. You've also change the pdbt tool behaviour in another location, this should probably be a dedicated commit with an own commit message, with the proper prefix. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3850#pullrequestreview-2058029377 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
