[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)
Thanks, if there is a workaround there its of course not necessary to backport. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887564694 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)
> Unfortunately it does not seems to work at least with "codec-accept=XXX": > kam02 rtpengine[570041]: WARNING: [jKOBctrRd-]: [core] Unknown dictionary key > encountered: 'codec-accept' Right, you have to use `codec-flag-...` (dash instead of equals) for this to work. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887560358 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)
Unfortunately it does not seems to work at least with "codec-accept=XXX": kam02 rtpengine[570041]: WARNING: [jKOBctrRd-]: [core] Unknown dictionary key encountered: 'codec-accept' -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887540631 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)
These flags should work without this patch, as they would just be put into the `flags` list of strings and rtpengine does parse them out of there. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887531455 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)
Thanks for the fast review and merge. I would like to cherry-pick this to 5.7 stable branch, as it should be available according to the module readme (at least codec-accept). If necessary I can also create a dedicated commit only for the codec-accept. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887528115 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)
Merged #3710 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#event-11458613293 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] rtpengine: Add support for codec-accept and codec-consume flags (PR #3710)
LGTM -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3710#issuecomment-1887427690 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
