[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
@juha-h is not a bug. The format checks each commit. I already told you how to properly do it. Just create one commit with the proper commit message prefix squashing both previous commits in the branch. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120073595 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Victor Seva writes: > Just create one commit with the proper commit message prefix squashing > both previous commits in the branch. Goes beyond me. In baresip project, nothing like that needs to be done. If there is new commit to PR, all checks are automatically re-run. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120096511 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
juha-h writes: > Goes beyond me. In baresip project, nothing like that needs to be > done. If there is new commit to PR, all checks are automatically > re-run. ... and red marks turn green without any extra action. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120106704 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
since it's a branch in kamailio repo I did it myself. ``` git rebase -i origin/master ``` squashed both commits and added the tm prefix -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120114049 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
The idea behind it's that all commits are properly formatted. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120117882 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Merged #3856 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#event-12864279478 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Is it OK to cherry-pick this to 5.8 branch? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120256287 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Yes, it can be cherry-picked, it is about a mandatory header. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120822692 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)
Daniel-Constantin Mierla writes: > Yes, it can be cherry-picked, it is about a mandatory header. Done. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120834113 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org