Re: [sr-dev] kamailio packaging, change in carrierroute Makefile

[Daniel-Constantin Mierla]

Hello,

ok, merge it if doesn't break anymore the jenking nightly builds --
revert also my revert to Henning's commit.

Cheers,
Daniel


On 04.04.18 16:53, Victor Seva wrote:
> Hello,
>
> 2018-04-03 23:03 GMT+02:00 Daniel-Constantin Mierla  >:
>
> changes expected to affect packaging should be discussed first and
> then
> committed, along with related updates to packaging specs.
>
> They can break nightly builds for packages, resulting in unnecessary
> alerts to the mailing list, repeating every day until the dev
> maintaining the specs is available to do the changes. Not being a
> critical issue, this can wait to be discussed and done properly.
>
>
>  I've reviewed the changes and I've changed the deb packaging to remove
> kamailio-carrierroute-modules package and being replaced by kamailio
> package
>
> Changes are at [0] a personal branch.
>
> Should I push changes?
>
> [0] https://github.com/kamailio/kamailio/tree/vseva/pkg_carrierroute
>

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - April 16-18, 2018, Berlin - www.asipto.com
Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com

___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] kamailio packaging, change in carrierroute Makefile

[Victor Seva]

Hello,

2018-04-03 23:03 GMT+02:00 Daniel-Constantin Mierla :

> changes expected to affect packaging should be discussed first and then
> committed, along with related updates to packaging specs.
>
> They can break nightly builds for packages, resulting in unnecessary
> alerts to the mailing list, repeating every day until the dev
> maintaining the specs is available to do the changes. Not being a
> critical issue, this can wait to be discussed and done properly.
>
>
 I've reviewed the changes and I've changed the deb packaging to remove
kamailio-carrierroute-modules package and being replaced by kamailio package

Changes are at [0] a personal branch.

Should I push changes?

[0] https://github.com/kamailio/kamailio/tree/vseva/pkg_carrierroute
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] kamailio packaging, change in carrierroute Makefile

[Daniel-Constantin Mierla]

Hello,

changes expected to affect packaging should be discussed first and then
committed, along with related updates to packaging specs.

They can break nightly builds for packages, resulting in unnecessary
alerts to the mailing list, repeating every day until the dev
maintaining the specs is available to do the changes. Not being a
critical issue, this can wait to be discussed and done properly.

Cheers,
Daniel

On 03.04.18 22:13, Henning Westerholt wrote:
> Hi Guys,
>
> a quick notice about a change that I did today that may or may not affect 
> some 
> of the kamailio packaging.
>
> Some years ago the carrierroute module was changed to do not depend on the 
> library libconfuse (commit 4c4f2c2bedb4a) anymore. 
>
> I changed the git master Makefile to move the carrierroute module from a 
> dedicated module to the extra module group.
>
> I had a quick look to the packaging, for e.g. debian builds carrierroute is 
> as 
> own module with a dependency to libconfuse. This should be changed, its not 
> necessary to build it as own package and the dependency is not needed 
> anymore. 
> You could move it as well to the extra modules package.
>
> Thanks and regards,
>
> Henning
>
>
>
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - April 16-18, 2018, Berlin - www.asipto.com
Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] kamailio packaging, change in carrierroute Makefile

[Henning Westerholt]

Hi Guys,

a quick notice about a change that I did today that may or may not affect some 
of the kamailio packaging.

Some years ago the carrierroute module was changed to do not depend on the 
library libconfuse (commit 4c4f2c2bedb4a) anymore. 

I changed the git master Makefile to move the carrierroute module from a 
dedicated module to the extra module group.

I had a quick look to the packaging, for e.g. debian builds carrierroute is as 
own module with a dependency to libconfuse. This should be changed, its not 
necessary to build it as own package and the dependency is not needed anymore. 
You could move it as well to the extra modules package.

Thanks and regards,

Henning



___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev