Re: [sr-dev] git:master:e85a5a6a: http_async_client: disable HTTP/2 multiplexing

2021-03-23 Thread Victor Seva
Hi Federico!

On 3/22/21 8:09 PM, Federico Cabiddu wrote:
> Module: kamailio
> Branch: master
> Commit: e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b
> URL: 
> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b
> 
> Author: Federico Cabiddu 
> Committer: Federico Cabiddu 
> Date: 2021-03-22T20:09:12+01:00
> 
> http_async_client: disable HTTP/2 multiplexing
> 
> ---
> 
> Modified: src/modules/http_async_client/http_multi.c
> 
> ---
> 
> Diff:  
> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b.diff
> Patch: 
> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b.patch
> 
> ---
> 
> diff --git a/src/modules/http_async_client/http_multi.c 
> b/src/modules/http_async_client/http_multi.c
> index 4f5cb30da8..c4351b1b94 100644
> --- a/src/modules/http_async_client/http_multi.c
> +++ b/src/modules/http_async_client/http_multi.c
> @@ -402,6 +402,7 @@ int init_http_multi(struct event_base *evbase, struct 
> http_m_global *wg)
>   curl_multi_setopt(g->multi, CURLMOPT_SOCKETDATA, g);
>   curl_multi_setopt(g->multi, CURLMOPT_TIMERFUNCTION, multi_timer_cb);
>   curl_multi_setopt(g->multi, CURLMOPT_TIMERDATA, g);
> + curl_multi_setopt(g->multi, CURLMOPT_PIPELINING, CURLPIPE_NOTHING);
>  
>   return init_http_m_table(hash_size);
>  }
> 

Sadly CURLPIPE_NOTHING was introduced at 7.43.0 [0] so jessie and trusty
builds are broken right now

[0] https://curl.se/libcurl/c/symbols-in-versions.html

___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] git:master:e85a5a6a: http_async_client: disable HTTP/2 multiplexing

2021-03-23 Thread Federico Cabiddu
Ops, I'll fix it!

On Tue, Mar 23, 2021 at 11:16 AM Victor Seva <
linuxman...@torreviejawireless.org> wrote:

> Hi Federico!
>
> On 3/22/21 8:09 PM, Federico Cabiddu wrote:
> > Module: kamailio
> > Branch: master
> > Commit: e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b
> > URL:
> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b
> >
> > Author: Federico Cabiddu 
> > Committer: Federico Cabiddu 
> > Date: 2021-03-22T20:09:12+01:00
> >
> > http_async_client: disable HTTP/2 multiplexing
> >
> > ---
> >
> > Modified: src/modules/http_async_client/http_multi.c
> >
> > ---
> >
> > Diff:
> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b.diff
> > Patch:
> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b.patch
> >
> > ---
> >
> > diff --git a/src/modules/http_async_client/http_multi.c
> b/src/modules/http_async_client/http_multi.c
> > index 4f5cb30da8..c4351b1b94 100644
> > --- a/src/modules/http_async_client/http_multi.c
> > +++ b/src/modules/http_async_client/http_multi.c
> > @@ -402,6 +402,7 @@ int init_http_multi(struct event_base *evbase,
> struct http_m_global *wg)
> >   curl_multi_setopt(g->multi, CURLMOPT_SOCKETDATA, g);
> >   curl_multi_setopt(g->multi, CURLMOPT_TIMERFUNCTION,
> multi_timer_cb);
> >   curl_multi_setopt(g->multi, CURLMOPT_TIMERDATA, g);
> > + curl_multi_setopt(g->multi, CURLMOPT_PIPELINING, CURLPIPE_NOTHING);
> >
> >   return init_http_m_table(hash_size);
> >  }
> >
>
> Sadly CURLPIPE_NOTHING was introduced at 7.43.0 [0] so jessie and trusty
> builds are broken right now
>
> [0] https://curl.se/libcurl/c/symbols-in-versions.html
>
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev


Re: [sr-dev] git:master:e85a5a6a: http_async_client: disable HTTP/2 multiplexing

2021-03-23 Thread Federico Cabiddu
Just seen that you already did it, sorry!


On Tue, Mar 23, 2021 at 12:17 PM Federico Cabiddu <
federico.cabi...@gmail.com> wrote:

> Ops, I'll fix it!
>
> On Tue, Mar 23, 2021 at 11:16 AM Victor Seva <
> linuxman...@torreviejawireless.org> wrote:
>
>> Hi Federico!
>>
>> On 3/22/21 8:09 PM, Federico Cabiddu wrote:
>> > Module: kamailio
>> > Branch: master
>> > Commit: e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b
>> > URL:
>> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b
>> >
>> > Author: Federico Cabiddu 
>> > Committer: Federico Cabiddu 
>> > Date: 2021-03-22T20:09:12+01:00
>> >
>> > http_async_client: disable HTTP/2 multiplexing
>> >
>> > ---
>> >
>> > Modified: src/modules/http_async_client/http_multi.c
>> >
>> > ---
>> >
>> > Diff:
>> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b.diff
>> > Patch:
>> https://github.com/kamailio/kamailio/commit/e85a5a6ae2ae01159ef4aeffd9f51f58c7bc844b.patch
>> >
>> > ---
>> >
>> > diff --git a/src/modules/http_async_client/http_multi.c
>> b/src/modules/http_async_client/http_multi.c
>> > index 4f5cb30da8..c4351b1b94 100644
>> > --- a/src/modules/http_async_client/http_multi.c
>> > +++ b/src/modules/http_async_client/http_multi.c
>> > @@ -402,6 +402,7 @@ int init_http_multi(struct event_base *evbase,
>> struct http_m_global *wg)
>> >   curl_multi_setopt(g->multi, CURLMOPT_SOCKETDATA, g);
>> >   curl_multi_setopt(g->multi, CURLMOPT_TIMERFUNCTION,
>> multi_timer_cb);
>> >   curl_multi_setopt(g->multi, CURLMOPT_TIMERDATA, g);
>> > + curl_multi_setopt(g->multi, CURLMOPT_PIPELINING,
>> CURLPIPE_NOTHING);
>> >
>> >   return init_http_m_table(hash_size);
>> >  }
>> >
>>
>> Sadly CURLPIPE_NOTHING was introduced at 7.43.0 [0] so jessie and trusty
>> builds are broken right now
>>
>> [0] https://curl.se/libcurl/c/symbols-in-versions.html
>>
>> ___
>> Kamailio (SER) - Development Mailing List
>> sr-dev@lists.kamailio.org
>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>>
>
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev