Re: [SR-Users] Kamailio 1.5.4 crash

2010-08-31 Thread Henning Westerholt
On Tuesday 31 August 2010, Iñaki Baz Castillo wrote:
> > I agree it is a free of a null pointer, but the if(hf->parsed) should be
> > the test for NULL, and only execute code if not NULL.  However this test
> > is failing.
> 
> Do you have a SIP flow/trace to reproduce the crash?

Hi Iñaki,

i discussed with Gene privatly, he send me the message in question, so far it 
looked ok. Apparently its related to an Re-INVITE. I also asked Marius to have 
a look to it.

Cheers,

Henning

___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


Re: [SR-Users] Kamailio 1.5.4 crash

2010-08-30 Thread Iñaki Baz Castillo
2010/8/30  :
> We were experiencing the issue with 1.5.4 released version, we upgraded from
> svn and the issue still persists.  I have a backtrace from both versions.
>
>
>
> I agree it is a free of a null pointer, but the if(hf->parsed) should be the
> test for NULL, and only execute code if not NULL.  However this test is
> failing.

Do you have a SIP flow/trace to reproduce the crash?

-- 
Iñaki Baz Castillo


___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


Re: [SR-Users] Kamailio 1.5.4 crash

2010-08-30 Thread gwillingham


We were experiencing the issue with 1.5.4 released version, we upgraded from 
svn and the issue still persists.  I have a backtrace from both versions. 



I agree it is a free of a null pointer, but the if(hf->parsed) should be the 
test for NULL, and only execute code if not NULL.  However this test is 
failing.  




- Original Message - 
From: "Henning Westerholt"  
To: sr-users@lists.sip-router.org 
Cc: "Alex Balashov" , gwilling...@comcast.net 
Sent: Monday, August 30, 2010 11:45:11 AM 
Subject: Re: [SR-Users] Kamailio 1.5.4 crash 

On Monday 30 August 2010, Alex Balashov wrote: 
> On 08/30/2010 11:33 AM, gwilling...@comcast.net wrote: 
> > output from gdb shows hf->parsed to be NULL, however the call to 
> > free_to(hf->parsed) is being called, from there bad things happen. 
> 
> Sounds like a double free(), or a free() of something that was never 
> allocated. 

Hello Gene, 

1.5.4 was released in February, i think - do you use the version from tar.gz? 
I've checked the file in question, there were one fix in the last month: 

r6036 | miconda | 2010-07-30 20:18:33 +0200 (Fr, 30 Jul 2010) | 4 lines 
- fix off-by-one bug for quoted parameter values in parse_to 
- patch by Alex Hermann, SF#3035382 

which maybe could help you here. I'd suggest that you extract the SIP message 
in question from the backtrace (receive_msg, buf) and then try to reproduce 
the crash. If it crash again, just update to the latest 1.5 branch state, and 
see if it crashes again. It contains some more fixes, one or two also could 
cause crashes in some special conditions. 

Cheers, 

Henning 
___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


Re: [SR-Users] Kamailio 1.5.4 crash

2010-08-30 Thread Henning Westerholt
On Monday 30 August 2010, Alex Balashov wrote:
> On 08/30/2010 11:33 AM, gwilling...@comcast.net wrote:
> > output from gdb shows hf->parsed to be NULL, however the call to
> > free_to(hf->parsed) is being called, from there bad things happen.
> 
> Sounds like a double free(), or a free() of something that was never
> allocated.

Hello Gene,

1.5.4 was released in February, i think - do you use the version from tar.gz? 
I've checked the file in question, there were one fix in the last month:

r6036 | miconda | 2010-07-30 20:18:33 +0200 (Fr, 30 Jul 2010) | 4 lines
- fix off-by-one bug for quoted parameter values in parse_to
- patch by Alex Hermann, SF#3035382

which maybe could help you here. I'd suggest that you extract the SIP message 
in question from the backtrace (receive_msg, buf) and then try to reproduce 
the crash. If it crash again, just update to the latest 1.5 branch state, and 
see if it crashes again. It contains some more fixes, one or two also could 
cause crashes in some special conditions.

Cheers,

Henning

___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


Re: [SR-Users] Kamailio 1.5.4 crash

2010-08-30 Thread Alex Balashov

On 08/30/2010 11:33 AM, gwilling...@comcast.net wrote:


output from gdb shows hf->parsed to be NULL, however the call to
free_to(hf->parsed) is being called, from there bad things happen.


Sounds like a double free(), or a free() of something that was never 
allocated.


--
Alex Balashov - Principal
Evariste Systems LLC
1170 Peachtree Street
12th Floor, Suite 1200
Atlanta, GA 30309
Tel: +1-678-954-0670
Fax: +1-404-961-1892
Web: http://www.evaristesys.com/

___
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users