Re: [SSSD] [PATCH] Remove mpg option

2009-10-09 Thread Simo Sorce
On Fri, 2009-10-09 at 21:54 +0200, Sumit Bose wrote:
 I think it make sense to have it as a DB attribute and I would prefer
 to
 keep the attribute around.
 
 ACK

Pushed.

Simo.

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


Re: [SSSD] [PATCH] use the correct kerberos context for each target

2009-10-09 Thread Simo Sorce
On Fri, 2009-10-09 at 15:55 +0200, Sumit Bose wrote:
 Hi,
 
 I found an error for the case where the kerberos provider is used as
 change password provider but not as auth provider. This patch sould
 fix it.

Looks obviously right!
Ack and pushed.

Simo.

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


Re: [SSSD] [PATCH] use old password if available during password change

2009-10-09 Thread Simo Sorce
On Fri, 2009-10-09 at 21:02 +0200, Sumit Bose wrote:
 Hi,
 
 this one should fix #223. Because sshd runs as root the old password
 was
 not sent to sssd and changing the user password failed. Please review
 carefully.

I guess the problem here is to understand what do current pam modules,
when used through the proxy backend, expect.

Do they skip checks or ignore if the provided password is valid or not ?
Should we think of forking a child in proxy and running it as the user
that is attempting the password change? (Assuming we know it ?)

Otherwise the patch looks sane to me, so I'd give a tentative ack.

Simo.

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel