[SSSD] [sssd PR#103][+Pushed] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/103
Title: #103: sudo: do not store usn if no rules are found

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#103][-Accepted] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/103
Title: #103: sudo: do not store usn if no rules are found

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#103][comment] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/103
Title: #103: sudo: do not store usn if no rules are found

jhrozek commented:
"""
master: 46703740e83a66909974a5ee8d47df6a6e5076e7
sssd-1-14: 76e97affaa05ce45709efd59d120595c5992aa21
sssd-1-13: 4e25db79aa514e09c8ad4482c45b24e7a3d4 


"""

See the full comment at 
https://github.com/SSSD/sssd/pull/103#issuecomment-265777376
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#103][closed] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek 
   URL: https://github.com/SSSD/sssd/pull/103
Author: pbrezina
 Title: #103: sudo: do not store usn if no rules are found
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/103/head:pr103
git checkout pr103
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#103][comment] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/103
Title: #103: sudo: do not store usn if no rules are found

jhrozek commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/58/31/summary.html

The rawhide failure is unrelated..
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/103#issuecomment-265775078
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] Re: [sssd PR#100][synchronized] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-08 Thread amit kumar 
Hello,

kindly review https://github.com/SSSD/sssd/pull/100

commit f8f208f6f1a12e25d46b80459d87ae269924117d

Thanks


On 12/08/2016 11:12 AM, amitkumar50 wrote:
>URL: https://github.com/SSSD/sssd/pull/100
> Author: amitkumar50
>  Title: #100: Updation of sssd-ad man page for case when 
> dyndns_refresh_interval < 60 seconds
> Action: synchronized
>
> To pull the PR as Git branch:
> git remote add ghsssd https://github.com/SSSD/sssd
> git fetch ghsssd pull/100/head:pr100
> git checkout pr100
>
>
> ___
> sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
> To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/106
Title: #106: Add a new "files" provider

jhrozek commented:
"""
One suggestion came from simo about using FGETPWENT(3) instead of opening the 
NSS module directly.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/106#issuecomment-265761268
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-08 Thread mzidek-rh 
  URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches

mzidek-rh commented:
"""
Just updated the patches.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/102#issuecomment-265736056
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#102][synchronized] Sssctl no case sensitive searches

2016-12-08 Thread mzidek-rh 
   URL: https://github.com/SSSD/sssd/pull/102
Author: mzidek-rh
 Title: #102: Sssctl no case sensitive searches
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/102/head:pr102
git checkout pr102
From de5a674e687163cdb6cafeeae6587b57456a204d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C5=BDidek?= 
Date: Thu, 1 Dec 2016 15:56:39 +0100
Subject: [PATCH 1/4] common: Fix domain case sensitivity init

The domain case sensitivity was wrongly set in the domain
context after initialization if the provider was AD.

Resolves:
https://fedorahosted.org/sssd/ticket/3235
---
 src/confdb/confdb.c | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
index f0e3942..69200f5 100644
--- a/src/confdb/confdb.c
+++ b/src/confdb/confdb.c
@@ -1292,7 +1292,7 @@ static int confdb_get_domain_internal(struct confdb_ctx *cdb,
 }
 
 tmp = ldb_msg_find_attr_as_string(res->msgs[0],
-  CONFDB_DOMAIN_CASE_SENSITIVE, "true");
+  CONFDB_DOMAIN_CASE_SENSITIVE, NULL);
 if (tmp != NULL) {
 if (strcasecmp(tmp, "true") == 0) {
 domain->case_sensitive = true;
@@ -1310,9 +1310,15 @@ static int confdb_get_domain_internal(struct confdb_ctx *cdb,
 }
 } else {
 /* default */
-domain->case_sensitive = true;
-domain->case_preserve = true;
+if (strcasecmp(domain->provider, "ad") == 0) {
+domain->case_sensitive = false;
+domain->case_preserve = false;
+} else {
+domain->case_sensitive = true;
+domain->case_preserve = true;
+}
 }
+
 if (domain->case_sensitive == false &&
 strcasecmp(domain->provider, "local") == 0) {
 DEBUG(SSSDBG_FATAL_FAILURE,

From 45a33b18f861423d9432257e496b10e82dee86aa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C5=BDidek?= 
Date: Thu, 1 Dec 2016 14:51:37 +0100
Subject: [PATCH 2/4] sssctl: Search by alias

Also search by alias when using sssctl to query the cache.

Resolves:
https://fedorahosted.org/sssd/ticket/3235
---
 src/tools/sssctl/sssctl_cache.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/tools/sssctl/sssctl_cache.c b/src/tools/sssctl/sssctl_cache.c
index b1a7cc9..01fcf91 100644
--- a/src/tools/sssctl/sssctl_cache.c
+++ b/src/tools/sssctl/sssctl_cache.c
@@ -327,8 +327,10 @@ static const char *sssctl_create_filter(TALLOC_CTX *mem_ctx,
 return NULL;
 }
 
-filter = talloc_asprintf(mem_ctx, "(&(objectClass=%s)(%s=%s))",
- class, attr_name, filter_value);
+filter = talloc_asprintf(mem_ctx, "(&(objectClass=%s)(|(%s=%s)(%s=%s)))",
+ class, attr_name, filter_value,
+ SYSDB_NAME_ALIAS, filter_value);
+
 talloc_free(filter_value);
 
 return filter;

From eb0bcdb68c832c81e68bd4a2341fcbfb5b82f59e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C5=BDidek?= 
Date: Thu, 1 Dec 2016 15:22:42 +0100
Subject: [PATCH 3/4] sssctl: Case insensitive filters

Lowercase the filter in case insensitive domains.

Resolves:
https://fedorahosted.org/sssd/ticket/3235
---
 src/tools/sssctl/sssctl_cache.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/src/tools/sssctl/sssctl_cache.c b/src/tools/sssctl/sssctl_cache.c
index 01fcf91..59c8cb4 100644
--- a/src/tools/sssctl/sssctl_cache.c
+++ b/src/tools/sssctl/sssctl_cache.c
@@ -327,6 +327,14 @@ static const char *sssctl_create_filter(TALLOC_CTX *mem_ctx,
 return NULL;
 }
 
+if (dom->case_sensitive == false) {
+char *filter_value_old;
+
+filter_value_old = filter_value;
+filter_value = sss_tc_utf8_str_tolower(mem_ctx, filter_value_old);
+talloc_free(filter_value_old);
+}
+
 filter = talloc_asprintf(mem_ctx, "(&(objectClass=%s)(|(%s=%s)(%s=%s)))",
  class, attr_name, filter_value,
  SYSDB_NAME_ALIAS, filter_value);

From 6f404ae65f18ffccad4141355acdde22c478ffc8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Michal=20=C5=BDidek?= 
Date: Fri, 2 Dec 2016 13:21:47 +0100
Subject: [PATCH 4/4] tests: sssctl user/group-show basic tests

Add basic tests for sssctl user/group-show commands. This includes
regression test for ticket #3235.

Resolves:
https://fedorahosted.org/sssd/ticket/3235
---
 src/tests/intg/Makefile.am|   1 +
 src/tests/intg/test_sssctl.py | 364 ++
 2 files changed, 365 insertions(+)
 create mode 100644 src/tests/intg/test_sssctl.py

diff --git a/src/tests/intg/Makefile.am b/src/tests/intg/Makefile.am
index 1e08ead..e81e5ee 100644
--- a/src/tests/intg/Makefile.am
+++ b/src/tests/intg/Makefile.am
@@ -18,6 +18,7 @@ dist_noinst_DATA = \

[SSSD] Re: [PATCH] Unit tests for pam_sss using pam_wrapper (need help with CI..)

2016-12-08 Thread Lukas Slebodnik 
On (09/11/16 14:12), Lukas Slebodnik wrote:
>On (11/10/16 19:56), Jakub Hrozek wrote:
>>On Tue, Sep 13, 2016 at 09:27:32AM +0200, Lukas Slebodnik wrote:
>>> On (09/08/16 10:18), Jakub Hrozek wrote:
>>> >On Tue, Aug 09, 2016 at 08:04:38AM +0200, Lukas Slebodnik wrote:
>>> >> On (09/05/16 10:07), Jakub Hrozek wrote:
>>> >> >On Wed, May 04, 2016 at 11:36:57PM +0200, Lukas Slebodnik wrote:
>>> >> >> On (27/04/16 10:51), Jakub Hrozek wrote:
>>> >> >> >Hi,
>>> >> >> >
>>> >> >> >the attached patches implement unit tests for the pam_sss module 
>>> >> >> >using
>>> >> >> >pam_wrapper and libpamtest. In my testing, the coverage is around 75%
>>> >> >> >with mostly the parts that require running as root being untested.
>>> >> >> >
>>> >> >> >I worked on this patchset even though the features for 1.14 are in 
>>> >> >> >full
>>> >> >> >swing because there are several tickets that will require us to patch
>>> >> >> >pam_sss, so it's important to have the code that changes tested. In
>>> >> >> >addition, when we merge Dan's patches to use TLS with integration 
>>> >> >> >tests,
>>> >> >> >then we'll be able to also test authentication in integration tests
>>> >> >> >easily using libpamtest-python.
>>> >> >> >
>>> >> >> >However, our CI fails for me constantly:
>>> >> >> >http://sssd-ci.duckdns.org/logs/job/42/75/fedora_rawhide/ci.html
>>> >> >> >The strange thing is that running CI locally works fine and so does 
>>> >> >> >make
>>> >> >> >check. Can anyone help point me in the right direction as to what 
>>> >> >> >should
>>> >> >> >I check next? I suspect some of the environment variables might not 
>>> >> >> >be
>>> >> >> >set correctly, but I don't see why..
>>> >> >> 
>>> >> >> Are you sure it pass locally with valgrind?
>>> >> >> 
>>> >> >> It failed because there are valgrind errors.
>>> >> >> I can see then on fedora 22 and fedora 23
>>> >> >> http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora22/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.1444.valgrind.log
>>> >> >> http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora22/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.log
>>> >> >> 
>>> >> >> I cannot see them on fedora 24 or fedora rawhide
>>> >> >> http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora_rawhide/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.10504.valgrind.log
>>> >> >> but it fails as well
>>> >> >> http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora_rawhide/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.log
>>> >> >> 
>>> >> >> If the problem is with missing environment variables
>>> >> >> then you might log all environment variables in main function
>>> >> >
>>> >> >just a quick update: the issues in tests were resolved. I hit two bugs
>>> >> >in pam_wrapper:
>>> >> >
>>> >> > https://github.com/jhrozek/pam_wrapper/commit/ff7ec1c5ea7ed2360cbc59bd58f9caae7c9fa53d
>>> >> >
>>> >> > https://github.com/jhrozek/pam_wrapper/commit/c9b11ac8947bc0ff2ec3c4140b4d7413bfaadb37
>>> >> >so once Andreas approves them, I will build a new pam_wrapper RPM for
>>> >> >Fedora and EPEL so that we can formally review the pam_sss test patches.
>>> >> Bump
>>> >
>>> >I only had time to rebase the patches:
>>> >https://github.com/jhrozek/sssd/tree/pwrap
>>> >But now the tests fail, so I did something wrong, somewhere. I don't
>>> >think I will have time to look into this until next week, sorry.
>>> 
>>> http://sssd-ci.duckdns.org/logs-test/job/4/48/summary.html
>>> http://sssd-ci.duckdns.org/logs-test/job/4/49/summary.html
>>> 
>>> All test passed only on rhel6 :-(
>>> Maybe because new test was skipped.
>>> 
>>> cwrap tests were not executed on debian_testing due to following failures
>>> /var/lib/jenkins/workspace/ci-test/label/debian_testing/src/tests/cwrap/become_user-tests.sh:
>>> 3: .: Can't open /cwrap_test_setup.sh
>>> FAIL become_user-tests.sh (exit status: 2)
>>> 
>>> @see
>>> http://sssd-ci.duckdns.org/logs-test/job/4/48/debian_testing/ci-build-debug/src/tests/cwrap/become_user-tests.sh.log
>>> http://sssd-ci.duckdns.org/logs-test/job/4/48/debian_testing/ci-build-debug/src/tests/cwrap/responder_common-tests.sh.log
>>> http://sssd-ci.duckdns.org/logs-test/job/4/48/debian_testing/ci-build-debug/src/tests/cwrap/server-tests.sh.log
>>> http://sssd-ci.duckdns.org/logs-test/job/4/48/debian_testing/ci-build-debug/src/tests/cwrap/usertools-tests.sh.log
>>> 
>>> mock build failed on epel7 (maybe missing pam_sss-tests.sh in tarball)
>>> make[3]: Entering directory 
>>> `/builddir/build/BUILD/sssd-1.14.2/src/tests/cwrap'
>>> make[4]: Entering directory 
>>> `/builddir/build/BUILD/sssd-1.14.2/src/tests/cwrap'
>>> make[4]: *** No rule to make target `pam_sss-tests.sh', needed by
>>> `pam_sss-tests.sh.log'.  Stop.
>>> make[4]: *** Waiting for unfinished jobs...
>>> 
>>> 
>>> The pam_sss-tests test failed on fedora24. There are valgrind errors.
>>> ==28387== Invalid read of size 1
>>> ==28387==at 0x9CC2600: __GI_strchr (in /usr/lib64/libc-2.23.so)
>>> ==28387==by 0x402234: service_arg

[SSSD] [sssd PR#95][closed] STAP: Check the number of transactions in the stap aggregate before dereferencing it.

2016-12-08 Thread lslebodn 
   URL: https://github.com/SSSD/sssd/pull/95
Author: jhrozek
 Title: #95: STAP: Check the number of transactions in the stap aggregate 
before dereferencing it.
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/95/head:pr95
git checkout pr95
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#95][+Pushed] STAP: Check the number of transactions in the stap aggregate before dereferencing it.

2016-12-08 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/95
Title: #95: STAP: Check the number of transactions in the stap aggregate before 
dereferencing it.

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#95][comment] STAP: Check the number of transactions in the stap aggregate before dereferencing it.

2016-12-08 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/95
Title: #95: STAP: Check the number of transactions in the stap aggregate before 
dereferencing it.

lslebodn commented:
"""
On (27/11/16 23:54), fidencio wrote:
>Patch looks good but the indentation level seems wrong.
>Feel free to fix it before pushing (IOW, no need to resend a new version 
>because of this).
>Also, speak out if you want a review from someone else more into this part of 
>the code (and then remove the "Accepted" label).
>
>Acked-by: Fabiano Fidêncio 
>
master:
* 150a0cc8fe1936002af136e5552ef6cdd210956f

sssd-1-14:
* e6c74de2cbc9b0b713ed6dadbfef80c7c1b5cd51

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/95#issuecomment-265732176
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-08 Thread amitkumar50 
  URL: https://github.com/SSSD/sssd/pull/100
Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval 
< 60 seconds

amitkumar50 commented:
"""
Kindly review this recent Pull request.. commit 
f8f208f6f1a12e25d46b80459d87ae269924117d
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/100#issuecomment-265727165
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#102][+Changes requested] Sssctl no case sensitive searches

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/102
Title: #102: Sssctl no case sensitive searches

Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#103][comment] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/103
Title: #103: sudo: do not store usn if no rules are found

jhrozek commented:
"""
ACK, thanks for the patch. I will push it once full CI finishes.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/103#issuecomment-265726131
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#103][+Accepted] sudo: do not store usn if no rules are found

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/103
Title: #103: sudo: do not store usn if no rules are found

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-08 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/89
Title: #89: nss: rewrite nss responder so it uses cache_req

pbrezina commented:
"""
The crash was caused by the same issue as the valgrind log. It is fixed with:

```c
diff --git a/src/responder/nss/nss_enum.c b/src/responder/nss/nss_enum.c
index 5f29d6d..9c922aa 100644
--- a/src/responder/nss/nss_enum.c
+++ b/src/responder/nss/nss_enum.c
@@ -118,6 +118,7 @@ static void nss_setent_internal_done(struct tevent_req 
*subreq)
 {
struct cache_req_result **result;
 struct nss_setent_internal_state *state;
+struct setent_req_list **notify_list;
 struct tevent_req *req;
 errno_t ret;
 errno_t tret;
@@ -168,12 +169,20 @@ static void nss_setent_internal_done(struct tevent_req 
*subreq)
 ret = EOK;

 done:
+/* We want to finish the requests in correct order, this was the
+ * first request, notify_list contain the subsequent request.
+ *
+ * Because callback invoked from tevent_req_done will free state,
+ * we must remember notify_list explicitly to avoid segfault.
+ */
+notify_list = >enum_ctx->notify_list;
+
if (ret == EOK) {
 tevent_req_done(req);
-setent_notify_done(>enum_ctx->notify_list);
+setent_notify_done(notify_list);
 } else {
-setent_notify(>enum_ctx->notify_list, ret);
 tevent_req_error(req, ret);
+setent_notify(notify_list, ret);
 }
 }
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/89#issuecomment-265718180
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-08 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/89
Title: #89: nss: rewrite nss responder so it uses cache_req

pbrezina commented:
"""
The crash was caused by the same issue as the valgrind log. It is fixed with:

```c
diff --git a/src/responder/nss/nss_enum.c b/src/responder/nss/nss_enum.c
index 5f29d6d..9c922aa 100644
--- a/src/responder/nss/nss_enum.c
+++ b/src/responder/nss/nss_enum.c
@@ -118,6 +118,7 @@ static void nss_setent_internal_done(struct tevent_req 
*subreq)
 {
struct cache_req_result **result;
 struct nss_setent_internal_state *state;
+struct setent_req_list **notify_list;
 struct tevent_req *req;
 errno_t ret;
 errno_t tret;
@@ -168,12 +169,20 @@ static void nss_setent_internal_done(struct tevent_req 
*subreq)
 ret = EOK;

 done:
+/* We want to finish the requests in correct order, this was the
+ * first request, notify_list contain the subsequent request.
+ *
+ * Because callback invoked from tevent_req_done will free state,
+ * we must remember notify_list explicitly to avoid segfault.
+ */
+notify_list = >enum_ctx->notify_list;
+
if (ret == EOK) {
 tevent_req_done(req);
-setent_notify_done(>enum_ctx->notify_list);
+setent_notify_done(notify_list);
 } else {
-setent_notify(>enum_ctx->notify_list, ret);
 tevent_req_error(req, ret);
+setent_notify(notify_list, ret);
 }
 }
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/89#issuecomment-265718180
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#99][+Pushed] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/99
Title: #99: Prevent use after free in fd_input_available

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#99][comment] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/99
Title: #99: Prevent use after free in fd_input_available

jhrozek commented:
"""
Since the patch looks good to me, apparently fixes a crash an none of the 
maintainers have another opinion, I'm ACKing the patch.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/99#issuecomment-265713216
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#99][closed] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek 
   URL: https://github.com/SSSD/sssd/pull/99
Author: chlunde
 Title: #99: Prevent use after free in fd_input_available
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/99/head:pr99
git checkout pr99
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#99][comment] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/99
Title: #99: Prevent use after free in fd_input_available

jhrozek commented:
"""
Fixed upstream:
master: 9676b464dd428557ff5a648e1351a3972440396f
sssd-1-14: fefdd70237cbe82af7d8845131e45401e73b3b07
sssd-1-13: 07959a61f12cd9e60dff6651f4e1ce05c83c4da7
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/99#issuecomment-265713224
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#99][-Accepted] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/99
Title: #99: Prevent use after free in fd_input_available

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#99][+Accepted] Prevent use after free in fd_input_available

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/99
Title: #99: Prevent use after free in fd_input_available

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#97][comment] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/97
Title: #97: IFP: Remove "ChangeDebugTemporarily" method

jhrozek commented:
"""
* master: 78b4b7e5ec55861c43775581c08ae1804cd865f0
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/97#issuecomment-265710166
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#97][closed] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek 
   URL: https://github.com/SSSD/sssd/pull/97
Author: fidencio
 Title: #97: IFP: Remove "ChangeDebugTemporarily" method
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/97/head:pr97
git checkout pr97
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#97][-Accepted] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/97
Title: #97: IFP: Remove "ChangeDebugTemporarily" method

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#97][+Pushed] IFP: Remove "ChangeDebugTemporarily" method

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/97
Title: #97: IFP: Remove "ChangeDebugTemporarily" method

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#104][closed] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek 
   URL: https://github.com/SSSD/sssd/pull/104
Author: jhrozek
 Title: #104: Suppress a confusing error message from timestamp cache updates
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/104/head:pr104
git checkout pr104
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#104][-Accepted] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/104
Title: #104: Suppress a confusing error message from timestamp cache updates

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#104][+Pushed] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/104
Title: #104: Suppress a confusing error message from timestamp cache updates

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#104][comment] Suppress a confusing error message from timestamp cache updates

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/104
Title: #104: Suppress a confusing error message from timestamp cache updates

jhrozek commented:
"""
* master: ee576602d8b46b313c4f7ac8324cc31faefae46a
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/104#issuecomment-265709337
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#105][closed] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek 
   URL: https://github.com/SSSD/sssd/pull/105
Author: lslebodn
 Title: #105: RESPONDER: Remove dead assignment to the variable ret
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/105/head:pr105
git checkout pr105
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#105][-Accepted] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/105
Title: #105: RESPONDER: Remove dead assignment to the variable ret

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#105][comment] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/105
Title: #105: RESPONDER: Remove dead assignment to the variable ret

jhrozek commented:
"""
* master: 3d5bf48ac5b8b807facbfda225cdebff2f685cb8
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/105#issuecomment-265709046
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#105][+Pushed] RESPONDER: Remove dead assignment to the variable ret

2016-12-08 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/105
Title: #105: RESPONDER: Remove dead assignment to the variable ret

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-08 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/89
Title: #89: nss: rewrite nss responder so it uses cache_req

lslebodn commented:
"""
Another crash from AD related test. 0xbe was initialized either by 
`MALLOC_PERTRUB` or `TALLOC_FREE_FILL`
```
#0  0x7fa2dd6a8423 in setent_notify (list=0xbebebebebebebede, 
err=err@entry=0) at src/responder/common/responder_cmd.c:222
#1  0x7fa2dd6a84d7 in setent_notify_done (list=) at 
src/responder/common/responder_cmd.c:251
#2  0x7fa2dd69dfd8 in nss_setent_internal_done (subreq=0x0) at 
src/responder/nss/nss_enum.c:173
#3  0x7fa2dd6b0195 in cache_req_done (subreq=0x0) at 
src/responder/common/cache_req/cache_req.c:690
#4  0x7fa2dd6b0a4e in cache_req_search_done (subreq=) at 
src/responder/common/cache_req/cache_req_search.c:409
#5  0x7fa2dd6ab4ac in sss_dp_internal_get_done (pending=, 
ptr=) at src/responder/common/responder_dp.c:813
#6  0x7fa2dc56c862 in complete_pending_call_and_unlock () from 
/lib64/libdbus-1.so.3
#7  0x7fa2dc56fb51 in dbus_connection_dispatch () from /lib64/libdbus-1.so.3
#8  0x7fa2dce29cf2 in sbus_dispatch (ev=0x7fa2ded16a30, te=, 
tv=..., data=) at src/sbus/sssd_dbus_connection.c:96
#9  0x7fa2d94c4b4f in tevent_common_loop_timer_delay 
(ev=ev@entry=0x7fa2ded16a30) at ../tevent_timed.c:341
#10 0x7fa2d94c5b5a in epoll_event_loop_once (ev=0x7fa2ded16a30, 
location=) at ../tevent_epoll.c:911
#11 0x7fa2d94c4257 in std_event_loop_once (ev=0x7fa2ded16a30, 
location=0x7fa2dce52787 "src/util/server.c:705") at ../tevent_standard.c:114
#12 0x7fa2d94c040d in _tevent_loop_once (ev=ev@entry=0x7fa2ded16a30, 
location=location@entry=0x7fa2dce52787 "src/util/server.c:705") at 
../tevent.c:533
#13 0x7fa2d94c05ab in tevent_common_loop_wait (ev=0x7fa2ded16a30, 
location=0x7fa2dce52787 "src/util/server.c:705") at ../tevent.c:637
#14 0x7fa2d94c41f7 in std_event_loop_wait (ev=0x7fa2ded16a30, 
location=0x7fa2dce52787 "src/util/server.c:705") at ../tevent_standard.c:140
#15 0x7fa2dce35073 in server_loop (main_ctx=0x7fa2ded17e80) at 
src/util/server.c:705
#16 0x7fa2dd69b357 in main (argc=6, argv=) at 
src/responder/nss/nsssrv.c:559
```

There are more failures in ad forest test; will provide reproducers
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/89#issuecomment-265708774
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-08 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/89
Title: #89: nss: rewrite nss responder so it uses cache_req

pbrezina commented:
"""
On 12/08/2016 09:50 AM, lslebodn wrote:
> Looks like there is use after free in latest version. sorry do not have
> a reproducer yet; just a valgrind output
>
> nss_setnetgrent_done (nss_cmd.c:566) ==6612== by 0x408747:

It seems to be a netgroup search. Do you have sssd.conf?


"""

See the full comment at 
https://github.com/SSSD/sssd/pull/89#issuecomment-265687913
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-08 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/89
Title: #89: nss: rewrite nss responder so it uses cache_req

lslebodn commented:
"""
Looks like there is use after free in latest version. sorry do not have a 
reproducer yet; just a valgrind output
```
==6612== 18 errors in context 1 of 1:
==6612== Invalid read of size 8
==6612==at 0x408748: nss_setent_internal_done (nss_enum.c:173)
==6612==by 0x419A19: cache_req_done (cache_req.c:690)
==6612==by 0x41A6B5: cache_req_search_done (cache_req_search.c:409)
==6612==by 0x415C8D: sss_dp_internal_get_done (responder_dp.c:813)
==6612==by 0x32C320E619: complete_pending_call_and_unlock 
(dbus-connection.c:2234)
==6612==by 0x32C321086E: dbus_connection_dispatch (dbus-connection.c:4397)
==6612==by 0x5068D7C: sbus_dispatch (sssd_dbus_connection.c:96)
==6612==by 0x32C4E08CC0: tevent_common_loop_timer_delay (tevent_timed.c:341)
==6612==by 0x32C4E09D01: epoll_event_loop_once (tevent_epoll.c:911)
==6612==by 0x32C4E08335: std_event_loop_once (tevent_standard.c:114)
==6612==by 0x32C4E03C3C: _tevent_loop_once (tevent.c:533)
==6612==by 0x32C4E03CBA: tevent_common_loop_wait (tevent.c:637)
==6612==  Address 0xedcb820 is 544 bytes inside a block of size 805 free'd
==6612==at 0x4A06430: free (vg_replace_malloc.c:446)
==6612==by 0x32C0E07886: _talloc_free_internal (talloc.c:1116)
==6612==by 0x4077A7: nss_setnetgrent_done (nss_cmd.c:566)
==6612==by 0x408747: nss_setent_internal_done (nss_enum.c:172)
==6612==by 0x419A19: cache_req_done (cache_req.c:690)
==6612==by 0x41A6B5: cache_req_search_done (cache_req_search.c:409)
==6612==by 0x415C8D: sss_dp_internal_get_done (responder_dp.c:813)
==6612==by 0x32C320E619: complete_pending_call_and_unlock 
(dbus-connection.c:2234)
==6612==by 0x32C321086E: dbus_connection_dispatch (dbus-connection.c:4397)
==6612==by 0x5068D7C: sbus_dispatch (sssd_dbus_connection.c:96)
==6612==by 0x32C4E08CC0: tevent_common_loop_timer_delay (tevent_timed.c:341)
==6612==by 0x32C4E09D01: epoll_event_loop_once (tevent_epoll.c:911)
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/89#issuecomment-265686249
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org